[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703599#comment-16703599
]
Hudson commented on HADOOP-12751:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15529 (See
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331429#comment-16331429
]
Konstantin Shvachko commented on HADOOP-12751:
--
Thanks for the review [~brahmareddy].
Yes
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329898#comment-16329898
]
genericqa commented on HADOOP-12751:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329736#comment-16329736
]
genericqa commented on HADOOP-12751:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327943#comment-16327943
]
Konstantin Shvachko commented on HADOOP-12751:
--
Yes it should be fine to back-port this to
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326950#comment-16326950
]
Vinayakumar B commented on HADOOP-12751:
This looks to be good candidate for branch-2.7.
Do you
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279050#comment-15279050
]
Hudson commented on HADOOP-12751:
-
FAILURE: Integrated in Hadoop-trunk-Commit #9741 (See
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268493#comment-15268493
]
Bolke de Bruin commented on HADOOP-12751:
-
Hi [~steve_l] any update on this?
> While using
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263936#comment-15263936
]
Hadoop QA commented on HADOOP-12751:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262655#comment-15262655
]
Bolke de Bruin commented on HADOOP-12751:
-
[~steve_l] All good now? Code style issue is due to
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262183#comment-15262183
]
Hadoop QA commented on HADOOP-12751:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256792#comment-15256792
]
Steve Loughran commented on HADOOP-12751:
-
turns out that precommits need to be explicitly
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256532#comment-15256532
]
Bolke de Bruin commented on HADOOP-12751:
-
How are we doing here?
> While using kerberos Hadoop
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253974#comment-15253974
]
Bolke de Bruin commented on HADOOP-12751:
-
Thanks. Normally I do have vm for this, just not now
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253081#comment-15253081
]
Hadoop QA commented on HADOOP-12751:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252800#comment-15252800
]
Hadoop QA commented on HADOOP-12751:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249771#comment-15249771
]
Bolke de Bruin commented on HADOOP-12751:
-
Latest patch is not picked up yet by hadoop-qa
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248261#comment-15248261
]
Hadoop QA commented on HADOOP-12751:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247984#comment-15247984
]
Bolke de Bruin commented on HADOOP-12751:
-
Ok. Ill have a look at the errors (I had some trouble
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247949#comment-15247949
]
Hadoop QA commented on HADOOP-12751:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247883#comment-15247883
]
Steve Loughran commented on HADOOP-12751:
-
LTGM, apart from something minor about a test I could
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239077#comment-15239077
]
Bolke de Bruin commented on HADOOP-12751:
-
Ah. I like that approach. I will cook something up,
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239016#comment-15239016
]
Steve Loughran commented on HADOOP-12751:
-
# we have to leave the auth code in hadoop-auth;
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238766#comment-15238766
]
Bolke de Bruin commented on HADOOP-12751:
-
[~drankye] yes we did. We did: we found some issues
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238212#comment-15238212
]
Kai Zheng commented on HADOOP-12751:
Moving the codes impacts big. Maybe the class can add a
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238182#comment-15238182
]
Kai Zheng commented on HADOOP-12751:
I thought the codes should be good and ok to be moved to
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238108#comment-15238108
]
Steve Loughran commented on HADOOP-12751:
-
oh, that's a problem. I'd assumed there was.
Do
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237866#comment-15237866
]
Bolke de Bruin commented on HADOOP-12751:
-
What do you consider the proper approach to make this
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235440#comment-15235440
]
Steve Loughran commented on HADOOP-12751:
-
yes, I mean the existing pattern check will take
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234821#comment-15234821
]
Bolke de Bruin commented on HADOOP-12751:
-
[~steve_l] I assume that you mean "make it
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234814#comment-15234814
]
Steve Loughran commented on HADOOP-12751:
-
One issue with OS login is that it is inevitably
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171767#comment-15171767
]
Steve Loughran commented on HADOOP-12751:
-
sorry, been to busy to look at this. More pressing
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171664#comment-15171664
]
Bolke de Bruin commented on HADOOP-12751:
-
[~templedf] [~steve_l] Any response?
> While using
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151013#comment-15151013
]
Bolke de Bruin commented on HADOOP-12751:
-
Ping [~templedf] [~ste...@apache.org]
If you don't
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145551#comment-15145551
]
Bolke de Bruin commented on HADOOP-12751:
-
Reporting on local testing:
/etc/passwd:
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126203#comment-15126203
]
Bolke de Bruin commented on HADOOP-12751:
-
[~steve_l] will keep your comments in mind and update
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126187#comment-15126187
]
Steve Loughran commented on HADOOP-12751:
-
ps, regarding the patch, don't catch exceptions and
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126184#comment-15126184
]
Steve Loughran commented on HADOOP-12751:
-
# pretty much all production enterprise customers run
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125518#comment-15125518
]
Daniel Templeton commented on HADOOP-12751:
---
Sounds like a plan. Thanks, [~bolke]!
> While
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125508#comment-15125508
]
Bolke de Bruin commented on HADOOP-12751:
-
Sure I understand the general concern, but I have
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125323#comment-15125323
]
Bolke de Bruin commented on HADOOP-12751:
-
I would suggest (in the future?) to rename this
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125407#comment-15125407
]
Daniel Templeton commented on HADOOP-12751:
---
Looking at the patch, it seems sound. My only
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124933#comment-15124933
]
Bolke de Bruin commented on HADOOP-12751:
-
[~steve_l] I understand that, however the MIT
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124884#comment-15124884
]
Steve Loughran commented on HADOOP-12751:
-
/ is integral to differentiate simple names
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124829#comment-15124829
]
Hadoop QA commented on HADOOP-12751:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124445#comment-15124445
]
Hadoop QA commented on HADOOP-12751:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124534#comment-15124534
]
Hadoop QA commented on HADOOP-12751:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124499#comment-15124499
]
Hadoop QA commented on HADOOP-12751:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124385#comment-15124385
]
Bolke de Bruin commented on HADOOP-12751:
-
Please note that zookeeper has the same code. I'm
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124265#comment-15124265
]
Bolke de Bruin commented on HADOOP-12751:
-
Yes if my assumption correct. I can prepare a small
[
https://issues.apache.org/jira/browse/HADOOP-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124026#comment-15124026
]
Daniel Templeton commented on HADOOP-12751:
---
So the suggestion is to remove the validation
51 matches
Mail list logo