[jira] [Commented] (HADOOP-13700) Remove unthrown IOException from TrashPolicy#initialize and #getInstance signatures
[ https://issues.apache.org/jira/browse/HADOOP-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570107#comment-15570107 ] Hudson commented on HADOOP-13700: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10598 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10598/]) HADOOP-13700. Remove unthrown IOException from TrashPolicy#initialize (wang: rev 12d739a34ba868b3f7f5adf7f37a60d4aca9061b) * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicy.java > Remove unthrown IOException from TrashPolicy#initialize and #getInstance > signatures > --- > > Key: HADOOP-13700 > URL: https://issues.apache.org/jira/browse/HADOOP-13700 > Project: Hadoop Common > Issue Type: Bug > Components: fs >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Haibo Chen >Assignee: Andrew Wang >Priority: Critical > Fix For: 2.8.0, 3.0.0-alpha2 > > Attachments: HADOOP-13700.001.patch > > > TrashPolicy is marked as public & evolving, but its public API, specifically > TrashPolicy.getInstance() has been changed in an incompatible way. > 1) The path parameter is removed in 3.0 > 2) A new IOException is thrown in 3.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13700) Remove unthrown IOException from TrashPolicy#initialize and #getInstance signatures
[ https://issues.apache.org/jira/browse/HADOOP-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566701#comment-15566701 ] Andrew Wang commented on HADOOP-13700: -- Thanks for reviewing Eddy. I'll wait until tomorrow to commit since Allen or Steve might also want to look. > Remove unthrown IOException from TrashPolicy#initialize and #getInstance > signatures > --- > > Key: HADOOP-13700 > URL: https://issues.apache.org/jira/browse/HADOOP-13700 > Project: Hadoop Common > Issue Type: Bug > Components: fs >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Haibo Chen >Assignee: Andrew Wang >Priority: Critical > Attachments: HADOOP-13700.001.patch > > > TrashPolicy is marked as public & evolving, but its public API, specifically > TrashPolicy.getInstance() has been changed in an incompatible way. > 1) The path parameter is removed in 3.0 > 2) A new IOException is thrown in 3.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13700) Remove unthrown IOException from TrashPolicy#initialize and #getInstance signatures
[ https://issues.apache.org/jira/browse/HADOOP-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566576#comment-15566576 ] Lei (Eddy) Xu commented on HADOOP-13700: Thanks [~andrew.wang]. It looks safe to me. +1. > Remove unthrown IOException from TrashPolicy#initialize and #getInstance > signatures > --- > > Key: HADOOP-13700 > URL: https://issues.apache.org/jira/browse/HADOOP-13700 > Project: Hadoop Common > Issue Type: Bug > Components: fs >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Haibo Chen >Assignee: Andrew Wang >Priority: Critical > Attachments: HADOOP-13700.001.patch > > > TrashPolicy is marked as public & evolving, but its public API, specifically > TrashPolicy.getInstance() has been changed in an incompatible way. > 1) The path parameter is removed in 3.0 > 2) A new IOException is thrown in 3.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13700) Remove unthrown IOException from TrashPolicy#initialize and #getInstance signatures
[ https://issues.apache.org/jira/browse/HADOOP-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566072#comment-15566072 ] Andrew Wang commented on HADOOP-13700: -- [~haibochen] thanks for reviewing, see HADOOP-13705 for the Path parameter, simple revert. > Remove unthrown IOException from TrashPolicy#initialize and #getInstance > signatures > --- > > Key: HADOOP-13700 > URL: https://issues.apache.org/jira/browse/HADOOP-13700 > Project: Hadoop Common > Issue Type: Bug > Components: fs >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Haibo Chen >Assignee: Andrew Wang >Priority: Critical > Attachments: HADOOP-13700.001.patch > > > TrashPolicy is marked as public & evolving, but its public API, specifically > TrashPolicy.getInstance() has been changed in an incompatible way. > 1) The path parameter is removed in 3.0 > 2) A new IOException is thrown in 3.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13700) Remove unthrown IOException from TrashPolicy#initialize and #getInstance signatures
[ https://issues.apache.org/jira/browse/HADOOP-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566059#comment-15566059 ] Haibo Chen commented on HADOOP-13700: - Thanks [~andrew.wang] for the fix. This solve most of the pain to user the new API. What about the path parameter that was in the parameter list before 3.0? > Remove unthrown IOException from TrashPolicy#initialize and #getInstance > signatures > --- > > Key: HADOOP-13700 > URL: https://issues.apache.org/jira/browse/HADOOP-13700 > Project: Hadoop Common > Issue Type: Bug > Components: fs >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Haibo Chen >Assignee: Andrew Wang >Priority: Critical > Attachments: HADOOP-13700.001.patch > > > TrashPolicy is marked as public & evolving, but its public API, specifically > TrashPolicy.getInstance() has been changed in an incompatible way. > 1) The path parameter is removed in 3.0 > 2) A new IOException is thrown in 3.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13700) Remove unthrown IOException from TrashPolicy#initialize and #getInstance signatures
[
https://issues.apache.org/jira/browse/HADOOP-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564094#comment-15564094
]
Hadoop QA commented on HADOOP-13700:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
43s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 23s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch
generated 1 new + 4 unchanged - 1 fixed = 5 total (was 5) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 57s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 13s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | org.apache.hadoop.http.TestHttpServerLifecycle |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HADOOP-13700 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12832578/HADOOP-13700.001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 3e18fbb5f933 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 96b1266 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10726/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10726/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10726/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10726/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
