[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648376#comment-15648376
]
Xiao Chen commented on HADOOP-13720:
Thanks [~yzhangal] for the new revs, and Steve for the reviews.
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645524#comment-15645524
]
Yongjun Zhang commented on HADOOP-13720:
Hi [~ste...@apache.org] and [~xiaochen],
Thanks a lot
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637287#comment-15637287
]
Hadoop QA commented on HADOOP-13720:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637119#comment-15637119
]
Yongjun Zhang commented on HADOOP-13720:
Thanks [~steve_l], did not see your comment until now,
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635801#comment-15635801
]
Steve Loughran commented on HADOOP-13720:
-
aah, findbugs is still complaining. You could just go
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631879#comment-15631879
]
Hadoop QA commented on HADOOP-13720:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631590#comment-15631590
]
Hadoop QA commented on HADOOP-13720:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631504#comment-15631504
]
Yongjun Zhang commented on HADOOP-13720:
Thanks [~ste...@apache.org], good comments! Uploaded
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631288#comment-15631288
]
Hadoop QA commented on HADOOP-13720:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630241#comment-15630241
]
Hadoop QA commented on HADOOP-13720:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630136#comment-15630136
]
Steve Loughran commented on HADOOP-13720:
-
looks pretty good. I think the bit where {{"
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630107#comment-15630107
]
Yongjun Zhang commented on HADOOP-13720:
Thanks [~xiaochen] much for the review, Very good
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603718#comment-15603718
]
Xiao Chen commented on HADOOP-13720:
Thanks [~yzhangal] for the patch.
Looking at the class, I think
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576241#comment-15576241
]
Hadoop QA commented on HADOOP-13720:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576110#comment-15576110
]
Yongjun Zhang commented on HADOOP-13720:
Hi [~ste...@apache.org], uploaded a quick patch, would
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575848#comment-15575848
]
Yongjun Zhang commented on HADOOP-13720:
Nice suggestion [~ste...@apache.org], thanks.
> Add
[
https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575756#comment-15575756
]
Steve Loughran commented on HADOOP-13720:
-
I'd add the current time too. Why? Helps identify one
17 matches
Mail list logo