[ https://issues.apache.org/jira/browse/HADOOP-14756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123991#comment-16123991 ]
Aaron Fabbri commented on HADOOP-14756: --------------------------------------- Thanks for filing this. FYI I wrote #3 in the code comments during early S3Guard development. I don't think we need it anymore since we can set the isAuthoritative (fully cached directory) bit in the DirListingMetadata instead. Might tweak the title here a bit to capture my original intent better. > S3Guard: instrument MetadataStore for asserting & testing > MetadataStoreTestBase > ------------------------------------------------------------------------------- > > Key: HADOOP-14756 > URL: https://issues.apache.org/jira/browse/HADOOP-14756 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: HADOOP-13345 > Reporter: Steve Loughran > Fix For: HADOOP-13345 > > > {{MetadataStoreTestBase.testListChildren}} would be improved with the ability > to query the features offered by the store, and the outcome of {{put()}}, so > probe the correctness of the authoritative mode > # Add predicate to MetadataStore interface > {{supportsAuthoritativeDirectories()}} or similar > # If #1 is true, assert that directory is fully cached after changes > # Add "isNew" flag to MetadataStore.put(DirListingMetadata); use to verify > when changes are made -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org