[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[ https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181138#comment-16181138 ] Bharat Viswanadham commented on HADOOP-14881: - Thank You [~jlowe] for reviewing and committing the patch. > LoadGenerator should use Time.monotonicNow() to measure durations > - > > Key: HADOOP-14881 > URL: https://issues.apache.org/jira/browse/HADOOP-14881 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Chetna Chaudhari >Assignee: Bharat Viswanadham > Fix For: 2.9.0, 3.0.0-beta1 > > Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch, > HADOOP-14881.03.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[ https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179752#comment-16179752 ] Hudson commented on HADOOP-14881: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12969 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12969/]) HADOOP-14881. LoadGenerator should use Time.monotonicNow() to measure (jlowe: rev ac05a51bbb2a3fad4e85f9334a3408571967900a) * (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/loadGenerator/LoadGenerator.java > LoadGenerator should use Time.monotonicNow() to measure durations > - > > Key: HADOOP-14881 > URL: https://issues.apache.org/jira/browse/HADOOP-14881 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Chetna Chaudhari >Assignee: Bharat Viswanadham > Fix For: 2.9.0, 3.0.0-beta1 > > Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch, > HADOOP-14881.03.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[ https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179734#comment-16179734 ] Jason Lowe commented on HADOOP-14881: - +1 for the latest patch. Committing this. > LoadGenerator should use Time.monotonicNow() to measure durations > - > > Key: HADOOP-14881 > URL: https://issues.apache.org/jira/browse/HADOOP-14881 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Chetna Chaudhari >Assignee: Bharat Viswanadham > Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch, > HADOOP-14881.03.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[
https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177153#comment-16177153
]
Hadoop QA commented on HADOOP-14881:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} hadoop-common-project/hadoop-common: The patch
generated 0 new + 51 unchanged - 4 fixed = 51 total (was 55) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
54s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:71bbb86 |
| JIRA Issue | HADOOP-14881 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888560/HADOOP-14881.03.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 55dbb58c80b2 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / b133dc5 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13361/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13361/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> LoadGenerator should use Time.monotonicNow() to measure durations
> -
>
> Key: HADOOP-14881
> URL: https://issues.apache.org/jira/browse/HADOOP-14881
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Chetna Chaudhari
>Assignee: Bharat Viswanadham
> Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch,
> HADOOP-14881.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[ https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177077#comment-16177077 ] Bharat Viswanadham commented on HADOOP-14881: - Hi Jason, Thank You for information. Updated the patch to revert close change. Attached v03 patch. > LoadGenerator should use Time.monotonicNow() to measure durations > - > > Key: HADOOP-14881 > URL: https://issues.apache.org/jira/browse/HADOOP-14881 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Chetna Chaudhari >Assignee: Bharat Viswanadham > Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch, > HADOOP-14881.03.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[
https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177074#comment-16177074
]
Jason Lowe commented on HADOOP-14881:
-
Thanks for updating the patch!
It's not quite that simple to fix the close issue. If {{out.close()}} throws
then we won't update the metrics and we'll also end up double-closing due to
the processing in the {{finally}} block. Double-close _should_ be OK, but I'd
rather not do it as the norm. The previous change in HADOOP-10328 implied they
want to suppress the exceptions during close, which we should discuss along
with the questions of whether metrics should or should not be updated when a
close fails. Therefore I think we should not complicate this fix with the
close issue and leave that for HADOOP-14902.
> LoadGenerator should use Time.monotonicNow() to measure durations
> -
>
> Key: HADOOP-14881
> URL: https://issues.apache.org/jira/browse/HADOOP-14881
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Chetna Chaudhari
>Assignee: Bharat Viswanadham
> Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch,
> HADOOP-14881.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[ https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177059#comment-16177059 ] Bharat Viswanadham commented on HADOOP-14881: - Hi Jason, Thank You for review. Good catch that closing file is not done. As it is minor change, updated the code to fix that issue also. Attached the patch v02. > LoadGenerator should use Time.monotonicNow() to measure durations > - > > Key: HADOOP-14881 > URL: https://issues.apache.org/jira/browse/HADOOP-14881 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Chetna Chaudhari >Assignee: Bharat Viswanadham > Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[ https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177049#comment-16177049 ] Jason Lowe commented on HADOOP-14881: - Filed HADOOP-14902 to track the incorrect WRITE_CLOSE timing issue. > LoadGenerator should use Time.monotonicNow() to measure durations > - > > Key: HADOOP-14881 > URL: https://issues.apache.org/jira/browse/HADOOP-14881 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Chetna Chaudhari >Assignee: Bharat Viswanadham > Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[
https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177035#comment-16177035
]
Jason Lowe commented on HADOOP-14881:
-
Thanks for updating the patch!
bq. also updated the variable startTime inside functions to startTime1 to
resolve checkstyle issue
Nit: could we use something like {{startTimestamp}} or just {{timestamp}}
rather than {{startTime1}}? The latter implies there's a {{startTime2}}
counterpart.
Looking closer there also appears to be a bug here:
{code}
-startTime = Time.now();
-executionTime[WRITE_CLOSE] += (Time.now() - startTime);
+startTime1 = Time.monotonicNow();
+executionTime[WRITE_CLOSE] += (Time.monotonicNow() - startTime1);
{code}
Both before and after the patch, it was getting the current time into a local
then simply subtracting the current time from that timestamp as the execution
time of the close of the file, but does not actually close the file. I'll file
a separate JIRA since this bug existed even in the previous code and isn't
related to converting to monotonicNow().
> LoadGenerator should use Time.monotonicNow() to measure durations
> -
>
> Key: HADOOP-14881
> URL: https://issues.apache.org/jira/browse/HADOOP-14881
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Chetna Chaudhari
>Assignee: Bharat Viswanadham
> Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[
https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175265#comment-16175265
]
Hadoop QA commented on HADOOP-14881:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} hadoop-common-project/hadoop-common: The patch
generated 0 new + 51 unchanged - 4 fixed = 51 total (was 55) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
8s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 59m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:71bbb86 |
| JIRA Issue | HADOOP-14881 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888341/HADOOP-14881.02.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 4f042751c9b5 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / b9e423f |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13341/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13341/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> LoadGenerator should use Time.monotonicNow() to measure durations
> -
>
> Key: HADOOP-14881
> URL: https://issues.apache.org/jira/browse/HADOOP-14881
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Chetna Chaudhari
>Assignee: Bharat Viswanadham
> Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[ https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175179#comment-16175179 ] Bharat Viswanadham commented on HADOOP-14881: - [~jlowe] Thank you for detailed explanation. Updated the patch to fix the review comments. And also updated the variable startTime inside functions to startTime1 to resolve checkstyle issue [long startTime = Time.monotonicNow();:12: 'startTime' hides a field. [HiddenField] > LoadGenerator should use Time.monotonicNow() to measure durations > - > > Key: HADOOP-14881 > URL: https://issues.apache.org/jira/browse/HADOOP-14881 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Chetna Chaudhari >Assignee: Bharat Viswanadham > Attachments: HADOOP-14881.01.patch, HADOOP-14881.02.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[
https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175029#comment-16175029
]
Jason Lowe commented on HADOOP-14881:
-
Thanks for the patch!
The TestSFTPFileSystem change looks unrelated.
Time.monotonicNow returns a value that only makes sense within the context of a
process when used for deltas of those values to measure elapsed time. The
Javadoc for System.nanoTime, which Time.montonicNow trivially wraps, states as
such:
{quote}
This method can only be used to measure elapsed time and is not related to any
other notion of system or wall-clock time. The value returned represents
nanoseconds since some fixed but arbitrary origin time (perhaps in the future,
so values may be negative). The same origin is used by all invocations of this
method in an instance of a Java virtual machine; other virtual machine
instances are likely to use a different origin.
{quote}
In LoadGenerator#submitAsMapReduce it stores the monotonicNow value placed into
LoadGenerator.startTime into a conf which will be shipped to another JVM as
part of a MapReduce job. That value likely will not make sense in the context
of the new job.
Similarly, LoadGenerator.startTime can be initialized via a command-line
argument. That argument will always be specified as seconds since the standard
epoch, whereas montonicNow will not be. Therefore we cannot change
LoadGenerator.startTime to use Time.monotonicNow. The use of monotonicNow may
be OK within the read, write, list, and genFile methods, but it's not going to
be OK in the LoadGenerator#barrier method.
> LoadGenerator should use Time.monotonicNow() to measure durations
> -
>
> Key: HADOOP-14881
> URL: https://issues.apache.org/jira/browse/HADOOP-14881
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Chetna Chaudhari
>Assignee: Bharat Viswanadham
> Attachments: HADOOP-14881.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14881) LoadGenerator should use Time.monotonicNow() to measure durations
[
https://issues.apache.org/jira/browse/HADOOP-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174358#comment-16174358
]
Hadoop QA commented on HADOOP-14881:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
40s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
51s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 12m
37s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
2m 11s{color} | {color:orange} root: The patch generated 6 new + 81 unchanged -
5 fixed = 87 total (was 86) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 9m 13s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 93m 10s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}197m 7s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.fs.sftp.TestSFTPFileSystem |
| | hadoop.security.TestKDiag |
| | hadoop.net.TestDNS |
| | hadoop.hdfs.server.namenode.TestReencryptionWithKMS |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure |
| | hadoop.hdfs.server.namenode.ha.TestPipelinesFailover |
| Timed out junit tests | org.apache.hadoop.hdfs.TestLeaseRecovery2 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:71bbb86 |
| JIRA Issue | HADOOP-14881 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888202/HADOOP-14881.01.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux cff5ef8e7ff6 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 53047f9 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/1/artifact/patchprocess/diff-checkstyle-root.txt
|
| unit |
