[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368539#comment-16368539
]
Akira Ajisaka commented on HADOOP-15223:
+1
> Replace Collections.EMPTY_SET and EMPTY_MAP with
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368279#comment-16368279
]
genericqa commented on HADOOP-15223:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368199#comment-16368199
]
fang zhenyi commented on HADOOP-15223:
--
Attach the updated HADOOP-15223.005.patch to fix
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367572#comment-16367572
]
genericqa commented on HADOOP-15223:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366918#comment-16366918
]
fang zhenyi commented on HADOOP-15223:
--
Thanks [~ajisakaa] for review.
I have replaced
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366678#comment-16366678
]
Akira Ajisaka commented on HADOOP-15223:
Thanks [~zhenyi] for the update.
Would you replace
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365553#comment-16365553
]
genericqa commented on HADOOP-15223:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365296#comment-16365296
]
fang zhenyi commented on HADOOP-15223:
--
Thanks [~ajisakaa] for review.I have attached
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365048#comment-16365048
]
Akira Ajisaka commented on HADOOP-15223:
Thanks [~zhenyi] for the update. The patch cannot be
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363945#comment-16363945
]
genericqa commented on HADOOP-15223:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363890#comment-16363890
]
fang zhenyi commented on HADOOP-15223:
--
Thanks [~ajisakaa] for comments.I have remove all of
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362712#comment-16362712
]
Akira Ajisaka commented on HADOOP-15223:
Thanks [~zhenyi] for the patch! Some comments:
1. Would
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362104#comment-16362104
]
genericqa commented on HADOOP-15223:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361891#comment-16361891
]
fang zhenyi commented on HADOOP-15223:
--
Thanks [~ajisakaa] for reporting this.I will attach a
14 matches
Mail list logo