[jira] [Commented] (HADOOP-15289) FileStatus.readFields() assertion incorrect
[ https://issues.apache.org/jira/browse/HADOOP-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387576#comment-16387576 ] Hudson commented on HADOOP-15289: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13777 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13777/]) HADOOP-15289. FileStatus.readFields() assertion incorrect. Contributed (stevel: rev 12ecb55ffee2b89108eea2565e7ad955ea1fabe7) * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java > FileStatus.readFields() assertion incorrect > --- > > Key: HADOOP-15289 > URL: https://issues.apache.org/jira/browse/HADOOP-15289 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 3.0.0, 3.1.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Critical > Fix For: 3.1.0, 3.0.2 > > Attachments: HADOOP-15289-001.patch > > > As covered inHBASE-20123, "Backup test fails against hadoop 3; ", I think > the assert at the end of {{FileStatus.readFields()}} is wrong; if you run the > code with assert=true against a directory, an IOE will get raised. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15289) FileStatus.readFields() assertion incorrect
[ https://issues.apache.org/jira/browse/HADOOP-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386870#comment-16386870 ] genericqa commented on HADOOP-15289: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 33s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 23s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m 7s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 58s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 26s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 21s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 13m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 8m 43s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 8s{color} | {color:red} hadoop-common in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 31s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 81m 15s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.ha.TestZKFailoverController | | | hadoop.ha.TestZKFailoverControllerStress | | | hadoop.fs.shell.TestCopyFromLocal | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d4cc50f | | JIRA Issue | HADOOP-15289 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12913104/HADOOP-15289-001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 19ffd8d5fb75 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12 21:23:04 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 245751f | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/14258/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/14258/testReport/ | | Max. process+thread count | 1385 (vs. ulimit of 1) | | modules | C:
[jira] [Commented] (HADOOP-15289) FileStatus.readFields() assertion incorrect
[ https://issues.apache.org/jira/browse/HADOOP-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386812#comment-16386812 ] Chris Douglas commented on HADOOP-15289: +1 > FileStatus.readFields() assertion incorrect > --- > > Key: HADOOP-15289 > URL: https://issues.apache.org/jira/browse/HADOOP-15289 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 3.0.0, 3.1.0 >Reporter: Steve Loughran >Priority: Critical > Attachments: HADOOP-15289-001.patch > > > As covered inHBASE-20123, "Backup test fails against hadoop 3; ", I think > the assert at the end of {{FileStatus.readFields()}} is wrong; if you run the > code with assert=true against a directory, an IOE will get raised. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15289) FileStatus.readFields() assertion incorrect
[ https://issues.apache.org/jira/browse/HADOOP-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386776#comment-16386776 ] Ted Yu commented on HADOOP-15289: - Thanks for the quick fix, Steve. lgtm > FileStatus.readFields() assertion incorrect > --- > > Key: HADOOP-15289 > URL: https://issues.apache.org/jira/browse/HADOOP-15289 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 3.0.0, 3.1.0 >Reporter: Steve Loughran >Priority: Critical > Attachments: HADOOP-15289-001.patch > > > As covered inHBASE-20123, "Backup test fails against hadoop 3; ", I think > the assert at the end of {{FileStatus.readFields()}} is wrong; if you run the > code with assert=true against a directory, an IOE will get raised. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15289) FileStatus.readFields() assertion incorrect
[ https://issues.apache.org/jira/browse/HADOOP-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386767#comment-16386767 ] Steve Loughran commented on HADOOP-15289: - a one line fix. No test, so I expect reviews by: +[~te...@apache.org], [~chris.douglas] > FileStatus.readFields() assertion incorrect > --- > > Key: HADOOP-15289 > URL: https://issues.apache.org/jira/browse/HADOOP-15289 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 3.0.0, 3.1.0 >Reporter: Steve Loughran >Priority: Critical > Attachments: HADOOP-15289-001.patch > > > As covered inHBASE-20123, "Backup test fails against hadoop 3; ", I think > the assert at the end of {{FileStatus.readFields()}} is wrong; if you run the > code with assert=true against a directory, an IOE will get raised. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org