[jira] [Commented] (HADOOP-15316) GenericTestUtils can exceed maxSleepTime
[
https://issues.apache.org/jira/browse/HADOOP-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541860#comment-16541860
]
Sean Mackrory commented on HADOOP-15316:
Committed & pushed.
> GenericTestUtils can exceed maxSleepTime
>
>
> Key: HADOOP-15316
> URL: https://issues.apache.org/jira/browse/HADOOP-15316
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Sean Mackrory
>Assignee: Adam Antal
>Priority: Trivial
> Attachments: HADOOP-15316.001.patch
>
>
> Probably shouldn't ever cause an issue, especially since Thread.sleep() can
> cause longer delays beyond your control anyway, but for larger values this
> could still behave unpredicatably in practice.
> {code:java}
> Thread.sleep(r.nextInt(maxSleepTime) + minSleepTime);
> {code}
> should be
> {code:java}
> Thread.sleep(r.nextInt(maxSleepTime - minSleepTime) + minSleepTime){code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15316) GenericTestUtils can exceed maxSleepTime
[
https://issues.apache.org/jira/browse/HADOOP-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541810#comment-16541810
]
Sean Mackrory commented on HADOOP-15316:
+1 - will commit shortly. Test passes for me too, and its dependency on
GenericTestUtils is not related.
> GenericTestUtils can exceed maxSleepTime
>
>
> Key: HADOOP-15316
> URL: https://issues.apache.org/jira/browse/HADOOP-15316
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Sean Mackrory
>Assignee: Adam Antal
>Priority: Trivial
> Attachments: HADOOP-15316.001.patch
>
>
> Probably shouldn't ever cause an issue, especially since Thread.sleep() can
> cause longer delays beyond your control anyway, but for larger values this
> could still behave unpredicatably in practice.
> {code:java}
> Thread.sleep(r.nextInt(maxSleepTime) + minSleepTime);
> {code}
> should be
> {code:java}
> Thread.sleep(r.nextInt(maxSleepTime - minSleepTime) + minSleepTime){code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15316) GenericTestUtils can exceed maxSleepTime
[
https://issues.apache.org/jira/browse/HADOOP-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541523#comment-16541523
]
Adam Antal commented on HADOOP-15316:
-
The failed test passes on my computer.
> GenericTestUtils can exceed maxSleepTime
>
>
> Key: HADOOP-15316
> URL: https://issues.apache.org/jira/browse/HADOOP-15316
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Sean Mackrory
>Assignee: Adam Antal
>Priority: Trivial
> Attachments: HADOOP-15316.001.patch
>
>
> Probably shouldn't ever cause an issue, especially since Thread.sleep() can
> cause longer delays beyond your control anyway, but for larger values this
> could still behave unpredicatably in practice.
> {code:java}
> Thread.sleep(r.nextInt(maxSleepTime) + minSleepTime);
> {code}
> should be
> {code:java}
> Thread.sleep(r.nextInt(maxSleepTime - minSleepTime) + minSleepTime){code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15316) GenericTestUtils can exceed maxSleepTime
[
https://issues.apache.org/jira/browse/HADOOP-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539820#comment-16539820
]
genericqa commented on HADOOP-15316:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 27m
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 27m
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 4s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 28m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 58s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 24s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
39s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}126m 13s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.security.token.delegation.TestZKDelegationTokenSecretManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HADOOP-15316 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12931030/HADOOP-15316.001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux f921931f0a53 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 7f1d3d0 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/14874/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/14874/testReport/ |
| Max. process+thread count | 1507 (vs. ulimit of 1) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/14874/console |
| Powered by | Apache
[jira] [Commented] (HADOOP-15316) GenericTestUtils can exceed maxSleepTime
[
https://issues.apache.org/jira/browse/HADOOP-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539674#comment-16539674
]
Sean Mackrory commented on HADOOP-15316:
Thanks for picking this up. The code looks good to me. +1 pending a clean Yetus
run.
> GenericTestUtils can exceed maxSleepTime
>
>
> Key: HADOOP-15316
> URL: https://issues.apache.org/jira/browse/HADOOP-15316
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Sean Mackrory
>Assignee: Adam Antal
>Priority: Trivial
> Attachments: HADOOP-15316.001.patch
>
>
> Probably shouldn't ever cause an issue, especially since Thread.sleep() can
> cause longer delays beyond your control anyway, but for larger values this
> could still behave unpredicatably in practice.
> {code:java}
> Thread.sleep(r.nextInt(maxSleepTime) + minSleepTime);
> {code}
> should be
> {code:java}
> Thread.sleep(r.nextInt(maxSleepTime - minSleepTime) + minSleepTime){code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
