[jira] [Commented] (HADOOP-15366) Add a helper shutdown routine in HadoopExecutor to ensure clean shutdown
[
https://issues.apache.org/jira/browse/HADOOP-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429314#comment-16429314
]
Hudson commented on HADOOP-15366:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13940 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/13940/])
HADOOP-15366. Add a helper shutdown routine in HadoopExecutor to ensure
(msingh: rev 0b345b765370515d7222154ad5cae9b86f137a76)
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/concurrent/HadoopExecutors.java
> Add a helper shutdown routine in HadoopExecutor to ensure clean shutdown
>
>
> Key: HADOOP-15366
> URL: https://issues.apache.org/jira/browse/HADOOP-15366
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Shashikant Banerjee
>Assignee: Shashikant Banerjee
>Priority: Minor
> Fix For: 3.2.0
>
> Attachments: HADOOP-15366.000.patch
>
>
> It is recommended to shut down an {{ExecutorService}} in two phases, first by
> calling {{shutdown}} to reject incoming tasks, and then calling
> {{shutdownNow}}, if necessary, to cancel any lingering tasks. This Jira aims
> to add a helper shutdown routine in Hadoop executor to achieve the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15366) Add a helper shutDown routine in HadoopExecutor to ensure clean shutdown
[
https://issues.apache.org/jira/browse/HADOOP-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429292#comment-16429292
]
Mukul Kumar Singh commented on HADOOP-15366:
Thanks for working on this [~shashikant].
+1, v0 patch looks good to me. I will commit this shortly.
> Add a helper shutDown routine in HadoopExecutor to ensure clean shutdown
>
>
> Key: HADOOP-15366
> URL: https://issues.apache.org/jira/browse/HADOOP-15366
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Shashikant Banerjee
>Assignee: Shashikant Banerjee
>Priority: Minor
> Attachments: HADOOP-15366.000.patch
>
>
> It is recommended to shut down an {{ExecutorService}} in two phases, first by
> calling {{shutdown}} to reject incoming tasks, and then calling
> {{shutdownNow}}, if necessary, to cancel any lingering tasks. This Jira aims
> to add a helper shutdown routine in Hadoop executor to achieve the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15366) Add a helper shutDown routine in HadoopExecutor to ensure clean shutdown
[
https://issues.apache.org/jira/browse/HADOOP-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427933#comment-16427933
]
genericqa commented on HADOOP-15366:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 27m
39s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 10s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 26m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 26m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 11s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
12s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
36s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}120m 5s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b |
| JIRA Issue | HADOOP-15366 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12917765/HADOOP-15366.000.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux fdd4a2ee4f55 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 6cf023f |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/1/testReport/ |
| Max. process+thread count | 1525 (vs. ulimit of 1) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/1/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Add a helper shutDown
[jira] [Commented] (HADOOP-15366) Add a helper shutDown routine in HadoopExecutor to ensure clean shutdown
[
https://issues.apache.org/jira/browse/HADOOP-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427508#comment-16427508
]
Shashikant Banerjee commented on HADOOP-15366:
--
Patch v0 adds a helper shutdown routine for hadoop executor service.
> Add a helper shutDown routine in HadoopExecutor to ensure clean shutdown
>
>
> Key: HADOOP-15366
> URL: https://issues.apache.org/jira/browse/HADOOP-15366
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Shashikant Banerjee
>Assignee: Shashikant Banerjee
>Priority: Minor
> Attachments: HADOOP-15366.000.patch
>
>
> It is recommended to shut down an {{ExecutorService}} in two phases, first by
> calling {{shutdown}} to reject incoming tasks, and then calling
> {{shutdownNow}}, if necessary, to cancel any lingering tasks. This Jira aims
> to add a helper shutdown routine in Hadoop executor to achieve the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
