[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084523#comment-17084523 ] Masatake Iwasaki commented on HADOOP-16982: --- committed to branch-3.2 and branch-3.1 > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0, 3.1.4, 3.2.2 > > Attachments: HADOOP-16982-branch-3.1.001.patch, > HADOOP-16982-branch-3.2.001.patch, HADOOP-16982.001.patch, > HADOOP-16982.002.patch, HADOOP-16982.003.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084481#comment-17084481 ] Masatake Iwasaki commented on HADOOP-16982: --- I'm backporting this to lower branches. HADOOP-16579 updated ZooKeeper fom 3.4.13 to 3.5.6. Only trunk and branch-3.3 has HADOOP-16579. Since ZooKeeper 3.4.13 does not depend on Netty, the exclusion part is not needed for lower branches. I will push the commit after testing on my local. QA build does not kick unit tests in sub-projects without change. > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0 > > Attachments: HADOOP-16982-branch-3.2.001.patch, > HADOOP-16982.001.patch, HADOOP-16982.002.patch, HADOOP-16982.003.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083644#comment-17083644 ] Hudson commented on HADOOP-16982: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18144 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/18144/]) HADOOP-16982. Update Netty to 4.1.48.Final. Contributed by Lisheng Sun. (iwasakims: rev ae474e1ae587569e7ccc2526537a0e6a90ebdfa9) * (edit) hadoop-project/pom.xml > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0 > > Attachments: HADOOP-16982.001.patch, HADOOP-16982.002.patch, > HADOOP-16982.003.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083631#comment-17083631 ] Masatake Iwasaki commented on HADOOP-16982: --- +1 on 003. Committing this. > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0 > > Attachments: HADOOP-16982.001.patch, HADOOP-16982.002.patch, > HADOOP-16982.003.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[
https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083403#comment-17083403
]
Hadoop QA commented on HADOOP-16982:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
34m 47s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 21s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
12s{color} | {color:green} hadoop-project in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 Image:yetus/hadoop:e6455cc864d |
| JIRA Issue | HADOOP-16982 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/1224/HADOOP-16982.003.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml |
| uname | Linux 064383029a73 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / aeeebc5 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_242 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16885/testReport/ |
| Max. process+thread count | 312 (vs. ulimit of 5500) |
| modules | C: hadoop-project U: hadoop-project |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16885/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Update Netty to 4.1.48.Final
>
>
> Key: HADOOP-16982
> URL: https://issues.apache.org/jira/browse/HADOOP-16982
> Project: Hadoop Common
> Issue Type: Task
>Affects Versions: 3.3.0
>Reporter: Wei-Chiu Chuang
>Assignee: Lisheng Sun
>Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: HADOOP-16982.001.patch, HADOOP-16982.002.patch,
>
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083353#comment-17083353 ] Lisheng Sun commented on HADOOP-16982: -- Thanx [~iwasakims] for your report. I updated the v003 patch. > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0 > > Attachments: HADOOP-16982.001.patch, HADOOP-16982.002.patch, > HADOOP-16982.003.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083311#comment-17083311 ] Masatake Iwasaki commented on HADOOP-16982: --- [~leosun08] io.netty:netty-handler and io.netty:netty-transport-native-epoll must be excluded too. Those bring conflicting dependencies. > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0 > > Attachments: HADOOP-16982.001.patch, HADOOP-16982.002.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[
https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083281#comment-17083281
]
Hadoop QA commented on HADOOP-16982:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
0s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m
3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
42m 56s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
16m 56s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
14s{color} | {color:green} hadoop-project in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 64m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 Image:yetus/hadoop:e6455cc864d |
| JIRA Issue | HADOOP-16982 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12999898/HADOOP-16982.002.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml |
| uname | Linux ee6332c5d08c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / aeeebc5 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_242 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16884/testReport/ |
| Max. process+thread count | 309 (vs. ulimit of 5500) |
| modules | C: hadoop-project U: hadoop-project |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16884/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Update Netty to 4.1.48.Final
>
>
> Key: HADOOP-16982
> URL: https://issues.apache.org/jira/browse/HADOOP-16982
> Project: Hadoop Common
> Issue Type: Task
>Affects Versions: 3.3.0
>Reporter: Wei-Chiu Chuang
>Assignee: Lisheng Sun
>Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: HADOOP-16982.001.patch, HADOOP-16982.002.patch
>
>
> We are currently
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083212#comment-17083212 ] Lisheng Sun commented on HADOOP-16982: -- Sorry, I leave for a long time. I really did not pay attention to the problem of jar conflicts. According to the above comment, I will update this patch later. > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0 > > Attachments: HADOOP-16982.001.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[
https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083136#comment-17083136
]
Masatake Iwasaki commented on HADOOP-16982:
---
{quote}
By Excluding netty jars from zookeeper test-jar, the testcase works fine.
{quote}
This should be reasonable solution. Since those transient netty dependencies
are already excluded in compile scope, Hadoop does not assume ZooKeeper's netty
features.
> Update Netty to 4.1.48.Final
>
>
> Key: HADOOP-16982
> URL: https://issues.apache.org/jira/browse/HADOOP-16982
> Project: Hadoop Common
> Issue Type: Task
>Affects Versions: 3.3.0
>Reporter: Wei-Chiu Chuang
>Assignee: Lisheng Sun
>Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: HADOOP-16982.001.patch
>
>
> We are currently on Netty 4.1.45.Final. We should update to the latest
> 4.1.48.Final
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[
https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083095#comment-17083095
]
Prabhu Joseph commented on HADOOP-16982:
By Excluding netty jars from zookeeper test-jar, the testcase works fine.
{code}
HW12663:hadoop pjoseph$ git diff
diff --git a/hadoop-project/pom.xml b/hadoop-project/pom.xml
index 0048cc5..229c690 100644
--- a/hadoop-project/pom.xml
+++ b/hadoop-project/pom.xml
@@ -140,7 +140,7 @@
4.1.0-incubating
3.2.4
3.10.6.Final
-4.1.45.Final
+4.1.48.Final
0.5.1
@@ -1305,6 +1305,18 @@
jline
jline
+
+io.netty
+netty-all
+
+
+io.netty
+netty-handler
+
+
+io.netty
+netty-transport-native-epoll
+
{code}
> Update Netty to 4.1.48.Final
>
>
> Key: HADOOP-16982
> URL: https://issues.apache.org/jira/browse/HADOOP-16982
> Project: Hadoop Common
> Issue Type: Task
>Affects Versions: 3.3.0
>Reporter: Wei-Chiu Chuang
>Assignee: Lisheng Sun
>Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: HADOOP-16982.001.patch
>
>
> We are currently on Netty 4.1.45.Final. We should update to the latest
> 4.1.48.Final
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083087#comment-17083087 ] Masatake Iwasaki commented on HADOOP-16982: --- Thanks, [~prabhujoseph] :-) > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0 > > Attachments: HADOOP-16982.001.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083085#comment-17083085 ] Prabhu Joseph commented on HADOOP-16982: Zookeeper test-jar brings netty-4.1.42.Final which is conflicting. INFO] +- org.apache.zookeeper:zookeeper:test-jar:tests:3.5.6:test [INFO] | +- org.apache.zookeeper:zookeeper-jute:jar:3.5.6:provided [INFO] | +- org.apache.yetus:audience-annotations:jar:0.5.0:provided [INFO] | +- io.netty:netty-handler:jar:4.1.42.Final:test > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0 > > Attachments: HADOOP-16982.001.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[
https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083084#comment-17083084
]
Masatake Iwasaki commented on HADOOP-16982:
---
netty-* jars in dependency tree with the patch applied.
{noformat}
$ cd hadoop-hdfs-project/hadoop-hdfs
$ mvn dependency:tree
...
[INFO] +- org.apache.zookeeper:zookeeper:test-jar:tests:3.5.6:test
[INFO] | +- org.apache.zookeeper:zookeeper-jute:jar:3.5.6:provided
[INFO] | +- org.apache.yetus:audience-annotations:jar:0.5.0:provided
[INFO] | +- io.netty:netty-handler:jar:4.1.42.Final:test
[INFO] | | +- io.netty:netty-common:jar:4.1.42.Final:test
[INFO] | | +- io.netty:netty-buffer:jar:4.1.42.Final:test
[INFO] | | +- io.netty:netty-transport:jar:4.1.42.Final:test
[INFO] | | | \- io.netty:netty-resolver:jar:4.1.42.Final:test
[INFO] | | \- io.netty:netty-codec:jar:4.1.42.Final:test
[INFO] | \- io.netty:netty-transport-native-epoll:jar:4.1.42.Final:test
[INFO] | \-
io.netty:netty-transport-native-unix-common:jar:4.1.42.Final:test
...
[INFO] +- io.netty:netty-all:jar:4.1.48.Final:compile
...
{noformat}
If I explicitly set the version of netty-codec to 4.1.48.Final, the test passed.
> Update Netty to 4.1.48.Final
>
>
> Key: HADOOP-16982
> URL: https://issues.apache.org/jira/browse/HADOOP-16982
> Project: Hadoop Common
> Issue Type: Task
>Affects Versions: 3.3.0
>Reporter: Wei-Chiu Chuang
>Assignee: Lisheng Sun
>Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: HADOOP-16982.001.patch
>
>
> We are currently on Netty 4.1.45.Final. We should update to the latest
> 4.1.48.Final
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083073#comment-17083073 ] Alexey Diomin commented on HADOOP-16982: need to validate dependency tree AppendableCharSequence.setLength was introduced with patch [https://github.com/netty/netty/commit/9ae782d632ff18f7c9e645c58458b3180d257ff3] Looks like you have old classes for netty common and new classes for netty codec-http > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0 > > Attachments: HADOOP-16982.001.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[
https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083056#comment-17083056
]
Masatake Iwasaki commented on HADOOP-16982:
---
Hmm.. The test has no problem without the patch for me. With the patch, the
test fails with following stacktrace in the test log.
{noformat}
2020-04-14 18:55:40,096 [nioEventLoopGroup-3-1] ERROR web.DatanodeHttpServer
(RestCsrfPreventionFilterHandler.java:exceptionCaught(94)) - Exception in
RestCsrfPreventionFilterHandler
java.lang.NoSuchMethodError:
io.netty.util.internal.AppendableCharSequence.setLength(I)V
at
io.netty.handler.codec.http.HttpObjectDecoder$HeaderParser.process(HttpObjectDecoder.java:893)
at
io.netty.handler.codec.http.HttpObjectDecoder$LineParser.process(HttpObjectDecoder.java:941)
at
io.netty.buffer.AbstractByteBuf.forEachByteAsc0(AbstractByteBuf.java:1350)
at
io.netty.buffer.AbstractByteBuf.forEachByte(AbstractByteBuf.java:1330)
at
io.netty.handler.codec.http.HttpObjectDecoder$HeaderParser.parse(HttpObjectDecoder.java:872)
at
io.netty.handler.codec.http.HttpObjectDecoder$LineParser.parse(HttpObjectDecoder.java:928)
at
io.netty.handler.codec.http.HttpObjectDecoder.decode(HttpObjectDecoder.java:195)
at
io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:505)
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:444)
at
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:283)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:374)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:360)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:352)
at
io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1422)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:374)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:360)
at
io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:931)
at
io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:163)
at
io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:700)
at
io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:635)
at
io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:552)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:514)
at
io.netty.util.concurrent.SingleThreadEventExecutor$6.run(SingleThreadEventExecutor.java:1044)
at
io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:748)
{noformat}
> Update Netty to 4.1.48.Final
>
>
> Key: HADOOP-16982
> URL: https://issues.apache.org/jira/browse/HADOOP-16982
> Project: Hadoop Common
> Issue Type: Task
>Affects Versions: 3.3.0
>Reporter: Wei-Chiu Chuang
>Assignee: Lisheng Sun
>Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: HADOOP-16982.001.patch
>
>
> We are currently on Netty 4.1.45.Final. We should update to the latest
> 4.1.48.Final
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[ https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082911#comment-17082911 ] Lisheng Sun commented on HADOOP-16982: -- [~iwasakims] Revert this patch, I run the UT TestDatanodeHttpXFrame#testDataNodeXFrameOptionsEnabled failed in my local. this failed ut is unrelated to this patch. > Update Netty to 4.1.48.Final > > > Key: HADOOP-16982 > URL: https://issues.apache.org/jira/browse/HADOOP-16982 > Project: Hadoop Common > Issue Type: Task >Affects Versions: 3.3.0 >Reporter: Wei-Chiu Chuang >Assignee: Lisheng Sun >Priority: Blocker > Fix For: 3.3.0 > > Attachments: HADOOP-16982.001.patch > > > We are currently on Netty 4.1.45.Final. We should update to the latest > 4.1.48.Final -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[
https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082843#comment-17082843
]
Masatake Iwasaki commented on HADOOP-16982:
---
TestDatanodeHttpXFrame fails with the patch on my local. This looks relevant.
Thanks, [~leosun08] and [~weichiu].
{noformat}
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.187 s
<<< FAILURE! - in
org.apache.hadoop.hdfs.server.datanode.web.TestDatanodeHttpXFrame
[ERROR]
testDataNodeXFrameOptionsEnabled(org.apache.hadoop.hdfs.server.datanode.web.TestDatanodeHttpXFrame)
Time elapsed: 0.65 s <<< FAILURE!
java.lang.AssertionError: X-FRAME-OPTIONS is absent in the header
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at
org.apache.hadoop.hdfs.server.datanode.web.TestDatanodeHttpXFrame.testDataNodeXFrameOptionsEnabled(TestDatanodeHttpXFrame.java:60)
...
{noformat}
> Update Netty to 4.1.48.Final
>
>
> Key: HADOOP-16982
> URL: https://issues.apache.org/jira/browse/HADOOP-16982
> Project: Hadoop Common
> Issue Type: Task
>Affects Versions: 3.3.0
>Reporter: Wei-Chiu Chuang
>Assignee: Lisheng Sun
>Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: HADOOP-16982.001.patch
>
>
> We are currently on Netty 4.1.45.Final. We should update to the latest
> 4.1.48.Final
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16982) Update Netty to 4.1.48.Final
[
https://issues.apache.org/jira/browse/HADOOP-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082814#comment-17082814
]
Hadoop QA commented on HADOOP-16982:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
35m 29s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
16s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 19s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
12s{color} | {color:green} hadoop-project in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 53m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 Image:yetus/hadoop:e6455cc864d |
| JIRA Issue | HADOOP-16982 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12999843/HADOOP-16982.001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml |
| uname | Linux 3967e1029634 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 3edbe87 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_242 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16882/testReport/ |
| Max. process+thread count | 309 (vs. ulimit of 5500) |
| modules | C: hadoop-project U: hadoop-project |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16882/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Update Netty to 4.1.48.Final
>
>
> Key: HADOOP-16982
> URL: https://issues.apache.org/jira/browse/HADOOP-16982
> Project: Hadoop Common
> Issue Type: Task
>Affects Versions: 3.3.0
>Reporter: Wei-Chiu Chuang
>Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: HADOOP-16982.001.patch
>
>
> We are currently on Netty 4.1.45.Final. We should update to the latest
>
