Re: [DBCP] Remove SQLNestedException

2007-07-24 Thread Phil Steitz
On 7/24/07, Rahul Akolkar <[EMAIL PROTECTED]> wrote: On 7/24/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: > On Jul 24, 2007, at 7:56 AM, Phil Steitz wrote: > > > On 7/23/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: > >> > >> So, should we drop SQLNestedException? > > > > This is tempting, but

Re: [DBCP] Remove SQLNestedException

2007-07-24 Thread Rahul Akolkar
On 7/24/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: On Jul 24, 2007, at 7:56 AM, Phil Steitz wrote: > On 7/23/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: >> >> So, should we drop SQLNestedException? > > This is tempting, but it breaks backward compatibility, so we should > probably deprec

Re: [DBCP] Remove SQLNestedException

2007-07-24 Thread Dain Sundstrom
On Jul 24, 2007, at 7:56 AM, Phil Steitz wrote: On 7/23/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: DBCP-143 talks about problem with propagation of SQLNestedException to clients and the comment suggests a conversion to normal Java nested exception when we switch to Java 1.4. Since we made t

Re: [DBCP] Remove SQLNestedException

2007-07-24 Thread Phil Steitz
On 7/23/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: DBCP-143 talks about problem with propagation of SQLNestedException to clients and the comment suggests a conversion to normal Java nested exception when we switch to Java 1.4. Since we made the leap, I did a bit of refactoring to remove this

[DBCP] Remove SQLNestedException

2007-07-23 Thread Dain Sundstrom
DBCP-143 talks about problem with propagation of SQLNestedException to clients and the comment suggests a conversion to normal Java nested exception when we switch to Java 1.4. Since we made the leap, I did a bit of refactoring to remove this exception class. Basically I replace: new