Validator inside of Email.java (RE: [email] Dumbster failing)

2004-10-26 Thread Matthias Wessendorf
- From: Eric Pugh [mailto:[EMAIL PROTECTED] Sent: Monday, October 25, 2004 11:35 PM Cc: Jakarta Commons Developers List Subject: RE: [email] Dumbster failing Not a problem. I appreciate your working with me on this. I am looking forward to getting [email] whipped into shape! ERi

RE: Validator inside of Email.java (RE: [email] Dumbster failing)

2004-10-26 Thread Matthias Wessendorf
AM To: 'Jakarta Commons Developers List'; [EMAIL PROTECTED] Subject: Validator inside of Email.java (RE: [email] Dumbster failing) Hi Eric, I just update my email sources. and looked abit on the patches you are submitting. Cool to have some unittest. Btw. I saw that EmailValidator

Re: Validator inside of Email.java (RE: [email] Dumbster failing)

2004-10-26 Thread Corey Scott
Matthias, I definately agree with you, inputs (emails in this case) should be validated before submission to a low level api such as [email]. However I added the validation just to make sure. I guess you could call it 'defensive' coding. I am happy to remove this and numerous other input

[email] was RE: Validator inside of Email.java (RE: [email] Dumbster failing)

2004-10-26 Thread Eric Pugh
! -Original Message- From: Matthias Wessendorf [mailto:[EMAIL PROTECTED] Sent: Tuesday, October 26, 2004 9:25 AM To: 'Jakarta Commons Developers List' Subject: RE: Validator inside of Email.java (RE: [email] Dumbster failing) Want to say: A object represented by a clazz (subclass

Re: [email] was RE: Validator inside of Email.java (RE: [email] Dumbster failing)

2004-10-26 Thread Stephen Colebourne
- Original Message - From: Eric Pugh [EMAIL PROTECTED] So, on the second side.. I guess, to what extent do we validate email information? I agree that requiring commons-validator seems a bit much for a small project like [email] just to use it. On the other hand, it does wrap the

Re: [email] was RE: Validator inside of Email.java (RE: [email] Dumbster failing)

2004-10-26 Thread Corey Scott
I believe the code for email validation is not too much (certainly less than the whole of validator package). Are you thinking of duplicating it in place of the validation reference or removing the validation from the functions and providing a validation function? Either of which should not be

RE: Validator inside of Email.java (RE: [email] Dumbster failing)

2004-10-26 Thread Eric Pugh
(RE: [email] Dumbster failing) Matthias, I definately agree with you, inputs (emails in this case) should be validated before submission to a low level api such as [email]. However I added the validation just to make sure. I guess you could call it 'defensive' coding. I am happy to remove

RE: [email] was RE: Validator inside of Email.java (RE: [email] Dumbster failing)

2004-10-26 Thread Matthias Wessendorf
: Tuesday, October 26, 2004 9:09 AM To: 'Jakarta Commons Developers List'; [EMAIL PROTECTED] Subject: Validator inside of Email.java (RE: [email] Dumbster failing) Hi Eric, I just update my email sources. and looked abit on the patches you are submitting. Cool to have

Re: Validator inside of Email.java (RE: [email] Dumbster failing)

2004-10-26 Thread David Graham
Message- From: Eric Pugh [mailto:[EMAIL PROTECTED] Sent: Monday, October 25, 2004 11:35 PM Cc: Jakarta Commons Developers List Subject: RE: [email] Dumbster failing Not a problem. I appreciate your working with me on this. I am looking forward to getting [email] whipped

Re: Validator inside of Email.java (RE: [email] Dumbster failing)

2004-10-26 Thread Corey Scott
So have we reached a concensus on all of this? To summarize: -Validation should NOT be included in the current version -This issue will be revisited after the release -The current functionality is appropriate AS IS -The major targets we have now prior to a first release are: 1) Complete the Unit

RE: [email] Dumbster failing

2004-10-25 Thread Eric Pugh
! We'll get there! It's nice to see new life in [email]. Eric -Original Message- From: Corey Scott [mailto:[EMAIL PROTECTED] Sent: Monday, October 25, 2004 5:11 AM To: Jakarta Commons Developers List Subject: Re: [email] Dumbster failing Ok, I will switch my build to maven from

Re: [email] Dumbster failing

2004-10-25 Thread Corey Scott
Ok, I have the tests all up and running with Maven. I have also made some minor mods, based on the tests or improving the input checking (this is why some of the tests are failing, there where against my changes not the HEAD version sorry) So once we get this formatting issue sorted, I will

RE: [email] Dumbster failing

2004-10-25 Thread Eric Pugh
List Subject: Re: [email] Dumbster failing Ok, I have the tests all up and running with Maven. I have also made some minor mods, based on the tests or improving the input checking (this is why some of the tests are failing, there where against my changes not the HEAD version sorry) So

[email] Dumbster failing

2004-10-24 Thread Eric Pugh
Hi all, I am getting some java security issues with the current unit tests and dumbster. Can any one else (corey ;-) ) verify that they work properly? I thought it was my SMTP server, but I stopped that. Eric - To

Re: [email] Dumbster failing

2004-10-24 Thread Corey Scott
Ok, I will switch my build to maven from Ant (although Maven seemed not to like dumbster too much last time I tried it). I will get the get the tests going and resubmit. I think I'm going to have to start again from the cvs, cause my code tree is becoming too different from the committed one. I