[jira] Resolved: (BEANUTILS-252) getNestedProperty doesn't work with maps properly

2006-11-07 Thread Niall Pemberton (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-252?page=all ]

Niall Pemberton resolved BEANUTILS-252.
---

Resolution: Won't Fix

OK thats good if you've found an alternative solution, thanks for your 
response. I'm closing this as wont' fix then.

Niall

 getNestedProperty doesn't work with maps properly
 -

 Key: BEANUTILS-252
 URL: http://issues.apache.org/jira/browse/BEANUTILS-252
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
Affects Versions: 1.7.0
 Environment: Any
Reporter: Masker71

 Hello,
 Here is an example of PropertyUtils.getProperty use:
 HashMap myMap = new HashMap();
 myMap.put(key,value);
 Request:
 System.out.println(PropertyUtils.getProperty(myMap, (key)));
 Result:
 null
 Workaround:
 HashMap myMap = new HashMap();
 myMap.put((key),value);
 Request:
 System.out.println(PropertyUtils.getProperty(myMap, (key)));
 Result:
 value
 The reason of this behaviour is that in the implementation of 
 PropertyUtilsBean.getNestedProperty function.
 Currently it doesn't extract 'key' from brackets. variable name is equal to 
 (key) when this method is invoked
 and it is used to extract value from the map:
 indexOfINDEXED_DELIM = name.indexOf(PropertyUtils.INDEXED_DELIM);
 indexOfMAPPED_DELIM = name.indexOf(PropertyUtils.MAPPED_DELIM);
 if (bean instanceof Map) {
 bean = ((Map) bean).get(name);
 } else if (indexOfMAPPED_DELIM = 0) {
 bean = getMappedProperty(bean, name);
 } else if (indexOfINDEXED_DELIM = 0) {
 bean = getIndexedProperty(bean, name);
 } else {
 bean = getSimpleProperty(bean, name);
 }
  For the bean methods which returs maps key extraction is performed, why it 
 isn't done for the Map? Cannot I use any string as a key in the map, why 
 should I use keys enveloped in brackets? I think what is mentioned to do is 
 that:
 indexOfINDEXED_DELIM = name.indexOf(PropertyUtils.INDEXED_DELIM);
 indexOfMAPPED_DELIM = name.indexOf(PropertyUtils.MAPPED_DELIM);
 indexOfMAPPED_DELIM2 = name.indexOf(PropertyUtils.MAPPED_DELIM2);
 if (bean instanceof Map) {
 if (indexOfMAPPED_DELIM = 0  indexOfMAPPED_DELIM2=0)
 name = name.substring(indexOfMAPPED_DELIM+1, 
 indexOfMAPPED_DELIM2);
 bean = ((Map) bean).get(name);
 } 
 Hope description was clear enough and you will approve it as a bug.
 Thank you

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [VOTE] Release commons-parent pom

2006-11-07 Thread Jörg Schaible
+1

Dennis Lundberg wrote on Monday, November 06, 2006 6:48 PM:

 Hello
 
 This is a new vote following up on the failed vote [1] that was held
 previously. 
 
 As far as I can tell, all the issues that were raised in the earlier
 vote has been addressed. So please cast your votes.
 
 This vote will be open for 72 hours and I will tally the votes no
 earlier than 19:00 GMT+1 on November 9th.
 
 [ ] +1
 [ ] =0
 [ ] -1
 
 
 [1]
 http://mail-archives.apache.org/mod_mbox/jakarta-commons-dev/2
00610.mbox/[EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release commons-parent pom

2006-11-07 Thread Niall Pemberton

+1 from me (I assume the version number will be updated from
1-SNAPSHOT when you do the actual release).

Niall

On 11/6/06, Dennis Lundberg [EMAIL PROTECTED] wrote:

Hello

This is a new vote following up on the failed vote [1] that was held
previously.

As far as I can tell, all the issues that were raised in the earlier
vote has been addressed. So please cast your votes.

This vote will be open for 72 hours and I will tally the votes no
earlier than 19:00 GMT+1 on November 9th.

[ ] +1
[ ] =0
[ ] -1


[1]
http://mail-archives.apache.org/mod_mbox/jakarta-commons-dev/200610.mbox/[EMAIL 
PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472025 - /jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java

2006-11-07 Thread niallp
Author: niallp
Date: Tue Nov  7 00:31:59 2006
New Revision: 472025

URL: http://svn.apache.org/viewvc?view=revrev=472025
Log:
BEANUTILS-64 - Add tests to new ArrayConverter to ensure leading/trailing 
spaces are not an issue

Modified:

jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java

Modified: 
jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java?view=diffrev=472025r1=472024r2=472025
==
--- 
jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java
 (original)
+++ 
jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java
 Tue Nov  7 00:31:59 2006
@@ -183,6 +183,60 @@
 }
 
 /**
+ * Test Converting a String[] to integer array (with leading/trailing 
whitespace)
+ */
+public void testStringArrayToNumber() {
+
+// Configure Converter
+IntegerConverter intConverter = new IntegerConverter();
+ArrayConverter arrayConverter = new ArrayConverter(int[].class, 
intConverter);
+
+// Test Data
+String[] array = new String[] {10,   11, 12  ,   13  };
+ArrayList list = new ArrayList();
+for (int i = 0; i  array.length; i++) {
+list.add(array[i]);
+}
+
+// Expected results
+String msg = null;
+int[] expectedInt = new int[] {10, 11, 12, 13};
+Integer[] expectedInteger = new Integer[] {new 
Integer(expectedInt[0]), new Integer(expectedInt[1]), new 
Integer(expectedInt[2]), new Integer(expectedInt[3])};
+
+// Test String[] -- int[]
+try {
+msg = String[] -- int[];
+checkArray(msg, expectedInt, arrayConverter.convert(int[].class, 
array));
+} catch (Exception e) {
+fail(msg +  failed  + e);
+}
+
+// Test String[] -- Integer[]
+try {
+msg = String[] -- Integer[];
+checkArray(msg, expectedInteger, 
arrayConverter.convert(Integer[].class, array));
+} catch (Exception e) {
+fail(msg +  failed  + e);
+}
+
+// Test List -- int[]
+try {
+msg = List -- int[];
+checkArray(msg, expectedInt, arrayConverter.convert(int[].class, 
list));
+} catch (Exception e) {
+fail(msg +  failed  + e);
+}
+
+// Test List -- Integer[]
+try {
+msg = List -- Integer[];
+checkArray(msg, expectedInteger, 
arrayConverter.convert(Integer[].class, list));
+} catch (Exception e) {
+fail(msg +  failed  + e);
+}
+   }
+
+/**
  * Test the Matrix (parses a String into a 2 dimensional integer array 
or matrix)
  */
 public void testTheMatrix() {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (BEANUTILS-64) [beanutils] ConvertUtils.convert returns 0 for Strings with leading blanks at converting String arrays to Integer arrays

2006-11-07 Thread Niall Pemberton (JIRA)
[ 
http://issues.apache.org/jira/browse/BEANUTILS-64?page=comments#action_12447710 
] 

Niall Pemberton commented on BEANUTILS-64:
--

This isn't an issue in the new ArrayConverter implementation (I've added tests 
ensure this issue isn't a problem there) which can be used to convert to any 
type of Number array (primitive or wrapper).

 [beanutils] ConvertUtils.convert returns 0 for Strings with leading blanks at 
 converting String arrays to Integer arrays
 

 Key: BEANUTILS-64
 URL: http://issues.apache.org/jira/browse/BEANUTILS-64
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: ConvertUtils  Converters
 Environment: Operating System: Windows XP
 Platform: PC
Reporter: Rainer Dollinger
 Assigned To: Henri Yandell
Priority: Minor
 Fix For: 1.8.0


 When using ConvertUtils.convert(String[], Class) with Integer as element type 
 to
 convert an Array of number Strings to Integer, it returns Integers with value 
 0,
 if there is a blank at the start of the number.
 If the method ConvertUtils.convert  would do a String.trim() internally on the
 elements of the String array this could be avoided.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472031 - /jakarta/commons/proper/commons-parent/trunk/pom.xml

2006-11-07 Thread niallp
Author: niallp
Date: Tue Nov  7 00:40:47 2006
New Revision: 472031

URL: http://svn.apache.org/viewvc?view=revrev=472031
Log:
Update the license header to reflect the new policy. See 
http://www.apache.org/legal/src-headers.html

Modified:
jakarta/commons/proper/commons-parent/trunk/pom.xml

Modified: jakarta/commons/proper/commons-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/commons-parent/trunk/pom.xml?view=diffrev=472031r1=472030r2=472031
==
--- jakarta/commons/proper/commons-parent/trunk/pom.xml (original)
+++ jakarta/commons/proper/commons-parent/trunk/pom.xml Tue Nov  7 00:40:47 2006
@@ -1,18 +1,19 @@
 !--
 
- Copyright 1999,2005 The Apache Software Foundation.
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the License); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
 
- Licensed under the Apache License, Version 2.0 (the License);
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
+   http://www.apache.org/licenses/LICENSE-2.0
 
-  http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an AS IS BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an AS IS BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
 
 --
 project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release commons-parent pom

2006-11-07 Thread Simon Kitching
On Mon, 2006-11-06 at 18:47 +0100, Dennis Lundberg wrote:
 Hello
 
 This is a new vote following up on the failed vote [1] that was held 
 previously.
 
 As far as I can tell, all the issues that were raised in the earlier 
 vote has been addressed. So please cast your votes.
 
 This vote will be open for 72 hours and I will tally the votes no 
 earlier than 19:00 GMT+1 on November 9th.

+1   (pmc member)



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r472006 - /jakarta/commons/proper/commons-parent/trunk/pom.xml

2006-11-07 Thread Simon Kitching
This is the old-style license header. The new style is as shown at the
top of this file:
http://svn.apache.org/repos/asf/jakarta/commons/proper/digester/trunk/build.xml

Regards,

Simon

On Tue, 2006-11-07 at 06:39 +, [EMAIL PROTECTED] wrote:
 Author: jochen
 Date: Mon Nov  6 22:39:17 2006
 New Revision: 472006
 
 URL: http://svn.apache.org/viewvc?view=revrev=472006
 Log:
 Adding the ASLv2 header.
 
 Modified:
 jakarta/commons/proper/commons-parent/trunk/pom.xml
 
 Modified: jakarta/commons/proper/commons-parent/trunk/pom.xml
 URL: 
 http://svn.apache.org/viewvc/jakarta/commons/proper/commons-parent/trunk/pom.xml?view=diffrev=472006r1=472005r2=472006
 ==
 --- jakarta/commons/proper/commons-parent/trunk/pom.xml (original)
 +++ jakarta/commons/proper/commons-parent/trunk/pom.xml Mon Nov  6 22:39:17 
 2006
 @@ -1,3 +1,20 @@
 +!--
 +
 + Copyright 1999,2005 The Apache Software Foundation.
 +
 + Licensed under the Apache License, Version 2.0 (the License);
 + you may not use this file except in compliance with the License.
 + You may obtain a copy of the License at
 +
 +  http://www.apache.org/licenses/LICENSE-2.0
 +
 + Unless required by applicable law or agreed to in writing, software
 + distributed under the License is distributed on an AS IS BASIS,
 + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 + See the License for the specific language governing permissions and
 + limitations under the License.
 +
 +--



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r472006 - /jakarta/commons/proper/commons-parent/trunk/pom.xml

2006-11-07 Thread Niall Pemberton

Fixed:

  http://svn.apache.org/viewvc?view=revrevision=472031

Niall

On 11/7/06, Simon Kitching [EMAIL PROTECTED] wrote:

This is the old-style license header. The new style is as shown at the
top of this file:
http://svn.apache.org/repos/asf/jakarta/commons/proper/digester/trunk/build.xml

Regards,

Simon

On Tue, 2006-11-07 at 06:39 +, [EMAIL PROTECTED] wrote:
 Author: jochen
 Date: Mon Nov  6 22:39:17 2006
 New Revision: 472006

 URL: http://svn.apache.org/viewvc?view=revrev=472006
 Log:
 Adding the ASLv2 header.

 Modified:
 jakarta/commons/proper/commons-parent/trunk/pom.xml

 Modified: jakarta/commons/proper/commons-parent/trunk/pom.xml
 URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/commons-parent/trunk/pom.xml?view=diffrev=472006r1=472005r2=472006
 ==
 --- jakarta/commons/proper/commons-parent/trunk/pom.xml (original)
 +++ jakarta/commons/proper/commons-parent/trunk/pom.xml Mon Nov  6 22:39:17 
2006
 @@ -1,3 +1,20 @@
 +!--
 +
 + Copyright 1999,2005 The Apache Software Foundation.
 +
 + Licensed under the Apache License, Version 2.0 (the License);
 + you may not use this file except in compliance with the License.
 + You may obtain a copy of the License at
 +
 +  http://www.apache.org/licenses/LICENSE-2.0
 +
 + Unless required by applicable law or agreed to in writing, software
 + distributed under the License is distributed on an AS IS BASIS,
 + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 + See the License for the specific language governing permissions and
 + limitations under the License.
 +
 +--



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release commons-parent pom

2006-11-07 Thread Simon Kitching
On Tue, 2006-11-07 at 07:43 +0100, Jochen Wiedmann wrote:
 On 11/7/06, Rahul Akolkar [EMAIL PROTECTED] wrote:
  c) The svn log is confident [1] the antrun bit is needed due to a bug
  in the source plugin, but subsequent conversations not so [2]. What is
  it, IYO? Figure you're as good a resource for this question.
 
 Sorry, but my english language parser (an ancient german model from
 1963, so please bear with me) can't understand your question?
 
My reading of the email referred to at [2] is confirmation that the
antrun bit *is* needed.


 
 P.S: I never experienced votes with so much considerations. Perhaps we
 should hide the POM in a zip file and add thousands of .java files, so
 that people don't look so much ... ;-)

Releases of other projects have gone through quite a few cycles too.
It's just fortunate that in this case we don't need to build RC bundles
each time :-)


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 17682] - [cli] HelpFormatter does not wrap lines correctly after the second line

2006-11-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=17682.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=17682





--- Additional Comments From [EMAIL PROTECTED]  2006-11-07 01:14 ---
Had the same problem. Since I want to use the library as is, I decided not to
use HelpFormatter at all. As this is quite an obvious bug I don't really
understand how
a) it got into the release in the first place
b) it still hasn't get fixed

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (CONFIGURATION-237) Contrib : managed reloading strategy

2006-11-07 Thread nicolas de loof (JIRA)
Contrib : managed reloading strategy


 Key: CONFIGURATION-237
 URL: http://issues.apache.org/jira/browse/CONFIGURATION-237
 Project: Commons Configuration
  Issue Type: New Feature
Affects Versions: Nightly Builds
Reporter: nicolas de loof
Priority: Minor
 Attachments: CONFIGURATION-237.patch

This patch adds a reloading strategy based on management request, typically 
from a JMX console. The Strategy implements a MBean interface so can be 
exported as a JMX Managed bean with no code change.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (CONFIGURATION-237) Contrib : managed reloading strategy

2006-11-07 Thread nicolas de loof (JIRA)
 [ http://issues.apache.org/jira/browse/CONFIGURATION-237?page=all ]

nicolas de loof updated CONFIGURATION-237:
--

Attachment: CONFIGURATION-237.patch

 Contrib : managed reloading strategy
 

 Key: CONFIGURATION-237
 URL: http://issues.apache.org/jira/browse/CONFIGURATION-237
 Project: Commons Configuration
  Issue Type: New Feature
Affects Versions: Nightly Builds
Reporter: nicolas de loof
Priority: Minor
 Attachments: CONFIGURATION-237.patch


 This patch adds a reloading strategy based on management request, typically 
 from a JMX console. The Strategy implements a MBean interface so can be 
 exported as a JMX Managed bean with no code change.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[configuration] Contrib : CONFIGURATION-237

2006-11-07 Thread Nicolas DE LOOF


I've created CONFIGURATION-237 for contributing. The patch adds a 
ManagedRealoadingStrategy taht is designed to be exposed as JMX bean to 
reload configuration from a JMX console.


Nico.



This message contains information that may be privileged or confidential and is 
the property of the Capgemini Group. It is intended only for the person to whom 
it is addressed. If you are not the intended recipient,  you are not authorized 
to read, print, retain, copy, disseminate,  distribute, or use this message or 
any part thereof. If you receive this  message in error, please notify the 
sender immediately and delete all  copies of this message.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [PROPOSAL] Major versions require package name change

2006-11-07 Thread Joerg Heinicke
Stephen Colebourne scolebourne at btopenworld.com writes:

 PROPOSAL:
 The major version number of a component, where it is greater than 1, 
 shall be included in the package name.

I really wonder why this should be a concern of the actual component at all. A
component is an encapsulated piece of software with a well-defined interface
(here API). If there are problems in the environment in using this component or
looking it up (here jar hell/classpath), then this is a problem of the
environment, not a concern of the component. Therefore this thing has also to be
fixed in the environment.

Classloader shielding is an appropriate solution. There is much ongoing work
like OSGi to standardize this and make it easier usable. So I wonder why this is
now still such a major topic though it worked ten years without it. Maybe in 2
or 3 years nobody will talk about it at all when classloader shielding is so
common and easily usable.

Jörg


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [PROPOSAL] Major versions require package name change

2006-11-07 Thread Torsten Curdt

On 11/7/06, Joerg Heinicke [EMAIL PROTECTED] wrote:

Stephen Colebourne scolebourne at btopenworld.com writes:

 PROPOSAL:
 The major version number of a component, where it is greater than 1,
 shall be included in the package name.

I really wonder why this should be a concern of the actual component at all. A
component is an encapsulated piece of software with a well-defined interface
(here API). If there are problems in the environment in using this component or
looking it up (here jar hell/classpath), then this is a problem of the
environment, not a concern of the component. Therefore this thing has also to be
fixed in the environment.

Classloader shielding is an appropriate solution. There is much ongoing work
like OSGi to standardize this and make it easier usable. So I wonder why this is
now still such a major topic though it worked ten years without it. Maybe in 2
or 3 years nobody will talk about it at all when classloader shielding is so
common and easily usable.


Classloader shielding does not help if your application uses libA and libB both
having dependencies on libC ...but of different versions - that are
incompatible.

I fail see how that is environment related.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[dbutils] Release process for dbutils-1.1. How can I help?

2006-11-07 Thread Alan Canon
Henri Yandell wrote:
 
So unless any of the non-versioned issues seem like they should go in,
it's time to start the fun of the release process.
Hen

 

Should I prepare a summary of the non-versioned issues? What else can I
do to push the release process?

 

Alan Canon

 



svn commit: r472200 - /jakarta/commons/proper/commons-parent/trunk/pom.xml

2006-11-07 Thread dennisl
Author: dennisl
Date: Tue Nov  7 10:49:33 2006
New Revision: 472200

URL: http://svn.apache.org/viewvc?view=revrev=472200
Log:
Fix the URL for the project.

Modified:
jakarta/commons/proper/commons-parent/trunk/pom.xml

Modified: jakarta/commons/proper/commons-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/commons-parent/trunk/pom.xml?view=diffrev=472200r1=472199r2=472200
==
--- jakarta/commons/proper/commons-parent/trunk/pom.xml (original)
+++ jakarta/commons/proper/commons-parent/trunk/pom.xml Tue Nov  7 10:49:33 2006
@@ -30,7 +30,7 @@
   !-- TODO: dummy version. In Maven 2.1, this will be auto-versioned being a 
generic parent --
   version1-SNAPSHOT/version
   nameJakarta Commons/name
-  urlhttp://jakarta.apache.org/commons/proper//url
+  urlhttp://jakarta.apache.org/commons//url
   inceptionYear2001/inceptionYear
 
   ciManagement



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release commons-parent pom

2006-11-07 Thread Dennis Lundberg

Rahul Akolkar wrote:

On 11/6/06, Dennis Lundberg [EMAIL PROTECTED] wrote:

Hello

This is a new vote following up on the failed vote [1] that was held
previously.

As far as I can tell, all the issues that were raised in the earlier
vote has been addressed. So please cast your votes.


snip/

Comments / questions:

a) IMO it needs a ASLv2 header


This seems to have been fixed now.


b) Incorrect URL at ${pom.url} (we need to remove proper/)


I've taken care of this.


c) The svn log is confident [1] the antrun bit is needed due to a bug
in the source plugin, but subsequent conversations not so [2]. What is
it, IYO? Figure you're as good a resource for this question.


My interpretation of the comments made in both [1] and [2] is that the 
antrun fix is needed. I haven't used the source plugin myself, so I 
can't verify this though.



-Rahul

[1] http://svn.apache.org/viewvc?view=revrevision=454001
[2] 
http://marc.theaimsgroup.com/?l=jakarta-commons-devm=116100241004848w=2

(see bottom of)



This vote will be open for 72 hours and I will tally the votes no
earlier than 19:00 GMT+1 on November 9th.

[ ] +1
[ ] =0
[ ] -1


[1]
http://mail-archives.apache.org/mod_mbox/jakarta-commons-dev/200610.mbox/[EMAIL PROTECTED] 



--
Dennis Lundberg



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




--
Dennis Lundberg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 17682] - [cli] HelpFormatter does not wrap lines correctly after the second line

2006-11-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=17682.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=17682





--- Additional Comments From [EMAIL PROTECTED]  2006-11-07 10:54 ---
Jakarta Commons has moved its issue tracking from Bugzilla to JIRA. This issue
is now at:
  http://issues.apache.org/jira/browse/CLI-37

Please make any comments you might have on this issue in JIRA.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dbutils] Release process for dbutils-1.1. How can I help?

2006-11-07 Thread Henri Yandell

On 11/7/06, Alan Canon [EMAIL PROTECTED] wrote:

Henri Yandell wrote:

So unless any of the non-versioned issues seem like they should go in,
it's time to start the fun of the release process.
Hen



Should I prepare a summary of the non-versioned issues?


Only if you think any should go in 1.1.


What else can I do to push the release process?


I did some work on it at the weekend - fixed the code to build under
1.3. I'm working on the changes.xml file (release notes), I'll have
that finished today.

Other things that jump to mind:

* We should create a pom.xml file (Maven-2 build). As long as the
parent gets deployed (cf: some other thread on commons-dev). Feel free
to take a stab at that - shouldn't be too hard as there are other
pom.xml's to (largely) copy.
* Update the site - this mostly means changing 1.0 for 1.1 if it
appears in the text, but any problems you can find/patch in the site
are good for now.
* Create a jardiff report - need to see what's changed API-wise and
add that to release notes.
* Build the ant dist and maven site and call a vote. I'll take care of
that once the other bits are done.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release commons-parent pom

2006-11-07 Thread Rahul Akolkar

On 11/7/06, Dennis Lundberg [EMAIL PROTECTED] wrote:

Rahul Akolkar wrote:

snip/


 a) IMO it needs a ASLv2 header

This seems to have been fixed now.

 b) Incorrect URL at ${pom.url} (we need to remove proper/)

I've taken care of this.

 c) The svn log is confident [1] the antrun bit is needed due to a bug
 in the source plugin, but subsequent conversations not so [2]. What is
 it, IYO? Figure you're as good a resource for this question.

My interpretation of the comments made in both [1] and [2] is that the
antrun fix is needed. I haven't used the source plugin myself, so I
can't verify this though.


snap/

Aha, a useful response. Thanks to you and Simon for your input on this.

ballot


[X] +1
[ ] =0
[ ] -1


/ballot

-Rahul

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472247 - /jakarta/commons/proper/commons-parent/trunk/pom.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 12:47:19 2006
New Revision: 472247

URL: http://svn.apache.org/viewvc?view=revrev=472247
Log:
We don't use continuum yet, so commenting that part out

Modified:
jakarta/commons/proper/commons-parent/trunk/pom.xml

Modified: jakarta/commons/proper/commons-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/commons-parent/trunk/pom.xml?view=diffrev=472247r1=472246r2=472247
==
--- jakarta/commons/proper/commons-parent/trunk/pom.xml (original)
+++ jakarta/commons/proper/commons-parent/trunk/pom.xml Tue Nov  7 12:47:19 2006
@@ -33,6 +33,8 @@
   urlhttp://jakarta.apache.org/commons//url
   inceptionYear2001/inceptionYear
 
+  !-- We don't use Continuum yet --
+  !--
   ciManagement
 systemcontinuum/system
 notifiers
@@ -43,6 +45,8 @@
   /notifier
 /notifiers
   /ciManagement
+  --
+
   distributionManagement
 
!--



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472248 - /jakarta/commons/proper/cli/trunk/pom.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 12:49:30 2006
New Revision: 472248

URL: http://svn.apache.org/viewvc?view=revrev=472248
Log:
Points to new commons-parent id

Modified:
jakarta/commons/proper/cli/trunk/pom.xml

Modified: jakarta/commons/proper/cli/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/pom.xml?view=diffrev=472248r1=472247r2=472248
==
--- jakarta/commons/proper/cli/trunk/pom.xml (original)
+++ jakarta/commons/proper/cli/trunk/pom.xml Tue Nov  7 12:49:30 2006
@@ -21,7 +21,7 @@
 xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
   parent
 groupIdorg.apache.commons/groupId
-artifactIdcommons/artifactId
+artifactIdcommons-parent/artifactId
 version1-SNAPSHOT/version
   /parent
   modelVersion4.0.0/modelVersion
@@ -37,19 +37,6 @@
   /description
 
   urlhttp://jakarta.apache.org/commons/cli//url
-
-  organization
-nameApache Software Foundation/name
-urlhttp://www.apache.org/url
-  /organization
-
-  licenses
-license
-  nameThe Apache Software License, Version 2.0/name
-  url/LICENSE.txt/url
-  distributionrepo/distribution
-/license
-  /licenses
 
   issueManagement
 systemjira/system



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472249 - /jakarta/commons/proper/io/trunk/pom.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 12:49:56 2006
New Revision: 472249

URL: http://svn.apache.org/viewvc?view=revrev=472249
Log:
Points to new commons-parent id. organization/licenses are in the top level 
apache pom, so removed. 

Modified:
jakarta/commons/proper/io/trunk/pom.xml

Modified: jakarta/commons/proper/io/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/pom.xml?view=diffrev=472249r1=472248r2=472249
==
--- jakarta/commons/proper/io/trunk/pom.xml (original)
+++ jakarta/commons/proper/io/trunk/pom.xml Tue Nov  7 12:49:56 2006
@@ -21,7 +21,7 @@
 xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
   parent
 groupIdorg.apache.commons/groupId
-artifactIdcommons/artifactId
+artifactIdcommons-parent/artifactId
 version1-SNAPSHOT/version
   /parent
   modelVersion4.0.0/modelVersion
@@ -36,19 +36,6 @@
   /description
 
   urlhttp://jakarta.apache.org/commons/io//url
-
-  organization
-nameThe Apache Software Foundation/name
-urlhttp://jakarta.apache.org/url
-  /organization
-
-  licenses
-license
-  nameThe Apache Software License, Version 2.0/name
-  url/LICENSE.txt/url
-  distributionrepo/distribution
-/license
-  /licenses
 
   issueManagement
 systemjira/system



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472251 - /jakarta/commons/proper/scxml/trunk/pom.xml

2006-11-07 Thread rahul
Author: rahul
Date: Tue Nov  7 12:53:56 2006
New Revision: 472251

URL: http://svn.apache.org/viewvc?view=revrev=472251
Log:
Correct POM inheritance.

Modified:
jakarta/commons/proper/scxml/trunk/pom.xml

Modified: jakarta/commons/proper/scxml/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/scxml/trunk/pom.xml?view=diffrev=472251r1=472250r2=472251
==
--- jakarta/commons/proper/scxml/trunk/pom.xml (original)
+++ jakarta/commons/proper/scxml/trunk/pom.xml Tue Nov  7 12:53:56 2006
@@ -19,6 +19,12 @@
 xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
 xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
 
+  parent
+groupIdorg.apache.commons/groupId
+artifactIdcommons-parent/artifactId
+version1-SNAPSHOT/version
+  /parent
+
   modelVersion4.0.0/modelVersion
   nameSCXML/name
   groupIdcommons-scxml/groupId



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release commons-parent pom

2006-11-07 Thread Henri Yandell

On 11/6/06, Dennis Lundberg [EMAIL PROTECTED] wrote:

Hello

This is a new vote following up on the failed vote [1] that was held
previously.

As far as I can tell, all the issues that were raised in the earlier
vote has been addressed. So please cast your votes.

This vote will be open for 72 hours and I will tally the votes no
earlier than 19:00 GMT+1 on November 9th.

[X] +1
[ ] =0
[ ] -1


Should we add otherArchive blocks to the mailing list, or are there
too many out there?

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472252 - /jakarta/commons/proper/logging/trunk/pom.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 12:56:49 2006
New Revision: 472252

URL: http://svn.apache.org/viewvc?view=revrev=472252
Log:
Points to the commons-parent now

Modified:
jakarta/commons/proper/logging/trunk/pom.xml

Modified: jakarta/commons/proper/logging/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/logging/trunk/pom.xml?view=diffrev=472252r1=472251r2=472252
==
--- jakarta/commons/proper/logging/trunk/pom.xml (original)
+++ jakarta/commons/proper/logging/trunk/pom.xml Tue Nov  7 12:56:49 2006
@@ -1,4 +1,25 @@
 ?xml version=1.0 encoding=UTF-8?project
+!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the License); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an AS IS BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+--
+  parent
+groupIdorg.apache.commons/groupId
+artifactIdcommons-parent/artifactId
+version1-SNAPSHOT/version
+  /parent
   modelVersion4.0.0/modelVersion
   groupIdcommons-logging/groupId
   artifactIdcommons-logging/artifactId
@@ -12,38 +33,8 @@
 urlhttp://issues.apache.org/jira//url
   /issueManagement
 
-  ciManagement
-notifiers
-  notifier
-configuration
-  addresscommons-dev@jakarta.apache.org/address
-/configuration
-  /notifier
-/notifiers
-  /ciManagement
-
   inceptionYear2001/inceptionYear
 
-  mailingLists
-mailingList
-  nameCommons Dev List/name
-  subscribe[EMAIL PROTECTED]/subscribe
-  unsubscribe[EMAIL PROTECTED]/unsubscribe
-  
archivehttp://mail-archives.apache.org/mod_mbox/jakarta-commons-dev//archive
-  otherArchives
-
archivehttp://www.mail-archive.com/commons-dev%40jakarta.apache.org//archive
-  /otherArchives
-/mailingList
-mailingList
-  nameCommons User List/name
-  subscribe[EMAIL PROTECTED]/subscribe
-  unsubscribe[EMAIL PROTECTED]/unsubscribe
-  
archivehttp://mail-archives.apache.org/mod_mbox/jakarta-commons-user//archive
-  otherArchives
-
archivehttp://www.mail-archive.com/commons-user%40jakarta.apache.org//archive
-  /otherArchives
-/mailingList
-  /mailingLists
   developers
 developer
   idmorgand/id
@@ -123,23 +114,11 @@
 /developer
   /developers
 
-  licenses
-license
-  nameThe Apache Software License, Version 2.0/name
-  url/LICENSE.txt/url
-/license
-  /licenses
-
   scm
 
connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk/connection
 
urlhttp://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk/url
   /scm
 
-  organization
-nameThe Apache Software Foundation/name
-urlhttp://jakarta.apache.org/url
-  /organization
-
   build
 sourceDirectorysrc/java/sourceDirectory
 testSourceDirectorysrc/test/testSourceDirectory
@@ -415,4 +394,4 @@
   urlscp://cvs.apache.org//www/jakarta.apache.org/commons/logging//url
 /site
   /distributionManagement
-/project
\ No newline at end of file
+/project



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472257 - /jakarta/commons/proper/scxml/trunk/pom.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 12:59:43 2006
New Revision: 472257

URL: http://svn.apache.org/viewvc?view=revrev=472257
Log:
organization, license and mailing lists are declared in the parent pom

Modified:
jakarta/commons/proper/scxml/trunk/pom.xml

Modified: jakarta/commons/proper/scxml/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/scxml/trunk/pom.xml?view=diffrev=472257r1=472256r2=472257
==
--- jakarta/commons/proper/scxml/trunk/pom.xml (original)
+++ jakarta/commons/proper/scxml/trunk/pom.xml Tue Nov  7 12:59:43 2006
@@ -36,38 +36,11 @@
 
   urlhttp://jakarta.apache.org/commons/scxml//url
 
-  organization
-nameThe Apache Software Foundation/name
-urlhttp://jakarta.apache.org/url
-  /organization
-  licenses
-license
-  nameThe Apache Software License, Version 2.0/name
-  url/LICENSE.txt/url
-  distributionrepo/distribution
-/license
-  /licenses
-
   scm
 
connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/proper/scxml/trunk/connection
 
developerConnectionscm:svn:https://svn.apache.org/repos/asf/jakarta/commons/proper/scxml/trunk/developerConnection
 urlhttp://svn.apache.org/viewvc/jakarta/commons/proper/scxml/trunk/url
   /scm
-
-  mailingLists
-mailingList
-  nameCommons Dev List/name
-  subscribe[EMAIL PROTECTED]/subscribe
-  unsubscribe[EMAIL PROTECTED]/unsubscribe
-  
archivehttp://mail-archives.apache.org/mod_mbox/jakarta-commons-dev//archive
-/mailingList
-mailingList
-  nameCommons User List/name
-  subscribe[EMAIL PROTECTED]/subscribe
-  unsubscribe[EMAIL PROTECTED]/unsubscribe
-  
archivehttp://mail-archives.apache.org/mod_mbox/jakarta-commons-user//archive
-/mailingList
-  /mailingLists
 
   developers
 developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472259 - /jakarta/commons/proper/vfs/trunk/pom.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 13:01:08 2006
New Revision: 472259

URL: http://svn.apache.org/viewvc?view=revrev=472259
Log:
Points to the commons-parent now

Modified:
jakarta/commons/proper/vfs/trunk/pom.xml

Modified: jakarta/commons/proper/vfs/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/vfs/trunk/pom.xml?view=diffrev=472259r1=472258r2=472259
==
--- jakarta/commons/proper/vfs/trunk/pom.xml (original)
+++ jakarta/commons/proper/vfs/trunk/pom.xml Tue Nov  7 13:01:08 2006
@@ -18,8 +18,13 @@
 
 project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
  xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
-  modelVersion4.0.0/modelVersion
+  parent
+groupIdorg.apache.commons/groupId
+artifactIdcommons-parent/artifactId
+version1-SNAPSHOT/version
+  /parent
 
+  modelVersion4.0.0/modelVersion
   groupIdorg.apache.commons/groupId
   artifactIdcommons-vfs-project/artifactId
   nameCommons VFS (project)/name
@@ -36,20 +41,6 @@
 modulesandbox/module
   /modules
 
-  organization
-nameApache Software Foundation/name
-urlhttp://www.apache.org//url
-  /organization
-
-  licenses
-license
-  nameThe Apache Software License, Version 2.0/name
-  urlhttp://www.apache.org/licenses/LICENSE-2.0.txt/url
-  distributionrepo/distribution
-/license
-  /licenses
-
-
   issueManagement
 systemjira/system
 urlhttps://issues.apache.org/jira/browse/VFS/url
@@ -136,20 +127,5 @@
   urlscp://people.apache.org/www/jakarta.apache.org/commons/vfs//url
 /site
   /distributionManagement
-
-  mailingLists
-mailingList
-  nameCommons Dev List/name
-  subscribe[EMAIL PROTECTED]/subscribe
-  unsubscribe[EMAIL PROTECTED]/unsubscribe
-  
archivehttp://mail-archives.apache.org/mod_mbox/jakarta-commons-dev//archive
-/mailingList
-mailingList
-  nameCommons User List/name
-  subscribe[EMAIL PROTECTED]/subscribe
-  unsubscribe[EMAIL PROTECTED]/unsubscribe
-  
archivehttp://mail-archives.apache.org/mod_mbox/jakarta-commons-user//archive
-/mailingList
-  /mailingLists
 
 /project



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472260 - /jakarta/commons/trunks-sandbox/pom.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 13:02:07 2006
New Revision: 472260

URL: http://svn.apache.org/viewvc?view=revrev=472260
Log:
Points to new commons-parent id

Modified:
jakarta/commons/trunks-sandbox/pom.xml

Modified: jakarta/commons/trunks-sandbox/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/trunks-sandbox/pom.xml?view=diffrev=472260r1=472259r2=472260
==
--- jakarta/commons/trunks-sandbox/pom.xml (original)
+++ jakarta/commons/trunks-sandbox/pom.xml Tue Nov  7 13:02:07 2006
@@ -3,7 +3,7 @@
   modelVersion4.0.0/modelVersion
   parent
 groupIdorg.apache.commons/groupId
-artifactIdcommons/artifactId
+artifactIdcommons-parent/artifactId
 version1-SNAPSHOT/version
   /parent
   groupIdorg.apache.commons/groupId



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472264 - /jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 13:06:24 2006
New Revision: 472264

URL: http://svn.apache.org/viewvc?view=revrev=472264
Log:
Changes report for dbutils 1.1

Modified:
jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml

Modified: jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml?view=diffrev=472264r1=472263r2=472264
==
--- jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml (original)
+++ jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml Tue Nov  7 13:06:24 
2006
@@ -38,7 +38,38 @@
   /properties
   body
 
-release version=1.1-dev date=in SVN
+release version=1.1 date=Unreleased description=
+
+  action dev=bayard type=fix issue=DBUTILS-32
+Tests fail to build under 1.6, and warning while compiling source  
+  /action
+  action dev=bayard type=fix issue=DBUTILS-1
+BeanListHandler and BeanHandler fail to support java.sql.Date()
+  /action
+  action dev=bayard type=update issue=DBUTILS-16
+ResultSetRowProcessor abstract handler and some classes rework
+  /action
+  action dev=bayard type=fix issue=DBUTILS-3
+Setting bean properties fails silently
+  /action
+  action dev=dgraham type=fix issue=DBUTILS-9
+MockResultSet needs to handle equals and hashCode 
+  /action
+  action dev=bayard type=fix issue=DBUTILS-7
+MockResultSet: Throw UnsupportedOperationException for not implemented 
methods
+  /action
+  action dev=dgraham type=add issue=DBUTILS-20
+Implement Pluggable Adaptors to Make BeanHandler Smarter
+  /action
+  action dev=dgraham type=update issue=DBUTILS-15
+Patch for extending BasicRowProcessor 
+  /action
+  action dev=dgraham type=add issue=DBUTILS-12
+Protected QueryRunner.close() methods 
+  /action
+  action dev=dgraham type=update issue=DBUTILS-23
+Updated docs for example.html page (select AS) 
+  /action
   action dev=dgraham type=add issue=DBUTILS-4
 Added protected ResultSetIterator.rethrow() method to wrap 
SQLExceptions in 
 RuntimeExceptions.
@@ -95,7 +126,7 @@
   /action
 /release
 
-release version=1.0 date=2003-11-10
+release version=1.0 date=2003-11-10 description=First release of 
DbUtils
   action type=add
 This is the first release of the Commons DbUtils package.  DbUtils
 is a small set of classes designed to make working with JDBC easier.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472265 - /jakarta/commons/proper/dbutils/trunk/project.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 13:07:44 2006
New Revision: 472265

URL: http://svn.apache.org/viewvc?view=revrev=472265
Log:
Adding pmd/checkstyle in. Removing changelog/developer-activity/file-activity 
as these are all useless without automated deploys

Modified:
jakarta/commons/proper/dbutils/trunk/project.xml

Modified: jakarta/commons/proper/dbutils/trunk/project.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/project.xml?view=diffrev=472265r1=472264r2=472265
==
--- jakarta/commons/proper/dbutils/trunk/project.xml (original)
+++ jakarta/commons/proper/dbutils/trunk/project.xml Tue Nov  7 13:07:44 2006
@@ -218,15 +218,13 @@
   /build
   
   reports
- reportmaven-changelog-plugin/report
  reportmaven-changes-plugin/report
- !--reportmaven-checkstyle-plugin/report--
- reportmaven-developer-activity-plugin/report
- reportmaven-file-activity-plugin/report
+ reportmaven-checkstyle-plugin/report
  reportmaven-javadoc-plugin/report
  reportmaven-junit-report-plugin/report
  reportmaven-jxr-plugin/report
  reportmaven-license-plugin/report
+ reportmaven-pmd-plugin/report
   /reports
 
 /project



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472266 - /jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 13:09:08 2006
New Revision: 472266

URL: http://svn.apache.org/viewvc?view=revrev=472266
Log:
Pending preferred to Unreleased I think

Modified:
jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml

Modified: jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml?view=diffrev=472266r1=472265r2=472266
==
--- jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml (original)
+++ jakarta/commons/proper/dbutils/trunk/xdocs/changes.xml Tue Nov  7 13:09:08 
2006
@@ -38,7 +38,7 @@
   /properties
   body
 
-release version=1.1 date=Unreleased description=
+release version=1.1 date=Pending description=
 
   action dev=bayard type=fix issue=DBUTILS-32
 Tests fail to build under 1.6, and warning while compiling source  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472270 - in /jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers: ArrayListHandler.java BeanListHandler.java ColumnListHandler.java MapListHandler.java

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 13:15:01 2006
New Revision: 472270

URL: http://svn.apache.org/viewvc?view=revrev=472270
Log:
Removed unused import

Modified:

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java?view=diffrev=472270r1=472269r2=472270
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
 Tue Nov  7 13:15:01 2006
@@ -18,7 +18,6 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 
-import org.apache.commons.dbutils.ResultSetHandler;
 import org.apache.commons.dbutils.RowProcessor;
 
 /**

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java?view=diffrev=472270r1=472269r2=472270
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
 Tue Nov  7 13:15:01 2006
@@ -18,7 +18,6 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 
-import org.apache.commons.dbutils.ResultSetHandler;
 import org.apache.commons.dbutils.RowProcessor;
 
 /**

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java?view=diffrev=472270r1=472269r2=472270
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java
 Tue Nov  7 13:15:01 2006
@@ -19,8 +19,6 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 
-import org.apache.commons.dbutils.ResultSetHandler;
-
 /**
  * codeResultSetHandler/code implementation that converts one
  * codeResultSet/code column into a codeList/code of

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java?view=diffrev=472270r1=472269r2=472270
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
 Tue Nov  7 13:15:01 2006
@@ -18,7 +18,6 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 
-import org.apache.commons.dbutils.ResultSetHandler;
 import org.apache.commons.dbutils.RowProcessor;
 
 /**



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (CONFIGURATION-237) Contrib : managed reloading strategy

2006-11-07 Thread Oliver Heger (JIRA)
[ 
http://issues.apache.org/jira/browse/CONFIGURATION-237?page=comments#action_12447925
 ] 

Oliver Heger commented on CONFIGURATION-237:


Looks interesting!

Is there any chance that you can add a unit test for this class? I think, this 
won't be too complicated.

Unfortunately I am no expert in JMX. Would it be possible for you to add an 
example about how this class can be used to the user guide? Or just attach a 
simple example and I will take care to add it to the guide.

Many thanks!

 Contrib : managed reloading strategy
 

 Key: CONFIGURATION-237
 URL: http://issues.apache.org/jira/browse/CONFIGURATION-237
 Project: Commons Configuration
  Issue Type: New Feature
Affects Versions: Nightly Builds
Reporter: nicolas de loof
Priority: Minor
 Attachments: CONFIGURATION-237.patch


 This patch adds a reloading strategy based on management request, typically 
 from a JMX console. The Strategy implements a MBean interface so can be 
 exported as a JMX Managed bean with no code change.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472272 - in /jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers: BeanListHandler.java GenericListHandler.java MapListHandler.java

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 13:17:25 2006
New Revision: 472272

URL: http://svn.apache.org/viewvc?view=revrev=472272
Log:
Changed tabs to spaces

Modified:

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/GenericListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java?view=diffrev=472272r1=472271r2=472272
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
 Tue Nov  7 13:17:25 2006
@@ -73,7 +73,7 @@
  * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
  */
 protected Object handleRow(ResultSet rs) throws SQLException {
-   return this.convert.toBean(rs, type);
+return this.convert.toBean(rs, type);
 }
 
 }

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/GenericListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/GenericListHandler.java?view=diffrev=472272r1=472271r2=472272
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/GenericListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/GenericListHandler.java
 Tue Nov  7 13:17:25 2006
@@ -28,27 +28,27 @@
  * classes that convert codeResultSet/code into codeList/code.
  */
 abstract class GenericListHandler implements ResultSetHandler {
-   /**
-* Whole codeResultSet/code handler. It produce codeList/code as
-* result. To convert individual rows into Java objects it uses
-* codehandleRow(ResultSet)/code method.
-*
-* @see #handleRow(ResultSet)
-*/
-   public Object handle(ResultSet rs) throws SQLException {
-   List rows = new ArrayList();
-   while (rs.next()) {
-   rows.add(this.handleRow(rs));
-   }
-   return rows;
-   }
-   
-   /**
-* Row handler. Method converts current row into some Java object.
-*
-* @param rs codeResultSet/code to process.
-* @return row processing result
-* @throws SQLException error occurs
-*/
-   protected abstract Object handleRow(ResultSet rs) throws SQLException;
+/**
+ * Whole codeResultSet/code handler. It produce codeList/code as
+ * result. To convert individual rows into Java objects it uses
+ * codehandleRow(ResultSet)/code method.
+ *
+ * @see #handleRow(ResultSet)
+ */
+public Object handle(ResultSet rs) throws SQLException {
+List rows = new ArrayList();
+while (rs.next()) {
+rows.add(this.handleRow(rs));
+}
+return rows;
+}
+
+/**
+ * Row handler. Method converts current row into some Java object.
+ *
+ * @param rs codeResultSet/code to process.
+ * @return row processing result
+ * @throws SQLException error occurs
+ */
+protected abstract Object handleRow(ResultSet rs) throws SQLException;
 }

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java?view=diffrev=472272r1=472271r2=472272
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
 Tue Nov  7 13:17:25 2006
@@ -64,7 +64,7 @@
  * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
  */
 protected Object handleRow(ResultSet rs) throws SQLException {
-   return this.convert.toMap(rs);
+return this.convert.toMap(rs);
 }
 
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472289 - in /jakarta/commons/proper/dbutils/trunk: ./ src/java/org/apache/commons/dbutils/ src/java/org/apache/commons/dbutils/handlers/ src/java/org/apache/commons/dbutils/wrappers/ xdoc

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 13:44:07 2006
New Revision: 472289

URL: http://svn.apache.org/viewvc?view=revrev=472289
Log:
Used Lang checkstyle config. Fixed the ones that looked worrisome - dbutils has 
a lot of @see tags and checkstyle gets whiney in those situations. Added 
package.htmls. 

Added:
jakarta/commons/proper/dbutils/trunk/checkstyle.xml   (with props)

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/package.html
   (with props)

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/package.html
   (with props)

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/wrappers/package.html
   (with props)
Modified:
jakarta/commons/proper/dbutils/trunk/project.properties

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BeanProcessor.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/DbUtils.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryRunner.java
jakarta/commons/proper/dbutils/trunk/xdocs/navigation.xml

Added: jakarta/commons/proper/dbutils/trunk/checkstyle.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/checkstyle.xml?view=autorev=472289
==
--- jakarta/commons/proper/dbutils/trunk/checkstyle.xml (added)
+++ jakarta/commons/proper/dbutils/trunk/checkstyle.xml Tue Nov  7 13:44:07 2006
@@ -0,0 +1,45 @@
+?xml version=1.0?
+!--
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.  See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the License); you may not use this file except in compliance with
+the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an AS IS BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+--
+
+!DOCTYPE module PUBLIC
+-//Puppy Crawl//DTD Check Configuration 1.1//EN
+http://www.puppycrawl.com/dtds/configuration_1_1.dtd;
+
+!-- commons lang customization of default Checkstyle behavior --
+module name=Checker
+  property name=localeLanguage value=en/
+  module name=PackageHtml/
+  module name=TreeWalker
+module name=TabCharacter/
+module name=AvoidStarImport/
+module name=RedundantImport/
+module name=UnusedImports/
+module name=NeedBraces/
+module name=RedundantThrows
+  property name=allowUnchecked value=true/
+/module
+module name=LineLength
+  property name=max value=120/
+/module
+module name=JavadocMethod
+  property name=allowUndeclaredRTE value=true/
+/module
+ /module
+/module
+
+

Propchange: jakarta/commons/proper/dbutils/trunk/checkstyle.xml
--
svn:eol-style = native

Modified: jakarta/commons/proper/dbutils/trunk/project.properties
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/project.properties?view=diffrev=472289r1=472288r2=472289
==
--- jakarta/commons/proper/dbutils/trunk/project.properties (original)
+++ jakarta/commons/proper/dbutils/trunk/project.properties Tue Nov  7 13:44:07 
2006
@@ -16,6 +16,7 @@
 #
 
 maven.changelog.factory=org.apache.maven.svnlib.SvnChangeLogFactory
+maven.checkstyle.properties=checkstyle.xml
 
 # Jar Manifest Additional Attributes
 
maven.jar.manifest.attributes.list=Implementation-Vendor-Id,X-Compile-Source-JDK,X-Compile-Target-JDK

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BeanProcessor.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BeanProcessor.java?view=diffrev=472289r1=472288r2=472289
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BeanProcessor.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BeanProcessor.java
 Tue Nov  7 13:44:07 2006
@@ -367,10 +367,10 @@
  * 
  * @param props The bean property descriptors.
  * 
+ * @throws SQLException 
+ *
  * @return An int[] with column index to property index mappings.  The 0th 
  * element is meaningless because JDBC column indexing starts at 1.
- * 
- * @throws SQLException 
  */
 protected int[] mapColumnsToProperties(ResultSetMetaData rsmd,
   

svn commit: r472293 - /jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java

2006-11-07 Thread imario
Author: imario
Date: Tue Nov  7 13:57:33 2006
New Revision: 472293

URL: http://svn.apache.org/viewvc?view=revrev=472293
Log:
VFS-98: try to avoid deadlock

Modified:

jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java

Modified: 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java?view=diffrev=472293r1=472292r2=472293
==
--- 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java
 (original)
+++ 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java
 Tue Nov  7 13:57:33 2006
@@ -64,20 +64,24 @@
 /**
  * Locates a file from its parsed URI.
  */
-protected synchronized FileObject findFile(final FileName name, final 
FileSystemOptions fileSystemOptions)
+protected FileObject findFile(final FileName name, final FileSystemOptions 
fileSystemOptions)
 throws FileSystemException
 {
-// Check in the cache for the file system
-final FileName rootName = 
getContext().getFileSystemManager().resolveName(name, FileName.ROOT_PATH);
-FileSystem fs = findFileSystem(rootName, fileSystemOptions);
-if (fs == null)
-{
-// Need to create the file system, and cache it
-fs = doCreateFileSystem(rootName, fileSystemOptions);
-addFileSystem(rootName, fs);
-}
+   FileSystem fs;
+   synchronized (this)
+   {
+   // Check in the cache for the file system
+   final FileName rootName = 
getContext().getFileSystemManager().resolveName(name, FileName.ROOT_PATH);
+   fs = findFileSystem(rootName, fileSystemOptions);
+   if (fs == null)
+   {
+   // Need to create the file system, and cache it
+   fs = doCreateFileSystem(rootName, 
fileSystemOptions);
+   addFileSystem(rootName, fs);
+   }
+   }
 
-// Locate the file
+   // Locate the file
 // return fs.resolveFile(name.getPath());
 return fs.resolveFile(name);
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472294 - in /jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider: AbstractFileProvider.java AbstractOriginatingFileProvider.java

2006-11-07 Thread imario
Author: imario
Date: Tue Nov  7 13:59:30 2006
New Revision: 472294

URL: http://svn.apache.org/viewvc?view=revrev=472294
Log:
VFS-98: try to avoid deadlock

Modified:

jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractFileProvider.java

jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java

Modified: 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractFileProvider.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractFileProvider.java?view=diffrev=472294r1=472293r2=472294
==
--- 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractFileProvider.java
 (original)
+++ 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractFileProvider.java
 Tue Nov  7 13:59:30 2006
@@ -66,7 +66,7 @@
  */
 public void close()
 {
-synchronized (fileSystems)
+synchronized (this)
 {
 fileSystems.clear();
 }
@@ -97,7 +97,7 @@
 FileSystemKey treeKey = new FileSystemKey(key, 
fs.getFileSystemOptions());
 ((AbstractFileSystem) fs).setCacheKey(treeKey);
 
-synchronized (fileSystems)
+synchronized (this)
 {
 fileSystems.put(treeKey, fs);
 }
@@ -112,7 +112,7 @@
 {
 FileSystemKey treeKey = new FileSystemKey(key, fileSystemProps);
 
-synchronized (fileSystems)
+synchronized (this)
 {
 return (FileSystem) fileSystems.get(treeKey);
 }
@@ -126,7 +126,7 @@
 public void freeUnusedResources()
 {
 Object[] item;
-synchronized (fileSystems)
+synchronized (this)
 {
 item = fileSystems.values().toArray();
 }
@@ -144,7 +144,7 @@
 {
 AbstractFileSystem fs = (AbstractFileSystem) filesystem;
 
-synchronized (fileSystems)
+synchronized (this)
 {
 if (fs.getCacheKey() != null)
 {

Modified: 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java?view=diffrev=472294r1=472293r2=472294
==
--- 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java
 (original)
+++ 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractOriginatingFileProvider.java
 Tue Nov  7 13:59:30 2006
@@ -67,11 +67,12 @@
 protected FileObject findFile(final FileName name, final FileSystemOptions 
fileSystemOptions)
 throws FileSystemException
 {
+   // Check in the cache for the file system
+   final FileName rootName = 
getContext().getFileSystemManager().resolveName(name, FileName.ROOT_PATH);
+   
FileSystem fs;
synchronized (this)
{
-   // Check in the cache for the file system
-   final FileName rootName = 
getContext().getFileSystemManager().resolveName(name, FileName.ROOT_PATH);
fs = findFileSystem(rootName, fileSystemOptions);
if (fs == null)
{



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (VFS-98) VFS causes deadlocks or is not thread-safe

2006-11-07 Thread Mario Ivankovits (JIRA)
[ http://issues.apache.org/jira/browse/VFS-98?page=comments#action_12447937 
] 

Mario Ivankovits commented on VFS-98:
-

Hi!

I committed a fix for this  hopefully.

Could you please try it again. In case it hangs again please attach the 
stacktrace again, but not the jstack one, it doesn't contain enough 
informations.

Thanks!
Ciao,
Mario

 VFS causes deadlocks or is not thread-safe
 --

 Key: VFS-98
 URL: http://issues.apache.org/jira/browse/VFS-98
 Project: Commons VFS
  Issue Type: Bug
Affects Versions: Nightly Builds
 Environment: jdk1.5.0_07 / Linux
Reporter: Juha-Matti Toppinen
 Assigned To: Mario Ivankovits
 Attachments: vfs.dead.jstack.txt, 
 vfs.dead.threaddump.synchronizedfileobject.txt, vfs.dead.threaddump.txt


 Newer versions of VFS seems to be unusable in multithreading environments, 
 causing a deadlock of some kind. This causes my Java  web server application 
 to completely hang when there is many concurrent connections. My application 
 uses a single FileSystemManager instance, and makes quite heavy use of VFS; 
 opening many files from many threads simultaneously.
 I have tried, without success different workarounds based on some mailing 
 list threads:
 - Using both NullReferenceFilesCache and the default SoftReferenceFilesCache. 
 (SoftReferenceFilesCache seemed to sometimes cause some additional 
 thread-related exceptions under heavy load, but propably unrelated to this 
 issue)
 - Using the new SynchorizedFileObjectDecorator also did not help. On the 
 contrary, it seemed to trigger the deadlock more easily.
 The version I have problems with is a nightly build: commons-vfs-20060831
 The older version commons-vfs-20060115 works beautifully, but I would like to 
 use newer version because I want to be able to use FileObject.refresh() to 
 reset the internal state of files (specially, to get a fresh list of 
 children).
 I hope the threading issues are going to be resolved in near future, and I am 
 willing to help in any way. I do not have very deep experience about 
 multithreading applications, so I wasn't able to get more close to the roots 
 of the issue. Feel free to ask for more information.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: VFS FTP Problem with Text data

2006-11-07 Thread Mario Ivankovits
Hi Moerk!
 I tried to use vfs to get some textfiles from a unix host to a windows 
 network drive on a regular basis.
 The problem is that the transfer program doesn't take care aobout the 
 different CR (0x0A--0x0D 0x0A) commands between Unix and Windows 
 I found that the FTP Conection is alwyas started in FTP.BINARY_FILE_TYPE) 
 that doesn't support the conversion of CR in ftp.
   
Eventually it is possible to extend the FtpFileSystemConfigBuilder with
such an option, though, another possibility is to use a BufferedReader
and a PrintWriter to do the conversation on client side, no?
Simply readline the file and writeln it should do the trick too ... will
work not only with ftp and in conjunction with an InputStreamReader you
can deal with charset conversion at the same time ...
Since the BufferedReader will use a (configureable) buffer to read the
file there should be no huge performance penalty.

What do you think?

Ciao,
Mario


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dbutils] Release process for dbutils-1.1. How can I help?

2006-11-07 Thread Henri Yandell

On 11/7/06, Henri Yandell [EMAIL PROTECTED] wrote:

On 11/7/06, Alan Canon [EMAIL PROTECTED] wrote:
 Henri Yandell wrote:

 So unless any of the non-versioned issues seem like they should go in,
 it's time to start the fun of the release process.
 Hen



 Should I prepare a summary of the non-versioned issues?

Only if you think any should go in 1.1.

 What else can I do to push the release process?

I did some work on it at the weekend - fixed the code to build under
1.3. I'm working on the changes.xml file (release notes), I'll have
that finished today.

Other things that jump to mind:

* We should create a pom.xml file (Maven-2 build). As long as the
parent gets deployed (cf: some other thread on commons-dev). Feel free
to take a stab at that - shouldn't be too hard as there are other
pom.xml's to (largely) copy.
* Update the site - this mostly means changing 1.0 for 1.1 if it
appears in the text, but any problems you can find/patch in the site
are good for now.
* Create a jardiff report - need to see what's changed API-wise and
add that to release notes.


http://people.apache.org/~bayard/dbutils-1.0-to-1.1-jardiff.html

It doesn't look that bad - jardiff complains that we've moved a method
into a superclass in a few places. So a recompile will be needed (I
think) rather than being able to drop the jar in place.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472311 - /jakarta/commons/proper/io/trunk/pom.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 14:38:56 2006
New Revision: 472311

URL: http://svn.apache.org/viewvc?view=revrev=472311
Log:
Mailing lists defined in the parent

Modified:
jakarta/commons/proper/io/trunk/pom.xml

Modified: jakarta/commons/proper/io/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/pom.xml?view=diffrev=472311r1=472310r2=472311
==
--- jakarta/commons/proper/io/trunk/pom.xml (original)
+++ jakarta/commons/proper/io/trunk/pom.xml Tue Nov  7 14:38:56 2006
@@ -48,21 +48,6 @@
 urlhttp://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/url
   /scm
 
-  mailingLists
-mailingList
-  nameCommons Dev List/name
-  subscribe[EMAIL PROTECTED]/subscribe
-  unsubscribe[EMAIL PROTECTED]/unsubscribe
-  
archivehttp://mail-archives.apache.org/mod_mbox/jakarta-commons-dev//archive
-/mailingList
-mailingList
-  nameCommons User List/name
-  subscribe[EMAIL PROTECTED]/subscribe
-  unsubscribe[EMAIL PROTECTED]/unsubscribe
-  
archivehttp://mail-archives.apache.org/mod_mbox/jakarta-commons-user//archive
-/mailingList
-  /mailingLists
-
   developers
 developer
   nameScott Sanders/name



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472314 - /jakarta/commons/proper/beanutils/trunk/pom.xml

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 14:46:09 2006
New Revision: 472314

URL: http://svn.apache.org/viewvc?view=revrev=472314
Log:
Maven 2 POM for BeanUtils

Added:
jakarta/commons/proper/beanutils/trunk/pom.xml   (with props)

Added: jakarta/commons/proper/beanutils/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/pom.xml?view=autorev=472314
==
--- jakarta/commons/proper/beanutils/trunk/pom.xml (added)
+++ jakarta/commons/proper/beanutils/trunk/pom.xml Tue Nov  7 14:46:09 2006
@@ -0,0 +1,192 @@
+?xml version=1.0?
+!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the License); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an AS IS BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+--
+project
+xmlns=http://maven.apache.org/POM/4.0.0;
+xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
+  parent
+groupIdorg.apache.commons/groupId
+artifactIdcommons-parent/artifactId
+version1-SNAPSHOT/version
+  /parent
+  modelVersion4.0.0/modelVersion
+  groupIdorg.apache.commons/groupId
+  artifactIdcommons-beanutils/artifactId
+  version1.8.0-SNAPSHOT/version
+  nameBeanUtils/name
+
+  inceptionYear2000/inceptionYear
+  descriptionBeanUtils provides an easy-to-use but flexible wrapper around 
reflection and introspection./description
+
+  urlhttp://jakarta.apache.org/commons/beanutils//url
+
+  issueManagement
+systemjira/system
+urlhttp://issues.apache.org/jira/browse/BEANUTILS/url
+  /issueManagement
+
+  scm
+
connectionscm:svn:scm:svn:https://svn.apache.org/repos/asf/jakarta/commons/proper/beanutils/trunk/connection
+
developerConnectionscm:svn:scm:svn:https://svn.apache.org/repos/asf/jakarta/commons/proper/beanutils/trunk/developerConnection
+
urlhttp://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/url
+  /scm
+
+  developers
+developer
+  nameRobert Burrell Donkin/name
+  idrdonkin/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  namedIon Gillard/name
+  iddion/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  nameCraig McClanahan/name
+  idcraigmcc/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  nameGeir Magnusson Jr./name
+  idgeirm/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  nameScott Sanders/name
+  idsanders/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  nameJames Strachan/name
+  idjstrachan/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  nameRodney Waldhoff/name
+  idrwaldhoff/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  nameMartin van den Bemt/name
+  idmvdb/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  nameYoav Shapira/name
+  idyoavs/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  nameNiall Pemberton/name
+  idniallp/id
+  emailniallp at apache dot org/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  nameSimon Kitching/name
+  idskitching/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+developer
+  nameJames Carman/name
+  idjcarman/id
+  email[EMAIL PROTECTED]/email
+  organizationApache Software Foundation/organization
+/developer
+  /developers
+
+  contributors
+contributor
+  namePaul Jack/name
+  email/email
+/contributor
+contributor
+  nameStephen Colebourne/name
+  email/email
+/contributor

[jira] Updated: (BEANUTILS-247) Arrays with multiple dimension are not supported

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-247?page=all ]

Henri Yandell updated BEANUTILS-247:


Fix Version/s: 1.8.0

 Arrays with multiple dimension are not supported
 

 Key: BEANUTILS-247
 URL: http://issues.apache.org/jira/browse/BEANUTILS-247
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
Affects Versions: 1.7.0
 Environment: I run BeanUtils on Windows XP with Eclipse 3.1.1.
Reporter: Christian Poitras
 Fix For: 1.8.0

 Attachments: beanerror.zip, PropertyUtilsBean.java


 When an array with multiple dimension is used, accessing and setting 
 properties is not supported.
 For instance, the call to PropertyUtils.getNestedProperty(myObject, 
 multiArray[0][0].id) fails since the second array index is never used.
 This raises the following exception.
 Exception in thread main java.lang.NoSuchMethodException: Unknown property 
 'id'
   at 
 org.apache.commons.beanutils.PropertyUtilsBean.getSimpleProperty(PropertyUtilsBean.java:1122)
   at 
 org.apache.commons.beanutils.PropertyUtilsBean.getNestedProperty(PropertyUtilsBean.java:686)
   at 
 org.apache.commons.beanutils.PropertyUtils.getNestedProperty(PropertyUtils.java:272)
   at Test.main(Test.java:24)
 The id property does exists in the object multiArray[0][0] and if I make 
 a call to multiArray[0][0].getId(), the correct value is returned.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-65) [beanutils] ConvertUtils supports String-String[], but BeanUtils does not call the converter

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-65?page=all ]

Henri Yandell updated BEANUTILS-65:
---

  Bugzilla Id:   (was: 38172)
Fix Version/s: 1.8.0

Niall's new code might alleviate this.

 [beanutils] ConvertUtils supports String-String[], but BeanUtils does not 
 call the converter
 -

 Key: BEANUTILS-65
 URL: http://issues.apache.org/jira/browse/BEANUTILS-65
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: ConvertUtils  Converters
 Environment: Operating System: other
 Platform: Other
Reporter: Alessio Pace
 Fix For: 1.8.0

 Attachments: StringToArrayTestCase.java


 Using commons-beanutils 1.7 I encountered this problem:
 ConvertUtils supports String-String[], but BeanUtils just doesn't call
 the converter
 (see TestCase attached)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-33) [beanutils] Can't use . (dot) in mapped properties for setProperty or getPropertyDescriptor

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-33?page=all ]

Henri Yandell updated BEANUTILS-33:
---

  Bugzilla Id:   (was: 28813)
Fix Version/s: 1.8.0

 [beanutils] Can't use . (dot) in mapped properties for setProperty or 
 getPropertyDescriptor
 ---

 Key: BEANUTILS-33
 URL: http://issues.apache.org/jira/browse/BEANUTILS-33
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Expression Syntax
 Environment: Operating System: other
 Platform: Other
Reporter: Eoin Curran
 Fix For: 1.8.0

 Attachments: beanutils.dotsinmappedindices.patch, 
 PropertyUtilsMappedDot.txt, PropertyUtilsMappedIssues.txt, 
 PropertyUtilsTestCase1.txt, PropertyUtilsTestMappedDot.txt


 http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10478
 fixed this problem for PropertyUtils.getProperty(); However, the problem 
 remains
 for setProperty and getPropertyDescriptor.
 I have fixed this against 1.6.1

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-86) [beanutils] StringArrayConverter does not handle long[] input

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-86?page=all ]

Henri Yandell updated BEANUTILS-86:
---

  Bugzilla Id:   (was: 39026)
Fix Version/s: 1.8.0

 [beanutils] StringArrayConverter does not handle long[] input
 -

 Key: BEANUTILS-86
 URL: http://issues.apache.org/jira/browse/BEANUTILS-86
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: ConvertUtils  Converters
 Environment: Operating System: All
 Platform: All
Reporter: Jarek Bojar
 Fix For: 1.8.0

 Attachments: StringArrayConverter.patch


 StringArrayConverter does not handle properly long[], double[] and other 
 arrays
 of builtin types. In fact it handles properly only int[] arrays. It is 
 important
 to improve this functionality, because this converter is used by
 BeanUtils.copyProperties(...) method, which is often used to copy data between
 ActionForms and data beans in both directions. In current state it handles
 properly copying from ActionForms containing String[] arrays to data beans
 containing int[], long[] etc. arrays, but not in opposite direction.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-257) Many of the helper methods expose the java.lang exceptions. I'd like to convert them to RuntimeExceptions

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-257?page=all ]

Henri Yandell updated BEANUTILS-257:


Fix Version/s: LATER THAN 1.8.0

 Many of the helper methods expose the java.lang exceptions. I'd like to 
 convert them to RuntimeExceptions
 -

 Key: BEANUTILS-257
 URL: http://issues.apache.org/jira/browse/BEANUTILS-257
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: Bean / Property Utils
Affects Versions: 1.8.0
Reporter: Aaron Digulla
 Fix For: LATER THAN 1.8.0


 Hello,
 A lot of the helper functions throw checked exceptions (mostly 
 IllegalAccessException, InvocationTargetException and NoSuchMethodException). 
 I'd like to write a patch which converts them all into RuntimeExceptions so 
 the code upstream doesn't have to handle them.
 Rationale: When working with properties, you usually expect the code to work. 
 When working with dynamic properties, you don't care about what went wrong 
 but only that something went wrong. In most cases, it's not possible to fix 
 the problem automatically but the code has to pass the exception up.
 This all calls for non-checked exceptions.
 My patch would be against the SVN version and contain these changes:
 - The old methods would still be there with an E at the end (for throws a 
 checked exception).
 - The new code would throw exceptions based on a common exception so you can 
 catch all the exceptions thrown in beanutils in one statement. IAE, ITE, etc. 
 would then be derived from this base class so you can still filter them.
 Since this is going to involve some work, I wanted to ask beforehand if you 
 would accept such a patch.
 Best regards.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[io] Ready for release?

2006-11-07 Thread Henri Yandell

Am I right in thinking that IO is ready for its next release?

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-242) Add general array type conversion

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-242?page=all ]

Henri Yandell updated BEANUTILS-242:


Fix Version/s: 1.8.0

 Add general array type conversion
 -

 Key: BEANUTILS-242
 URL: http://issues.apache.org/jira/browse/BEANUTILS-242
 Project: Commons BeanUtils
  Issue Type: New Feature
  Components: ConvertUtils  Converters
Affects Versions: 1.7.0
Reporter: Kenny MacLeod
 Fix For: 1.8.0


 When using a method such as BeanUtils.copyProperty(), it would be good if it 
 could automatically handle conversion between array types, rather than having 
 to explicitly write an array converter for each target type.
 For example, if I pass a String[] to BeanUtils to copy on to a property of 
 type Integer[], then it would recognise the presense of an array, and then 
 use the registered converters for the arrays' component types to decide how 
 to map them together.
 This would remove the need to essentially duplicate converters already 
 written, just to add array support.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dbutils] Release process for dbutils-1.1. How can I help?

2006-11-07 Thread Stephen Colebourne

Henri Yandell wrote:

http://people.apache.org/~bayard/dbutils-1.0-to-1.1-jardiff.html

It doesn't look that bad - jardiff complains that we've moved a method
into a superclass in a few places. So a recompile will be needed (I
think) rather than being able to drop the jar in place.


You might want to try a clirr report to check for binary compatability. 
IIRC, moving a method up the hierarchy is binary compatible.


If not, then a simple super.xxx() method in the subclasses where the 
method was removed from should be added.


Stephen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (BEANUTILS-163) [beanutils] MappedPropertyDescriptor broken

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-163?page=all ]

Henri Yandell resolved BEANUTILS-163.
-

Resolution: Cannot Reproduce

Doesn't sound like we can do anything here - so marking as Cannot Reproduce.

 [beanutils] MappedPropertyDescriptor broken
 ---

 Key: BEANUTILS-163
 URL: http://issues.apache.org/jira/browse/BEANUTILS-163
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
 Environment: Operating System: All
 Platform: All
Reporter: Daniel Spilker

 When trying to create a MappedPropertyDescriptor for a mapped property with an
 invalid setter method, an IntrospectionException is thrown. E.g. I have a
 class with the methods:
 getProperty(String):Property
 setProperty(String, Value):void
 Since MappedPropertyDescriptor#findMethod(Class, String, int, Class[]) returns
 that invalid setter method MappedPropertyDescriptor#findMappedPropertyType
 fails. It would be nice for MappedPropertyDescriptor to ignore invalid 
 setter
 methods.
 After some debugging I found that
 MappedPropertyDescriptor#internalFindMethod(Class, String, int, Class[]) calls
 MappedPropertyDescriptor#internalFindMethod(Class, String, int) for the class'
 interfaces. So it misses the parameter which specifies the method's argument
 classes. I think the way it's meant to be is to use
 MappedPropertyDescriptor#internalFindMethod(Class, String, int, Class[]) for
 that call, too.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-157) [beanutils] 1.6.1 cannot determine reader methods for anonymous class

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-157?page=all ]

Henri Yandell updated BEANUTILS-157:


  Bugzilla Id:   (was: 33461)
Fix Version/s: 1.8.0

 [beanutils] 1.6.1 cannot determine reader methods for anonymous class
 -

 Key: BEANUTILS-157
 URL: http://issues.apache.org/jira/browse/BEANUTILS-157
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
 Environment: Operating System: Windows XP
 Platform: PC
Reporter: Thorbjørn Ravn Andersen
 Fix For: 1.8.0


 I have the following snippet in a JSP-page which uses BeanUtils 1.6.1 and I 
 get
 an exception.
 Code snippet (the anonymous class is to get a JavaBean defined in the 
 JSP-page):
 ---
   List l = new ArrayList();
   for(int i = 1; i  10; i++) {
 final int i2 = i;
Object o = new Serializable() {
   String x =  + i2;
   String y =  + (100+i2) ;
   public String getX() {
 return x;
   }
   public String getY() {
 return y;
   }   
   public String toString() {
   return getX() +   + getY();
   }   
   };
   l.add(o);
   Map map = BeanUtils.describe(o);
  ---
 which gives me the following exception:
 ---
 javax.servlet.ServletException: Property 'y' has no getter method
   at
 org.apache.jasper.runtime.PageContextImpl.doHandlePageException(PageContextImpl.java:825)
   at
 org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:758)
   at org.apache.jsp.main_jsp._jspService(main_jsp.java:257)
   at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
   at 
 org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:324)
   at 
 org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
   at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
   at
 org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
   at
 org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
   at
 org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:704)
   at
 org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:474)
   at
 org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:409)
   at
 org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:312)
   at 
 com.transaxiom.axsWHSweb.servlet.GetCurrentStock.doPost(GetCurrentStock.java:31)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:709)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
   at
 org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
   at
 org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
   at
 org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214)
   at
 org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
   at 
 org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
   at
 org.apache.catalina.core.StandardContextValve.invokeInternal(StandardContextValve.java:198)
   at
 org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:152)
   at
 org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
   at 
 org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
   at 
 org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:137)
   at
 org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
   at 
 org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:118)
   at
 org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102)
   at 
 org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
   at
 org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
   at
 org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
   at 
 org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
   at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:929)
   at 
 org.apache.coyote.tomcat5.CoyoteAdapter.service(CoyoteAdapter.java:160)
   at 
 

[jira] Updated: (BEANUTILS-156) [beanutils] Memory leak on webapp undeploy in MappedPropertyDescriptor

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-156?page=all ]

Henri Yandell updated BEANUTILS-156:


  Bugzilla Id:   (was: 35262)
Fix Version/s: LATER THAN 1.8.0

 [beanutils] Memory leak on webapp undeploy in MappedPropertyDescriptor
 --

 Key: BEANUTILS-156
 URL: http://issues.apache.org/jira/browse/BEANUTILS-156
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
Affects Versions: 1.6
 Environment: Operating System: All
 Platform: All
Reporter: Simon Kitching
 Fix For: LATER THAN 1.8.0


 Class MappedPropertyDescriptor has a Hashtable declaredMethodCache containing 
 a
 mapping from Class to Method[]. If this class were to be deployed via a shared
 webapp, then any reference in there to a class loaded via the webapp 
 classloader
 will prevent the webapp classloader from being garbage-collected when the 
 webapp
 is undeployed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-142) [beanutils] RowSetDynaClass fails to copy resulset to DynaBean with Oracle 10g JDBC driver

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-142?page=all ]

Henri Yandell updated BEANUTILS-142:


  Bugzilla Id:   (was: 39343)
Fix Version/s: 1.8.0

 [beanutils] RowSetDynaClass fails to copy resulset to DynaBean with Oracle 
 10g JDBC driver
 --

 Key: BEANUTILS-142
 URL: http://issues.apache.org/jira/browse/BEANUTILS-142
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: DynaBean
 Environment: Operating System: Windows XP
 Platform: All
Reporter: Li Zhang
 Fix For: 1.8.0


 Beginning in Oracle 9.2, DATE is mapped to Date and TIMESTAMP is mapped to
 Timestamp. However if you were relying on DATE values to contain time
 information, there is a problem. When using Oracle 10g JDBC driver, the
 ResultSetMetaData.getColumnClassName returns java.sql.Timestamp but
 ResultSet.getObject(name).getClass() returns java.sql.Date. Obviously these 
 two
 do not match each other. When the RowSetDynaClass.copy function tries to set 
 the
 value to BasicDynaBean, it throws exception. Need a workaround.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-140) [beanutils] LocaleBeanUtils setProperty does not work on nested property

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-140?page=all ]

Henri Yandell updated BEANUTILS-140:


  Bugzilla Id:   (was: 30203)
Fix Version/s: 1.8.0

 [beanutils] LocaleBeanUtils setProperty does not work on nested property
 

 Key: BEANUTILS-140
 URL: http://issues.apache.org/jira/browse/BEANUTILS-140
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Locale BeanUtils / Converters
 Environment: Operating System: All
 Platform: All
Reporter: Marco La Porta
 Fix For: 1.8.0


 LocaleBeanUtils setProperty does not work on nested property.
 I think the problem is in the method definePropertyType(Object target, String 
 name, String propName).
 When property is a nested property (prop1.propnested) target is the result 
 of a call of the prop1 getter on the oroginal bean, name is the property 
 name complete (prop1.propnested) and propName is the property name in 
 target 
 object (propnested).
 At line 601 the property descriptor is defined as
 descriptor = PropertyUtils.getPropertyDescriptor(target, name);
 and in case of nested propery it is never found (null)
 I think the correct line 601 is
 descriptor = PropertyUtils.getPropertyDescriptor(target, propName);

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472319 - in /jakarta/commons/proper/commons-parent/trunk: LICENSE.txt NOTICE.txt

2006-11-07 Thread dennisl
Author: dennisl
Date: Tue Nov  7 15:08:25 2006
New Revision: 472319

URL: http://svn.apache.org/viewvc?view=revrev=472319
Log:
Set EOL style to native.

Modified:
jakarta/commons/proper/commons-parent/trunk/LICENSE.txt   (props changed)
jakarta/commons/proper/commons-parent/trunk/NOTICE.txt   (props changed)

Propchange: jakarta/commons/proper/commons-parent/trunk/LICENSE.txt
--
svn:eol-style = native

Propchange: jakarta/commons/proper/commons-parent/trunk/NOTICE.txt
--
svn:eol-style = native



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472320 - /jakarta/commons/proper/commons-parent/trunk/pom.xml

2006-11-07 Thread dennisl
Author: dennisl
Date: Tue Nov  7 15:09:09 2006
New Revision: 472320

URL: http://svn.apache.org/viewvc?view=revrev=472320
Log:
Add other archives for the mailing lists.

Modified:
jakarta/commons/proper/commons-parent/trunk/pom.xml

Modified: jakarta/commons/proper/commons-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/commons-parent/trunk/pom.xml?view=diffrev=472320r1=472319r2=472320
==
--- jakarta/commons/proper/commons-parent/trunk/pom.xml (original)
+++ jakarta/commons/proper/commons-parent/trunk/pom.xml Tue Nov  7 15:09:09 2006
@@ -79,6 +79,10 @@
   unsubscribe[EMAIL PROTECTED]/unsubscribe
   postcommons-dev@jakarta.apache.org/post
   
archivehttp://mail-archives.apache.org/mod_mbox/jakarta-commons-dev/archive
+  otherArchives
+
otherArchivehttp://www.mail-archive.com/commons-dev@jakarta.apache.org//otherArchive
+
otherArchivehttp://www.nabble.com/Commons---Dev-f317.html/otherArchive
+  /otherArchives
 /mailingList
 mailingList
   nameCommons User List/name
@@ -86,6 +90,10 @@
   unsubscribe[EMAIL PROTECTED]/unsubscribe
   postcommons-user@jakarta.apache.org/post
   
archivehttp://mail-archives.apache.org/mod_mbox/jakarta-commons-user/archive
+  otherArchives
+
otherArchivehttp://www.mail-archive.com/commons-user@jakarta.apache.org//otherArchive
+
otherArchivehttp://www.nabble.com/Commons---User-f319.html/otherArchive
+  /otherArchives
 /mailingList
   /mailingLists
   build



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dbutils] Release process for dbutils-1.1. How can I help?

2006-11-07 Thread Henri Yandell

On 11/7/06, Stephen Colebourne [EMAIL PROTECTED] wrote:

Henri Yandell wrote:
 http://people.apache.org/~bayard/dbutils-1.0-to-1.1-jardiff.html

 It doesn't look that bad - jardiff complains that we've moved a method
 into a superclass in a few places. So a recompile will be needed (I
 think) rather than being able to drop the jar in place.

You might want to try a clirr report to check for binary compatability.
IIRC, moving a method up the hierarchy is binary compatible.


It seems to give the same info:

http://people.apache.org/~bayard/dbutils-1.0-to-1.1-clirr.txt


If not, then a simple super.xxx() method in the subclasses where the
method was removed from should be added.


Yup, that'd work.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472321 - /jakarta/commons/proper/commons-parent/trunk/

2006-11-07 Thread dennisl
Author: dennisl
Date: Tue Nov  7 15:10:04 2006
New Revision: 472321

URL: http://svn.apache.org/viewvc?view=revrev=472321
Log:
Ignore target directory.

Modified:
jakarta/commons/proper/commons-parent/trunk/   (props changed)

Propchange: jakarta/commons/proper/commons-parent/trunk/
--
--- svn:ignore (original)
+++ svn:ignore Tue Nov  7 15:10:04 2006
@@ -1 +1,2 @@
 .project
+target



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release commons-parent pom

2006-11-07 Thread Dennis Lundberg

Henri Yandell wrote:

On 11/6/06, Dennis Lundberg [EMAIL PROTECTED] wrote:

Hello

This is a new vote following up on the failed vote [1] that was held
previously.

As far as I can tell, all the issues that were raised in the earlier
vote has been addressed. So please cast your votes.

This vote will be open for 72 hours and I will tally the votes no
earlier than 19:00 GMT+1 on November 9th.

[X] +1
[ ] =0
[ ] -1


Should we add otherArchive blocks to the mailing list, or are there
too many out there?

Hen


That's a good idea.
I've added The Mail Archive and Nabble.

--
Dennis Lundberg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472323 - in /jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers: ArrayListHandler.java BeanListHandler.java ColumnListHandler.java MapListHandler.java

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 15:16:34 2006
New Revision: 472323

URL: http://svn.apache.org/viewvc?view=revrev=472323
Log:
Added the handle(ResultSet) methods back in with calls to super.handle(rs) and 
a deprecated tag

Modified:

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java?view=diffrev=472323r1=472322r2=472323
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
 Tue Nov  7 15:16:34 2006
@@ -67,4 +67,14 @@
  return this.convert.toArray(rs);
  }
 
+ /*
+  * Kept for binary compatibility. 
+  *
+  * @deprecated Remove in 2.0
+  * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
+  */
+ public Object handle(ResultSet rs) throws SQLException {
+ return super.handle(rs);
+ }
+
 }

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java?view=diffrev=472323r1=472322r2=472323
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
 Tue Nov  7 15:16:34 2006
@@ -76,4 +76,14 @@
 return this.convert.toBean(rs, type);
 }
 
+/**
+ * Kept for binary compatibility. 
+ *
+ * @deprecated Remove in 2.0
+ * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
+ */
+public Object handle(ResultSet rs) throws SQLException {
+return super.handle(rs);
+}
+
 }

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java?view=diffrev=472323r1=472322r2=472323
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java
 Tue Nov  7 15:16:34 2006
@@ -85,4 +85,14 @@
 }
}
 
+/**
+ * Kept for binary compatibility. 
+ *
+ * @deprecated Remove in 2.0
+ * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
+ */
+public Object handle(ResultSet rs) throws SQLException {
+return super.handle(rs);
+}
+
 }

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java?view=diffrev=472323r1=472322r2=472323
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
 Tue Nov  7 15:16:34 2006
@@ -67,4 +67,14 @@
 return this.convert.toMap(rs);
 }
 
+/**
+ * Kept for binary compatibility. 
+ *
+ * @deprecated Remove in 2.0
+ * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
+ */
+public Object handle(ResultSet rs) throws SQLException {
+return super.handle(rs);
+}
+
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472324 - /jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 15:16:58 2006
New Revision: 472324

URL: http://svn.apache.org/viewvc?view=revrev=472324
Log:
Fixed indent/javadoc

Modified:

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java?view=diffrev=472324r1=472323r2=472324
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
 Tue Nov  7 15:16:58 2006
@@ -56,25 +56,25 @@
 
 
 /**
-  * Convert row's columns into an codeObject[]/code.
-  * 
-  * @return codeObject[]/code, never codenull/code.
-  * 
-  * @throws SQLException
-  * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
-  */
- protected Object handleRow(ResultSet rs) throws SQLException {
- return this.convert.toArray(rs);
- }
+ * Convert row's columns into an codeObject[]/code.
+ * 
+ * @return codeObject[]/code, never codenull/code.
+ * 
+ * @throws SQLException
+ * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
+ */
+protected Object handleRow(ResultSet rs) throws SQLException {
+return this.convert.toArray(rs);
+}
 
- /*
-  * Kept for binary compatibility. 
-  *
-  * @deprecated Remove in 2.0
-  * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
-  */
- public Object handle(ResultSet rs) throws SQLException {
- return super.handle(rs);
- }
+/**
+ * Kept for binary compatibility. 
+ *
+ * @deprecated Remove in 2.0
+ * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
+ */
+public Object handle(ResultSet rs) throws SQLException {
+return super.handle(rs);
+}
 
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-113) [beanutils] Indexed property inside a mapped property cannot be accessed

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-113?page=all ]

Henri Yandell updated BEANUTILS-113:


  Bugzilla Id:   (was: 32380)
Fix Version/s: 1.8.0

 [beanutils] Indexed property inside a mapped property cannot be accessed
 

 Key: BEANUTILS-113
 URL: http://issues.apache.org/jira/browse/BEANUTILS-113
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Expression Syntax
Affects Versions: 1.6
 Environment: Operating System: All
 Platform: All
Reporter: Firepica
 Fix For: 1.8.0


 Hi, guys.
 Suppose I have a Map, let's call it building, inside that map I have an 
 entry
 with key rooms, which is a Collection. If I try to access room number 20 
 like
 this:
 building.rooms[20].type it doesn't work (throws IllegalArgumentException).
 I made a custom implementation of building Map so that I can see what param 
 is
 passed to the get() method. Surprisingly I see, that
 PropertyUtilsBean.getInstance().getProperty(bean, name) calls get() method on 
 my
 Map with parameter rooms[20] (including index part). 
 This is definitely a bug, because getProperty() should recognize, that rooms
 is an indexed property (because it has []), so it should cut off [20], call
 get(rooms) and then obtain element with index 20 from the retrieved 
 Collection.
 Please have a look.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-109) [beanutils] BeanUtils.setProperty fails with mapped properties containing several MAPPED_DELIM2 characters

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-109?page=all ]

Henri Yandell updated BEANUTILS-109:


  Bugzilla Id:   (was: 30637)
Fix Version/s: 1.8.0

Consider for 1.8.0 anyway.

 [beanutils] BeanUtils.setProperty fails with mapped properties containing 
 several MAPPED_DELIM2 characters
 --

 Key: BEANUTILS-109
 URL: http://issues.apache.org/jira/browse/BEANUTILS-109
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Expression Syntax
Affects Versions: 1.6
 Environment: Operating System: All
 Platform: All
Reporter: Alejandro H. Gil Sanda
 Fix For: 1.8.0


 If you have some struts property of type HashMap in a form bean, and the key 
 of 
 the hashmap has an ( or an ) the method will incorrectly parse the name 
 of 
 the property causing struts to fail.
 html:text property=myhashmap(some_key_with_)_map_delim_in_it) /
 Some fix to the problem is to change the following lines:
 BeanUtils.java:375
 - int k = propName.indexOf(PropertyUtils.MAPPED_DELIM2);
 + int k = propName.lastIndexOf(PropertyUtils.MAPPED_DELIM2);
 BeanUtils.java:914
 - int k = propName.indexOf(PropertyUtils.MAPPED_DELIM2);
 + int k = propName.lastIndexOf(PropertyUtils.MAPPED_DELIM2);

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-104) [beanutils]special characters in mapped property keys are parsed incorrectly

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-104?page=all ]

Henri Yandell updated BEANUTILS-104:


  Bugzilla Id:   (was: 32748)
Fix Version/s: 1.8.0

 [beanutils]special characters in mapped property keys are parsed incorrectly
 

 Key: BEANUTILS-104
 URL: http://issues.apache.org/jira/browse/BEANUTILS-104
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Expression Syntax
 Environment: Operating System: All
 Platform: All
Reporter: rey abe
 Fix For: 1.8.0


 When using mapped properties (the ones backed by a HashMap in the 
 ActionForm), 
 HashMap keys containing . or [ / ] characters will result in an 
 Exception on 
 submission of forms containing input elements with such keys.
 Obviously these characters are mistaken for subproperty and array delimiters 
 when the 
 RequestProcessor tries to populate the ActionForm.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-95) [beanutils] Handling exceptions during BeanUtils.populate()

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-95?page=all ]

Henri Yandell updated BEANUTILS-95:
---

  Bugzilla Id:   (was: 31571)
Fix Version/s: 1.8.0

 [beanutils] Handling exceptions during BeanUtils.populate()
 ---

 Key: BEANUTILS-95
 URL: http://issues.apache.org/jira/browse/BEANUTILS-95
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
 Environment: Operating System: other
 Platform: Other
Reporter: Xavier Dury
 Fix For: 1.8.0


 Hi,
 I know this has been asked already before but could there be a way to handle 
 exceptions that occur during population? The populate() function could either 
 return a map(property, exception), take that kind of map as argument or -even 
 better- take a PopulateExceptionHandler as argument.
 The reason I would like to see this feature implemented is to allow struts to 
 use this mechanism to convert parameters from the request to actionform's 
 properties without *falling apart* when encountering one that is not well-
 formed. 
 It would be nice too if we were not *forced* to use string-only properties 
 for 
 actionforms (which in fact is a way to circumvent this conversion problem). I 
 would like my ActionForm or DynaActionForm declare strongly-typed properties 
 (maybe custom classes), register proper Converters into ConvertUtils in the 
 ActionServlet.initServlet() for example, and then maybe get back conversion 
 errors from within my action (maybe the PopulateExceptionHandler could add 
 some ActionErrors to the request).
 What do you think? I know this issue is tightly coupled to struts but 
 well... ;-)
 Thanks a lot,
 Xavier

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-88) [beanutils] PropertyUtilsBean.isReadable/isWriteable always returns false for mapped properties

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-88?page=all ]

Henri Yandell updated BEANUTILS-88:
---

  Bugzilla Id:   (was: 36980)
Fix Version/s: 1.8.0

 [beanutils] PropertyUtilsBean.isReadable/isWriteable always returns false for 
 mapped properties
 ---

 Key: BEANUTILS-88
 URL: http://issues.apache.org/jira/browse/BEANUTILS-88
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
 Environment: Operating System: All
 Platform: All
Reporter: Chuck Daniels
 Fix For: 1.8.0


 PropertyUtilsBean.isReadable/isWriteable always returns false for mapped 
 properties because it does not account for them.  The core logic within the 
 try 
 block of the isReadable method should look as follows (the logic for 
 isWriteable should be updated similarly):
 PropertyDescriptor desc =
 getPropertyDescriptor(bean, name);
 if (desc != null) {
 Method readMethod = desc.getReadMethod();
 if (readMethod == null) {
 if (desc instanceof IndexedPropertyDescriptor) {
 readMethod = ((IndexedPropertyDescriptor) 
 desc).getIndexedReadMethod
 ();
 } else if (desc instanceof MappedPropertyDescriptor) {
 readMethod = ((MappedPropertyDescriptor) desc).getMappedReadMethod
 ();
 }
 }
 return (readMethod != null);
 } else {
 return (false);
 }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-72) [beanutils] Problem with setting properties which are strings array.

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-72?page=all ]

Henri Yandell updated BEANUTILS-72:
---

  Bugzilla Id:   (was: 38654)
Fix Version/s: 1.8.0

 [beanutils] Problem with  setting properties which are strings array.
 -

 Key: BEANUTILS-72
 URL: http://issues.apache.org/jira/browse/BEANUTILS-72
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: ConvertUtils  Converters
 Environment: Operating System: other
 Platform: PC
Reporter: ivan matmati
 Fix For: 1.8.0


 In my work, I had to deal with indexed properties with Struts.Some of them, 
 using multibox, should be string arrays.
 But unfortunately, the setter I wrote was never called (It had a string array 
 as input parameter with the index as an other one).As I search the code, I 
 found what seemed a mistake in the code of BeanUtilsBean (version 1.7 of 
 commons bean utilities).
 In line 1003, in setProperty method :
 else if (value instanceof String[]) {
 newValue = getConvertUtils().convert(((String[]) value)[0], 
 type);
 I had to  correct it to 
 else if (value instanceof String[]) {
 newValue = getConvertUtils().convert(((String[]) value), 
 type);
 In no way, I want a string as newValue but the array itself.
 I hope it can help.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-66) [beanutils] MethodUtils.getAccessibleMethod does not work for enums

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-66?page=all ]

Henri Yandell updated BEANUTILS-66:
---

  Bugzilla Id:   (was: 39271)
Fix Version/s: LATER THAN 1.8.0

 [beanutils] MethodUtils.getAccessibleMethod does not work for enums
 ---

 Key: BEANUTILS-66
 URL: http://issues.apache.org/jira/browse/BEANUTILS-66
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
 Environment: Operating System: other
 Platform: Other
Reporter: Chris
 Fix For: LATER THAN 1.8.0


 I dont know if this is supposed to work or not, but it would be nice if 
 MethodUtils.getAccessibleMethod correctly detected accessible enum methods.  
 I 
 am in the most recent production beanutils.jar (1.7.0).
 I have an enum like this in its own file:
 public enum DataEditDataType {
   /** string data type */
   STRING {
 @Override
 public String getValueName() {
   return string;
 }
 
   },  ...
 Then I am getting the property descriptor ok
 PropertyDescriptor propertyDescriptor = PropertyUtils.getPropertyDescriptor
 (DataEditDataType.STRING, valueName);
 Then the method is fine
 Method method = propertyDescriptor.getReadMethod();
 But then it is seen as not accessible
 Method method = MethodUtils.getAccessibleMethod(method);
 Which return null
 The problem is line 415 of MethodUtils
 // If the declaring class is public, we are done
 Class clazz = method.getDeclaringClass();
 if (Modifier.isPublic(clazz.getModifiers())) {
 return (method);
 }
 For some reason, Modifer.isPrivate(clazz.getModifiers()) returns true (since 
 STRING is a subclass of the DataEditDataType enum.  but this is an enum 
 (DataEditDataType) which is publicly available???   There could be a line 
 here 
 to see if it is an enum, then if the superclass is public in which case it is 
 ok?  Something like this
 if (Enum.class.isAssignableFrom(clazz)  
 Modifier.isPublic(clazz.getSuperclass
 ().getModifiers()) {
   return method;
 }
 That would work for me, but not sure if it would work in all cases or break 
 something else or if there is another workaround I can do for my enum code.
 Thanks!
 Chris

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-59) [beanutils] Memory leak on webapp undeploy in WrapDynaClass

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-59?page=all ]

Henri Yandell updated BEANUTILS-59:
---

  Bugzilla Id:   (was: 35263)
Fix Version/s: 1.8.0

 [beanutils] Memory leak on webapp undeploy in WrapDynaClass
 ---

 Key: BEANUTILS-59
 URL: http://issues.apache.org/jira/browse/BEANUTILS-59
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: DynaBean
Affects Versions: 1.6
 Environment: Operating System: All
 Platform: All
Reporter: Simon Kitching
 Fix For: 1.8.0

 Attachments: WrapDynaClassClassKey.txt, WrapDynaClassClassKey.txt


 Class WrapDynaClass has a HashMap dynaClasses containing a mapping from Class 
 to
 WrapDynaClass. If this class were to be deployed via a shared webapp, then any
 reference in there to a class loaded via the webapp classloader will prevent 
 the
 webapp classloader from being garbage-collected when the webapp is undeployed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dbutils] Release process for dbutils-1.1. How can I help?

2006-11-07 Thread Rahul Akolkar

On 11/7/06, Henri Yandell [EMAIL PROTECTED] wrote:

On 11/7/06, Stephen Colebourne [EMAIL PROTECTED] wrote:
 Henri Yandell wrote:
  http://people.apache.org/~bayard/dbutils-1.0-to-1.1-jardiff.html
 
  It doesn't look that bad - jardiff complains that we've moved a method
  into a superclass in a few places. So a recompile will be needed (I
  think) rather than being able to drop the jar in place.

 You might want to try a clirr report to check for binary compatability.
 IIRC, moving a method up the hierarchy is binary compatible.

It seems to give the same info:

http://people.apache.org/~bayard/dbutils-1.0-to-1.1-clirr.txt


snip/

INFOs are OK though.

-Rahul



 If not, then a simple super.xxx() method in the subclasses where the
 method was removed from should be added.

Yup, that'd work.

Hen



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-184) [beanutils] Add BeanFactory class for dynamic factories.

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-184?page=all ]

Henri Yandell updated BEANUTILS-184:


  Bugzilla Id:   (was: 18087)
Fix Version/s: LATER THAN 1.8.0

 [beanutils] Add BeanFactory class for dynamic factories.
 

 Key: BEANUTILS-184
 URL: http://issues.apache.org/jira/browse/BEANUTILS-184
 Project: Commons BeanUtils
  Issue Type: Improvement
 Environment: Operating System: other
 Platform: Other
Reporter: David Graham
Priority: Minor
 Fix For: LATER THAN 1.8.0

 Attachments: FactoryException.java, ObjectFactory.java, 
 ObjectFactoryTest.java


 I have developed a utility class called ObjectFactory that allows you to 
 configure a dynamic factory.  You provide it a Map of logical names to fully 
 qualified class names and it will create objects of that type for that name.
 Example Usage:
 ObjectFactory factory = new ObjectFactory(myMap);
 try{
Set set = (Set)factory.create(my name for set);
 } catch (FactoryException e) {// error handling}
 BeanUtils might be a good home for this class with a name change to 
 BeanFactory. 
  I am willing to support this and supporting classes if adopted into 
 BeanUtils.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-248) Code to create a JavaBean and set its properties from a Java Properties instance

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-248?page=all ]

Henri Yandell updated BEANUTILS-248:


Fix Version/s: 1.8.0

Map - Bean seems useful, so putting in 1.8.0 - however might get punted to a 
later version if we decide we don't want big new features in there.

 Code to create a JavaBean and set its properties from a Java Properties 
 instance
 

 Key: BEANUTILS-248
 URL: http://issues.apache.org/jira/browse/BEANUTILS-248
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: Bean / Property Utils
 Environment: Coded on Windows XP professional with Netbean 5.5 Beta 2 
 using JDK 1.5.0
Reporter: Trevor Charles Miller
Priority: Minor
 Fix For: 1.8.0

 Attachments: BeanCreator.java


 The idea is simple and I've seen this done in Log4J and had a use case for it 
 myself in another project. Given a set of properties, create an instance of a 
 specified class and set properties on it. I think this could be very useful 
 for runtime configuration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dbutils] Release process for dbutils-1.1. How can I help?

2006-11-07 Thread Henri Yandell

On 11/7/06, Rahul Akolkar [EMAIL PROTECTED] wrote:

On 11/7/06, Henri Yandell [EMAIL PROTECTED] wrote:
 On 11/7/06, Stephen Colebourne [EMAIL PROTECTED] wrote:
  Henri Yandell wrote:
   http://people.apache.org/~bayard/dbutils-1.0-to-1.1-jardiff.html
  
   It doesn't look that bad - jardiff complains that we've moved a method
   into a superclass in a few places. So a recompile will be needed (I
   think) rather than being able to drop the jar in place.
 
  You might want to try a clirr report to check for binary compatability.
  IIRC, moving a method up the hierarchy is binary compatible.

 It seems to give the same info:

 http://people.apache.org/~bayard/dbutils-1.0-to-1.1-clirr.txt

snip/

INFOs are OK though.


Yep, you're both right. Quick test shows that in 1.3 and 1.5 the JVM
happily switches to the parent method of 1.1 if compiled against the
child method in 1.0.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [io] Ready for release?

2006-11-07 Thread Stephen Colebourne
Just sent a patch about DirectoryWalker, esp. for Niall to comment on. 
Otherwise, done for release, including release notes.


Stephen


Henri Yandell wrote:

Am I right in thinking that IO is ready for its next release?

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (IO-86) Add DirectoryWalker based on FileFinder

2006-11-07 Thread Stephen Colebourne (JIRA)
 [ http://issues.apache.org/jira/browse/IO-86?page=all ]

Stephen Colebourne updated IO-86:
-

Attachment: io.patch

After some consideration, I would like to add in a little more structure for 
the external use case of cancellation. Niall, I believe that this actually fits 
with your original proposal.

This patch adds a handleIsCancelled() method, but leaves the implementation up 
to the subclass. The subclass is still free to ignore this method and do their 
own thing if they need to, but IMO this method simplifies the cross thread 
collaboration for most external cancellation use cases.

If adopted, a test is needed for this patch.

 Add DirectoryWalker based on FileFinder
 ---

 Key: IO-86
 URL: http://issues.apache.org/jira/browse/IO-86
 Project: Commons IO
  Issue Type: New Feature
  Components: Utilities
Affects Versions: 1.2
Reporter: Niall Pemberton
 Fix For: 1.3

 Attachments: FileFinder.java, FileFinderTestCase.java, 
 io-DirectoryWalker-cancellation-3.patch, io-filefinder-start-end.patch, 
 io.patch


 I'd like to propose adding a FileFinder back into Commons IO. This is a 
 simplified version of what was recently moved out of Commons IO into the 
 finder component currently in the sandbox.
 I believe this is a simpler, more generic implementation than the finder 
 component and therefore would be considered suitable for inclusion in Commons 
 IO. Although simpler it could be used as the basis for achieving the finder 
 component's aims - namely to emulate the unix find command.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (BEANUTILS-49) [beanutils] Lock in BeanUtilsBean.getInstance(BeanUtilsBean.java:78)

2006-11-07 Thread Henri Yandell (JIRA)
[ 
http://issues.apache.org/jira/browse/BEANUTILS-49?page=comments#action_12447974 
] 

Henri Yandell commented on BEANUTILS-49:


Niall - any opinion? Should we wontfix this and send it Struts-wards to be 
fixed there?

 [beanutils] Lock in BeanUtilsBean.getInstance(BeanUtilsBean.java:78)
 

 Key: BEANUTILS-49
 URL: http://issues.apache.org/jira/browse/BEANUTILS-49
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
 Environment: Operating System: other
 Platform: Other
Reporter: Jesper Richter-Reichhelm

 Commons Beanutils 1.7 introduced a new problem:
 During high traffic times threads begin to wait at the synchronized method
 org.apache.commons.beanutils.BeanUtilsBean.getInstance() which causes the
 complete thread pool to be used up in our Struts 1.2.7 based web application. 
 In
 our live environment this caused all 70 threads to be blocked by the same 
 lock.
 This behaviour can be easily reproduced by a calling a test JSP provided below
 with multiple threads. Using the tool siege to concurrently call the JSP with
 two threads is enough to reproduce the lock scenario, the situation gets worse
 the more concurrent threads are used (i.e. the throughput decreases).
 !-- begin of test JSP --
 %@ taglib uri=/struts-logic.tld prefix=logic %
 %@ taglib uri=/struts-bean.tld prefix=bean %
 %@ taglib uri=/struts-tiles.tld prefix=tiles %
 %@ taglib uri=/struts-html.tld prefix=html %
 %@ taglib uri=/JLog.tld prefix=jlog %
 %@ page import=java.util.*%
 %
final long t0 = System.currentTimeMillis();
  Collection col = new ArrayList();
  for(int i = 0; i5; i++)
  {
   org.apache.struts.util.LabelValueBean lvb = new
 org.apache.struts.util.LabelValueBean(col+i, col+i);
   col.add(lvb);
  }
pageContext.setAttribute(col, col);
 %
 logic:notEmpty name=collogic:iterate name=col id=testlogic:iterate
 name=col id=test2logic:iterate name=col id=test3logic:iterate
 name=col id=test3logic:iterate name=col id=test4logic:iterate
 name=col id=test4
 bean:define id=foo name=test4 property=value/bean:define id=bar
 name=test4 property=label/
 /logic:iterate/logic:iterate/logic:iterate/logic:iterate/logic:iterate/logic:iterate/logic:notEmpty
 Finished!
 !-- end of test JSP -- 
 A test run with Struts 1.2.7 and Commons Beanutls 1.7.0 reproduces the lock 
 (in
 this example with 10 concurrent threads):
 siege -c10 -r20 localhost:1701/dcw/test.jsp
 = Thread dump is full with threads like this:
 ExecuteThread: '4' for queue: 'weblogic.kernel.Default' daemon prio=1
 tid=0x083859f8 nid=0x76f4 waiting for monitor entry [7628c000..7628c8bc]
 at
 org.apache.commons.beanutils.BeanUtilsBean.getInstance(BeanUtilsBean.java:78)
 - waiting to lock 0x6c86eab0 (a java.lang.Class)
 at
 org.apache.commons.beanutils.PropertyUtilsBean.getInstance(PropertyUtilsBean.java:101)
 at
 org.apache.commons.beanutils.PropertyUtils.getProperty(PropertyUtils.java:290)
 at org.apache.struts.taglib.TagUtils.lookup(TagUtils.java:950)
 at 
 org.apache.struts.taglib.bean.DefineTag.doEndTag(DefineTag.java:230)
 at jsp_servlet.__test._jspService(__test.java:309)
 ...
 This behaviour is new to version 1.7. The same test using Commons Beanutils
 1.6.1 showed no problems: By falling back to the old version we could
 temporarily solve our live problems and could continue to use Struts 1.2.7.
 Nevertheless this should be fixed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[beanutils] 1.8.0...

2006-11-07 Thread Henri Yandell

I'm sure no one has noticed, but Niall and I have been puttering
around with BeanUtils.

Niall's got a bit of a converter rewrite in there that will hopefully
resolve a bunch of issues.

One question - should we release the optional bit at the same time?

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472329 - in /jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers: ArrayListHandler.java BeanListHandler.java ColumnListHandler.java MapListHandler.java

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 15:35:12 2006
New Revision: 472329

URL: http://svn.apache.org/viewvc?view=revrev=472329
Log:
Removed the backwards compatible handle(ResultSet) super call because it's not 
necessary for backwards compatibility

Modified:

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java

jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java?view=diffrev=472329r1=472328r2=472329
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ArrayListHandler.java
 Tue Nov  7 15:35:12 2006
@@ -67,14 +67,4 @@
 return this.convert.toArray(rs);
 }
 
-/**
- * Kept for binary compatibility. 
- *
- * @deprecated Remove in 2.0
- * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
- */
-public Object handle(ResultSet rs) throws SQLException {
-return super.handle(rs);
-}
-
 }

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java?view=diffrev=472329r1=472328r2=472329
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/BeanListHandler.java
 Tue Nov  7 15:35:12 2006
@@ -76,14 +76,4 @@
 return this.convert.toBean(rs, type);
 }
 
-/**
- * Kept for binary compatibility. 
- *
- * @deprecated Remove in 2.0
- * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
- */
-public Object handle(ResultSet rs) throws SQLException {
-return super.handle(rs);
-}
-
 }

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java?view=diffrev=472329r1=472328r2=472329
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/ColumnListHandler.java
 Tue Nov  7 15:35:12 2006
@@ -85,14 +85,4 @@
 }
}
 
-/**
- * Kept for binary compatibility. 
- *
- * @deprecated Remove in 2.0
- * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
- */
-public Object handle(ResultSet rs) throws SQLException {
-return super.handle(rs);
-}
-
 }

Modified: 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java?view=diffrev=472329r1=472328r2=472329
==
--- 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
 (original)
+++ 
jakarta/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/handlers/MapListHandler.java
 Tue Nov  7 15:35:12 2006
@@ -67,14 +67,4 @@
 return this.convert.toMap(rs);
 }
 
-/**
- * Kept for binary compatibility. 
- *
- * @deprecated Remove in 2.0
- * @see 
org.apache.commons.dbutils.handlers.GenericListHandler#handle(ResultSet)
- */
-public Object handle(ResultSet rs) throws SQLException {
-return super.handle(rs);
-}
-
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r472344 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/DirectoryWalker.java

2006-11-07 Thread bayard
Author: bayard
Date: Tue Nov  7 16:07:40 2006
New Revision: 472344

URL: http://svn.apache.org/viewvc?view=revrev=472344
Log:
Missing / in HTML

Modified:

jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/DirectoryWalker.java

Modified: 
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/DirectoryWalker.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/DirectoryWalker.java?view=diffrev=472344r1=472343r2=472344
==
--- 
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/DirectoryWalker.java
 (original)
+++ 
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/DirectoryWalker.java
 Tue Nov  7 16:07:40 2006
@@ -144,7 +144,7 @@
  *HiddenFileFilter.VISIBLE,
  *FileFilterUtils.suffixFileFilter(.txt),
  *  );
- * pre
+ * /pre
  * This is much simpler than the previous example, and is why it is the 
preferred
  * option for filtering.
  *



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-43) [beanutils] Mapped property inside a mapped property is not populated on submit

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-43?page=all ]

Henri Yandell updated BEANUTILS-43:
---

  Bugzilla Id:   (was: 31852)
Fix Version/s: 1.8.0

 [beanutils] Mapped property inside a mapped property is not populated on 
 submit
 ---

 Key: BEANUTILS-43
 URL: http://issues.apache.org/jira/browse/BEANUTILS-43
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
 Environment: Operating System: Windows XP
 Platform: PC
Reporter: Firepica
 Fix For: 1.8.0


 Hi, everyone.
 Suppose, I have a Map in my form, called person: 
 private Map person;
 That Map has (besides other entries), a entry called addresses, which is in
 turn a Map again. This addresses Map has several addresses of the person. 
 One
 of those addresses has key home and String value of home address.
 I want to render a text input field for the home address - I use EL syntax, 
 no
 brackets (it renders element correctly):
 nested:text property=person.addresses.home/
 In html this element is _being rendered correctly_, including correctly
 displayed value of home address, taken from the addresses Map.
 However, if I submit this form with changed value of address, it's not being
 populated.
 I wrote my own implementation of addresses Map to see what's happening, and 
 I
 saw that no put method is called at all (only get() while rendering the 
 element).
 So then I also made custom implementation of person Map and saw there, that
 while submitting, it calls get(addresses) (which returns addresses Map) 
 and
 that's all. 
 So apparently, BeanUtils sees, that it retrieved a Map and stops processing, 
 not
 generating any exceptions BTW.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-10) [beanutils] StringLocaleConverter uses same pattern for numbers and dates

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-10?page=all ]

Henri Yandell updated BEANUTILS-10:
---

  Bugzilla Id:   (was: 39477)
Fix Version/s: 1.8.0

 [beanutils] StringLocaleConverter uses same pattern for numbers and dates
 -

 Key: BEANUTILS-10
 URL: http://issues.apache.org/jira/browse/BEANUTILS-10
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Locale BeanUtils / Converters
 Environment: Operating System: All
 Platform: All
Reporter: Brian Rodgers
 Fix For: 1.8.0

 Attachments: mixed-bean-test.zip


 StringLocaleConverter doesn't appear to allow for the fact that you need 
 separate patterns when converting a date field than you do when converting a 
 number field.  Hence, when copying values from a typed bean to a String bean 
 (such as when copying data into an ActionForm), if the typed bean has both 
 numbers and dates, one or the other will be corrupted.
 To reproduce:
 1. Create a bean that contains a java.util.Date field and a number (any 
 numeric object or primative) field.  
 2. Create another bean with matching String fields.
 3. Populate data into the typed bean from step 1.
 4. Register a StringLocaleConverter using a date pattern.  
 5. User LocalBeanUtils.copyProperties to copy from the typed bean (step 1) to 
 the String bean (step 2).
 6. Print the fields in the String bean.  The date field will be properly 
 converted, but the number field will be formatted (to the extent that it can 
 be) using the date pattern.
 Of course, it also works the other way -- specify a number pattern and the 
 date field will be corrupted.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-35) [beanutils] Indexed properties with Array type cause IllegalArgumentException in setProperty/populate

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-35?page=all ]

Henri Yandell updated BEANUTILS-35:
---

  Bugzilla Id:   (was: 29203)
Fix Version/s: 1.8.0

 [beanutils] Indexed properties with Array type cause IllegalArgumentException 
 in setProperty/populate
 -

 Key: BEANUTILS-35
 URL: http://issues.apache.org/jira/browse/BEANUTILS-35
 Project: Commons BeanUtils
  Issue Type: Bug
  Components: Bean / Property Utils
Affects Versions: Nightly Builds
 Environment: Operating System: All
 Platform: All
Reporter: David Wood
 Fix For: 1.8.0

 Attachments: ArrayIndexedProperty.patch, 
 beanutils-indexed-arrays.patch


 If you attempt:
 public String[] getIndexedArrayProperty(int index)
 public void setIndexedArrayProperty(int index,String newvalue[])
 ...this will fail with an IllegalArgumentException in PropertyUtilsBean, 
 because
 setProperty will decide to store the first element of the newvalue array 
 rather
 than the whole array.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-244) [collections] Add a multi property beancomparator

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-244?page=all ]

Henri Yandell updated BEANUTILS-244:


  Bugzilla Id:   (was: 39008)
Fix Version/s: LATER THAN 1.8.0

 [collections] Add a multi property beancomparator
 -

 Key: BEANUTILS-244
 URL: http://issues.apache.org/jira/browse/BEANUTILS-244
 Project: Commons BeanUtils
  Issue Type: New Feature
  Components: Bean-Collections
 Environment: Operating System: Windows XP
 Platform: All
Reporter: Baptiste MATHUS
Priority: Minor
 Fix For: LATER THAN 1.8.0


 Hi,
 I recently needed to be able to sort a list of beans on many properties. So I
 thought I would try and pick one of the collections comparators.
 I had to to the sorting close to the sql way : be able to sort on n 
 properties,
 some ascending, some descending.
 I haven't found what I'm looking for (:p), but I found some comparators in the
 commons I used to do this : I used BeanComparator, NullComparator and
 ComparatorChain to create a class : MultiPropertyBeanComparator.
 Is there already something in one of the commons package that could be used
 instead of it ? 
 If not, I'd be glad to contribute the small piece of code if wanted. It has
 dependencies against commons-beanutils (BeanComparator, which is moving from 
 one
 package to another at the moment, no ?) and commons-lang
 (StringUtils.isBlank()). I think some things might not satisfactory for
 everybody, but hey, could still be improved without problems, that's not big
 work :p.
 As adviced on the user mailing list, I'm posting the code on this bugzilla, so
 as maybe one of the coder could take a look at it.
 Here it is :
 ===
 import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.Comparator;
 import java.util.List;
 import org.apache.commons.beanutils.BeanComparator;
 import org.apache.commons.collections.ComparatorUtils;
 import org.apache.commons.collections.comparators.NullComparator;
 import org.apache.commons.collections.comparators.ReverseComparator;
 import org.apache.commons.lang.StringUtils;
 /**
  * This comparator lets you sort a list using a list of properties. You can
 specify ascending or
  * descending order on these properties.
  * p
  * For example, if you want to sort with natural order a list of beans with
 properties firstname,
  * nickname and address, sorting the firstname descending, you can do it this 
 way:
  * /p
  * codeList l = .../code
  * code.../code
  * codeMultiPropertyBeanComparator multiPropBeanComp = new
 MultiPropertyBeanComparator();/code
  * codemultiPropBeanComp.append(firstname,
 true).append(nickname).append(address);/code
  * codeCollections.sort(l,multiPropBeanComp);/code
  * 
  * @author Baptiste MATHUS
  */
 public class MultiPropertyBeanComparator implements Comparator, Serializable
 {
   private static final long serialVersionUID = -1431852774261001458L;
   private List comparatorList = new ArrayList();
   /**
* Use this method to add a comparator to the list.
* 
* @param property
*the property on which to apply the given comparator.
* @param comparator
*the comparator to be added. If null, natural order will 
 be used.
* @param reverse
*p
*must be true if the given comparator must be used in 
 opposite
 order to sort. For
*example, if the comparator is designed to sort in 
 ascending
 order, put this
*parameter to codetrue/code if you want descending 
 order.
*/p
*p
*If the comparator is null, then the reversed natural 
 order is used.
*/p
*/
   public MultiPropertyBeanComparator append(String property, Comparator 
 comparator,
   boolean reverse)
   {
   if (StringUtils.isBlank(property))
   {
   throw new IllegalArgumentException(The given property 
 is blank);
   }
   // If the comparator is null, then compare only on the given 
 property
   // with a natural sort.
   if (comparator == null)
   {
   comparator = new BeanComparator(property, new 
 NullComparator(false));
   }
   // Else : compare on the property, but with given comparator.
   else
   {
   comparator = new BeanComparator(property, comparator);
   }
   // Here, the comparator cannot be null anymore, so reverse it if
   // necessary.
   if (reverse)
   {
   comparator = new ReverseComparator(comparator);
   

[jira] Updated: (BEANUTILS-238) [beanutils] Add nullate utilities

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-238?page=all ]

Henri Yandell updated BEANUTILS-238:


  Bugzilla Id:   (was: 27074)
Fix Version/s: LATER THAN 1.8.0

 [beanutils] Add nullate utilities
 -

 Key: BEANUTILS-238
 URL: http://issues.apache.org/jira/browse/BEANUTILS-238
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: Bean / Property Utils
 Environment: Operating System: other
 Platform: Other
Reporter: Marc Guillemot
Priority: Minor
 Fix For: LATER THAN 1.8.0


 It's a common task to reset all properties of an object to null (or to default
 values for primitives), for instance in Struts in the reset method of 
 subclasses
 of ActionForm.
 It would be usefull to have something like
 - nullateProperties(Object _o)
  to nullate the properties of _o declared by the class of _o
 - nullateProperties(Object _o, Class _clazz)
  to nullate the properties of _o declared by _clazz
 - nullateProperties(Object _o, Class _clazz, boolean _bAncestorsToo)
  to nullate the properties of _o declared by _clazz and its ancestors

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-237) [beanutils] Add aggressive mode for BeanUtils.copyProperty()

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-237?page=all ]

Henri Yandell updated BEANUTILS-237:


  Bugzilla Id:   (was: 21076)
Fix Version/s: LATER THAN 1.8.0

 [beanutils] Add aggressive mode for BeanUtils.copyProperty()
 --

 Key: BEANUTILS-237
 URL: http://issues.apache.org/jira/browse/BEANUTILS-237
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: Bean / Property Utils
 Environment: Operating System: other
 Platform: Other
Reporter: apachebugs
Priority: Minor
 Fix For: LATER THAN 1.8.0


 Currently, the Beanutils.copyProperty() method behaves as per the javadoc:
 If the specified bean does not have a property of the specified name, or the 
 property is read only on the destination bean, return without doing anything
 It would be good if the method could take an optional extra parameter which 
 indicated whether or not this behaviour should be more aggressive, i.e. if the
 bean does not have a read-write property of the appropriate name, then throw 
 an
 exception.  An overloaded copyProperty() is the obvious choice.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-233) [beanutils] DynaProperty doesn't override equals or hashCode

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-233?page=all ]

Henri Yandell updated BEANUTILS-233:


  Bugzilla Id:   (was: 34457)
Fix Version/s: 1.8.0

 [beanutils] DynaProperty doesn't override equals or hashCode
 

 Key: BEANUTILS-233
 URL: http://issues.apache.org/jira/browse/BEANUTILS-233
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: DynaBean
Affects Versions: Nightly Builds
 Environment: Operating System: All
 Platform: All
Reporter: Russell
Priority: Minor
 Fix For: 1.8.0

 Attachments: DynaPropertyTestCase.java, patchfile.txt


 Meaningful implementations of these methods are necessary for implementing the
 same methods in classes that use DynaProperty. The reference equality test
 provided by Object is not useful in most cases.
 I have a patch and a new TestCase, but don't see a way to attach it on this 
 form.
 I wasn't sure about the build number either. I got the source from anonymous 
 svn.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-228) [beanutils] ConvertUtilsBean: register converter for specific property

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-228?page=all ]

Henri Yandell updated BEANUTILS-228:


  Bugzilla Id:   (was: 31568)
Fix Version/s: 1.8.0

 [beanutils] ConvertUtilsBean: register converter for specific property
 --

 Key: BEANUTILS-228
 URL: http://issues.apache.org/jira/browse/BEANUTILS-228
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: ConvertUtils  Converters
Affects Versions: 1.5
 Environment: Operating System: other
 Platform: Other
Reporter: Michael Schuerig
Priority: Minor
 Fix For: 1.8.0


 Currently, converters are selected only based on the class to which they 
 convert objects. In general this works pretty well, but I've encountered 
 cases, where this doesn't work out.  
  
 For example, I'm using java.util.Date objects to represent points and 
 intervals in time that are not completely specific, such as day of the week 
 and month. Now I can easily write a Converter that uses SimpleDateFormat to 
 convert string representations of these dates (Mon, Feb) to Date objects. 
  
  
 When I register one of these converters with ConvertUtils(Bean), though, it 
 preempts any conversion to Date. Something I clearly don't want as I have to 
 deal with different kinds of dates. 
  
 As a solution, I'd like to be able to register a converter for a specific 
 property of a bean class, with a method this 
  
 ConvertUtilsBean#register(Converter converter, java.lang.Class 
 destinationClass, java.lang.Class beanClass, java.lang.String propertyName) 
  
 Michael

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-227) [beanutils] Register converters by both target class and source class

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-227?page=all ]

Henri Yandell updated BEANUTILS-227:


  Bugzilla Id:   (was: 20686)
Fix Version/s: 1.8.0

 [beanutils] Register converters by both target class and source class
 -

 Key: BEANUTILS-227
 URL: http://issues.apache.org/jira/browse/BEANUTILS-227
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: ConvertUtils  Converters
 Environment: Operating System: All
 Platform: All
Reporter: Eric Pabst
Priority: Minor
 Fix For: 1.8.0


 One of the big shortcomings I see with the ConvertUtils is that you can't 
 intuitively register different converters based on source class.  e.g. 
 SomeClass to String, and OtherClass to String.  Especially since multiple 
 ConvertUtilsBeans can co-exist, it only makes sense to be able to get away 
 from 
 depending on the toString() method for ALL conversions to a String type (this 
 is the nearest match that I can see to what I'm asking for).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-226) [beanutils] Instantiate property if null in form bean

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-226?page=all ]

Henri Yandell updated BEANUTILS-226:


  Bugzilla Id:   (was: 10319)
Fix Version/s: LATER THAN 1.8.0

 [beanutils] Instantiate property if null in form bean
 -

 Key: BEANUTILS-226
 URL: http://issues.apache.org/jira/browse/BEANUTILS-226
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: Bean / Property Utils
 Environment: Operating System: other
 Platform: All
Reporter: Emmanuel Boudrant
Priority: Minor
 Fix For: LATER THAN 1.8.0

 Attachments: auto-instantiate-smart-converters.txt, 
 extensible-bean-utils.txt


 Hello,
 When nested property used inside a form bean, example :
 a class Date composed by 3 String.
 if the property is null, PropertyUtils.lookup return a null value.
 Is it possible to change this comportement by returning, if property is null, 
 the property instanciated by default constructor, like the comportment of the 
 jsp tag jsp:useBean ... 
 Else I can't write/read the nested property date.day if date is null, Struts 
 throw a exception.
 -Emmanuel

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-223) [beanutils] Localizing beanutils

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-223?page=all ]

Henri Yandell updated BEANUTILS-223:


  Bugzilla Id:   (was: 20836)
Fix Version/s: 1.8.0

 [beanutils] Localizing beanutils
 

 Key: BEANUTILS-223
 URL: http://issues.apache.org/jira/browse/BEANUTILS-223
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: ConvertUtils  Converters
Affects Versions: 1.6
 Environment: Operating System: All
 Platform: All
Reporter: José Tito C. Paiva
Priority: Minor
 Fix For: 1.8.0

 Attachments: BeanUtils.java, BigDecimalConverter.java


 Copy and converter funcions in bean utils aren't localized. I created a patch 
 adding locale parameter to copyProperties/Property method. SQL  Date 
 converters were also modified. Now, when copying and converting properties, 
 localized date and number formats are considered.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-221) [beanutils] add protected accessor to fundamental map in BeanUtils project

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-221?page=all ]

Henri Yandell updated BEANUTILS-221:


  Bugzilla Id:   (was: 33384)
Fix Version/s: LATER THAN 1.8.0

 [beanutils] add protected accessor to fundamental map in BeanUtils project
 --

 Key: BEANUTILS-221
 URL: http://issues.apache.org/jira/browse/BEANUTILS-221
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: Bean / Property Utils
 Environment: Operating System: All
 Platform: All
Reporter: Marc DeXeT
Priority: Minor
 Fix For: LATER THAN 1.8.0


 In the maintime, it's impossible to extends major BeanUtils utils class ( as
 BeanUtilsBean, PropertyUtilsBean and so on) because of fundamental maps are
 private and there no protected access to them.
 It will be very nice for further enhancements to add protected accessor to 
 them.
 Thanks !

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-218) [beanutils] Need utility for collecting differences between objects

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-218?page=all ]

Henri Yandell updated BEANUTILS-218:


  Bugzilla Id:   (was: 34470)
Fix Version/s: LATER THAN 1.8.0

 [beanutils] Need utility for collecting differences between objects
 ---

 Key: BEANUTILS-218
 URL: http://issues.apache.org/jira/browse/BEANUTILS-218
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: Bean / Property Utils
 Environment: Operating System: other
 Platform: Other
Reporter: Nathan Egge
Priority: Minor
 Fix For: LATER THAN 1.8.0


 It would be really convinient if there was a method on the BeanUtils object 
 that
 would return a list of all the attributes that have changed between two 
 objects.
  This is useful for creating an audit trail of those attributes that have been
 modified.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-215) BeanUtilsBean: Set a mapped/indexed property, for example property(time)[0]

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-215?page=all ]

Henri Yandell updated BEANUTILS-215:


  Bugzilla Id:   (was: 38722)
Fix Version/s: 1.8.0

 BeanUtilsBean: Set a mapped/indexed property, for example property(time)[0]
 -

 Key: BEANUTILS-215
 URL: http://issues.apache.org/jira/browse/BEANUTILS-215
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: Expression Syntax
 Environment: Operating System: other
 Platform: Other
Reporter: Ludwig Wensauer
Priority: Minor
 Fix For: 1.8.0


 From line 1014 ff there is the following piece of code:
 try {
 if (index = 0) {
 getPropertyUtils().setIndexedProperty(target, propName,
  index, newValue);
 } else if (key != null) {
 getPropertyUtils().setMappedProperty(target, propName,
 key, newValue);
 } else {
 getPropertyUtils().setProperty(target, propName, newValue);
 }
 ...
 That's good for mapped OR indexed properties, but unfortunatly i have both at
 the same time. So index is = 0 and key is also != null.
 My property-name looks like this one here: 
 property(time)[0]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-214) [beanutils] Preserving DynaBean Property Ordering

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-214?page=all ]

Henri Yandell updated BEANUTILS-214:


  Bugzilla Id:   (was: 37825)
Fix Version/s: LATER THAN 1.8.0

A LinkedHashMap would push the required JDK version up, so won't be in 1.8.0.

 [beanutils] Preserving DynaBean Property Ordering
 -

 Key: BEANUTILS-214
 URL: http://issues.apache.org/jira/browse/BEANUTILS-214
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: DynaBean
 Environment: Operating System: All
 Platform: All
Reporter: Martin Fick
Priority: Minor
 Fix For: LATER THAN 1.8.0


 The order of properties is not preserved when using the beanutils to fetch 
 properties from a DynaBean.  Since DynaBeans use an array to define 
 properties 
 it is natural desire to use the order of this array to do things with a 
 DynaBean.  With a 2 line patch to BeanUtilsBean.java, it can be made to 
 return 
 a LinkedHashMap for DynaBean properties which preserves the ordering of these 
 properties.   
  
 This patch is particularly usefull if you are using the display tag to 
 display DynaBeans.  Several people have suggested a patch like this on the 
 display tag mailing list. 
  
  
 *** BeanUtilsBean.java 
 --- BeanUtilsBean.java.ordered 
 *** 
 *** 26,31  
 --- 26,32  
   import java.util.ArrayList; 
   import java.util.Collection; 
   import java.util.HashMap; 
 + import java.util.LinkedHashMap; 
   import java.util.Iterator; 
   import java.util.Map; 
   import java.util.WeakHashMap; 
 *** 
 *** 487,493  
   log.debug(Describing bean:  + bean.getClass().getName()); 
   } 
  
 ! Map description = new HashMap(); 
   if (bean instanceof DynaBean) { 
   DynaProperty descriptors[] = 
   ((DynaBean) bean).getDynaClass().getDynaProperties(); 
 --- 488,494  
   log.debug(Describing bean:  + bean.getClass().getName()); 
   } 
  
 ! Map description = new LinkedHashMap(); 
   if (bean instanceof DynaBean) { 
   DynaProperty descriptors[] = 
   ((DynaBean) bean).getDynaClass().getDynaProperties();

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (BEANUTILS-213) [beanutils] Enhancement to ResultSetDynaClass to allow case-insensitive and missing parameter bean mapping

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-213?page=all ]

Henri Yandell updated BEANUTILS-213:


  Bugzilla Id:   (was: 24185)
Fix Version/s: LATER THAN 1.8.0

 [beanutils] Enhancement to ResultSetDynaClass to allow case-insensitive and 
 missing parameter bean mapping
 --

 Key: BEANUTILS-213
 URL: http://issues.apache.org/jira/browse/BEANUTILS-213
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: DynaBean
Affects Versions: 1.6.1
 Environment: Operating System: other
 Platform: Other
Reporter: Michael Mainguy
Priority: Minor
 Fix For: LATER THAN 1.8.0

 Attachments: introspectClassJDBCDynaClass.patch, 
 ResultSetDynaClass.java


 ##This is a 1 file patch for JDBCDynaClass and ResultSetDynaClass to allow 
 more
 ##flexibility in the mapping of variable names to bean attributes.  
 ##e.g. PROJNBR in resultset will automatically get mapped to ProjNbr or 
 PrOjNbR
 ##in bean.  class returned by iterator will not fail if there are fewer fields
 ##in resultset than in input bean.
 --- JDBCDynaClass.orig2003-10-14 11:40:20.0 -0400
 +++ JDBCDynaClass.java2003-10-13 11:39:49.0 -0400
 @@ -69,11 +69,13 @@
  import java.util.HashMap;
  import java.util.Map;
  
 +
  /**
   * pProvides common logic for JDBC implementations of [EMAIL PROTECTED] 
 DynaClass}./p
   *
   * @author   Craig R. McClanahan
   * @author   George Franciscus
 + * @author   Michael Mainguy
   * @version $Revision: 1.3 $ $Date: 2003/10/09 20:43:15 $
   */
  
 @@ -256,6 +258,48 @@
  
  }
  
 -}
  
 + /**
 +  * pIntrospect the metadata associated with our result set, and 
 populate
 +  * the codeproperties/code and codepropertiesMap/code instance
 +  * variables./p
 +  *
 +  * @param resultSet The coderesultSet/code whose metadata is to
 +  *  be introspected
 +  * @param resultSet The codeDynaClass/code whose properties we want
 +  *  to use
 +  * 
 +  * @exception SQLException if an error is encountered processing the
 +  *  result set metadata
 +  * 
 +  */
 + protected void introspect(ResultSet resultSet, DynaClass dynaClass) 
 throws SQLException {
 + HashMap propmap = new HashMap();
 + DynaProperty[] props = dynaClass.getDynaProperties();
 + for (int i = 0; i props.length; i++) {
 + propmap.put(props[i].getName().toLowerCase(), props[i]);
 + 
 + }
 + // Accumulate an ordered list of DynaProperties
 + ArrayList list = new ArrayList();
 + ResultSetMetaData metadata = resultSet.getMetaData();
 + int n = metadata.getColumnCount();
 + for (int i = 1; i = n; i++) { // JDBC is one-relative!
 + DynaProperty dynaProperty = (DynaProperty)propmap.get
 (metadata.getColumnName(i).toLowerCase());
 + if (dynaProperty != null) {
 + list.add(dynaProperty);
 + }
 + }
 +
 + // Convert this list into the internal data structures we need
 + properties =
 + (DynaProperty[]) list.toArray(new DynaProperty[list.size
 ()]);
 + for (int i = 0; i  properties.length; i++) {
 + propertiesMap.put(properties[i].getName(), properties
 [i]);
 + }
 +
 + }
 +
 +
 +}
 --- ResultSetDynaClass.orig   2003-10-14 11:39:15.0 -0400
 +++ ResultSetDynaClass.java   2003-10-13 11:39:47.0 -0400
 @@ -123,145 +123,171 @@
   * /pre
   *
   * @author Craig R. McClanahan
 + * @author Michael Mainguy
   * @version $Revision: 1.13 $ $Date: 2003/10/09 20:43:15 $
   */
  
  public class ResultSetDynaClass extends JDBCDynaClass implements DynaClass {
  
  
 - // --- 
 Constructors
 +// --- 
 Constructors
  
  
 - /**
 -  * pConstruct a new ResultSetDynaClass for the specified
 -  * codeResultSet/code.  The property names corresponding
 -  * to column names in the result set will be lower cased./p
 -  *
 -  * @param resultSet The result set to be wrapped
 -  *
 -  * @exception NullPointerException if coderesultSet/code
 -  *  is codenull/code
 -  * @exception SQLException if the metadata for this result set
 -  *  cannot be introspected
 -  */
 - public ResultSetDynaClass(ResultSet resultSet) throws SQLException {
  
 - this(resultSet, true);
  
 - }
 +/**
 + * pConstruct a new ResultSetDynaClass for the specified
 + * codeResultSet/code.  The property names corresponding
 + 

[jira] Updated: (BEANUTILS-210) [beanutils] copyProperties should have optional flag for including transient member variables

2006-11-07 Thread Henri Yandell (JIRA)
 [ http://issues.apache.org/jira/browse/BEANUTILS-210?page=all ]

Henri Yandell updated BEANUTILS-210:


  Bugzilla Id:   (was: 34644)
Fix Version/s: 1.8.0

 [beanutils] copyProperties should have optional flag for including transient 
 member variables
 -

 Key: BEANUTILS-210
 URL: http://issues.apache.org/jira/browse/BEANUTILS-210
 Project: Commons BeanUtils
  Issue Type: Improvement
  Components: Bean / Property Utils
 Environment: Operating System: other
 Platform: Other
Reporter: Nathan Egge
Priority: Minor
 Fix For: 1.8.0


 The EqualsBuilder, HashCodeBuilder, and ToStringBuilder all have a flag for
 allowing you to use only the non-transient member variables on an object.  The
 BeanUtils.copyProperties method should have a similar such variable (which can
 default to false) so you can designate only some variables to copy across 
 domains.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  1   2   >