Re: stream is now frozen for 2.0 alpha 2

2003-01-25 Thread Jeffrey Dever
The stream is now (re)tagged as HTTPCLIENT_2_0_ALPHA_2 Any checkins are fine at this point. Jandalf. Jeffrey Dever wrote: There are no bugs currently targeted for alpha 2 (or the old tag milestone 1). I'm just doing some finalizations now, dealing with Maven, running checkstyle and

Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
Okay, I have release builds for 2.0 alpha 2 up on the jakarta website. Can someone please have a look at them and ensure that they are sane in your environment? I'll announce it and delploy the website (you are gonna love the new logo) after I get some confirmation. http://jakarta.apache.org

Re: Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
vski wrote: Jandalf There are no examples in the binary package. Is it the way you wanted it to be? Olegolas On Sat, 2003-01-25 at 18:19, Jeffrey Dever wrote: Okay, I have release builds for 2.0 alpha 2 up on the jakarta website. Can someone please have a look at them and ensure that they are sa

Re: Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
Good catch. Working on it. Oleg Kalnichevski wrote: Jandalf build.properties.sample is missing in the source package. This is a bit unpleasant. People may have problems recompiling HttpClient using source package Oleg On Sat, 2003-01-25 at 18:19, Jeffrey Dever wrote: Okay, I have

Re: Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
There are 4 deprecation compiler warnings in test-nohost target which I thought I had fixed this morning. Otherwise things look all right after Did you check in those changes? build.properties is provided and edited to point to correct external libraries. I recompiled stuff, built testwebapp,

Re: Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
, 2003-01-25 at 19:03, Jeffrey Dever wrote: There are 4 deprecation compiler warnings in test-nohost target which I thought I had fixed this morning. Otherwise things look all right after Did you check in those changes? build.properties is provided and edited to point to correct

Re: Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
n the future. Thats it, I'm going for lunch! Jandalf. Jeffrey Dever wrote: Good catch. Working on it. Oleg Kalnichevski wrote: Jandalf build.properties.sample is missing in the source package. This is a bit unpleasant. People may have problems recompiling HttpClient using source package

Re: Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
, 2003-01-25 at 19:03, Jeffrey Dever wrote: There are 4 deprecation compiler warnings in test-nohost target which I thought I had fixed this morning. Otherwise things look all right after Did you check in those changes? build.properties is provided a

Re: Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
- From: Jeffrey Dever [mailto:[EMAIL PROTECTED]] Sent: Saturday, January 25, 2003 10:50 AM To: Commons HttpClient Project Subject: Re: Need sanity testing of 2.0 alpha 2 builds Tag name: HTTPCLIENT_2_0_ALPHA_2 <http://cvs.apache.org/viewcvs/jakarta-commons/httpclient/src/ test/org/apa

Re: Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
ote: Done. -- Martin Cooper -Original Message----- From: Jeffrey Dever [mailto:[EMAIL PROTECTED]] Sent: Saturday, January 25, 2003 10:50 AM To: Commons HttpClient Project Subject: Re: Need sanity testing of 2.0 alpha 2 builds Tag name: HTTPCLIENT_2_0_ALPHA_2 <http://cvs.apache.org/vi

garbled characters

2003-01-25 Thread Jeffrey Dever
Hey Olegolas, The last patch you submitted garbled a bunch of characters in the HttpMethodBase file. Whats up with that? http://cvs.apache.org/viewcvs.cgi/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethodBase.java.diff?r1=1.97&r2=1.98&diff_format=h Jandslf. -- To un

Re: Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
and I have not had breakfast yet. Jandlaf. Jeffrey Dever wrote: Okay, I have release builds for 2.0 alpha 2 up on the jakarta website. Can someone please have a look at them and ensure that they are sane in your environment? I'll announce it and delploy the website (you are gonna lov

Re: garbled characters

2003-01-25 Thread Jeffrey Dever
for this mess. I'll try to immediately correct it Oleg On Sat, 2003-01-25 at 21:40, Jeffrey Dever wrote: Hey Olegolas, The last patch you submitted garbled a bunch of characters in the HttpMethodBase file. Whats up with that? http://cvs.apache.org/viewcvs.cgi/jakarta-commons/httpclien

website is deployed

2003-01-25 Thread Jeffrey Dever
The website has been deployed thanks to Maven. There are a few broken links, and a few things there that don't have links to them. I'm still trying to figure out how to control the generation of the nav bar. Check it out! http://jakarta.apache.org/commons/httpclient/ -- To unsubscribe, e-mai

Re: Need sanity testing of 2.0 alpha 2 builds

2003-01-25 Thread Jeffrey Dever
That change did not make it into the release. No biggie. Oleg Kalnichevski wrote: Jandlaf, Even wizards must eat ;-) I have just corrected garbled comments. I hope it's all right now Olegolas On Sat, 2003-01-25 at 21:49, Jeffrey Dever wrote: Okay, there are a new set of packages o

Re: website is deployed

2003-01-25 Thread Jeffrey Dever
Working on that now ... Oleg Kalnichevski wrote: Jandalf The site looks great! Is there going to be a release announcement of the Jakarta front page? Oleg On Sat, 2003-01-25 at 23:50, Jeffrey Dever wrote: The website has been deployed thanks to Maven. There are a few broken links, and

[Announce] HttpClient 2.0 Alpha 2 Released!

2003-01-25 Thread Jeffrey Dever
After many months and a great resurgence of developers, the new build of /HttpClient/ is finally here. The new group of developers has done extensive refactoring to move the project along the new vision. The code base has reached a significant level of maturity and we expect that the beta build

The release is done

2003-01-25 Thread Jeffrey Dever
*At that moment Gandalf lifted his staff, and, crying aloud, he smote the bridge before him. The staff broke asunder and fell from his hand. A blinding sheet of white flame sprang up. The bridge cracked. Right at the Balrog's feet it broke, and the stone upon which it stood crashed into the gu

Re: [Announce] HttpClient 2.0 Alpha 2 Released!

2003-01-25 Thread Jeffrey Dever
Thats excellent. Its not exactly Slashdot news, but we like it ;-) otisg wrote: Congratulations, this is good to see! I took the liberty of submitting this great news to jGuru.com. -- To unsubscribe, e-mail: For additional commands, e-mail:

website is redeployed

2003-01-25 Thread Jeffrey Dever
Redeployed the website with some updates. -- To unsubscribe, e-mail: For additional commands, e-mail:

Re: website is redeployed

2003-01-26 Thread Jeffrey Dever
Redeployed (again). I was informed of the navigation.xml file, with which I was able to fix all the broken links that I could find and remove irrevelent links where I thought was reasonable. Let me know if you see anything wrong with the website or want anything added. Jandalf. Jeffrey

call for projects using httpclient

2003-01-26 Thread Jeffrey Dever
If you have an application that uses HttpClient, and would like to see it on our applications page, please send an email to: [EMAIL PROTECTED] http://jakarta.apache.org/commons/httpclient/applications.html -- To unsubscribe, e-mail: For additional commands, e-mail

Beta 1 development starts

2003-01-26 Thread Jeffrey Dever
For all current contributors and anyone wishing to contribute to HttpClient, we are now in the Beta 1 development stage. There is currently a rather complete list of bugs in bugzilla now. To find them, do a query for the *Commons* project, *HttpClient* component, and target milestone *2.0 Beta

Re: call for projects using httpclient

2003-01-26 Thread Jeffrey Dever
Got it. Thanks Mike. Mike Bowler wrote: HtmlUnit - A testing tool for web based applications http://htmlunit.sourceforge.net BTW The applications page lists the wrong email address "To have your application listed, write to [EMAIL PROTECTED]

NTLM tests fail when building with jdk1.3.1

2003-01-26 Thread Jeffrey Dever
It's come up here before about maintaining compatability with jdk1.3.1, and its come up on the commons-dev list as well. As it stands right now, some NTLM tests fail when building under 1.3.1. It seems that a single problem in authenticator is causing the issue. I can start to be more diligen

mailing list archive

2003-01-26 Thread Jeffrey Dever
There are two new archives for this mailing list. Looks like someone up there is starting to like us ;-) http://archives.apache.org/eyebrowse/SummarizeList?listId=128 http://www.mail-archive.com/commons-httpclient-dev%40jakarta.apache.org/ Jandalf. -- To unsubscribe, e-mail:

Re: [PATCH] Bug 16429 Align the code base with checkstyle

2003-01-26 Thread Jeffrey Dever
Ummm, there is no attachement to the email or the bug ... Mike Bowler wrote: Here is the first step towards fixing the checkstyle warnings. I've cleaned up warnings in quite a few files but lots still to go. -- To unsu

Re: [HttpClient] Proposed style change

2003-01-27 Thread Jeffrey Dever
Ah ha! I knew that this was going to come up, and I'm somewhat prepared. Both of your suggestions do have precedent in other Jakarta projects. I am open to the idea of having a coding standard specific to HttpClient. It is our right to have our own coding standard, if we so choose. Perhaps a

Re: NTLM tests fail when building with jdk1.3.1

2003-01-27 Thread Jeffrey Dever
ssage- From: Jeffrey Dever [mailto:[EMAIL PROTECTED]] Sent: Sonntag, 26. Januar 2003 20:42 To: Commons HttpClient Project Subject: NTLM tests fail when building with jdk1.3.1 It's come up here before about maintaining compatability with jdk1.3.1, and its come up on the commons-dev list as we

Re: [PATCH] Closing HttpConnection before retrying

2003-01-27 Thread Jeffrey Dever
A JUnit test case that we could patch into the HttpClient tests would be ideal ... As of yet, I haven't written any test cases for this problem. Perhaps you can provide the stack trace of the exception failure, or a more specific "trace" of the scenario, mentioning routine names (and line

Re: [HttpClient] Proposed style change

2003-01-27 Thread Jeffrey Dever
My proposals for changes to the default sun style rules: checkstyle.maxlinelen=100 I agree with Mike and Simon that the line length should be longer. 100 is fairly standard in other projects. (comment blocks should still be 80 however it is not enforceable with checkstyle). Martin brought up

Re: [HttpClient] Proposed style change

2003-01-27 Thread Jeffrey Dever
I propose that we change the pattern for instance variables to ^_?[a-z][a-zA-Z0-9]*$ so that we will allow leading underscores but will not insist on it. Uuuugh, please no! Besides being ugly, it's worth sticking to the Sun coding style (as is the default with checkstyle). That way, anyon

Re: [PATCH] Bug 16429 Align the code base with checkstyle

2003-01-27 Thread Jeffrey Dever
Ok, I thought we might wait on style related patches untill we finalize some guidelines, but you have focused on issues not is dispute so thats good. I do prefer patches to bugzilla, less traffic generated by email (someone has to be paying for the apache bandwitdh). Mike Bowler wrote: I've

Re: [PATCH] relative URIs

2003-01-27 Thread Jeffrey Dever
Sung-Gu, Do you approve of this patch? Sung-Gu wrote: - Original Message - From: "Michael Becke" <[EMAIL PROTECTED]> Subject: [PATCH] relative URIs Attached is a patch and test case for a few minor bugs I discovered in the URI(URI, URI) constructor. The patch changes the follow

Re: [PATCH] Bug 16429 Align the code base with checkstyle

2003-01-27 Thread Jeffrey Dever
Hey Mike, A couple issues with the patch. The tests failed due to a change to the parameters member in HeaderElement. A protected member was made to be private and given an accessor. I think that this is a good change, but patches should pass the tests before they are posted. The tests were

Re: [PATCH] relative URIs

2003-01-27 Thread Jeffrey Dever
e compared with included test cases that it's not consistent with httpclient test cases.) Sung-Gu P.S. Someone modify them comittable to httpclient? - Original Message - From: "Jeffrey Dever" <[EMAIL PROTECTED]> To: "Commons HttpClient Project" <[EMAIL

Re: [PATCH] relative URIs - take 2

2003-01-27 Thread Jeffrey Dever
econd issue. I'll look into that a little later. Mike On Monday, January 27, 2003, at 11:44 PM, Jeffrey Dever wrote: (Jeff rubs his head and tries to figure out what that means) So you mean that this is a bug: - fixes the case when the second arg to URI(URI,URI) is just a fragment

Re: [HttpClient] Proposed style change

2003-01-28 Thread Jeffrey Dever
nce variables in order to be able to differentiate them from local ones. I am aware there are tons of people who passionately hate this kind of convention. However, I am just wondering if it is going to be considered a violation new coding guidelines? Oleg -Original Message- From: Jef

Re: [PATCH] Bug 16429 Align the code base with checkstyle

2003-01-28 Thread Jeffrey Dever
I'd say that if there is a bugzilla bug for an issue, patches for that issue should be posted to bugzilla. If there is no bug, send to the list. Previously the bugzilla emails were being sent to the commons-dev list, which was no good. I just recently had that changed so this list is the defa

new webapp test guide

2003-01-28 Thread Jeffrey Dever
http://jakarta.apache.org/commons/httpclient/testwebapp.html I added a new dynamicly generated document. This was converted from the testwebapp guide Oleg originally posted in star office format. I'm not sure why its so "wide" but at least its there. Its the guide I use when I run the webapp

Re: new webapp test guide

2003-01-28 Thread Jeffrey Dever
Good call. [EMAIL PROTECTED] wrote: The reason it's so wide is the blockquote in the HTML. -- dIon Gillard, Multitask Consulting Blog: http://www.freeroller.net/page/dion/Weblog Work: http://www.multitask.com.au Jeffrey Dever <[EMAIL PROTECTED]> wrote on 29/01/2003

Re: Time for more mailing lists ?

2003-01-28 Thread Jeffrey Dever
single component mailing lists -- i think that single component mailing lists have not proved very successful. I completely disagree. As the HttpClient 2.0 release prime, I am disheartened that you feel that way. not only are they unpopular with the components t

[VOTE] checkstyle rules

2003-01-28 Thread Jeffrey Dever
There has not been any more discussion on this topic so its time to call a vote. Please vote on each entry with one of the following answers: +1 agree 0 don't care -1 disagree For more information on what these mean, please see the email thread on this and the checkstyle documentation: http://

Re: [VOTE] checkstyle rules

2003-01-28 Thread Jeffrey Dever
My votes. checkstyle.maxlinelen=100 +1 checkstyle.pattern.publicmember=^[a-z][a-zA-Z0-9]*$ +1 checkstyle.pattern.package=^[a-z]+(\.[a-z]*)*$ +1 checkstyle.header.file=license.regexp checkstyle.header.regexp=true +1 checkstyle.ignore.maxlinelen=Header: +1 checkstyle.tab.width=4

Re: performance

2003-01-29 Thread Jeffrey Dever
There have been a few performance enhancements along the way, but we have never gone through a performance optimizing phase. Sometime during late beta that should be done. Its encouraging that you are finding it fast now though! Kalnichevski, Oleg wrote: I am not aware of HttpClient being s

Re: [VOTE] checkstyle rules

2003-01-29 Thread Jeffrey Dever
Correct. There is another property for the maximum number of lines in a class, which by default is 2000. Currently HttpMethodBase violates this. Sung-Gu wrote: - Original Message - checkstyle.maxlinelen=100 -1 Does it mean really every max line length of a file or class? --

Re: [VOTE] checkstyle rules - results

2003-01-29 Thread Jeffrey Dever
ern.member=^_?[a-z][a-zA-Z0-9]*$ +11 0 2 -1 5 Jeffrey Dever wrote: There has not been any more discussion on this topic so its time to call a vote. Please vote on each entry with one of the following answers: +1 agree 0 don't care -1 disagree For more information on what these mean, pleas

Number of mailing list users

2003-01-29 Thread Jeffrey Dever
I checked to see how many subscriptions there are to the HttpClient mailing list for the first time today. I was pleasently surprised as it was *many* more than I had expected. Now in that number there are about 3 archive services subscribed, and probablly a few users subscribed twice, but th

Re: Bug 16429: Align the code base with checkstyle

2003-01-29 Thread Jeffrey Dever
Ha, ha. When I committed round 4 the commit message was rejected because it was longer than 100kB. Thats a BIG patch. Mike Bowler wrote: Another patch for the style changes is attached to the bug report ("round3"). http://issues.apache.org/bugzilla/show_bug.cgi?id=16429 There were a couple

Re: Bug 16429: Align the code base with checkstyle

2003-01-30 Thread Jeffrey Dever
There are lots of TODO: comments in the code. There were also a bunch of FIXME: comments which I've changed to "TODO" because checkstyle will warn us about TODO but not FIXME. Longer term we should probably change checkstyle to look for FIXME as well but for now it was easier to change those

Re: Not giving ourselves enough credit on the home page

2003-01-30 Thread Jeffrey Dever
All good points. I had not yet had a chance to update those documents. Its great to have input from everyone as the content is the hardest part. I created a bug report for it and am refrencing back to this mail thread. http://issues.apache.org/bugzilla/show_bug.cgi?id=16625 BTW: anyone can subm

Re: [PATCH] PostMethod & PutMethod revision (take 2)

2003-01-30 Thread Jeffrey Dever
1) I'm sure stuff like this is unintentional: - * @author Ortwin Glück - * @author mailto:[EMAIL PROTECTED]";>Mike Bowler + * @author Ortwin Glück 2) I thought we had deprecated the "use disk" methods in GetMethod, but I don't see it that way in the source. Didn't we agree that those methods w

Re: [PATCH] PostMethod & PutMethod revision (take 2)

2003-01-30 Thread Jeffrey Dever
Do you envision multiple calls to setRequestBody() still causing an IllegalStateException. On appearances, setRequestBody() looks like a setter method. I would not expect a setter method to throw an exception because I called it twice, I would expect it to just overwrite the previous value an

deployed website - new javadoc links

2003-01-30 Thread Jeffrey Dever
I rebuild and redeployed the website. The cool change of significance is the javadocs now link internally to j2sdk1.4.1 and commons-logging online javadocs. So if a method returns a String, it does not show up as java.lang.String, but as hyperlink to the String documentation. -jsd -

Re: [PATCH] PostMethod & PutMethod revision (take 2)

2003-01-31 Thread Jeffrey Dever
Internally we should just have one "body" datamember, which would be an InputStream. When setting the request body, if the streamBody() form is used, its trivial. When the stringBody() is used, create a StringInputStream which is easy. When the parametersBody() form is used, url encode it

Response Header ordering

2003-01-31 Thread Jeffrey Dever
think. I'm happy to do it now, but there are so many changes in 2.0 already it may be difficult for users to catch up. Mike On Friday, January 31, 2003, at 01:54 AM, Jeffrey Dever wrote: Well, at one point I was going to rewrite Header and NameValuePair, but the more I looked at the m

Re: [PATCH] PostMethod & PutMethod revision (take 3)

2003-01-31 Thread Jeffrey Dever
The local and webapp tests are fine here (except that one timeout issue that has been around for a while). There are a few things that could be tweaked, but please submit the patch so we can all benefit from it. Very high quality, great work! Jandalf Kalnichevski, Oleg wrote: Bug fixes: ht

Re: Minor bug in checkstyle.properties

2003-01-31 Thread Jeffrey Dever
Squashed it. Good catch. Laura Werner wrote: I just noticed a minor bug in checkstyle.properties. There are two settings for checkstyle.pattern.publicmember: checkstyle.pattern.publicmember=^f[A-Z][a-zA-Z0-9]*$ and checkstyle.pattern.publicmember=^[a-z][a-zA-Z0-9]*$ I'm not submitting a p

Re: [PATCH] PostMethod & PutMethod revision (take 3)

2003-01-31 Thread Jeffrey Dever
Hey Oleg. I'm Playing with PostMethod writing some tests. It looks really good in there, and will be even better after get rid the deprecated stuff. I had a few changes, and a few questions: 1) PostMethod.generateRequestBody() This method just url encodes the parameters. In the 5000 lines of

Re: [PATCH] PostMethod & PutMethod revision (take 3)

2003-02-01 Thread Jeffrey Dever
I have almost started moving code of PostMethod.generateRequestBody(NameValuePair[]) to URIUtils class, but there's one point that made me reconsider. Currently URIUtils does not know any HttpClient specific classes and that sort of makes sense. I am not sure if we should make URIUtils be tightly

Re: [PATCH] PostMethod & PutMethod revision (take 3)

2003-02-01 Thread Jeffrey Dever
I'd say that those Eclipse folks might find it an interesting idea to toy with. It falls more into their area expertise. Any buddies involved in Eclipse? Naw, I'm just a user :-) - To unsubscribe, e-mail: [EMAIL PROTECTED]

Re: Running out of connections

2003-02-01 Thread Jeffrey Dever
Yes, there are many uses of HttpClient with massive multiple connections so this is a serious issue. Mike Becke is the expert here. Oleg Kalnichevski wrote: Jandalf, Nobody responded to Simon so far, even though this problem sounds like a pretty nasty one. Shall we file a bug report? I suppose

Re: Not giving ourselves enough credit on the home page

2003-02-01 Thread Jeffrey Dever
Hey Juergen, Could you give us more of an update on what is happening with Slide and HttpClient? I see that the original httpclient package has been removed from slide (yay!), but how is the uptake of commons HtpClient? Anything standing in the way of using HttpClient for JSR147? Jandalf.

webapp tests

2003-02-01 Thread Jeffrey Dever
I modifyed a couple of the webapp servlets so you'll need to redeploy the war file before running the test-local ant target. I've started to make the webapp tests a bit more approachable. I'm running them all the time now and would like to get more of the new tests to be webapp based. Speakin

Re: cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclientTestGetMethodLocal.java TestHttps.java TestMethodsExternalHost.java TestMethodsLocalHost.javaTestWebappBasicAuth.java TestWebappCookie.java TestWebappHeaders.java TestWebappMethods.javaTestWebappParameters.java TestWebappRedirect.java

2003-02-02 Thread Jeffrey Dever
Too may deprecation warnings for ya? Sorry about that. I don't know why the tests all bothered to call useDisk(false), it was the default anyway. I also see that finally deprecating those usdisk methods has caused some gump warnings for Slide. I'll see what I can do over there, but they have

problem with recycling methods - use case

2003-02-02 Thread Jeffrey Dever
The idea of recycling methods is good, but at the moment, its not very useful. Consider the following use case: 1) User needs to make a bunch of GETs as efficiently as possible 2) All the resources that they want to get are full string urls 3) In a loop, iterate over the list of resources and do

Re: Running out of connections

2003-02-02 Thread Jeffrey Dever
public void testConnectionPool() throws IOException, HttpException { final MultiThreadedHttpConnectionManager manager = new MultiThreadedHttpConnectionManager(); HttpClient httpClient = new HttpClient(manager); httpClient.getHostConfiguration().setHost("www.

Re: more common classes need a home

2003-02-02 Thread Jeffrey Dever
Also noticed that codec and xml-rpc also have their own Base64 classes. The NameValuePair is also a candidate for a more general package (perhaps lang?) Jeffrey Dever wrote: There are still a bunch of classes that are in both HttpClient and Slide. In particular: Base64.java HttpsURL.java

more common classes need a home

2003-02-02 Thread Jeffrey Dever
There are still a bunch of classes that are in both HttpClient and Slide. In particular: Base64.java HttpsURL.java HttpURL.java URIException.java URI.java URIUtil.java URLUtil.java First of all, I think these should come out of Slide as part of their migration to commons-httpclient which is sti

Re: more common classes need a home

2003-02-02 Thread Jeffrey Dever
What are HttpsURL and HttpURL generally used for? Nothing. They are never even imported in httpclient classes, they are just ghosts in some comments and log strings. Thats part of the reason why I want to move them away from here. Also I don't find them a particularly useful abstraction t

Re: AW: POST method - Default content encoding

2003-02-03 Thread Jeffrey Dever
Just a unrelated comment about style in using httpclient. The method objects can take a full URL as a constructor, which is cleaner than setting up a HostConfiguration object for a one off request. Also, addParameter has recently been deprecated in favour of setRequestBody with an array of Na

Re: AW: POST method - Default content encoding

2003-02-03 Thread Jeffrey Dever
Note, he is using *getRequestBodyAsString*, not getResponseBodyAsString. There is no echo. [EMAIL PROTECTED] wrote: Mathis, I have double-checked the code and so far I have got no reason to assume it produces errnous results. I have run a simple echo test against HttpClient test web application.

Moving Base64 in HttpClient to commons-codec

2003-02-03 Thread Jeffrey Dever
There is a vote on the commons-dev list to use the Base64 encoder from HttpClient in the commons-codec package. If that passes we should discuss using the the new package and deprecating/removing the fork in HttpClient. I think that this would be good for code reuse and for commons. If you

Re: [Fwd: Re: Redirects?]

2003-02-03 Thread Jeffrey Dever
Its true that redirects to another host are very common. HttpMethod is very anal about not redirecting to a new host or port or protocol. The RFCs certainly allow that. There was state information that made it unrealistic to forward outside the current connection. But a lot has changed, ther

Re: Moving Base64 in HttpClient to commons-codec

2003-02-03 Thread Jeffrey Dever
enjoy! -- Ryan Hoegg ISIS Networks http://www.isisnetworks.net Jeffrey Dever wrote: There is a vote on the commons-dev list to use the Base64 encoder from HttpClient in the commons-codec package. If that passes we should discuss using the the new package and deprecating/removing the fork in

Re: [Fwd: Re: Redirects?]

2003-02-03 Thread Jeffrey Dever
Right, we should go back to the HttpClient to get another HttpConnection. Perhaps the entire redirect mechanism should be pushed up to the HttpClient class. I never liked the idea of a user holding onto a HttpState, HttpMethod and HttpConnection and calling the execute() method itself. This

Re: Moving Base64 in HttpClient to commons-codec

2003-02-03 Thread Jeffrey Dever
codec] Base64 class (based off of an old HttpClient Base64) will be deprecated for a week and then removed. Tim O'Brien -Original Message----- From: Jeffrey Dever [mailto:[EMAIL PROTECTED]] Sent: Monday, February 03, 2003 2:02 PM To: Commons HttpClient Project Cc: [EMAIL

using httpclient without a HttpClient object (was Redirects?)

2003-02-03 Thread Jeffrey Dever
would require quite a bit of change. I am all for it, but that's would spell quite a bit of change in just beginning to stabilize HttpClient's Middle Earth. What's your call? Oleg On Mon, 2003-02-03 at 21:17, Jeffrey Dever wrote: Right, we should go back to the HttpClient to ge

[off-list] Re: using httpclient without a HttpClient object (wasRedirects?)

2003-02-03 Thread Jeffrey Dever
Hey Eric, I know I sounded rash. I just wanted to entice people that never post to share their views, not incite revolt! I was also in a bit of a bad mood when I sent that off. It showed. I try to build an image of being level headed, but there I cracked. * We should not remove function

Re: DO NOT REPLY [Bug 11218] - handle multivalue headers correctly

2003-02-03 Thread Jeffrey Dever
- no need for fully qualified class names in @see or @link comments - please use @since 2.0beta1 new methods/classes - don't see a need for getFirstHeader and getLastHeader - getCondensedHeader, if there is one header, it returns a refrence to an internal datastructure, if more than one, it retur

Re: more common classes need a home

2003-02-03 Thread Jeffrey Dever
iginal Message - From: "Tomasz Pik" <[EMAIL PROTECTED]> Subject: Re: more common classes need a home Jeffrey Dever wrote: There are still a bunch of classes that are in both HttpClient and Slide. In particular: Base64.java HttpsURL.java HttpURL.java URIException.java URI.jav

voting on httpclient issues

2003-02-04 Thread Jeffrey Dever
There were a couple threads over on the commons-dev list about having a seperate VOTE list for all commons issues. I was in support of this, but was clearly in the minority. The issue is now closed: all voting will take place on the list where the issues are discussed. Therefore, votes concer

deprecate Base64 - use commons-codec in 2.1

2003-02-06 Thread Jeffrey Dever
The Commons Codec project (currently in the sandbox) is taking the responsibility for maintaining the Base64 class that is in common use in Jakarta. They initially took the code from the httpclient package (including the associated tests), and have merged some changes that were made by the xml

[patch] for Bug 16864

2003-02-06 Thread Jeffrey Dever
I created some tests for this issue and checked them in. Attached is a patch to fix the issue and make the tests pass, but it needs to be reviewed. I changed slightly the semantics of one very important method: HttpConnection.readLine(). It now requires the a "\r\n" be present as a pair to t

Re: [patch] for Bug 16864

2003-02-06 Thread Jeffrey Dever
utton, Software Engineer Ephox Corporation www.ephox.com -Original Message- From: Jeffrey Dever [mailto:[EMAIL PROTECTED]] Sent: Friday, 7 February 2003 2:33 PM To: Commons HttpClient Project Subject: [patch] for Bug 16864 I created some tests for this issue and checked them in. Attache

Re: nogoop: HttpClient competition

2003-02-06 Thread Jeffrey Dever
Looks like a reasonable comparison. NTLM auth is listed as soon, but in fact it is available now. "Plug Compatable" (ie have a HttpUrlConnection interface). We do have one that was contirbuted by Vincent Massol from the Jakarta Cactus project. Its only partially implemented, but nobody has

Re: nogoop: HttpClient competition

2003-02-07 Thread Jeffrey Dever
I contacted nogoop. They are very reasonable. Francis Upton over there is willing to take updates for their product comparision page. I'd like to just refrence their product comparison page as opposed to creating our own at this point. Jandalf. Mike Moran wrote: I just found this on my tr

Re: call for projects using httpclient

2003-02-07 Thread Jeffrey Dever
ssage- From: Jeffrey Dever [mailto:[EMAIL PROTECTED]] Sent: Sunday, January 26, 2003 16.01 PM To: Commons HttpClient Project Subject: call for projects using httpclient If you have an application that uses HttpClient, and would like to see it on our applications page, please send an email to: [

Propose a new commons-uri package

2003-02-07 Thread Jeffrey Dever
This is just a draft regarding factoring out the URI based code in HttpClient into its own dedicated package. Please comment. (0) rationale The concept of a URI is prevelent in networking. A specific form of URI, a URL is used ubiquitously across the internet. Currently HttpClient houses

supported jre version [was Re: Propose a new commons-uri package]

2003-02-07 Thread Jeffrey Dever
Agreed. If we were building an application, then we could arbitrairly decide to use whichever jre version that was most suitable. But we are not building an application, we are building a framework. As a result we must support the lowest reasonable version. This has always been jre1.2.x Whi

Re: [patch] for Bug 16864

2003-02-07 Thread Jeffrey Dever
I guess no comments are good comments ;-) I'll check in the patch. Jeffrey Dever wrote: I was too hot on the send button. This'll help ;-) I have tests that I'm just committing now ... Adrian Sutton wrote: Jeff, There was no attached patch. :) At least, not at my end

Re: DO NOT REPLY [Bug 11218] - handle multivalue headers correctly

2003-02-07 Thread Jeffrey Dever
I've been thinking about it too. I still feel that we should keep the HeaderGroup behind the scenes, and only expose Header[]. This will still solve the requirements of this feature, while protecting users from change. We can consider making HeaderGroup public in 2.1. Ideally we could add th

website redeployed

2003-02-07 Thread Jeffrey Dever
The website has been regenerated and redeployed. In particular, the applications page has been updated. Jandalf. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 16892] New: - Empty response body is notproperly handled when chunked encoding is used

2003-02-08 Thread Jeffrey Dever
2068 has been replaced by 2616, so I'll use that as the basis for this discussion. To determine if this is compliant behaviour, there are a couple of questions to answer. 1) Does a empty body qualify as a chunked body? Chunked-Body = *chunk last-chunk

Re: supported jre version [was Re: Propose a new commons-uri package]

2003-02-08 Thread Jeffrey Dever
should Cheers Oleg (Olegolas) On Fri, 2003-02-07 at 23:16, Jeffrey Dever wrote: Agreed. If we were building an application, then we could arbitrairly decide to use whichever jre version that was most suitable. But we are not building an application, we are building a framework. As a result

handle multivalue headers correctly

2003-02-08 Thread Jeffrey Dever
Hi Mike, I'm concerned about having public methods in HttpMethodBase that are not in the HttpMethod interface. These two public interfaces should not diverge. I had this same problem in the past, where I added a public method to the abstract class, and not the interface. Then I saw user code t

handle multivalue headers correctly

2003-02-08 Thread Jeffrey Dever
Hi Mike, I'm still concerned about having public methods in HttpMethodBase that are not in the HttpMethod interface. These two public interfaces should not diverge. I had this same problem in a the past, where I added a public method to the abstract class, and not the interface. Then I saw

Re: handle multivalue headers correctly

2003-02-09 Thread Jeffrey Dever
My thought was that people creating specific instances of HttpMethod like PostMethod would be able to access the HeaderGroups. I still would like to have the header groups available for subclasses though. How would you feel about making these methods protected? Protected would be fine. I ca

Re: call for projects using httpclient

2003-02-09 Thread Jeffrey Dever
ansmission, ...). Thank you a lot for this great package! Luc Claes R&D Manager, ContactOffice Group SA. Jeffrey Dever wrote: If you have an application that uses HttpClient, and would like to see it on our applications page, please send an email to: [EMAIL PROTECTED] http://jakarta.apac

Re: Problem with Post

2003-02-10 Thread Jeffrey Dever
The documentation on the website is for the latest code in cvs head. You can use addParameter(name, value) insetad for now. There are other reasons this code won't compile too ... Tom Samplonius wrote: I'm having what is likely a simple problem posting. Code snippet: ... NameValuePair user

  1   2   >