Re: [PATCH] Add echo/noise reduction to processing of CNAP messages
**I think it should be some where in the *NeoCallProvider::cpiNotification*function. The comment says *Call progress notification for the NEO device.* On Thu, Mar 12, 2009 at 12:28 PM, Chris Samuel ch...@csamuel.org wrote: This patch adds the AT commands to set up noise/echo reduction upon receiving a CNAP message from the network which is (hopefully) the notification of an incoming call. Signed-off-by: Chris Samuel ch...@csamuel.org --- .../src/plugins/phonevendors/neo/vendor_neo.cpp|6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp index 35f7a0b..093ff18 100644 --- a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp +++ b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp @@ -144,6 +144,12 @@ void NeoCallProvider::cnapNotification( const QString msg ) QAtUtils::skipField( msg, posn ); // name_length QString name = QAtUtils::nextString( msg, posn ); QModemCall *call = incomingCall(); + +// do undocumented echo cancellation and noise reduction + +modemService-primaryAtChat()-chat( a...@st=\-26\ ); +modemService-primaryAtChat()-chat( AT%N0187 ); + if ( call ) call-emitNotification( QPhoneCall::CallingName, name ); } -- 1.5.6.3 ___ Openmoko community mailing list community@lists.openmoko.org http://lists.openmoko.org/mailman/listinfo/community -- Best Regards HouYu Li, Karajan karajan_ii (at) hotmail.com karadog (at) gmail.com lihouyu (at) phpex.net PHP Developer Red Hat Certified Engineer Shanghai, China ___ Openmoko community mailing list community@lists.openmoko.org http://lists.openmoko.org/mailman/listinfo/community
Re: [PATCH] Add echo/noise reduction to processing of CNAP messages
On Thursday 12 March 2009, HouYu Li wrote: I think it should be some where in the NeoCallProvider::cpiNotification function. The comment says Call progress notification for the NEO device. The patch I sent does the AT commands just before it tells you who is calling you, which is why I thought it might be the best place. It's midnight here now so I'll take another look over the next few days (back to work tomorrow!). cheers, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC This email may come with a PGP signature as a file. Do not panic. For more info see: http://en.wikipedia.org/wiki/OpenPGP signature.asc Description: This is a digitally signed message part. ___ Openmoko community mailing list community@lists.openmoko.org http://lists.openmoko.org/mailman/listinfo/community
[PATCH] Add echo/noise reduction to processing of CNAP messages
This patch adds the AT commands to set up noise/echo reduction upon receiving a CNAP message from the network which is (hopefully) the notification of an incoming call. Signed-off-by: Chris Samuel ch...@csamuel.org --- .../src/plugins/phonevendors/neo/vendor_neo.cpp|6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp index 35f7a0b..093ff18 100644 --- a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp +++ b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp @@ -144,6 +144,12 @@ void NeoCallProvider::cnapNotification( const QString msg ) QAtUtils::skipField( msg, posn ); // name_length QString name = QAtUtils::nextString( msg, posn ); QModemCall *call = incomingCall(); + +// do undocumented echo cancellation and noise reduction + +modemService-primaryAtChat()-chat( a...@st=\-26\ ); +modemService-primaryAtChat()-chat( AT%N0187 ); + if ( call ) call-emitNotification( QPhoneCall::CallingName, name ); } -- 1.5.6.3 ___ Openmoko community mailing list community@lists.openmoko.org http://lists.openmoko.org/mailman/listinfo/community
