Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-18 Thread Chris Samuel
On Wednesday 18 March 2009, Radek Polak wrote:

 did you built it yourself or are you using binary from somewhere?

I think he's using the latest (as I write) snapbuild from here:

http://trac.karadog.net/qt-extended-improved/wiki/SnapBuilds

-- 
 Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC

This email may come with a PGP signature as a file. Do not panic.
For more info see: http://en.wikipedia.org/wiki/OpenPGP



signature.asc
Description: This is a digitally signed message part.
___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-18 Thread Franky Van Liedekerke
On Wed, Mar 18, 2009 at 12:37 PM, Chris Samuel ch...@csamuel.org wrote:

 On Wednesday 18 March 2009, Radek Polak wrote:

  did you built it yourself or are you using binary from somewhere?

 I think he's using the latest (as I write) snapbuild from here:

 http://trac.karadog.net/qt-extended-improved/wiki/SnapBuilds

 --


Well, this one is for sure echo free:
qt-extended-improved-bin-only-20090313-echo-fix.tar.gzhttp://dashi-x02.karadog.net/%7Elihouyu/qtextended/snapbuild/qt-extended-improved-bin-only-20090313-echo-fix.tar.gz

but I haven't tried
qt-extended-improved-bin-only-20090316.tar.gzhttp://dashi-x02.karadog.net/%7Elihouyu/qtextended/snapbuild/qt-extended-improved-bin-only-20090316.tar.gzyet

Franky
___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-18 Thread Ian
On Wed, Mar 18, 2009 at 10:52 PM, Franky Van Liedekerke
liede...@telenet.be wrote:
 On Wed, Mar 18, 2009 at 12:37 PM, Chris Samuel ch...@csamuel.org wrote:

 On Wednesday 18 March 2009, Radek Polak wrote:

  did you built it yourself or are you using binary from somewhere?

 I think he's using the latest (as I write) snapbuild from here:
 http://trac.karadog.net/qt-extended-improved/wiki/SnapBuilds

Yep that's right - I'm using qt-extended-improved-bin-only-20090316.tar.gz

 Well, this one is for sure echo free:
 qt-extended-improved-bin-only-20090313-echo-fix.tar.gz
 but I haven't tried qt-extended-improved-bin-only-20090316.tar.gz yet

-- 
http://darkstarshout.blogspot.com/
--
On the day *I* go to work for Microsoft, faint oinking sounds will be
heard from far overhead, the moon will not merely turn blue but
develop polkadots, and hell will freeze over so solid the brimstone
will go superconductive.
 -- Erik Raymond, 2005
--
Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-17 Thread Ian
Seems that this hasn't yet been 100% solved. I'm using QT Extended
Improved 20090316 and my friend reported hearing bad echo when he
called me today. I'm pretty sure that it was the first call since
boot, so it's likely that none of the places in the code that the echo
suppression is activated had been called by that stage.

-I

-- 
http://darkstarshout.blogspot.com/
--
On the day *I* go to work for Microsoft, faint oinking sounds will be
heard from far overhead, the moon will not merely turn blue but
develop polkadots, and hell will freeze over so solid the brimstone
will go superconductive.
 -- Erik Raymond, 2005
--
Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-17 Thread Radek Polak

 Seems that this hasn't yet been 100% solved. I'm using QT Extended
 Improved 20090316 and my friend reported hearing bad echo when he
 called me today. I'm pretty sure that it was the first call since
 boot, so it's likely that none of the places in the code that the echo
 suppression is activated had been called by that stage.

 -I

   
Hi Ian,
did you built it yourself or are you using binary from somewhere?

Radek

___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-12 Thread Joerg Reisenweber
Am Do  12. März 2009 schrieb Al Johnson:
 I can see the patch setting %N0187 when making a call, waking, initialising 
 etc. but not when answering a call. It seems like it needs adding there too 
to 
 fix this for some people. AFAIK we never did find out why the echo/nr 
settings 
 are persistent for some people and not for others. 

To me it seems %N should be sent to modem *after* every call, and on modem 
power-up/reset.
After a call is before a call (to quote some famous german soccer saying ;)

/j


signature.asc
Description: This is a digitally signed message part.
___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-11 Thread Al Johnson
I can see the patch setting %N0187 when making a call, waking, initialising 
etc. but not when answering a call. It seems like it needs adding there too to 
fix this for some people. AFAIK we never did find out why the echo/nr settings 
are persistent for some people and not for others. 

On Tuesday 10 March 2009, HouYu Li wrote:
 Just had a test, when someone call my freerunner, he or she still can hear
 the echo. but when calling someone from my freerunner, no echo.

 On Tue, Mar 10, 2009 at 4:54 PM, Chris Samuel ch...@csamuel.org wrote:
  On Tuesday 10 March 2009, HouYu Li wrote:
   The binary with your echo suppression patch is now available at
   http://dashi-x02.karadog.net/~lihouyu/qtextended/snapbuild/http://dash
  i-x02.karadog.net/%7Elihouyu/qtextended/snapbuild/.
 
  build
 
   20090310.
 
  Wow, that's fast work!  Thanks!
 
  Have you tried the 4.4.3 version out yet ?
 
  --
   Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC
 
  This email may come with a PGP signature as a file. Do not panic.
  For more info see: http://en.wikipedia.org/wiki/OpenPGP
 
 
  ___
  Openmoko community mailing list
  community@lists.openmoko.org
  http://lists.openmoko.org/mailman/listinfo/community



___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-11 Thread Chris Samuel
On Wednesday 11 March 2009, HouYu Li wrote:

 Just had a test, when someone call my freerunner, he or she still can hear
 the echo. but when calling someone from my freerunner, no echo.

That's weird, as on QtE 4.4.2 I've had no reports of that when people are 
calling me.

I couldn't figure out where to insert that AT command when a call was 
received, so the best I could do was put it in when unsuspending as 99% of the 
time my FR is suspended when someone calls.

I'm not working today so I might get a chance this afternoon to take a look at 
the code in 4.4.3 and see if I can figure out if there is anything called when 
a call comes in (there must be, but I can't see it for looking).

cheers!
Chris
-- 
 Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC

This email may come with a PGP signature as a file. Do not panic.
For more info see: http://en.wikipedia.org/wiki/OpenPGP



signature.asc
Description: This is a digitally signed message part.
___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-11 Thread Chris Samuel
On Thursday 12 March 2009, Al Johnson wrote:

 I can see the patch setting %N0187 when making a call, waking, initialising
 etc. but not when answering a call.

Yup, I agree, I just can't find anything in the OpenMoko library that gets 
called at that point where I can insert it!

-- 
 Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC

This email may come with a PGP signature as a file. Do not panic.
For more info see: http://en.wikipedia.org/wiki/OpenPGP



signature.asc
Description: This is a digitally signed message part.
___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-11 Thread Chris Samuel
On Thursday 12 March 2009, Chris Samuel wrote:

 I couldn't figure out where to insert that AT command when a call was
 received

I've just sent a patch to the list that inserts those AT commands when we 
process a CNAP message from the network, which is hopefully an incoming call.

Completely untested!

cheers,
Chris
-- 
 Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC

This email may come with a PGP signature as a file. Do not panic.
For more info see: http://en.wikipedia.org/wiki/OpenPGP



signature.asc
Description: This is a digitally signed message part.
___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-10 Thread Chris Samuel
On Tuesday 10 March 2009, HouYu Li wrote:

 The binary with your echo suppression patch is now available at
 http://dashi-x02.karadog.net/~lihouyu/qtextended/snapbuild/. build
 20090310.

Wow, that's fast work!  Thanks!

Have you tried the 4.4.3 version out yet ?

-- 
 Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC

This email may come with a PGP signature as a file. Do not panic.
For more info see: http://en.wikipedia.org/wiki/OpenPGP



signature.asc
Description: This is a digitally signed message part.
___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-10 Thread Filip Onkelinx
HouYu Li,

was the FR suspended when you received the call (i.e. did the call wake  
your FR), or was it on ?

Filip.

On Tue, 10 Mar 2009 15:08:58 +0100, HouYu Li kara...@gmail.com wrote:

 Just had a test, when someone call my freerunner, he or she still can  
 hear
 the echo. but when calling someone from my freerunner, no echo.

 On Tue, Mar 10, 2009 at 4:54 PM, Chris Samuel ch...@csamuel.org wrote:

 On Tuesday 10 March 2009, HouYu Li wrote:

  The binary with your echo suppression patch is now available at
   
 http://dashi-x02.karadog.net/~lihouyu/qtextended/snapbuild/http://dashi-x02.karadog.net/%7Elihouyu/qtextended/snapbuild/.
 build
  20090310.

 Wow, that's fast work!  Thanks!

 Have you tried the 4.4.3 version out yet ?

 --
  Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC

 This email may come with a PGP signature as a file. Do not panic.
 For more info see: http://en.wikipedia.org/wiki/OpenPGP


 ___
 Openmoko community mailing list
 community@lists.openmoko.org
 http://lists.openmoko.org/mailman/listinfo/community





-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/


___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-10 Thread andrew howlett

Hi Chris,

Thanks for the update. I've been using the 4.4.2 patch against 4.4.3 source
with no compile problems and no echo since 4.4.3 was released last week.

Hats off and many thanks for fixing the echo/noise reduction problems.

andrew howlett,
owen sound, canada.



Chris Samuel wrote:
 
 The original Qt Extended 4.4.3 initially set both echo
 suppression and noise reduction in separate AT commands
 which might result in the second command negating the
 first one.  It also only set them for outgoing calls.
 
 This new version uses the AT command to set both
 echo suppression and noise reduction at the same
 time as well as setting them on initialisation and
 after a wake up.
 
 This is identical to the patch against QtE 4.4.2 and
 applied cleanly with no fuzz with QtE 4.4.3.
 
 Signed-off-by: Chris Samuel ch...@csamuel.org
 ---
  .../src/plugins/phonevendors/neo/vendor_neo.cpp|   17
 ++---
  1 files changed, 14 insertions(+), 3 deletions(-)
 
 diff --git a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 index d27b4eb..35f7a0b 100644
 --- a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 +++ b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 @@ -153,8 +153,7 @@ QString NeoCallProvider::dialVoiceCommand(const
 QDialOptions options) const
  // do undocumented echo cancellation and noise reduction
  
  modemService-primaryAtChat()-chat( a...@st=\-26\ );
 -modemService-primaryAtChat()-chat( AT%N028B );
 -modemService-primaryAtChat()-chat( AT%N0125 );
 +modemService-primaryAtChat()-chat( AT%N0187 );
  return QModemCallProvider::dialVoiceCommand(options);
  }
  
 @@ -551,11 +550,14 @@ NeoModemService::NeoModemService
  
  //  chat(AT%CMGRS=1); //message transmission to get any failed sms
 during suspend
  
 -   chat(AT%SLEEP=2); //makes my Moko8 not respond to calls during
 sosuend
 +   chat(AT%SLEEP=2); //makes my Moko8 not respond to calls during
 suspend
  // Turn cell id information back on.
  chat( AT+CREG=2 );
  chat( AT+CGREG=2 );
  
 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
 +
  QTimer::singleShot(200, this, SLOT(sendRego()));
  }
  
 @@ -572,6 +574,9 @@ void NeoModemService::sendRego()
  if( !cfg.value(PlaneMode,false).toBool()) {
  //   chat(AT%NRG=0,0); //force auto operations
  chat(AT+COPS=0); //force auto operations
 +
 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
  }
  }
  
 @@ -679,6 +684,9 @@ void NeoModemService::reset()
  chat(AT%CWUP=1);
  chat(ATE0);
  
 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
 +
  // Turn on %CNAP notifications, which supply the caller's
  // name on an call.  Only supported on some networks.
  chat( AT%CNAP=1 );
 @@ -738,6 +746,9 @@ void NeoModemService::wake()
  
  // Re-enable signal quality notifications when the system wakes up
 again.
  chat( AT%CSQ=1, this, SLOT(mcsqOn()) );
 +
 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
  }
  
  void NeoModemService::mcsqOff()
 -- 
 1.5.6.3
 
 
 ___
 Openmoko community mailing list
 community@lists.openmoko.org
 http://lists.openmoko.org/mailman/listinfo/community
 
 

-- 
View this message in context: 
http://n2.nabble.com/-PATCH--Added-echo-suppression-fixes-for-the-OpenMoko-Neo-phone.-tp2448716p2455741.html
Sent from the Openmoko Community mailing list archive at Nabble.com.


___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-10 Thread HouYu Li
My freerunner is awake when I receive call.

On Tue, Mar 10, 2009 at 11:11 PM, andrew howlett and...@howlett.net wrote:


 Hi Chris,

 Thanks for the update. I've been using the 4.4.2 patch against 4.4.3 source
 with no compile problems and no echo since 4.4.3 was released last week.

 Hats off and many thanks for fixing the echo/noise reduction problems.

 andrew howlett,
 owen sound, canada.



 Chris Samuel wrote:
 
  The original Qt Extended 4.4.3 initially set both echo
  suppression and noise reduction in separate AT commands
  which might result in the second command negating the
  first one.  It also only set them for outgoing calls.
 
  This new version uses the AT command to set both
  echo suppression and noise reduction at the same
  time as well as setting them on initialisation and
  after a wake up.
 
  This is identical to the patch against QtE 4.4.2 and
  applied cleanly with no fuzz with QtE 4.4.3.
 
  Signed-off-by: Chris Samuel ch...@csamuel.org
  ---
   .../src/plugins/phonevendors/neo/vendor_neo.cpp|   17
  ++---
   1 files changed, 14 insertions(+), 3 deletions(-)
 
  diff --git a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
  b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
  index d27b4eb..35f7a0b 100644
  --- a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
  +++ b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
  @@ -153,8 +153,7 @@ QString NeoCallProvider::dialVoiceCommand(const
  QDialOptions options) const
   // do undocumented echo cancellation and noise reduction
 
   modemService-primaryAtChat()-chat( a...@st=\-26\ );
  -modemService-primaryAtChat()-chat( AT%N028B );
  -modemService-primaryAtChat()-chat( AT%N0125 );
  +modemService-primaryAtChat()-chat( AT%N0187 );
   return QModemCallProvider::dialVoiceCommand(options);
   }
 
  @@ -551,11 +550,14 @@ NeoModemService::NeoModemService
 
   //  chat(AT%CMGRS=1); //message transmission to get any failed sms
  during suspend
 
  -   chat(AT%SLEEP=2); //makes my Moko8 not respond to calls during
  sosuend
  +   chat(AT%SLEEP=2); //makes my Moko8 not respond to calls during
  suspend
   // Turn cell id information back on.
   chat( AT+CREG=2 );
   chat( AT+CGREG=2 );
 
  +// Turn on echo suppression and noise reduction.
  +chat( AT%N0187 );
  +
   QTimer::singleShot(200, this, SLOT(sendRego()));
   }
 
  @@ -572,6 +574,9 @@ void NeoModemService::sendRego()
   if( !cfg.value(PlaneMode,false).toBool()) {
   //   chat(AT%NRG=0,0); //force auto operations
   chat(AT+COPS=0); //force auto operations
  +
  +// Turn on echo suppression and noise reduction.
  +chat( AT%N0187 );
   }
   }
 
  @@ -679,6 +684,9 @@ void NeoModemService::reset()
   chat(AT%CWUP=1);
   chat(ATE0);
 
  +// Turn on echo suppression and noise reduction.
  +chat( AT%N0187 );
  +
   // Turn on %CNAP notifications, which supply the caller's
   // name on an call.  Only supported on some networks.
   chat( AT%CNAP=1 );
  @@ -738,6 +746,9 @@ void NeoModemService::wake()
 
   // Re-enable signal quality notifications when the system wakes up
  again.
   chat( AT%CSQ=1, this, SLOT(mcsqOn()) );
  +
  +// Turn on echo suppression and noise reduction.
  +chat( AT%N0187 );
   }
 
   void NeoModemService::mcsqOff()
  --
  1.5.6.3
 
 
  ___
  Openmoko community mailing list
  community@lists.openmoko.org
  http://lists.openmoko.org/mailman/listinfo/community
 
 

 --
 View this message in context:
 http://n2.nabble.com/-PATCH--Added-echo-suppression-fixes-for-the-OpenMoko-Neo-phone.-tp2448716p2455741.html
 Sent from the Openmoko Community mailing list archive at Nabble.com.


 ___
 Openmoko community mailing list
 community@lists.openmoko.org
 http://lists.openmoko.org/mailman/listinfo/community




-- 
Best Regards

HouYu Li, Karajan

karajan_ii (at) hotmail.com
karadog (at) gmail.com
lihouyu (at) phpex.net

PHP Developer
Red Hat Certified Engineer

Shanghai, China
___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-09 Thread HouYu Li
OK. I have committed your patch to my main repository. Now building
binaries.

On Mon, Mar 9, 2009 at 8:21 PM, Chris Samuel ch...@csamuel.org wrote:

 The original Qt Extended 4.4.3 initially set both echo
 suppression and noise reduction in separate AT commands
 which might result in the second command negating the
 first one.  It also only set them for outgoing calls.

 This new version uses the AT command to set both
 echo suppression and noise reduction at the same
 time as well as setting them on initialisation and
 after a wake up.

 This is identical to the patch against QtE 4.4.2 and
 applied cleanly with no fuzz with QtE 4.4.3.

 Signed-off-by: Chris Samuel ch...@csamuel.org
 ---
  .../src/plugins/phonevendors/neo/vendor_neo.cpp|   17
 ++---
  1 files changed, 14 insertions(+), 3 deletions(-)

 diff --git a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 index d27b4eb..35f7a0b 100644
 --- a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 +++ b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 @@ -153,8 +153,7 @@ QString NeoCallProvider::dialVoiceCommand(const
 QDialOptions options) const
  // do undocumented echo cancellation and noise reduction

 modemService-primaryAtChat()-chat( a...@st=\-26\ );
 -modemService-primaryAtChat()-chat( AT%N028B );
 -modemService-primaryAtChat()-chat( AT%N0125 );
 +modemService-primaryAtChat()-chat( AT%N0187 );
 return QModemCallProvider::dialVoiceCommand(options);
  }

 @@ -551,11 +550,14 @@ NeoModemService::NeoModemService

 //  chat(AT%CMGRS=1); //message transmission to get any failed sms
 during suspend

 -   chat(AT%SLEEP=2); //makes my Moko8 not respond to calls during
 sosuend
 +   chat(AT%SLEEP=2); //makes my Moko8 not respond to calls during
 suspend
 // Turn cell id information back on.
 chat( AT+CREG=2 );
 chat( AT+CGREG=2 );

 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
 +
 QTimer::singleShot(200, this, SLOT(sendRego()));
  }

 @@ -572,6 +574,9 @@ void NeoModemService::sendRego()
 if( !cfg.value(PlaneMode,false).toBool()) {
 //   chat(AT%NRG=0,0); //force auto operations
 chat(AT+COPS=0); //force auto operations
 +
 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
 }
  }

 @@ -679,6 +684,9 @@ void NeoModemService::reset()
 chat(AT%CWUP=1);
 chat(ATE0);

 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
 +
 // Turn on %CNAP notifications, which supply the caller's
 // name on an call.  Only supported on some networks.
 chat( AT%CNAP=1 );
 @@ -738,6 +746,9 @@ void NeoModemService::wake()

 // Re-enable signal quality notifications when the system wakes up
 again.
 chat( AT%CSQ=1, this, SLOT(mcsqOn()) );
 +
 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
  }

  void NeoModemService::mcsqOff()
 --
 1.5.6.3


 ___
 Openmoko community mailing list
 community@lists.openmoko.org
 http://lists.openmoko.org/mailman/listinfo/community




-- 
Best Regards

HouYu Li, Karajan

karajan_ii (at) hotmail.com
karadog (at) gmail.com
lihouyu (at) phpex.net

PHP Developer
Red Hat Certified Engineer

Shanghai, China
___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community


Re: [PATCH] Added echo suppression fixes for the OpenMoko Neo phone.

2009-03-09 Thread HouYu Li
The binary with your echo suppression patch is now available at
http://dashi-x02.karadog.net/~lihouyu/qtextended/snapbuild/. build 20090310.

On Mon, Mar 9, 2009 at 9:31 PM, HouYu Li kara...@gmail.com wrote:

 OK. I have committed your patch to my main repository. Now building
 binaries.


 On Mon, Mar 9, 2009 at 8:21 PM, Chris Samuel ch...@csamuel.org wrote:

 The original Qt Extended 4.4.3 initially set both echo
 suppression and noise reduction in separate AT commands
 which might result in the second command negating the
 first one.  It also only set them for outgoing calls.

 This new version uses the AT command to set both
 echo suppression and noise reduction at the same
 time as well as setting them on initialisation and
 after a wake up.

 This is identical to the patch against QtE 4.4.2 and
 applied cleanly with no fuzz with QtE 4.4.3.

 Signed-off-by: Chris Samuel ch...@csamuel.org
 ---
  .../src/plugins/phonevendors/neo/vendor_neo.cpp|   17
 ++---
  1 files changed, 14 insertions(+), 3 deletions(-)

 diff --git a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 index d27b4eb..35f7a0b 100644
 --- a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 +++ b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp
 @@ -153,8 +153,7 @@ QString NeoCallProvider::dialVoiceCommand(const
 QDialOptions options) const
  // do undocumented echo cancellation and noise reduction

 modemService-primaryAtChat()-chat( a...@st=\-26\ );
 -modemService-primaryAtChat()-chat( AT%N028B );
 -modemService-primaryAtChat()-chat( AT%N0125 );
 +modemService-primaryAtChat()-chat( AT%N0187 );
 return QModemCallProvider::dialVoiceCommand(options);
  }

 @@ -551,11 +550,14 @@ NeoModemService::NeoModemService

 //  chat(AT%CMGRS=1); //message transmission to get any failed sms
 during suspend

 -   chat(AT%SLEEP=2); //makes my Moko8 not respond to calls during
 sosuend
 +   chat(AT%SLEEP=2); //makes my Moko8 not respond to calls during
 suspend
 // Turn cell id information back on.
 chat( AT+CREG=2 );
 chat( AT+CGREG=2 );

 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
 +
 QTimer::singleShot(200, this, SLOT(sendRego()));
  }

 @@ -572,6 +574,9 @@ void NeoModemService::sendRego()
 if( !cfg.value(PlaneMode,false).toBool()) {
 //   chat(AT%NRG=0,0); //force auto operations
 chat(AT+COPS=0); //force auto operations
 +
 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
 }
  }

 @@ -679,6 +684,9 @@ void NeoModemService::reset()
 chat(AT%CWUP=1);
 chat(ATE0);

 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
 +
 // Turn on %CNAP notifications, which supply the caller's
 // name on an call.  Only supported on some networks.
 chat( AT%CNAP=1 );
 @@ -738,6 +746,9 @@ void NeoModemService::wake()

 // Re-enable signal quality notifications when the system wakes up
 again.
 chat( AT%CSQ=1, this, SLOT(mcsqOn()) );
 +
 +// Turn on echo suppression and noise reduction.
 +chat( AT%N0187 );
  }

  void NeoModemService::mcsqOff()
 --
 1.5.6.3


 ___
 Openmoko community mailing list
 community@lists.openmoko.org
 http://lists.openmoko.org/mailman/listinfo/community




 --
 Best Regards

 HouYu Li, Karajan

 karajan_ii (at) hotmail.com
 karadog (at) gmail.com
 lihouyu (at) phpex.net

 PHP Developer
 Red Hat Certified Engineer

 Shanghai, China




-- 
Best Regards

HouYu Li, Karajan

karajan_ii (at) hotmail.com
karadog (at) gmail.com
lihouyu (at) phpex.net

PHP Developer
Red Hat Certified Engineer

Shanghai, China
___
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community