Re: [compiz] [PATCH] Case insensitive matching for the regex plugin

2007-07-11 Thread David Reveman
On Wed, 2007-06-20 at 14:53 +0200, Danny Baumann wrote:
 Hi,
 
 I have created an addition to the regex plugin that allows case
 insensitive matching for title/class/name/role. To enable the case
 insentive matching, I chose to prepend an 'i' before the tag (ititle=,
 iclass=, ...). The patch is obviously attached ;-)
 
 Are there any objections against putting this code in?

No, but instead of adding a second set of tags maybe we should allow the
expressions to end with /i for case insensitive matching like perl.
I'm ok with either solution and not really sure which one I actually
prefer.

-David

___
compiz mailing list
compiz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/compiz


Re: [compiz] [PATCH] Case insensitive matching for the regex plugin

2007-06-21 Thread Mike Dransfield
Danny Baumann wrote:
 Hi,

 I have created an addition to the regex plugin that allows case
 insensitive matching for title/class/name/role. To enable the case
 insentive matching, I chose to prepend an 'i' before the tag (ititle=,
 iclass=, ...). The patch is obviously attached ;-)

 Are there any objections against putting this code in?
   

No objections as such, but maybe it would be better
to make the regex plugin be case-insensitive by default
and if necessary, add an option to be case-sensitive.

I cannot think of any real-world cases where the average
user would want case-sensitive.  In fact it leads to a lot of
support issues when matching by class.

Regards
Mike

 Regards,

 Danny
   
 

 ___
 compiz mailing list
 compiz@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/compiz
   

___
compiz mailing list
compiz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/compiz


[compiz] [PATCH] Case insensitive matching for the regex plugin

2007-06-20 Thread Danny Baumann
Hi,

I have created an addition to the regex plugin that allows case
insensitive matching for title/class/name/role. To enable the case
insentive matching, I chose to prepend an 'i' before the tag (ititle=,
iclass=, ...). The patch is obviously attached ;-)

Are there any objections against putting this code in?

Regards,

Danny


0001-Added-case-insensitive-matching.patch
Description: application/mbox
___
compiz mailing list
compiz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/compiz