Re: [compiz] WindowRemoveNotifyProc

[David Reveman]

On Wed, 2007-08-22 at 12:53 -0400, Nicolas Viennot wrote: 
 Hello,
 
 I'm doing a C++ wrapper and I need the counterpart of WindowAddNotifyProc
 Every plugin must be rebuild since CompScreen is modified, hence ABIVERSION 
 should be changed as well.
 Would it be possible to implement it ?
 
 Patch attached

Thanks, I applied it to my local branch. However, we need these kind of
hooks for any kind of object so
WindowAddNotifyProc/WindowRemoveNotifyProc has now been replaced by
ObjectAdd and ObjectRemove hooks.

-David

___
compiz mailing list
compiz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/compiz

[compiz] WindowRemoveNotifyProc

[Nicolas Viennot]

Hello,

I'm doing a C++ wrapper and I need the counterpart of WindowAddNotifyProc
Every plugin must be rebuild since CompScreen is modified, hence ABIVERSION 
should be changed as well.
Would it be possible to implement it ?

Patch attached

Pafy.
diff -ur a/include/compiz.h b/include/compiz.h
--- a/include/compiz.h	2007-08-22 12:46:38.0 -0400
+++ b/include/compiz.h	2007-08-22 12:46:54.0 -0400
@@ -1753,6 +1753,8 @@
 
 typedef void (*WindowAddNotifyProc) (CompWindow *window);
 
+typedef void (*WindowRemoveNotifyProc) (CompWindow *window);
+
 typedef void (*OutputChangeNotifyProc) (CompScreen *screen);
 
 typedef void (*InitWindowWalkerProc) (CompScreen *screen,
@@ -2058,6 +2060,7 @@
 DamageCursorRectProc damageCursorRect;
 
 WindowAddNotifyProcwindowAddNotify;
+WindowRemoveNotifyProc windowRemoveNotify;
 WindowResizeNotifyProc windowResizeNotify;
 WindowMoveNotifyProc   windowMoveNotify;
 WindowGrabNotifyProc   windowGrabNotify;
@@ -2855,6 +2858,9 @@
 void
 windowAddNotify (CompWindow *w);
 
+void
+windowRemoveNotify (CompWindow *w);
+
 
 /* plugin.c */
 
diff -ur a/src/screen.c b/src/screen.c
--- a/src/screen.c	2007-08-22 12:46:38.0 -0400
+++ b/src/screen.c	2007-08-22 12:46:54.0 -0400
@@ -1596,6 +1596,7 @@
 s-damageCursorRect	= damageCursorRect;
 
 s-windowAddNotify= windowAddNotify;
+s-windowRemoveNotify = windowRemoveNotify;
 s-windowResizeNotify = windowResizeNotify;
 s-windowMoveNotify	  = windowMoveNotify;
 s-windowGrabNotify   = windowGrabNotify;
diff -ur a/src/window.c b/src/window.c
--- a/src/window.c	2007-08-22 12:46:38.0 -0400
+++ b/src/window.c	2007-08-22 12:46:54.0 -0400
@@ -2193,6 +2193,8 @@
 	showOutputWindow (w-screen);
 }
 
+(*w-screen-windowRemoveNotify) (w);
+
 windowFiniPlugins (w);
 
 freeWindow (w);
@@ -4836,3 +4838,8 @@
 w-added = TRUE;
 }
 
+void
+windowRemoveNotify (CompWindow *w)
+{
+}
+
___
compiz mailing list
compiz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/compiz

[compiz] WindowRemoveNotifyProc

[Nicolas Viennot]

Hello,

I'm doing a C++ wrapper and I need the counterpart of WindowAddNotifyProc
Every plugin must be rebuild since CompScreen is modified, hence ABIVERSION 
should be changed as well.
Would it be possible to implement it ?

Patch attached

Pafy.
--- a/include/compiz.h
+++ b/include/compiz.h
@@ -1712,6 +1712,8 @@ typedef void (*WindowStateChangeNotifyProc) (CompWindow *window);

 typedef void (*WindowAddNotifyProc) (CompWindow *window);

+typedef void (*WindowRemoveNotifyProc) (CompWindow *window);
+
 typedef void (*OutputChangeNotifyProc) (CompScreen *screen);

 typedef void (*InitWindowWalkerProc) (CompScreen *screen,
@@ -2017,6 +2019,7 @@ struct _CompScreen {
 DamageCursorRectProc damageCursorRect;

 WindowAddNotifyProcwindowAddNotify;
+WindowRemoveNotifyProc windowRemoveNotify;
 WindowResizeNotifyProc windowResizeNotify;
 WindowMoveNotifyProc   windowMoveNotify;
 WindowGrabNotifyProc   windowGrabNotify;
@@ -2814,6 +2817,9 @@ compareWindowActiveness (CompWindow *w1,
 void
 windowAddNotify (CompWindow *w);

+void
+windowRemoveNotify (CompWindow *w);
+

 /* plugin.c */

--- a/src/screen.c
+++ b/src/screen.c
@@ -1584,6 +1584,7 @@ addScreen (CompDisplay *display,
 s-damageCursorRect= damageCursorRect;

 s-windowAddNotify= windowAddNotify;
+s-windowRemoveNotify = windowRemoveNotify;
 s-windowResizeNotify = windowResizeNotify;
 s-windowMoveNotify  = windowMoveNotify;
 s-windowGrabNotify   = windowGrabNotify;
--- a/src/window.c
+++ b/src/window.c
@@ -2169,6 +2169,8 @@ removeWindow (CompWindow *w)
showOutputWindow (w-screen);
 }

+(*w-screen-windowRemoveNotify) (w);
+
 windowFiniPlugins (w);

 freeWindow (w);
@@ -4799,3 +4801,8 @@ windowAddNotify (CompWindow *w)
 w-added = TRUE;
 }

+void
+windowRemoveNotify (CompWindow *w)
+{
+}
+
___
compiz mailing list
compiz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/compiz