** Description changed:
+ [ Impact ]
+
+ Unity could crash when closed with some memory corruption error
+
+ [ Test case ]
+
+ Run unity, loging in and out multiple times, you should get no crash
+ report or /var/lib/crash file mentioning compiz.
+
+ [ Regression potential ]
+
+ Really none, the change could only cause compilation issues, not really
+ anything for the user changed.
+
+
+ -
+
+
Valgrind is a good friend here...
==30842== Memcheck, a memory error detector
==30842== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==30842== Using Valgrind-3.13.0 and LibVEX; rerun with -h for copyright info
==30842== Command: ./test-decorations-input-mixer
==30842==
Gtk-Message: 12:17:20.414: Failed to load module "canberra-gtk-module"
Gtk-Message: 12:17:20.483: Failed to load module "unity-gtk-module"
Gtk-Message: 12:17:22.584: Failed to load module "canberra-gtk-module"
Gtk-Message: 12:17:22.699: Failed to load module "canberra-gtk-module"
m_GLCtx = glXCreateContext(m_X11Display, m_X11VisualInfo, 0, GL_TRUE);
WARN 2018-02-20 12:17:37 xim.controller XIMController.cpp:103 IBus natively
supported.
Cleaning up window 178257923
curThreadState = 0x15b427e0
DispatchCurrentUnref, currents are 1
DEstroying context 0x1f2687e0
m_GLCtx = NULL;
==30842== Invalid read of size 8
==30842==at 0x68EA1E4: XDestroyRegion (in
/usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==30842==by 0x4130A16: CompRegion::~CompRegion() (region.cpp:113)
==30842==by 0x8A8F239: __cxa_finalize (cxa_finalize.c:56)
==30842==by 0x76D6B02: ??? (in
/tmp/NUX_INSTALL/lib/libcompiz_core.so.0.9.13.1)
==30842==by 0x4011219: _dl_fini (dl-fini.c:235)
==30842==by 0x8A8EEBF: __run_exit_handlers (exit.c:83)
==30842==by 0x8A8EF19: exit (exit.c:105)
==30842==by 0x8A741C7: (below main) (libc-start.c:342)
==30842== Address 0x15943e10 is 16 bytes inside a block of size 32 free'd
==30842==at 0x4C30D3B: free (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==30842==by 0x68EA1F4: XDestroyRegion (in
/usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==30842==by 0x4130A16: CompRegion::~CompRegion() (region.cpp:113)
==30842==by 0x8A8F239: __cxa_finalize (cxa_finalize.c:56)
==30842==by 0x40E5432: ??? (in /tmp/NUX_INSTALL/lib/compiz/libopengl.so)
==30842==by 0x4011219: _dl_fini (dl-fini.c:235)
==30842==by 0x8A8EEBF: __run_exit_handlers (exit.c:83)
==30842==by 0x8A8EF19: exit (exit.c:105)
==30842==by 0x8A741C7: (below main) (libc-start.c:342)
==30842== Block was alloc'd at
==30842==at 0x4C2FB0F: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==30842==by 0x68EA03A: XCreateRegion (in
/usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==30842==by 0x4130A2A: CompRegion::init() (region.cpp:120)
==30842==by 0x41307CB: CompRegion::CompRegion() (region.cpp:56)
==30842==by 0x4131E29: __static_initialization_and_destruction_0(int,
int) (region.cpp:43)
==30842==by 0x4131E73: _GLOBAL__sub_I_region.cpp (region.cpp:441)
==30842==by 0x4010AD9: call_init.part.0 (dl-init.c:72)
==30842==by 0x4010BEA: call_init (dl-init.c:30)
==30842==by 0x4010BEA: _dl_init (dl-init.c:120)
==30842==by 0x4000ED9: ??? (in /lib/x86_64-linux-gnu/ld-2.26.so)
==30842==
==30842== Invalid free() / delete / delete[] / realloc()
==30842==at 0x4C30D3B: free (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==30842==by 0x68EA1EC: XDestroyRegion (in
/usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==30842==by 0x4130A16: CompRegion::~CompRegion() (region.cpp:113)
==30842==by 0x8A8F239: __cxa_finalize (cxa_finalize.c:56)
==30842==by 0x76D6B02: ??? (in
/tmp/NUX_INSTALL/lib/libcompiz_core.so.0.9.13.1)
==30842==by 0x4011219: _dl_fini (dl-fini.c:235)
==30842==by 0x8A8EEBF: __run_exit_handlers (exit.c:83)
==30842==by 0x8A8EF19: exit (exit.c:105)
==30842==by 0x8A741C7: (below main) (libc-start.c:342)
==30842== Address 0x15943e60 is 0 bytes inside a block of size 8 free'd
==30842==at 0x4C30D3B: free (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==30842==by 0x68EA1EC: XDestroyRegion (in
/usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==30842==by 0x4130A16: CompRegion::~CompRegion() (region.cpp:113)
==30842==by 0x8A8F239: __cxa_finalize (cxa_finalize.c:56)
==30842==by 0x40E5432: ??? (in /tmp/NUX_INSTALL/lib/compiz/libopengl.so)
==30842==by 0x4011219: _dl_fini (dl-fini.c:235)
==30842==by 0x8A8EEBF: __run_exit_handlers (exit.c:83)
==30842==by 0x8A8EF19: exit (exit.c:105)
==30842==by 0x8A741C7: (below main) (libc-start.c:342)
==30842== Block was alloc'd at
==30842==at 0x4C2FB0F: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==30842==by 0x68EA04C: XCreateRegion (in
/usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==30842==by
