Re: [Conkeror] [PATCH] reddit.js: add support for comments

2013-02-12 Thread John J. Foerch
On Mon, Feb 04, 2013 at 05:01:26PM +0100, Joren Van Onder wrote:
> Features: - scroll through comments with 'j' and 'k'
>   - scroll through parent comments with 'J' and 'K'
>   - vote on comments with ',' and '.'
>   - automatically load more comments on end of page

For a large patch like this, we should update the legalese of reddit.js.
Do you want copyright on your patch, or to assign it to someone else?

-- 
John Foerch
___
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror


Re: [Conkeror] [PATCH] reddit.js: add support for comments

2013-02-12 Thread John J. Foerch
On Wed, Feb 13, 2013 at 04:11:11AM +0100, Joren Van Onder wrote:
> On Wed, Feb 13, 2013 at 3:38 AM, John J. Foerch  
> wrote:
> > On Mon, Feb 04, 2013 at 05:01:26PM +0100, Joren Van Onder wrote:
> >> Features: - scroll through comments with 'j' and 'k'
> >>   - scroll through parent comments with 'J' and 'K'
> >>   - vote on comments with ',' and '.'
> >>   - automatically load more comments on end of page
> >
> > For a large patch like this, we should update the legalese of reddit.js.
> > Do you want copyright on your patch, or to assign it to someone else?
> 
> Okay, I'd like copyright on my patch. Will you update it? Or should I do it
> and send it again?

I'll do that.  Can you stop by the #conkeror irc channel some time to chat
about the patch?

-- 
John Foerch
___
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror


Re: [Conkeror] [PATCH] reddit.js: add support for comments

2013-02-12 Thread Joren Van Onder
On Wed, Feb 13, 2013 at 3:38 AM, John J. Foerch  wrote:
> On Mon, Feb 04, 2013 at 05:01:26PM +0100, Joren Van Onder wrote:
>> Features: - scroll through comments with 'j' and 'k'
>>   - scroll through parent comments with 'J' and 'K'
>>   - vote on comments with ',' and '.'
>>   - automatically load more comments on end of page
>
> For a large patch like this, we should update the legalese of reddit.js.
> Do you want copyright on your patch, or to assign it to someone else?

Okay, I'd like copyright on my patch. Will you update it? Or should I do it
and send it again?
___
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror