Re: [Conkeror] GMail focus issues
On 15 October 2012 22:31, John J. Foerch wrote: > I have pushed a patch. Please test it. Working OK here. Many thanks. ___ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
Re: [Conkeror] GMail focus issues
On Mon, Oct 15, 2012 at 10:15:46PM +0200, Jean-Baptiste Mestelan wrote: > On 15 October 2012 22:00, Jean-Baptiste Mestelan wrote: > > I should probably not have mentioned the cursor keys: this has to be a > > different issue altogether. > > Let's make this clearer: > > Two issues have been discussed about the GMail mode: > 1) the navigation keys (gi, gl, r, c...) work only after a manual > mouse focus. Both patches solve this issue. > > 2) The scrolling keys (C-n, C-p, PgUp, PgDown, Home, End) never work, > whichever frame gets the focus. Neither of the patches solve this > issue. > > I could not tell how much these issues are related. I have pushed a patch. Please test it. -- John Foerch ___ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
Re: [Conkeror] GMail focus issues
On 15 October 2012 22:00, Jean-Baptiste Mestelan wrote: > I should probably not have mentioned the cursor keys: this has to be a > different issue altogether. Let's make this clearer: Two issues have been discussed about the GMail mode: 1) the navigation keys (gi, gl, r, c...) work only after a manual mouse focus. Both patches solve this issue. 2) The scrolling keys (C-n, C-p, PgUp, PgDown, Home, End) never work, whichever frame gets the focus. Neither of the patches solve this issue. I could not tell how much these issues are related. ___ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
Re: [Conkeror] GMail focus issues
On 15 October 2012 20:58, John J. Foerch wrote: > When you mention the several keys that are still dead, I get the > impression that you and Tim have both achieved the same results by > different patches. His comments out gmail_focus_primary_frame's contents > altogether. What is going on? Once all agree about what should be done, > I'll commit the appropriate patch. I should probably not have mentioned the cursor keys: this has to be a different issue altogether. I have tried both patches, and found that they have the same behaviour exactly. So, we might as well go for Tim's patch, and get rid of the these unnecessary lines. Cheers. ___ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
Re: [Conkeror] GMail focus issues
On Mon, Oct 15, 2012 at 05:25:57PM +0200, Jean-Baptiste Mestelan wrote: > On 15 October 2012 15:07, John J. Foerch wrote: > > The first thing to try is to see if some small change to > > gmail_focus_primary_frame (like frame number) resolves it. > > Thanks, John: this seems to be the case. > > In GMail window, buffer.top_frame.frames.length now goes up to 5,6 or 7. > > > The attached patch here solves the issues about keyboard shortcuts. > Could someone else please confirm? > > (The keys PgUp, PgDown, Home, End are still dead though...) When you mention the several keys that are still dead, I get the impression that you and Tim have both achieved the same results by different patches. His comments out gmail_focus_primary_frame's contents altogether. What is going on? Once all agree about what should be done, I'll commit the appropriate patch. -- John Foerch ___ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
Re: [Conkeror] GMail focus issues
All,
I would not classify this as a 'fix' but it does make things work a bit
better for me (diff below). Essentially I am commenting out the call to
change focus while in gmail mode. I still do not have C-n and C-p work to
move my page up and down but, even so, this is much better for me.
-Tim Ramsey
diff --git a/modules/page-modes/gmail.js b/modules/page-modes/gmail.js
index 7159b1d..6196b72 100644
--- a/modules/page-modes/gmail.js
+++ b/modules/page-modes/gmail.js
@@ -66,9 +66,9 @@ var gmail_modality = {
};
function gmail_focus_primary_frame (buffer) {
-var frames = buffer.top_frame.frames;
-if (frames.length >= 4)
-buffer.top_frame.frames[3].focus();
+// var frames = buffer.top_frame.frames;
+// if (frames.length >= 4)
+// buffer.top_frame.frames[3].focus();
}
define_page_mode("gmail_mode",
On Mon, Oct 15, 2012 at 9:07 AM, John J. Foerch wrote:
> On Wed, Oct 03, 2012 at 09:16:38AM -0400, Tim Ramsey wrote:
> > Hello Conkeror Community,
> >
> > Recently I have been having troubles in GMail mode in Conkeror. The
> focus
> > seems to have changed such that the keyboard shortcuts no longer work
> without
> > manually clicking elements to move the focus (and therefore defeat the
> purpose
> > of a keyboard shortcut). A typical example is when I respond to a message
> > (keyboard shortcut r) it used to go to the reply screen and the focus
> would be
> > in the text area ready to compose a new message. Now, when I type 'r'
> on a
> > message the response screen comes up and I can see the focus go to the
> text
> > area but then immediately the text area loses focus. To start composing
> a
> > message I have to click back in the text area so that it once again has
> the
> > focus.
> >
> > That is only one example of several little annoyances that seem to have
> popped
> > up overnight. I am on a Windows 7 machine and running the Firefox exe
> (with
> > the --app switch) version 15.0.1. My conkeror HEAD is at:
> >
> > commit 34fbea2b8833ad35de12b3718ddff6e232efa060
> > Author: Axel Beckert
> > Date: Sat Sep 1 11:36:29 2012 +0200
> >
> > Debian package: Add support for xulrunner 17
> >
> > Any one else experience these? Anyone have any fixes?
> >
> > Thanks,
> > -Tim Ramsey
>
> The first thing to try is to see if some small change to
> gmail_focus_primary_frame (like frame number) resolves it.
>
> --
> John Foerch
>
___
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror
Re: [Conkeror] GMail focus issues
On 15 October 2012 15:07, John J. Foerch wrote:
> The first thing to try is to see if some small change to
> gmail_focus_primary_frame (like frame number) resolves it.
Thanks, John: this seems to be the case.
In GMail window, buffer.top_frame.frames.length now goes up to 5,6 or 7.
The attached patch here solves the issues about keyboard shortcuts.
Could someone else please confirm?
(The keys PgUp, PgDown, Home, End are still dead though...)
diff --git a/modules/page-modes/gmail.js b/modules/page-modes/gmail.js
index 930de2b..5623bec 100644
--- a/modules/page-modes/gmail.js
+++ b/modules/page-modes/gmail.js
@@ -65,8 +65,9 @@ var gmail_modality = {
function gmail_focus_primary_frame (buffer) {
var frames = buffer.top_frame.frames;
-if (frames.length >= 4)
-buffer.top_frame.frames[3].focus();
+var i=frames.length
+if ( i >= 4)
+buffer.top_frame.frames[i-1].focus();
}
define_page_mode("gmail-mode",
___
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror
Re: [Conkeror] GMail focus issues
On Wed, Oct 03, 2012 at 09:16:38AM -0400, Tim Ramsey wrote: > Hello Conkeror Community, > > Recently I have been having troubles in GMail mode in Conkeror. The focus > seems to have changed such that the keyboard shortcuts no longer work without > manually clicking elements to move the focus (and therefore defeat the purpose > of a keyboard shortcut). A typical example is when I respond to a message > (keyboard shortcut r) it used to go to the reply screen and the focus would be > in the text area ready to compose a new message. Now, when I type 'r' on a > message the response screen comes up and I can see the focus go to the text > area but then immediately the text area loses focus. To start composing a > message I have to click back in the text area so that it once again has the > focus. > > That is only one example of several little annoyances that seem to have popped > up overnight. I am on a Windows 7 machine and running the Firefox exe (with > the --app switch) version 15.0.1. My conkeror HEAD is at: > > commit 34fbea2b8833ad35de12b3718ddff6e232efa060 > Author: Axel Beckert > Date: Sat Sep 1 11:36:29 2012 +0200 > > Debian package: Add support for xulrunner 17 > > Any one else experience these? Anyone have any fixes? > > Thanks, > -Tim Ramsey The first thing to try is to see if some small change to gmail_focus_primary_frame (like frame number) resolves it. -- John Foerch ___ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
Re: [Conkeror] GMail focus issues
On 3 October 2012 15:16, Tim Ramsey wrote: > Any one else experience these? Anyone have any fixes? Yes, I have the same exact issues. Plus, the PgUp, PgDown, Home, End keys no longer work. Running the latest Git HEAD (commit 4c6b9426db61c673c21471b46b05e546da30ce47), through the Firefox -app switch. (Just to confirm: these issues do not appear in plain Firefox). Sorry to say, I am clueless about a fix. Regards. ___ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
