Re: [Conkeror] Patch for google-search-results page mode

2012-08-16 Thread John J. Foerch 
On Tue, Jun 05, 2012 at 08:46:25AM +0200, Konrad Hinsen wrote:
> Recently I switched to https transfer for most sites (using HTTPSEveryWhere),
> including Google searches. This broke the page mode for Google search results
> because the returned URLs start with encrypted. With the attached patch,
> the search result page mode applies to those URLs as well.
> 
> Konrad.
> 
> 
> 
> diff --git a/modules/page-modes/google-search-results.js 
> b/modules/page-modes/google-search-results.js
> index 307611b..126485b 100644
> --- a/modules/page-modes/google-search-results.js
> +++ b/modules/page-modes/google-search-results.js
> @@ -62,7 +62,7 @@ var google_search_results_modality = {
>  
>  
>  define_page_mode("google-search-results-mode",
> -build_url_regexp($domain = "google",
> +build_url_regexp($domain = /(?:encrypted.)?google/,
>   $allow_www = true,
>   $path = /search\?|cse\?/,
>   $tlds = ["com", "com.au", "co.uk", "de", "dk", "es",

Pushed, but didn't test.  Made a trivial change to the regexp.  Let me
know if I broke it :)

-- 
John Foerch
___
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [Conkeror] Patch for google-search-results page mode

2012-06-05 Thread Konrad Hinsen 
Johnny writes:

 > > After using this for a while, I ran into a problem (probably not
 > > related to my patch): there doesn't seem to be any way to follow the
 > > "next" and "previous" links, except using the mouse. Am I overlooking
 > > something?
 > 
 > Have you tried '[[' and ']]'? 

I hadn't, but that's exactly what I need, thanks!

Konrad.

___
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [Conkeror] Patch for google-search-results page mode

2012-06-05 Thread Johnny 
Konrad Hinsen  writes:

> After using this for a while, I ran into a problem (probably not
> related to my patch): there doesn't seem to be any way to follow the
> "next" and "previous" links, except using the mouse. Am I overlooking
> something?

Have you tried '[[' and ']]'? 

-- 
Johnny
___
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror