RE: [PATCH 3/4] call __connman_technology_add_interface() after rtnl-newlink()

2010-12-09 Thread Xu, Martin
-Original Message- From: Samuel Ortiz [mailto:sa...@linux.intel.com] Sent: Wednesday, December 08, 2010 6:59 PM To: Xu, Martin Cc: connman@connman.net Subject: Re: [PATCH 3/4] call __connman_technology_add_interface() after rtnl-newlink() Hi Martin, On Fri, Dec 03, 2010 at

[PATCH] call __connman_technology_add_interface() after rtnl-newlink()

2010-12-09 Thread martin . xu
From: Martin Xu martin...@intel.com The device is created and attach technology at rtnl-newlink(), so __connman_technology_add_interface() nees to be called after rtnl-newlink() --- src/rtnl.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/rtnl.c

[PATCH IPv6 v2 00/10] Separate IPv4 and IPv6 data

2010-12-09 Thread Jukka Rissanen
Hi all, this is second version of the IPv6 and IPv4 separation in connman_ipconfig struct. The v1 patch was a big one and now it is split to smaller chunks as instructed by Samuel. The patches are necessary so that connman can be used in an environment where might not be IPv4 addresses

[PATCH IPv6 v2 03/10] Do not add duplicate IP address to address list.

2010-12-09 Thread Jukka Rissanen
--- src/ipconfig.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 133db61..62323c7 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -594,6 +594,17 @@ void __connman_ipconfig_dellink(int index, struct

[PATCH IPv6 v2 02/10] Removed ipconfig from connman_network struct as it is not used.

2010-12-09 Thread Jukka Rissanen
--- src/network.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/network.c b/src/network.c index 0e22522..e5fd7ab 100644 --- a/src/network.c +++ b/src/network.c @@ -44,7 +44,6 @@ struct connman_network { char *name; char *node; char

[PATCH IPv6 v2 04/10] Allow more than one IP address in the address list.

2010-12-09 Thread Jukka Rissanen
--- src/ipconfig.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 62323c7..fe99b81 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -649,9 +649,6 @@ void __connman_ipconfig_newaddr(int index, int family, const char *label,

[PATCH IPv6 v2 06/10] Separate IPv4 and IPv6 in connman_ipconfig struct so that connman can work with IPv6 only networks.

2010-12-09 Thread Jukka Rissanen
This patch does not yet enable IPv6 only network support but it is required for later work. --- include/ipconfig.h |3 +- include/network.h |4 +- plugins/ofono.c|4 +- src/connman.h | 11 ++- src/ipconfig.c | 321

[PATCH IPv6 v2 07/10] Return only a valid IPv6 configuration

2010-12-09 Thread Jukka Rissanen
--- src/ipconfig.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index a2a7bf2..9ba8486 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -1202,7 +1202,7 @@ void connman_ipconfig_set_ops(struct connman_ipconfig *ipconfig, struct

[PATCH IPv6 v2 08/10] Set the IPv6 gateway address only if using IPv6 config

2010-12-09 Thread Jukka Rissanen
--- src/ipconfig.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 9ba8486..cf164c0 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -1254,7 +1254,8 @@ void __connman_ipconfig_set_element_ipv6_gateway(

[PATCH IPv6 v2 09/10] Check that ipconfig is valid IPv4 config before returning data

2010-12-09 Thread Jukka Rissanen
--- src/ipconfig.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index cf164c0..fef98cc 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -1528,6 +1528,9 @@ void __connman_ipconfig_append_ipv4(struct connman_ipconfig *ipconfig,

[PATCH IPv6 v2 10/10] Check that ipconfig is valid IPv6 config before returning data

2010-12-09 Thread Jukka Rissanen
--- src/ipconfig.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index fef98cc..17ac5d3 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -1567,6 +1567,9 @@ void __connman_ipconfig_append_ipv6(struct connman_ipconfig *ipconfig,

[PATCH IPv6 v2 01/10] Make sure ipconfig is not null before accessing members

2010-12-09 Thread Jukka Rissanen
--- src/ipconfig.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index a872dff..133db61 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -998,7 +998,8 @@ static void free_ipv6config(struct connman_ipconfig *ipconfig) */ void

[PATCH v6 2/3] stats: sum stats ring bufffer up info history file

2010-12-09 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de When the ring buffer (SERVICE_NAME.data file) is full then it is summarized into a history (SERVICE_NAME.history) file. The history file has the same format as the data file. --- v6: - rename arguments in stats_file_close_swap() - handle return

[PATCH v6 3/3] Rename stats-ringbuffer-dump to stats-tool

2010-12-09 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Due to new functionality added to the stats-ringbuffer-dump tool it is now called stats-tool. Besides to dump statistic ring buffer files it also allows to create them for testing. Furthermore, it create history files now too. --- v6: - rename

Re: [PATCH] call __connman_technology_add_interface() after rtnl-newlink()

2010-12-09 Thread Samuel Ortiz
Hi Martin, On Thu, Dec 09, 2010 at 06:08:53PM +0800, martin...@intel.com wrote: From: Martin Xu martin...@intel.com The device is created and attach technology at rtnl-newlink(), so __connman_technology_add_interface() nees to be called after rtnl-newlink() Patch applied, with this minor

Re: [PATCH] dhcp: Handle proxy PAC option correctly

2010-12-09 Thread Samuel Ortiz
Hi David, On Tue, Dec 07, 2010 at 11:29:49PM +, David Woodhouse wrote: We're requesting the unofficial proxy option (252) but then throwing away the response because we don't recognise the type for it. This fixes proxy detection via DHCP. Thanks, patch applied. Cheers, Samuel. --

Re: connman 0.64 crash in connection.c update_order

2010-12-09 Thread Benoît Monin
Hi Samuel, De : Samuel Ortiz Hi Benoit, On Tue, Dec 07, 2010 at 06:04:18PM +0100, Benoît Monin wrote: [snip] I can post the full syslog or run some other tests if needed. The full syslog would be a good start. Full syslog from power-up to crash is here :

Re: [PATCH v6 2/3] stats: sum stats ring bufffer up info history file

2010-12-09 Thread Samuel Ortiz
Hi Daniel, On Thu, Dec 09, 2010 at 01:49:33PM +0100, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de When the ring buffer (SERVICE_NAME.data file) is full then it is summarized into a history (SERVICE_NAME.history) file. The history file has the same format as the data

Re: [PATCH v6 3/3] Rename stats-ringbuffer-dump to stats-tool

2010-12-09 Thread Samuel Ortiz
Hi Daniel, On Thu, Dec 09, 2010 at 01:49:53PM +0100, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de Due to new functionality added to the stats-ringbuffer-dump tool it is now called stats-tool. Besides to dump statistic ring buffer files it also allows to create them