[PATCH 2/3 v5] Add build suppport for VPNC.

2011-01-26 Thread Mohamed Abbas
Initial --- Makefile.plugins | 28 configure.ac | 17 + 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index d8ca1b1..e87f10b 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -100,6 +10

[PATCH 3/3 v5] Add VPNC test script support

2011-01-26 Thread Mohamed Abbas
Initial. --- test/connect-vpn |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/connect-vpn b/test/connect-vpn index a43c4cd..3cc0b34 100755 --- a/test/connect-vpn +++ b/test/connect-vpn @@ -40,6 +40,15 @@ elif sys.argv[1] == "openvpn":

[PATCH 1/3 v5] dd vpnc support.

2011-01-26 Thread Mohamed Abbas
Initial code. Modified the code to addess David Woodhouse comments, This patch also used many code from David Woodhouse patch. --- plugins/vpnc.c | 281 ++ scripts/openconnect-script.c |4 + 2 files changed, 285 insertions(+), 0 deletions(

Re: [PATCH 1/3 v4] Add vpnc support.

2011-01-26 Thread David Woodhouse
On Thu, 2011-01-27 at 00:50 +0100, Samuel Ortiz wrote: > Thanks for the patchset. I pushed some provider changes that allow for an > easier route settings from the VPN plugins. See how I did it for openconnect.c > Could you please update your patches accordingly, and see if my code didnt > break th

Re: [PATCH 1/3 v4] Add vpnc support.

2011-01-26 Thread Samuel Ortiz
Hi Mohamed, On Tue, Jan 18, 2011 at 12:50:23PM -0800, Mohamed Abbas wrote: > Initial code. Modified the code to addess David Woodhouse comments, > This patch also used many code from David Woodhouse patch. Thanks for the patchset. I pushed some provider changes that allow for an easier route setti

Re: regression: resolv.conf empty

2011-01-26 Thread Daniel Wagner
Hi Kalle, I noticed this evening that my resolv.conf is empty: Could you post the log? thanks, daniel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

regression: resolv.conf empty

2011-01-26 Thread Kalle Valo
Hi, I noticed this evening that my resolv.conf is empty: tukki:~$ cat /etc/resolv.conf # Generated by Connection Manager tukki:~$ Even though I have nameservers configured: tukki:~$ cmcc show valo | grep Nameservers Nameservers = [ 192.168.1.1 2001:b18:0:1000:2e0:81ff:fe61:ae0d 2001:16d8:a

[PATCH 4/4] dbus: allow owning org.freedesktop.NetworkManager

2011-01-26 Thread Kalle Valo
The network-manager compatibility interface doesn't start unless we allow connman to own the interface in the dbus configuration. --- src/connman-dbus.conf |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/connman-dbus.conf b/src/connman-dbus.conf index 311f28c..fa70297

[PATCH 3/4] nmcompat: support nm dbus properties

2011-01-26 Thread Kalle Valo
After some investigation I found that network-manager also provides the network state through properties and libnm-glib library uses this instead of the GetState() method. Add Get() method call retrieve the property and a PropertyChanged signal to notify state changes. Now empathy, which uses libn

[PATCH 2/4] nmcompat: add plugin

2011-01-26 Thread Kalle Valo
Add plugin which provides network-manager state interface to applications. This is a direct copy of what was in src/manager.c, just copied all into a plugin. --- Makefile.plugins | 12 +++ configure.ac |6 ++ plugins/nmcompat.c | 183 +

[PATCH 1/4] manager: remove network-manager compatibility code

2011-01-26 Thread Kalle Valo
Remove the network-manager compatibility code from src/manager.c so that all this can be implemented as a plugin. -c command line switch is still left but marked as obsole to avoid breaking current start scripts. By removing the switch connman would not start at all if -c is used. --- src/connman

[PATCH 0/4] nmcompat plugin

2011-01-26 Thread Kalle Valo
Based on discussion on IRC, here are patches to move all nm code to a plugin. This way it doesn't affect core code but still applications get network state events. Tested with pidgin and empathy from Ubuntu 10.10. --- Kalle Valo (4): manager: remove network-manager compatibility code

[PATCH v1] dhcp: Move plugins/dhcp in to core

2011-01-26 Thread Daniel Wagner
From: Daniel Wagner --- v1: - move dhcp_request/release down so no forward decleration is needed v0: - inital version Makefile.am |2 +- Makefile.plugins |3 - include/dhcp.h | 81 -- plugins/dhcp.c | 227 - src/connman.h|

[ofono-autoconnect PATCHv2 3/5] Mark service as failed if connect fails

2011-01-26 Thread Pekka . Pessi
From: Pekka Pessi The connman_network/provider_connect() could fail in two different ways, returning an error code or setting the service state to failed. Ethernet, WiMax, Bluetooth, VPN, Cellular and WiFi services now get marked as failed if connect() fails with error code, too. This makes conn

[ofono-autoconnect PATCHv2 4/5] ofono: be proactive when connecting

2011-01-26 Thread Pekka . Pessi
From: Pekka Pessi Return error immediately if connection attempts are known to fail. --- plugins/ofono.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 90b579d..3afe0f8 100644 --- a/plugins/ofono.c +++ b/plugins/ofon

[ofono-autoconnect PATCHv2 5/5] ofono: be proactive with registration status

2011-01-26 Thread Pekka . Pessi
From: Pekka Pessi Return error immediately if connection attempts are known to fail. --- plugins/ofono.c | 62 -- 1 files changed, 41 insertions(+), 21 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 3afe0f8..480f7f7 100644

[ofono-autoconnect PATCHv2 1/5] Add connman_network_clear_error()

2011-01-26 Thread Pekka . Pessi
From: Pekka Pessi Clear the error on corresponding service (and set reconnect) in order to retry autoconnecting. --- include/network.h |1 + src/connman.h |1 + src/network.c | 16 src/service.c | 20 4 files changed, 38 insertions(+)

[ofono-autoconnect PATCHv2 2/5] ofono: retry autoconnect when gprs gets attached

2011-01-26 Thread Pekka . Pessi
From: Pekka Pessi --- plugins/ofono.c | 146 +- 1 files changed, 121 insertions(+), 25 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 7abcf8d..90b579d 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -81,6 +81,11 @@ st

[ofono-autoconnect PATCHv2 0/5]

2011-01-26 Thread Pekka . Pessi
Hi Samuel, Thanks for the feedback. I hope I've addressed all the issues you raised in the previous patch set. --Pekka ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

[PATCH v0] dhcp: Move plugins/dhcp in to core

2011-01-26 Thread Daniel Wagner
From: Daniel Wagner --- Hi, This is shoot from the hips... cheers, daniel Makefile.am |2 +- Makefile.plugins |3 - include/dhcp.h | 81 - plugins/dhcp.c | 227 --- src/connman.h|2 - src/dhcp.c | 352 +++

Re: [PATCH v0] provider: Handle empty nameservers

2011-01-26 Thread Samuel Ortiz
Hi Daniel, On Wed, Jan 26, 2011 at 09:22:06AM +0100, Daniel Wagner wrote: > From: Daniel Wagner > > If the VPN server doesn't set any DNS entries provider->nameservers is NULL. > When we change the state of the provider to CONNMAN_PROVIDER_STATE_READY > we shouldn't do any string operations on t

RE: USB tethering issues

2011-01-26 Thread Lucas, GuillaumeX
Hi Martin, > > You might just have a kernel without bridge support by accident. I think > > we used to have a MeeGo bug open for that, but that got fixed. Same > > applies for having a kernel with proper set of netfilter modules for IP > > forwarding and masquerading. > MeeGo tethering feature is

RE: USB tethering issues

2011-01-26 Thread Xu, Martin
Hi > -Original Message- > From: connman-boun...@connman.net > [mailto:connman-boun...@connman.net] On Behalf Of Marcel Holtmann > Sent: Tuesday, January 25, 2011 7:49 PM > To: connman@connman.net > Subject: RE: USB tethering issues > > Hi Guillaume, > > > > > I'm currently trying to test

Re: [PATCH] Add TAGS and openvpn-script to gitignore

2011-01-26 Thread Marcel Holtmann
Hi Kalle, > TAGS is created with 'make tags'. > --- > .gitignore |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/.gitignore b/.gitignore > index 835ee2a..28a679a 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -23,6 +23,7 @@ ltmain.sh > missing > stamp-h1 > au

[PATCH] Add TAGS and openvpn-script to gitignore

2011-01-26 Thread Kalle Valo
To clean up git status output. TAGS is created with 'make tags'. --- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 835ee2a..28a679a 100644 --- a/.gitignore +++ b/.gitignore @@ -23,6 +23,7 @@ ltmain.sh missing stamp-h1 autom4t

Re: [PATCH 0/2] Support for libnm-glib

2011-01-26 Thread Kalle Valo
Marcel Holtmann writes: >> > Or put it in an extra daemon on top of ConnMan. >> >> That's a lot of extra infrastructure work. Creating a new package etc >> just for a simple dbus interface wrapper. > > you could do it as tools/network-manager.c inside the ConnMan code if > you prefer. Yes, that

Re: [PATCH 0/2] Support for libnm-glib

2011-01-26 Thread Marcel Holtmann
Hi Kalle, > >> > I investigated more about network-manager compat support and here is > >> > what I found. Please take a look. > >> > > >> > --- > >> > > >> > Kalle Valo (2): > >> > dbus: allow owning org.freedesktop.NetworkManager > >> > manager: support nm dbus properties > >> > >>

Re: [PATCH 0/2] Support for libnm-glib

2011-01-26 Thread Kalle Valo
Marcel Holtmann writes: > Hi Kalle, Hi Marcel, >> > I investigated more about network-manager compat support and here is >> > what I found. Please take a look. >> > >> > --- >> > >> > Kalle Valo (2): >> > dbus: allow owning org.freedesktop.NetworkManager >> > manager: support nm dbu

Re: [PATCH v4 0/5] Move dnsproxy from plugins to core

2011-01-26 Thread Marcel Holtmann
Hi Daniel, > v4: - remove new line at end of file > - pass option_dnsproxy into __connman_dnsproxy_init() > v3: - use '-r' instead of '-x' for disabling the DNS Proxy > v2: - remove resolver module > - cleanup configure.ac and README (dnsproxy: plugin -> core) > v1: - remove ondemand > v0

[PATCH v4 4/5] ondemand: Remove ondemand.c

2011-01-26 Thread Daniel Wagner
From: Daniel Wagner --- Makefile.am|8 ++--- include/ondemand.h | 38 src/connman.h |3 -- src/dnsproxy.c | 37 +--- src/main.c |2 - src/ondemand.c | 96 6 fi

[PATCH v4 5/5] resolver: Only support resolv.conf and dnsproxy

2011-01-26 Thread Daniel Wagner
From: Daniel Wagner Remove resolver module support. --- include/resolver.h | 17 --- src/connman.h |7 +- src/dnsproxy.c | 33 ++--- src/main.c |4 +- src/resolver.c | 400 5 files changed, 173 insertions(+),

[PATCH v4 3/5] dnsproxy: Add command line switch

2011-01-26 Thread Daniel Wagner
From: Daniel Wagner Command line switch to disable dnsproxy. --- src/connman.h |2 +- src/dnsproxy.c | 10 +- src/main.c |6 +- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/connman.h b/src/connman.h index 9d8e46c..6e80e6d 100644 --- a/src/connman

[PATCH v4 2/5] dnsproxy: Fix checkpatch warnings

2011-01-26 Thread Daniel Wagner
From: Daniel Wagner --- src/dnsproxy.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index f09368c..cf907bc 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -195,7 +195,7 @@ static void send_response(int sk, unsigne

[PATCH v4 0/5] Move dnsproxy from plugins to core

2011-01-26 Thread Daniel Wagner
From: Daniel Wagner v4: - remove new line at end of file - pass option_dnsproxy into __connman_dnsproxy_init() v3: - use '-r' instead of '-x' for disabling the DNS Proxy v2: - remove resolver module - cleanup configure.ac and README (dnsproxy: plugin -> core) v1: - remove ondemand v0: -

Re: [PATCH v3 3/5] dnsproxy: Add command line switch

2011-01-26 Thread Marcel Holtmann
Hi Daniel, > > > - __connman_dnsproxy_init(); > > > + if (option_dnsproxy == TRUE) > > > + __connman_dnsproxy_init(); > > > > this might be better done as, > > > > __connman_dnsproxy_init(option_dnsproxy); > > > > I do have the slight suspicion that we have to run basic DNS

Re: [PATCH 0/2] Support for libnm-glib

2011-01-26 Thread Marcel Holtmann
Hi Kalle, > > I investigated more about network-manager compat support and here is > > what I found. Please take a look. > > > > --- > > > > Kalle Valo (2): > > dbus: allow owning org.freedesktop.NetworkManager > > manager: support nm dbus properties > > Any comments? I think we are

Re: [PATCH 0/2] Support for libnm-glib

2011-01-26 Thread Kalle Valo
Kalle Valo writes: > I investigated more about network-manager compat support and here is > what I found. Please take a look. > > --- > > Kalle Valo (2): > dbus: allow owning org.freedesktop.NetworkManager > manager: support nm dbus properties Any comments? -- Kalle Valo __

[PATCH v0] provider: Handle empty nameservers

2011-01-26 Thread Daniel Wagner
From: Daniel Wagner If the VPN server doesn't set any DNS entries provider->nameservers is NULL. When we change the state of the provider to CONNMAN_PROVIDER_STATE_READY we shouldn't do any string operations on the NULL pointer namerservers. (gdb) bt full #0 0x0039ee88124a in __strchr_sse2

[PATCH 16/16] TODO: removing WPS related part.

2011-01-26 Thread Tomasz Bursztyka
--- TODO | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/TODO b/TODO index 73aeb03..ea90f08 100644 --- a/TODO +++ b/TODO @@ -95,16 +95,6 @@ Core WiFi -- WPS - - Priority: Low - Complexity: C2 - Dependencies: Core:Agent callbacks - Owner: Tomasz B

[PATCH 15/16] gsupplicant: Disconnect request might not need to go through RemoveNetwork call.

2011-01-26 Thread Tomasz Bursztyka
--- gsupplicant/supplicant.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index bed049a..8c91a83 100644 --- a/gsupplicant/supplicant.c +++ b/gsupplicant/supplicant.c @@ -2835,6 +2835,12 @@ static void interface_di

[PATCH 14/16] WPS: input added in agent api test script.

2011-01-26 Thread Tomasz Bursztyka
--- test/simple-agent | 44 1 files changed, 36 insertions(+), 8 deletions(-) diff --git a/test/simple-agent b/test/simple-agent index 859d403..5c73599 100755 --- a/test/simple-agent +++ b/test/simple-agent @@ -11,7 +11,8 @@ class Canceled(dbus.DBusE

[PATCH 13/16] WPS: connection logic in service.c.

2011-01-26 Thread Tomasz Bursztyka
--- src/service.c | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/service.c b/src/service.c index d0590dd..1921acc 100644 --- a/src/service.c +++ b/src/service.c @@ -2316,9 +2316,12 @@ static void request_input_cb (struct connman_service *service

[PATCH 11/16] WPS: service internal accessor to know wether or not wps is enabled

2011-01-26 Thread Tomasz Bursztyka
--- src/connman.h |1 + src/service.c |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 37946f6..10bc401 100644 --- a/src/connman.h +++ b/src/connman.h @@ -474,6 +474,7 @@ const char *__connman_service_get_path(struct connman_s

[PATCH 12/16] WPS: input request logic in agent.c.

2011-01-26 Thread Tomasz Bursztyka
--- src/agent.c | 77 ++- 1 files changed, 76 insertions(+), 1 deletions(-) diff --git a/src/agent.c b/src/agent.c index d000a56..9d42ad1 100644 --- a/src/agent.c +++ b/src/agent.c @@ -94,7 +94,9 @@ struct request_input_reply { static voi

[PATCH 09/16] WPS: service's wps property support in test scripts.

2011-01-26 Thread Tomasz Bursztyka
--- test/get-services |2 +- test/list-services |2 +- test/test-manager |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/get-services b/test/get-services index 29d4ea0..605e278 100755 --- a/test/get-services +++ b/test/get-services @@ -43,7 +43,7 @@ for ent

[PATCH 10/16] WPS: method input for wps added in agent api documentation.

2011-01-26 Thread Tomasz Bursztyka
--- doc/agent-api.txt | 25 - 1 files changed, 24 insertions(+), 1 deletions(-) diff --git a/doc/agent-api.txt b/doc/agent-api.txt index b4b8a39..98499a3 100644 --- a/doc/agent-api.txt +++ b/doc/agent-api.txt @@ -66,10 +66,19 @@ Fields string Name

[PATCH 07/16] WPS: support in service core part.

2011-01-26 Thread Tomasz Bursztyka
--- src/service.c | 25 - 1 files changed, 24 insertions(+), 1 deletions(-) diff --git a/src/service.c b/src/service.c index 0ea1223..8c06727 100644 --- a/src/service.c +++ b/src/service.c @@ -106,6 +106,7 @@ struct connman_service { char **proxies; char

[PATCH 08/16] WPS: service's wps attribute documented in service-api.txt.

2011-01-26 Thread Tomasz Bursztyka
--- doc/service-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/service-api.txt b/doc/service-api.txt index 87a8e18..99f78d7 100644 --- a/doc/service-api.txt +++ b/doc/service-api.txt @@ -214,6 +214,16 @@ Properties string State [readonly]

[PATCH 04/16] WPS: Start() method enabler added in gsupplicant library.

2011-01-26 Thread Tomasz Bursztyka
--- gsupplicant/gsupplicant.h |2 + gsupplicant/supplicant.c | 82 - 2 files changed, 83 insertions(+), 1 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 05f5c35..0df8640 100644 --- a/gsupplicant/gsupplicant.

[PATCH 06/16] WPS: support in wifi plugin (non legacy one).

2011-01-26 Thread Tomasz Bursztyka
--- plugins/wifi.c | 449 +--- 1 files changed, 266 insertions(+), 183 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 040d2f9..2bcf40a 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -292,6 +292,192 @@ static void system_ki

[PATCH 05/16] WPS: support in network core part.

2011-01-26 Thread Tomasz Bursztyka
--- src/network.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/network.c b/src/network.c index 612e923..a83fc40 100644 --- a/src/network.c +++ b/src/network.c @@ -67,6 +67,9 @@ struct connman_network { char *private_key_path;

[PATCH 03/16] WPS: event signal support added in gsupplicant library.

2011-01-26 Thread Tomasz Bursztyka
--- gsupplicant/gsupplicant.h |7 ++ gsupplicant/supplicant.c | 52 + 2 files changed, 59 insertions(+), 0 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 4f507e3..05f5c35 100644 --- a/gsupplicant/gsuppli

[PATCH 02/16] WPS: credentials signal support added in gsupplicant library.

2011-01-26 Thread Tomasz Bursztyka
--- gsupplicant/gsupplicant.h |3 + gsupplicant/supplicant.c | 92 + 2 files changed, 95 insertions(+), 0 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 9404402..4f507e3 100644 --- a/gsupplicant/gsupplicant.

[PATCH 00/16] WPS support (reviewed)

2011-01-26 Thread Tomasz Bursztyka
Hi Samuel, I adapted you comments on the patches. I hope it suits better now. I did not merged patch 11 to 7 though (I still think it is 2 different things) Overall modifications seems bigger than before but it's not. It's due to a whole block of code moved in patch 6 (we talked about that on ir

[PATCH 01/16] WPS: bss/network wps enabled support in gsupplicant library.

2011-01-26 Thread Tomasz Bursztyka
--- gsupplicant/gsupplicant.h |1 + gsupplicant/supplicant.c | 93 - 2 files changed, 93 insertions(+), 1 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 1da9661..9404402 100644 --- a/gsupplicant/gsupplicant.