Re: [PATCH ipv6 v3 00/12] Support IPv6 only networks

2011-02-11 Thread Samuel Ortiz
Hi Jukka, On Thu, Feb 10, 2011 at 05:52:09PM +0200, Jukka Rissanen wrote: Hi Samuel, here is the v3 of the IPv6 only patchset. Thanks a lot. I applied all patches, and added a correction for patch #6, as we want to go back to IDLE mode when calling set_connected() wit a disconnected network.

Re: [PATCH v2] doc: Add EAP login support in Agent API

2011-02-11 Thread Samuel Ortiz
Hi Henri, On Thu, Feb 10, 2011 at 04:05:09PM +0200, Henri Bragge wrote: --- How about this? eap- not absolutely necessary prefix for types but I tried to avoid any confusion. PATCH v2: - dropped phase2 method, new fields types eap-password and eap-response instead That

Re: [PATCH v1] doc: Add EAP login support in Agent API

2011-02-11 Thread Samuel Ortiz
Hi Patrik, On Thu, Feb 10, 2011 at 03:55:50PM +0200, Patrik Flykt wrote: Hi, On Wed, 2011-02-09 at 20:21 +0100, ext Samuel Ortiz wrote: + string AuthMethod + + EAP Phase2 authentication method. For example gtc, + mschapv2 or md5.

[PATCH] network: IPv6 must go through disconnect state before idle.

2011-02-11 Thread Jukka Rissanen
--- Hi Samuel, please apply this patch as without it the system will not go offline. The patch adds DISCONNECT state for IPv6 that should be entered before IDLE state. Eventually the IPv6 disconnection should be handled in connection.c as you pointed out in IRC but that probably needs to wait

Re: [RFC v7 00/12] DHCP refactoring (aka get rid of DHCP element)

2011-02-11 Thread Samuel Ortiz
Hi Daniel, On Wed, Feb 09, 2011 at 12:03:48PM +0100, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de Hi, another update on this series. Up to the connection element removal patch it should work. Read: the removal of the connection element works ;) Very good. I really

Re: [RFC v7 01/12] service: Refactor Service nameserver API

2011-02-11 Thread Samuel Ortiz
Hi Daniel, On Wed, Feb 09, 2011 at 12:03:49PM +0100, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de __connman_service_append/remove_namerserver() is renamed to __connman_service_nameserver_append/remove to be more consistent with the other Service API naming. Also the

Re: [RFC v7 11/12] dhcp: Remove DHCP element

2011-02-11 Thread Samuel Ortiz
Hi Daniel, On Wed, Feb 09, 2011 at 12:03:59PM +0100, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de I think you have not changed this part according to my last comments on it. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/

Re: [RFC v7 08/12] connection: Remove connection element

2011-02-11 Thread Samuel Ortiz
Hi Daniel, On Wed, Feb 09, 2011 at 12:03:56PM +0100, Daniel Wagner wrote: @@ -154,49 +136,47 @@ static void connection_newgateway(int index, const char *gateway) static void set_default_gateway(struct gateway_data *data) { - struct connman_element *element = data-element; -