[PATCH memleak service 0/3] Memory leak fixes in service

2011-01-05 Thread Jukka Rissanen
Hi again, while doing IPv6 work I found some more memory leak problems. The patch 1 is optional as it just adds some more debug output in ipconfig ref/unref functions but I needed it to find the problem described in second patch. The patch 2 fixes reference counting issue in service.c file. The

[PATCH memleak service 1/3] ipconfig: add debugging to ref counting functions

2011-01-05 Thread Jukka Rissanen
--- src/ipconfig.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 690b51e..b5dc98f 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -915,6 +915,9 @@ struct connman_ipconfig *connman_ipconfig_create(int index, */

[PATCH memleak service 2/3] memoryleak: ipconfig was not unreferenced properly

2011-01-05 Thread Jukka Rissanen
The service creates ipconfig and then enables it which means that ref count goes to 2. At some point it then disables ipconfig but does not do unref which means there is a memory leak as ref count never goes to 0. --- src/service.c | 40 1 files changed,

[PATCH memleak service 3/3] memoryleak: IPv6 gateway was not freed

2011-01-05 Thread Jukka Rissanen
--- src/connection.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/connection.c b/src/connection.c index bfd19b5..789a242 100644 --- a/src/connection.c +++ b/src/connection.c @@ -221,6 +221,7 @@ static int remove_gateway(struct gateway_data *data)

Re: [PATCH memleak service 0/3] Memory leak fixes in service

2011-01-05 Thread Marcel Holtmann
Hi Jukka, while doing IPv6 work I found some more memory leak problems. The patch 1 is optional as it just adds some more debug output in ipconfig ref/unref functions but I needed it to find the problem described in second patch. The patch 2 fixes reference counting issue in service.c

Re: [PATCH v5] Add inotify monitoring .config file.

2011-01-05 Thread Marcel Holtmann
Hi Mohamed, Reflect new and modify *.config to connman config list. with patch any modified or added .config file will be read by connman and add these configuration for new provisioning. --- src/config.c | 171 +++--- 1 files changed,

[PATCH resend] Fix Valgrind invalid write error for WiFi plugin

2011-01-05 Thread leena.gunda
From: Leena Gunda leena.gu...@wipro.com Fixes BMC#11684 --- g_supplicant_unregister first destroys the interface table and then invokes system_killed callback which will trigger wifi device driver removal. wifi_remove will now set it's interface data to NULL but the GSupplicantInterface has

Re: [PATCH resend] Fix memory leaks in gsupplicant interface_property

2011-01-05 Thread Marcel Holtmann
Hi Leena, diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 6302af0..1459aea 100644 --- a/gsupplicant/supplicant.c +++ b/gsupplicant/supplicant.c @@ -1272,20 +1272,32 @@ static void interface_property(const char *key, DBusMessageIter *iter, const char

Re: [PATCH resend] Fix Valgrind invalid write error for WiFi plugin

2011-01-05 Thread Marcel Holtmann
Hi Leena, From: Leena Gunda leena.gu...@wipro.com Fixes BMC#11684 --- g_supplicant_unregister first destroys the interface table and then invokes system_killed callback which will trigger wifi device driver removal. wifi_remove will now set it's interface data to NULL but the

[PATCH resend v1] Fix memory leaks in gsupplicant interface_property

2011-01-05 Thread leena.gunda
From: Leena Gunda leena.gu...@wipro.com Free the interface properties before doing a g_strdup. Fixes BMC#11687 --- gsupplicant/supplicant.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index

Re: [PATCH resend v1] Fix memory leaks in gsupplicant interface_property

2011-01-05 Thread Marcel Holtmann
Hi Leena, Free the interface properties before doing a g_strdup. Fixes BMC#11687 --- gsupplicant/supplicant.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) patch has been applied. Thanks. Regards Marcel ___ connman

Re: [PATCH resend] Fix missing and empty WiFi APs issue after kill/restart

2011-01-05 Thread Marcel Holtmann
Hi Leena, From: Leena Gunda leena.gu...@wipro.com Fixes BMC#10454 and #11201 --- When ConnMan is SIGKILLed and restarted WiFi plugin will reuse the existing interface. It will get a list of existing BSSs and for each BSS in the BSSs list, interface_bss_added() is called. In