Hi Samuel,
thanks for the comments to v1 patchset. This second version
fixes the issues you found out:
Patch #4:
- connman_service_indicate_state() prototype changed so that
only one state can be changed at a time
- is_connected() and is_connecting() function prototypes changed
back to what
---
src/ipconfig.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 6ef39c5..bd664f3 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -682,7 +682,8 @@ void __connman_ipconfig_deladdr(int index, int family,
const char *label,
---
src/ipconfig.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 4d9b30f..0627b5b 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -1778,6 +1778,14 @@ int __connman_ipconfig_load(struct connman_ipconfig
*ipconfig,
---
src/connman.h |2 ++
src/ipconfig.c |6 ++
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/src/connman.h b/src/connman.h
index 992d533..7f18ff4 100644
--- a/src/connman.h
+++ b/src/connman.h
@@ -218,6 +218,8 @@ void __connman_ipconfig_delroute(int index, int
---
include/property.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/property.h b/include/property.h
index e18e1e9..487a170 100644
--- a/include/property.h
+++ b/include/property.h
@@ -57,6 +57,7 @@ enum connman_property_id {
---
src/network.c | 35 +++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/src/network.c b/src/network.c
index c3febd3..a338a58 100644
--- a/src/network.c
+++ b/src/network.c
@@ -768,6 +768,37 @@ static int manual_ipv6_set(struct connman_network
---
src/service.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/src/service.c b/src/service.c
index c27431c..89f7b4d 100644
--- a/src/service.c
+++ b/src/service.c
@@ -3245,6 +3245,7 @@ int __connman_service_indicate_state(struct
connman_service
---
src/connection.c |6 +-
src/connman.h|3 +-
src/location.c |3 +-
src/network.c| 24 +++--
src/provider.c | 27 +++--
src/service.c| 309 +-
6 files changed, 300 insertions(+), 72 deletions(-)
diff --git
---
src/network.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/src/network.c b/src/network.c
index c59a091..ec7666f 100644
--- a/src/network.c
+++ b/src/network.c
@@ -1094,12 +1094,14 @@ int __connman_network_clear_ipconfig(struct
connman_network *network,
{
---
src/service.c | 28
1 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/src/service.c b/src/service.c
index 89f7b4d..28a8f6a 100644
--- a/src/service.c
+++ b/src/service.c
@@ -4129,18 +4129,46 @@ static void service_lower_down(struct connman_ipconfig
---
src/service.c | 65 +++--
1 files changed, 49 insertions(+), 16 deletions(-)
diff --git a/src/service.c b/src/service.c
index 28a8f6a..2dff83a 100644
--- a/src/service.c
+++ b/src/service.c
@@ -2012,6 +2012,49 @@ error:
return
---
src/ipconfig.c | 15 ++-
1 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 0627b5b..1fb8281 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -1782,8 +1782,21 @@ int __connman_ipconfig_load(struct connman_ipconfig
*ipconfig,
---
src/service.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/service.c b/src/service.c
index 2dff83a..ff20e42 100644
--- a/src/service.c
+++ b/src/service.c
@@ -4202,6 +4202,12 @@ static void service_ip_release(struct connman_ipconfig
*ipconfig)
---
src/service.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/service.c b/src/service.c
index ff20e42..a5ade8d 100644
--- a/src/service.c
+++ b/src/service.c
@@ -3344,6 +3344,9 @@ int __connman_service_indicate_state(struct
connman_service *service,
Hi Kalle,
On Mon, Feb 07, 2011 at 03:33:49PM +0200, Kalle Valo wrote:
src/rtnl.c:578:8: error: ‘src’ may be used uninitialized in this function
src/rtnl.c:610:8: error: ‘src’ may be used uninitialized in this function
src/rtnl.c:1108:19: error: ‘servers’ may be used uninitialized in this
Hi Kalle,
On Mon, Feb 07, 2011 at 03:33:56PM +0200, Kalle Valo wrote:
src/iptables.c:432:20: error: ‘entry_return’ may be used uninitialized in
this function
Patch applied as well, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
Hi Alok,
On Tue, Feb 08, 2011 at 03:03:41PM +0200, Alok Barsode wrote:
From: Alok Barsode alok.bars...@nokia.com
Instead of looping through the technology_list, using the technology pointer
returned by technology_get().
Nice catch. Patch applied, many thanks.
Cheers,
Samuel.
--
Intel Open
Samuel Ortiz sa...@linux.intel.com writes:
Hi Kalle,
On Mon, Feb 07, 2011 at 04:04:33PM +0200, Kalle Valo wrote:
A user reported that his konversation (a kde irc client) is disconnecting
periodically every 30 minutes. After some investigation the culprit was
dhcp renewal handling in
src/rtnl.c:578:8: error: 'src' may be used uninitialized in this function
src/rtnl.c:610:8: error: 'src' may be used uninitialized in this function
src/rtnl.c:1108:19: error: 'servers' may be used uninitialized in this function
---
src/rtnl.c | 12 +---
1 files changed, 5 insertions(+),
From: Kalle Valo kalle.v...@canonical.com
For some reason there's a null check for host_ret in parse_url(), which
is at that point is an uninitialised local variable. Just remove the check.
plugins/pacrunner.c:316:5: error: 'host_ret' may be used uninitialized in
this function
---
From: Daniel Wagner daniel.wag...@bmw-carit.de
Remove also connman_ipaddress_set_ipv4/ipv6.
---
include/inet.h |2 --
include/ipconfig.h |3 ---
src/connman.h |6 ++
src/ipconfig.c | 48 +---
4 files changed, 43
From: Daniel Wagner daniel.wag...@bmw-carit.de
---
include/element.h |1 -
src/connection.c | 327 +---
src/connman.h | 11 ++
src/element.c | 11 +-
src/ipconfig.c| 27 -
src/ipv4.c| 35 +++---
src/main.c
From: Daniel Wagner daniel.wag...@bmw-carit.de
WIP
---
src/connman.h |9 ++
src/dhcp.c| 303 +---
src/element.c |2 -
src/main.c|2 +
src/network.c | 99 +--
5 files changed, 217 insertions(+), 198
From: Daniel Wagner daniel.wag...@bmw-carit.de
Things which should go into one of the other patches.
---
src/ipconfig.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index abb548f..dd6ddef 100644
--- a/src/ipconfig.c
+++
ignore that one. just noise ;)
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
Original Message
Subject: Re: connmand 0.67 crashing while processing timeserver option
during S3 resume from standby
From: Neil MacLeod cityblue2...@googlemail.com
To:
Date: 28 January 2011 22:09:40
That backtrace managed to get itself all mangled, here it is again:
pptp and l2tp does not use tun/tab approach so I changed the vpn.c to
allow vpn daemon to create the interface. Now vpn plugin tell
vpn to create the device or leave to vpn client.
On connection vpn will get the interface name set the index
for the provider.
---
plugins/vpn.c | 116
pppd will use this library to talk with connman vpn plugin.
---
scripts/libppp-plugin.c | 305 +++
1 files changed, 305 insertions(+), 0 deletions(-)
create mode 100644 scripts/libppp-plugin.c
diff --git a/scripts/libppp-plugin.c
Initial
---
plugins/pptp.c | 278
1 files changed, 278 insertions(+), 0 deletions(-)
create mode 100644 plugins/pptp.c
diff --git a/plugins/pptp.c b/plugins/pptp.c
new file mode 100644
index 000..ea0b599
--- /dev/null
+++
Hello everyone,
I've had some initial success starting connmand on a working connection.
I have a desktop that is in another room from my wireless router. It has
a static connection that way. Been using wpa to connect and checking
connman occasionally to see if it would work with no success till
30 matches
Mail list logo