Re: [PATCH] gsupplicant: Add/remove a dbus match which connman interested

2014-08-01 Thread Tomasz Bursztyka
Hi, +++ b/gsupplicant/supplicant.c @@ -4804,6 +4804,8 @@ static const char *g_supplicant_rule5 = type=signal, interface= SUPPLICANT_INTERFACE .Network; static const char *g_supplicant_rule6 = type=signal, interface= SUPPLICANT_INTERFACE

Re: [PATCH 1/5] gsupplicant: Add an helper to know if a peer is connected as client or not

2014-08-01 Thread leonew
Hi Tomasz, I met a wifi direct issue when use latest connman. I'm not sure whether I catch your point, if I'm wrong , please correct me, thanks:-) This patch seem that connman will use peer's */Group/* member to check whether local side is GC. and peer's group will updata when peer property

Re: Routing problem

2014-08-01 Thread G
2014-07-24 23:22 GMT+02:00 Jukka Rissanen jukka.rissa...@gmail.com: Hi, On 24 July 2014 10:21, G i...@asidev.com wrote: Hi folks, I have a strange bahaviour using connman 1.20 If possible try to upgrade to latest release (1.24), it fixes lot of bugs, although probably does not fix your

Re: [PATCH] gsupplicant: Add/remove a dbus match which connman interested

2014-08-01 Thread leonew
On 08/01/2014 05:23 PM, Tomasz Bursztyka wrote: Hi, +++ b/gsupplicant/supplicant.c @@ -4804,6 +4804,8 @@ static const char *g_supplicant_rule5 = type=signal, interface= SUPPLICANT_INTERFACE .Network; static const char *g_supplicant_rule6 = type=signal, interface=

[PATCH] Fix UTF-8 ssid's

2014-08-01 Thread Lorn Potter
I found an old patch that crashed, and fixed it up. Enjoy! --- gsupplicant/supplicant.c | 20 1 file changed, 20 insertions(+) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 534944b..19dbb1a 100644 --- a/gsupplicant/supplicant.c +++

[PATCH] gsupplicant: Remove the dbus match when not needed

2014-08-01 Thread Guoqiang Liu
From: Guoqiang Liu guoqiang@archermind.com Remove the dbus match when connman is no loger interested in. --- gsupplicant/supplicant.c |1 + 1 file changed, 1 insertion(+) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 534944b..d26b6e2 100644 ---

Re: [PATCH] Fix UTF-8 ssid's

2014-08-01 Thread Jukka Rissanen
Hi Lorn, I just wonder what is the issue that this patch is fixing, isn't the current implementation working? On pe, 2014-08-01 at 19:42 +1000, Lorn Potter wrote: I found an old patch that crashed, and fixed it up. Enjoy! --- gsupplicant/supplicant.c | 20 1 file

Re: [PATCH] Fix UTF-8 ssid's

2014-08-01 Thread Tomasz Bursztyka
Hi, I found an old patch that crashed, and fixed it up. Enjoy! New commit message style? ^^ Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] gsupplicant: Remove the dbus match when not needed

2014-08-01 Thread Tomasz Bursztyka
ACK from me. Thanks! Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 1/5] gsupplicant: Add an helper to know if a peer is connected as client or not

2014-08-01 Thread Tomasz Bursztyka
Hi, I met a wifi direct issue when use latest connman. I'm not sure whether I catch your point, if I'm wrong , please correct me, thanks:-) This patch seem that connman will use peer's */Group/* member to check whether local side is GC. and peer's group will updata when peer property

Re: [PATCH] Fix UTF-8 ssid's

2014-08-01 Thread Patrik Flykt
Hi, On Fri, 2014-08-01 at 12:53 +0300, Jukka Rissanen wrote: Hi Lorn, + result = g_convert_with_fallback((const char *)ssid, -1, + UTF-8, ISO-8859-1, + 0, 0, +

[PATCH] wifi: Free g_hash_table_get_values on connect_peer

2014-08-01 Thread Eduardo Abinader
Glist returned from g_hash_table_get_values was not being freed during p2p connect, causing a leak. --- src/peer.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/peer.c b/src/peer.c index 7f23059..1d802e1 100644 --- a/src/peer.c +++ b/src/peer.c @@ -480,7 +480,7

Re: [PATCH] wifi: Free g_hash_table_get_values on connect_peer

2014-08-01 Thread Tomasz Bursztyka
ACK Thanks Eduardo Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

[RFC/PATCH 00/16] Peer's Agent API support

2014-08-01 Thread Tomasz Bursztyka
Sending this as an RFC, since I could not test all the use-cases yet. This patch-set add the Peer's Agent API documentation and implementation. However, this only works in the context when ConnMan initiates the connection and not the other way round (which requires quite a bit of work to get it)

[PATCH 01/16] doc: Add RequestPeerInput method to agent API

2014-08-01 Thread Tomasz Bursztyka
This method will be used to handle extra input which might be requested when connecting to a peer or in case a peer wants to connect to us. --- doc/agent-api.txt | 49 + 1 file changed, 49 insertions(+) diff --git a/doc/agent-api.txt

[PATCH 02/16] agent: Refactor the error reporting method to be more generic

2014-08-01 Thread Tomasz Bursztyka
Thus it will be possible afterwards to implement RequestPeerError very simply. --- include/agent.h | 4 src/agent.c | 17 + 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/include/agent.h b/include/agent.h index 05462df..6961f7a 100644 ---

[PATCH 03/16] agent: Add a specific function to call ReportPeerError agent method

2014-08-01 Thread Tomasz Bursztyka
This will be exclusively used by peer core code to report an error. --- src/agent-connman.c | 10 ++ src/connman.h | 8 2 files changed, 18 insertions(+) diff --git a/src/agent-connman.c b/src/agent-connman.c index ab538f3..7502f0f 100644 --- a/src/agent-connman.c +++

[PATCH 05/16] agent: Provide a function for the Peer RequestPeerAuthorization call

2014-08-01 Thread Tomasz Bursztyka
This will be used by peer.c when there will be a need to choose between WPS PBC or PIN. This choice will be raised to the user via an agent RequestPeerAuthorization call. --- src/agent-connman.c | 167 ++-- src/connman.h | 8 +++ 2 files

[PATCH 13/16] wifi: Find and use peer's path do disconnect

2014-08-01 Thread Tomasz Bursztyka
Peer's lookup is done in wifi plugin and not anymore in gsupplicant part. --- plugins/wifi.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index e789f8c..95bc458 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -305,7 +305,9

[PATCH 09/16] gsupplicant: WPS PIN and Peer's path parameters are copied value

2014-08-01 Thread Tomasz Bursztyka
These are no longer constants, this is necessary for the future changes. --- gsupplicant/gsupplicant.h | 4 ++-- gsupplicant/supplicant.c | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 387a3aa..ff56001 100644

[PATCH 07/16] peer: Manage peer connection properly through an Agent report

2014-08-01 Thread Tomasz Bursztyka
Thus the upper layer, if providing an agent, will get a report from connman and it will be possible at this point to ask for a proper retry. --- src/peer.c | 66 +- 1 file changed, 53 insertions(+), 13 deletions(-) diff --git

[PATCH 08/16] peer: Call Agent RequestPeerAuthorization on WPS needs

2014-08-01 Thread Tomasz Bursztyka
This call will be raised if only a peer support both WPS pbc and pin method and is not currently advertizing for pbc, thus the need for the user to tell which method is necessary to proceed with the connection. --- src/peer.c | 59 +++ 1

[PATCH 15/16] client: Add Agent ReportPeerError method support

2014-08-01 Thread Tomasz Bursztyka
This will be used to report error from ConnMan. --- client/agent.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/client/agent.c b/client/agent.c index baa0a87..64c84da 100644 --- a/client/agent.c +++ b/client/agent.c @@ -368,6 +368,36 @@ static

[PATCH 11/16] gsupplicant: Add an helper to get the supplicant peer's object path

2014-08-01 Thread Tomasz Bursztyka
Since wifi plugin will be looking up for the peer while connecting, it will be the right place to get such information for the connection parameters. --- gsupplicant/gsupplicant.h | 1 + gsupplicant/supplicant.c | 8 2 files changed, 9 insertions(+) diff --git

[PATCH 16/16] client: Add support for RequestPeerAuthorization on WPS

2014-08-01 Thread Tomasz Bursztyka
This method will be requested by ConnMan when it will need to know whether to use WPS PIN or WPS PBC when connecting a peer. --- client/agent.c | 110 ++--- 1 file changed, 82 insertions(+), 28 deletions(-) diff --git a/client/agent.c

[PATCH 12/16] wifi: Handle properly WPS parameters while connecting a peer

2014-08-01 Thread Tomasz Bursztyka
It checks whether the peer has proper WPS method requested. It can return ENOKEY in case of none can be decided (thus peer core code will request it through an agent call). --- plugins/wifi.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git

[PATCH 10/16] gsupplicant: Add an helper to find a peer via its identifier

2014-08-01 Thread Tomasz Bursztyka
Wifi plugin will need to find the peer to check whether it supports WPS PBC or PIN method while connectin, and action upon it. --- gsupplicant/gsupplicant.h | 2 ++ gsupplicant/supplicant.c | 45 +++-- 2 files changed, 29 insertions(+), 18 deletions(-)

[PATCH 14/16] gsupplicant: Do not use and remove identifier parameter for peer

2014-08-01 Thread Tomasz Bursztyka
Wifi plugins is now using path as the only way to identify the peer while connecting or disconnecting. --- gsupplicant/gsupplicant.h | 1 - gsupplicant/supplicant.c | 14 +- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/gsupplicant/gsupplicant.h