RE: [PATCH autoconf v3 06/12] ipv6: Clear the IPv6 address if that address is removed from system

2011-01-11 Thread Jukka.Rissanen
Hi Samuel, ext Samuel Ortiz wrote: I think it would make sense to clear the address every time deladdr is called, not only for the IPv6 system address. Something like that: diff --git a/src/ipconfig.c b/src/ipconfig.c index 6ef39c5..bd664f3 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c

Re: [PATCH autoconf v3 06/12] ipv6: Clear the IPv6 address if that address is removed from system

2011-01-11 Thread Samuel Ortiz
Hi Jukka, On Tue, Jan 11, 2011 at 12:45:33PM +, jukka.rissa...@nokia.com wrote: g_slist_remove(ipdevice-address_list, ipaddress); - connman_ipaddress_free(ipaddress); + connman_ipaddress_clear(ipaddress); + g_free(ipaddress); But isn't connman_ipaddress_free()

RE: [PATCH autoconf v3 06/12] ipv6: Clear the IPv6 address if that address is removed from system

2011-01-11 Thread Jukka.Rissanen
Hi Samuel, ext Samuel Ortiz wrote: Hi Jukka, On Tue, Jan 11, 2011 at 12:45:33PM +, jukka.rissa...@nokia.com wrote: g_slist_remove(ipdevice-address_list, ipaddress); - connman_ipaddress_free(ipaddress); + connman_ipaddress_clear(ipaddress); + g_free(ipaddress);

Re: [PATCH autoconf v3 06/12] ipv6: Clear the IPv6 address if that address is removed from system

2011-01-10 Thread Samuel Ortiz
Hi Jukka, On Mon, Jan 10, 2011 at 01:45:15PM +, jukka.rissa...@nokia.com wrote: Hi Samuel, ext Samuel Ortiz wrote: Hi Jukka, On Fri, Jan 07, 2011 at 02:55:13PM +0200, Jukka Rissanen wrote: --- src/ipconfig.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-)

[PATCH autoconf v3 06/12] ipv6: Clear the IPv6 address if that address is removed from system

2011-01-07 Thread Jukka Rissanen
--- src/ipconfig.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 7a14c42..2c0ede6 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -616,6 +616,15 @@ void __connman_ipconfig_deladdr(int index, int family, const char

Re: [PATCH autoconf v3 06/12] ipv6: Clear the IPv6 address if that address is removed from system

2011-01-07 Thread Samuel Ortiz
Hi Jukka, On Fri, Jan 07, 2011 at 02:55:13PM +0200, Jukka Rissanen wrote: --- src/ipconfig.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 7a14c42..2c0ede6 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -616,6