Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: Wifi interface not recognized by connman (Jason Abele)
2. RE: Wifi interface not recognized by connman
(Francis Leblanc-Lebeau)
3. [PATCHv3] client: Fix Memory Leak (Niraj Kumar Goit)
4. [PATCHv3] client: Fix Memory Leak (Niraj Kumar Goit)
5. Fast connect path in wpa_supplicant (Naveen Singh)
6. [PATCH] neard: Remove extra dbus_message_unref()
(Milind Ramesh Murhekar)
7. [PATCH] main: Create parent directories if not created
(Saurav Babu)
----------------------------------------------------------------------
Message: 1
Date: Tue, 2 Feb 2016 16:03:49 -0800
From: Jason Abele <jason.ab...@gmail.com>
To: Francis Leblanc-Lebeau <flebl...@orthogone.ca>
Cc: connman@lists.01.org
Subject: Re: Wifi interface not recognized by connman
Message-ID:
<cadspesxrtp0yrnt-_0qw58xezkwk_ihpitqzozxdk4gpmfa...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
On Tue, Feb 2, 2016 at 11:39 AM, Francis Leblanc-Lebeau
<flebl...@orthogone.ca> wrote:
> The wifi device is not recognized by connman, but it is by wpa_supplicant
> (named mlan0) and working if manually configuring wpa_supplicant.conf,
> dhcpd, etc.
Did you enable the dbus interface in wpa_supplicant?
It looks like connman never contacted wpa_supplicant via dbus.
Cheers!
Jason
------------------------------
Message: 2
Date: Tue, 2 Feb 2016 22:04:41 -0500
From: "Francis Leblanc-Lebeau" <flebl...@orthogone.ca>
To: "'Jason Abele'" <jason.ab...@gmail.com>
Cc: connman@lists.01.org, Richard Brunelle <rbrune...@orthogone.ca>
Subject: RE: Wifi interface not recognized by connman
Message-ID: <000001d15e2f$a06bfac0$e143f040$@orthogone.ca>
Content-Type: text/plain; charset="UTF-8"
Thanks for the answer Jason !
Indeed DBUS is enabled for wpa_supplicant.
# grep DBUS defconfig
#CONFIG_CTRL_IFACE_DBUS=y
CONFIG_CTRL_IFACE_DBUS_NEW=y
#CONFIG_CTRL_IFACE_DBUS_INTRO=y
CONFIG_CTRL_IFACE_DBUS=y
CONFIG_CTRL_IFACE_DBUS_NEW=y
In my research I saw that rfkill was not enabled for the kernel !
I looked too fast at that debug.log, it was there all along:
connmand[1342]: Failed to open RFKILL control device
So with CONFIG_RFKILL=y in the kernel, /dev/rfkill is now available and I can
now use connmanctl enable wifi !
I didn't know that rfkill was mandatory to access the wifi/bt devices.
Now I am not able to scan for devices ... I don't have access to my device, but
from my research my wpa_supplicant must be missing the -u argument.
#connmanctl scan wifi
Error /net/connman/technology/wifi: Not supported
With all this everything should work tomorrow !
Cheers !
Francis
-----Original Message-----
From: Jason Abele [mailto:jason.ab...@gmail.com]
Sent: February 2, 2016 19:04
To: Francis Leblanc-Lebeau
Cc: connman@lists.01.org
Subject: Re: Wifi interface not recognized by connman
On Tue, Feb 2, 2016 at 11:39 AM, Francis Leblanc-Lebeau <flebl...@orthogone.ca>
wrote:
> The wifi device is not recognized by connman, but it is by
> wpa_supplicant (named mlan0) and working if manually configuring
> wpa_supplicant.conf, dhcpd, etc.
Did you enable the dbus interface in wpa_supplicant?
It looks like connman never contacted wpa_supplicant via dbus.
Cheers!
Jason
------------------------------
Message: 3
Date: Wed, 03 Feb 2016 12:04:26 +0530
From: Niraj Kumar Goit <nira...@samsung.com>
To: connman@lists.01.org
Cc: sachin....@samsung.com
Subject: [PATCHv3] client: Fix Memory Leak
Message-ID: <1454481266-4892-1-git-send-email-nira...@samsung.com>
In cmd_service_move_before() function, allocate memory to services
structure after error checks to fix memory leak.
---
v3: Declare services struct at beginning of function and allocate
memory to services after all error checks.
client/commands.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/client/commands.c b/client/commands.c
index db24d16..2faa51c 100644
--- a/client/commands.c
+++ b/client/commands.c
@@ -795,7 +795,7 @@ static int cmd_service_move_before(char *args[], int num,
struct connman_option *options)
{
const char *iface = "net.connman.Service";
- struct move_service *services = g_new(struct move_service, 1);
+ struct move_service *services;
if (num > 3)
return -E2BIG;
@@ -806,6 +806,8 @@ static int cmd_service_move_before(char *args[], int num,
if (check_dbus_name(args[1]) == false)
return -EINVAL;
+ services = g_new(struct move_service, 1);
+
services->service = g_strdup_printf("/net/connman/service/%s", args[1]);
services->target = g_strdup_printf("/net/connman/service/%s", args[2]);
--
1.7.9.5
------------------------------
Message: 4
Date: Wed, 03 Feb 2016 12:07:08 +0530
From: Niraj Kumar Goit <nira...@samsung.com>
To: connman@lists.01.org
Cc: sachin....@samsung.com
Subject: [PATCHv3] client: Fix Memory Leak
Message-ID: <1454481428-4933-1-git-send-email-nira...@samsung.com>
In cmd_service_move_after() function, allocate memory to services
structure after error checks to fix memory leak.
---
v3: Declare services struct at beginning of function and allocate
memory to services after all error checks.
client/commands.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/client/commands.c b/client/commands.c
index 2faa51c..eec200f 100644
--- a/client/commands.c
+++ b/client/commands.c
@@ -855,7 +855,7 @@ static int cmd_service_move_after(char *args[], int num,
struct connman_option *options)
{
const char *iface = "net.connman.Service";
- struct move_service *services = g_new(struct move_service, 1);
+ struct move_service *services;
if (num > 3)
return -E2BIG;
@@ -866,6 +866,8 @@ static int cmd_service_move_after(char *args[], int num,
if (check_dbus_name(args[1]) == false)
return -EINVAL;
+ services = g_new(struct move_service, 1);
+
services->service = g_strdup_printf("/net/connman/service/%s", args[1]);
services->target = g_strdup_printf("/net/connman/service/%s", args[2]);
--
1.7.9.5
------------------------------
Message: 5
Date: Tue, 2 Feb 2016 23:57:41 -0800
From: Naveen Singh <naveensingh0...@gmail.com>
To: connman@lists.01.org
Subject: Fast connect path in wpa_supplicant
Message-ID:
<CAGTDzKksPTPCh6tFz+ecY4CGMZ+bzgP2f59vPqQX9==25cm...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Hi All
Just after losing wifi link because of an incoming deauth with reason
code 6 or 7, wpa_supplicant sets the fast_reconnect and
fast_reconnect_ssid to current bss and current ssid.
Later on if fast_reconnect is not NULL it tries to connect to same
SSID. This makes sense for some devices which does not use connman.
Devices using wpa_supplicant with connman this connect is not useful
at all as connman when it gets notified of this disconnect would
disable the network that would end up causing a locally generated
deauth and would nullify this connection attempt.
In stead of having this feature turned on all the time, it would be
good to have a configuration from connman. Initialized value of this
configuration would be turned on meaning fast connect is enabled and
devices using connman along with wpa_supplicant would disable this
feature.
Does this make sense?
Regards
Naveen
------------------------------
Message: 6
Date: Wed, 03 Feb 2016 18:34:12 +0530
From: Milind Ramesh Murhekar <m.murhe...@samsung.com>
To: connman@lists.01.org
Cc: sachin....@samsung.com
Subject: [PATCH] neard: Remove extra dbus_message_unref()
Message-ID: <1454504652-6677-1-git-send-email-m.murhe...@samsung.com>
Remove extra dbus_message_unref(), If dbus_connection_send_with_reply()
fails.
---
plugins/neard.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/plugins/neard.c b/plugins/neard.c
index 1a0fc1c..69586df 100644
--- a/plugins/neard.c
+++ b/plugins/neard.c
@@ -534,10 +534,8 @@ static void register_agent(void)
&path, DBUS_TYPE_STRING, &type, DBUS_TYPE_INVALID);
if (!dbus_connection_send_with_reply(connection, message,
- ®ister_call, TIMEOUT)) {
- dbus_message_unref(message);
+ ®ister_call, TIMEOUT))
goto out;
- }
if (!dbus_pending_call_set_notify(register_call,
register_agent_cb, NULL, NULL))
--
1.9.1
------------------------------
Message: 7
Date: Wed, 03 Feb 2016 19:37:00 +0530
From: Saurav Babu <saurav.b...@samsung.com>
To: connman@lists.01.org
Cc: sachin....@samsung.com
Subject: [PATCH] main: Create parent directories if not created
Message-ID:
<1454508420-23432-1-git-send-email-saurav.b...@samsung.com>
When connman tries to create STORAGEDIR and its parent directory(/var/lib)
doesn't exist then it fails to create STORAGEDIR. This patch creates
parent directories also if they don't exist.
---
src/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main.c b/src/main.c
index e46fa7b..17f0c95 100644
--- a/src/main.c
+++ b/src/main.c
@@ -617,7 +617,7 @@ int main(int argc, char *argv[])
}
}
- if (mkdir(STORAGEDIR, S_IRUSR | S_IWUSR | S_IXUSR |
+ if (g_mkdir_with_parents(STORAGEDIR, S_IRUSR | S_IWUSR | S_IXUSR |
S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH) < 0) {
if (errno != EEXIST)
perror("Failed to create storage directory");
--
1.9.1
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
connman@lists.01.org
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 4, Issue 3
*************************************
