Re: [controller-dev] DataTreeChangeService - pre-existing data

2016-12-01 Thread Robert Varga
On 12/01/2016 12:52 PM, Tom Pantelis wrote: > I also have a patch to change > the DefaultShardDataTreeChangeListenerPublisher to derive from the > mdsal AbstractDOMStoreTreeChangePublisher. I'll leave the > AbstractDOMStoreTreeChangePublisher in controller as is. Right. We really should start reti

Re: [controller-dev] DataTreeChangeService - pre-existing data

2016-12-01 Thread Tom Pantelis
Actually I pushed https://git.opendaylight.org/gerrit/#/c/48846/ to change the AbstractDOMStoreTreeChangePublisher to batch. I think it's better to do it in the base class. I also have a patch to change the DefaultShardDataTreeChangeListenerPublisher to derive from the mdsal AbstractDOMStoreTreeCha

Re: [controller-dev] DataTreeChangeService - pre-existing data

2016-12-01 Thread Robert Varga
On 12/01/2016 09:46 AM, Faiz Kothari wrote: > Hey Sela, > > So I started going through the code for DataTreeChangeListener > registration which led me to the following code: > > https://github.com/opendaylight/controller/blob/master/opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/c

Re: [controller-dev] DataTreeChangeService - pre-existing data

2016-12-01 Thread Faiz Kothari
mpante...@gmail.com] > *Sent:* Tuesday, November 29, 2016 1:59 PM > *To:* Sela, Guy > *Cc:* mdsal-...@lists.opendaylight.org; controller-dev@lists. > opendaylight.org > *Subject:* Re: [controller-dev] DataTreeChangeService - pre-existing data > > > > yes - on registratio

Re: [controller-dev] DataTreeChangeService - pre-existing data

2016-11-29 Thread Sela, Guy
repeats itself in other entities too, and in different setups. From: Tom Pantelis [mailto:tompante...@gmail.com] Sent: Tuesday, November 29, 2016 1:59 PM To: Sela, Guy Cc: mdsal-...@lists.opendaylight.org; controller-dev@lists.opendaylight.org Subject: Re: [controller-dev] DataTreeChangeService - pre

Re: [controller-dev] DataTreeChangeService - pre-existing data

2016-11-29 Thread Tom Pantelis
yes - on registration it grabs the current data tree and sends it. If you're getting subsequent data then that must have occurred after your registration. On Tue, Nov 29, 2016 at 6:53 AM, Sela, Guy wrote: > Hi, > > > > In the Javadoc of DataTreeChangeService it says: > > “ > > If there is any pr

[controller-dev] DataTreeChangeService - pre-existing data

2016-11-29 Thread Sela, Guy
Hi, In the Javadoc of DataTreeChangeService it says: " If there is any pre-existing data in the data tree for the path for which you are registering, you will receive an initial data change event, which will contain all pre-existing data, marked as created. " Is this behavior guaranteed? Will al