Re: [Cooker] Re: qt patch for XIM
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Narfi Stefansson wrote: > On Tuesday 18 February 2003 02:26, Laurent Montel wrote: > >>Strange I have last qt-copy and patch was not adopted >> > > I beg to differ. FYI: Name: qt3 Relocations: (not relocateable) Version : 3.1.1 Vendor: MandrakeSoft Release : 12mdk Build Date: Tue Feb 18 13:41:31 2003 Install date: (not installed) Build Host: ke.mandrakesoft.com Group : System/Libraries Source RPM: (none) Size: 12444254 License: GPL and QPL Packager: Mandrake Linux KDE Team <[EMAIL PROTECTED]> URL : http://www.troll.no/ Summary : Qt3 - Sources [...] * Tue Feb 18 2003 Laurent MONTEL <[EMAIL PROTECTED]> 3.1.1-12mdk - - Add patch12: fix xim problem - -- |--Another happy Mandrake Club member--| Buchan MilneMechanical Engineer, Network Manager Cellphone * Work+27 82 472 2231 * +27 21 8828820x121 Stellenbosch Automotive Engineering http://www.cae.co.za GPG Key http://ranger.dnsalias.com/bgmilne.asc 1024D/60D204A7 2919 E232 5610 A038 87B1 72D6 AC92 BA50 60D2 04A7 -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.1 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQE+UkImrJK6UGDSBKcRAlLsAJ0WVXK2TnPY+fcOfbtui0+5ne0O5gCgienN tPXHfChkza1FMzZGXyHQfek= =H6v4 -END PGP SIGNATURE-
Re: [Cooker] Re: qt patch for XIM
On Tuesday 18 February 2003 02:26, Laurent Montel wrote: > Le Tuesday 18 February 2003 05:28, Narfi Stefansson a écrit : > > Laurent, > > > > would you please be so kind as to tell me whether the patch I forwarded > > to you for Qt is accepted or rejected? [bug #1097, Jan. 27, 2003] > > > > I know that without this patch, keyboard shortcuts in kinput2 don't work > > with numerous KDE programs since they are grabbed by the Qt applications > > before they are offered to kinput2. I would expect the same to hold for > > all of the XIM. > > > > Furthermore, the author of the patch [Daisuke Kameda] told me that the > > patch was accepted by Trolltech but didn't make it in time for 3.1.1. > > However, in the newest qt-copy, this modification has already been > > adopted. > > Strange I have last qt-copy and patch was not adopted > I beg to differ. Look at int QApplication::x11ProcessEvent( XEvent* event ) in src/kernel/qapplication_x11.cpp I am looking at this function in qt-x11-free-3.1.1 and qt-x11-free-3.1.2-snapshot-20030218 In 3.1.1, the function starts with a switch statement and right after that comes if ( qt_x11EventFilter(event) ) // send through app filter return 1; [lines 3057-3058] In 3.1.2-snapshot-20030218, the function starts with the same switch statement, however the statement if (qt_x11EventFilter(event)) return 1; has been moved. It is now below the block marked #ifndef QT_NO_XIM #endif // QT_NO_XIM [The QT_NO_XIM block is in lines 3154-3216, qt_x11EventFilter(event) is now in lines 3221-3222] In short: I believe the patch has been applied and that bug #1097 should not be closed without applying this patch or upgrading to 3.1.2 Narfi.
[Cooker] Re: qt patch for XIM
Le Tuesday 18 February 2003 05:28, Narfi Stefansson a écrit : > Laurent, > > would you please be so kind as to tell me whether the patch I forwarded to > you for Qt is accepted or rejected? [bug #1097, Jan. 27, 2003] > > I know that without this patch, keyboard shortcuts in kinput2 don't work > with numerous KDE programs since they are grabbed by the Qt applications > before they are offered to kinput2. I would expect the same to hold for all > of the XIM. > > Furthermore, the author of the patch [Daisuke Kameda] told me that the > patch was accepted by Trolltech but didn't make it in time for 3.1.1. > However, in the newest qt-copy, this modification has already been adopted. Strange I have last qt-copy and patch was not adopted Regards. > Thanks, > > Narfi.