Re: Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

[Pavel Raiskup]

On Thursday, September 22, 2016 7:40:08 AM CEST Michal Novotny wrote:
> On Wed, Sep 21, 2016 at 3:32 PM, Pavel Raiskup  wrote:
> > :) Consider that others consume Copr sources ...
> >
> > > What is important for me is not important for you and vice versa.
>
> I would say that every commit is important.

Do I hear you correctly that also doing every-commit-review _is important_ ?

> > Yup, it is on my TODO list to make the upstream packages usable for me
> > too (because otherwise it is real pain), but so far (except for client
> > side) I need to re-build the packages with downstream patches.  If
> > there was something docker-related, I would have to rebuild the images
> > probably too...
>
> You don't need to rebuild any images manually, just restart
> copr-dist-git.service.

Yup, but _if there was_ yet something else docker related..

Pavel
___
copr-devel mailing list -- copr-devel@lists.fedorahosted.org
To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org

Re: Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

[Michal Novotny]

On Wed, Sep 21, 2016 at 3:32 PM, Pavel Raiskup  wrote:

>
> :) Consider that others consume Copr sources ...
>
> > What is important for me is not important for you and vice versa.
>

I would say that every commit is important.


>
> ... and have Copr working, want to have it as stable as possible, and are
> planning regular updates with new releases.  So to answer your question:
> Whatever could complicate updating is worth having a look (by other
> consumers)
> whether it is (a) necessary, (b) shouldn't be made optional; or (c) at
> worth
> study hard how to re-configure properly.
>
> Typical "hint" can be:
>
> - "you have to hack something on XX (backend e.g)" because you changed
> something
>   on "YY (e.g. dist git)", and whetever else component.
>
> - API changes, copr client should detect that server supports older API
>
> - You need to change deployment scripts, others will need this too
>
> - you put requirement on software that is not in base Fedora repo, be that
> yum
>   repo or other software repo ... (like dockerhub)
>
> Yup, it is on my TODO list to make the upstream packages usable for me too
> (because otherwise it is real pain), but so far (except for client side) I
> need
> to re-build the packages with downstream patches.  If there was something
> docker-related, I would have to rebuild the images probably too...
>

You don't need to rebuild any images manually, just restart
copr-dist-git.service.

clime


>
> Pavel
> ___
> copr-devel mailing list -- copr-devel@lists.fedorahosted.org
> To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org
>
___
copr-devel mailing list -- copr-devel@lists.fedorahosted.org
To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org

Re: Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

[Miroslav Suchý]

Dne 21.9.2016 v 12:52 Pavel Raiskup napsal(a):
> Thanks, I'll subscribe there.  Let's hope I'll be able to find good
> heuristic to pick important changes for review -- but unfortunately, I can
> not review everything.  Is there possibility to highlight important
> changes?

Define "important changes" :)

What is important for me is not important for you and vice versa.
-- 
Miroslav Suchy, RHCA
Red Hat, Senior Software Engineer, #brno, #devexp, #fedora-buildsys
___
copr-devel mailing list -- copr-devel@lists.fedorahosted.org
To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org

Re: Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

[Vít Ondruch]

As I read the recent discussions on this ML, this appears to me to be
more about design decisions, not about particular commits ...


Vít



Dne 19.9.2016 v 13:53 Miroslav Suchý napsal(a):
> This is not really bug. So I will close it in BZ. But I'm happy to discuss it 
> here.
>
> I disagree that we need code review before push. This is quite small project, 
> with only few active developers.
> Although you can find some commits which can be discussed, most of them are 
> straight.
>
> If you want to do review, then you can subscribe to:
>   
> https://lists.fedorahosted.org/admin/lists/copr-commits.lists.fedorahosted.org/
> And comment the commit here on this mailing list. If needed, it can be 
> rejected.
>
> Mirek
>
>
>  Přeposlaná zpráva 
> Předmět: [Bug 1376844] New: Please start using processes like code-review, 
> etc.
> Datum: Fri, 16 Sep 2016 14:53:30 +
> Od: bugzi...@redhat.com
> Komu: msu...@redhat.com
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1376844
>
> Bug ID: 1376844
>Summary: Please start using processes like code-review, etc.
>Product: Copr
>  Component: backend
>   Assignee: msu...@redhat.com
>   Reporter: prais...@redhat.com
>
>
>
> Copr is starting to be very popular and key part of Fedora's and Red Hat's
> infrastructure, and it deserves proper processes.  I'm not talking about hard
> bureaucracy, but some clear 'Pull-request -> code-review -> push' is enough.
> If there is done something like that in background (I strongly believe there
> is) please open that process.
>
> I'd be glad to be part of the review process if there is something really
> design breaking.
>
> Copr really needs new consumer, that is important point, so please:
>
> - let's not hard-wire anything specific to Fedora instance copr
> - if there is something Fedora-instance specific, make it optional, pluggable
>   thing
>
___
copr-devel mailing list -- copr-devel@lists.fedorahosted.org
To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org