Re: [concurrency-interest] NavigableMap implementation bugs

2008-06-09 Thread Martin Buchholz
Osvaldo, I fundamentally agree with you that optimizing HashSet in the manner you describe is worthwhile, but because the implementation needs to "parallel" HashMap, it would be good to do this after the current hacking activity on HashMap quiesces. Unfortunately, this kind of programming is pure

Re: [concurrency-interest] NavigableMap implementation bugs

2008-06-09 Thread Doug Lea
Martin Buchholz wrote: TreeMap.navigableKeySet().subSet(x,y).remove(o) fails because TreeMap.KeySet.subset calls the TreeSet(NavigableMap) constructor Thanks for finding this! In the case of ConcurrentSkipListMap, the correctness issue is even more serious, since remove(existing element) fai

Re: HashMap implementations and Integer specializations

2008-06-09 Thread Martin Buchholz
Charlie, Test case code is different from regular code in that bad practice is often a good idea. People should know better than to "fix" test cases using their IDE. But I added this comment: // This code intentionally uses the denigrated constructors // that are guaranteed to re

Re: HashMap implementations and Integer specializations

2008-06-09 Thread Martin Buchholz
Charlie, Hotspot engineers throughout the ages have been tempted to optimize away object identity semantics of Integer and String, but I'm pretty sure that for e.g. new Integer(x) and new String(y) hotspot will certainly continue to return _new_ objects (unless of course the application can be pro

Re: HashMap implementations and Integer specializations

2008-06-09 Thread Martin Buchholz
Peter, Thanks. Fixed. Martin On Sun, Jun 8, 2008 at 10:59 PM, Peter Arrenbrecht <[EMAIL PROTECTED]> wrote: > Typo: testPutPreversesObjectIdentity > > On Mon, Jun 9, 2008 at 12:13 AM, Martin Buchholz <[EMAIL PROTECTED]> wrote: >> JavaOne 2008 technical session PDFs are now available >> >> http://