Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-13 Thread Tim Bell
Martin Buchholz wrote: I've put the patch up on http://cr.openjdk.java.net/~martin/LoggingDeadlock2 (my first use (or abuse? I didn't use webrev) of cr.openjdk.java.net) Perfectly OK. cr.ojn is mostly used for webrevs, but it is fine to use it for anything you want to share with the commun

Logger.log should call getHandlers

2009-04-13 Thread Martin Buchholz
Hi Swamy Our recent change changeset: 810:6eac3829cb41 user:martin date:Tue Jan 27 15:04:30 2009 -0800 summary: 6797480: Remove synchronization bottleneck in logger unfortunately introduced a serious bug. Logger.log should call Logger.getHandlers(), not Logger.handlers, be

hg: jdk7/tl/jdk: 6829098: Regression test java/security/Security/ClassLoaderDeadlock/Deadlock2.java error - missing "; "

2009-04-13 Thread yu-ching . peng
Changeset: 6f99dbd58123 Author:valeriep Date: 2009-04-13 18:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6f99dbd58123 6829098: Regression test java/security/Security/ClassLoaderDeadlock/Deadlock2.java error - missing ";" Summary: Added back the missing ";" Reviewed-by:

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-13 Thread David Holmes - Sun Microsystems
I concur with the caution here. When looking at the lazy initialization change, it never occurred to me that first-use could actually occur after shutdown had commenced. David Martin Buchholz said the following on 04/14/09 06:57: On Mon, Apr 13, 2009 at 10:56, Mandy Chung wrote: With the f

Re: Source of sun.nio.cs.StandardCharsets.java - Please help!

2009-04-13 Thread Xueming Shen
Ulf Zibis wrote: > it should be simplified to something like below (let me know if I'm wrong on this one) I'm not sure, if I'm the right person to "review" your My apology for the confusion. "that" is not for you, the author of that script is still here:-) so I asked just in case, but I bel

Re: Source of sun.nio.cs.StandardCharsets.java - Please help!

2009-04-13 Thread Ulf Zibis
Sherman, thanks for catching my request. > Just took a quick look at the original awk script, it looks like there might be some "old" leftover code, > it should be simplified to something like below (let me know if I'm wrong on this one) I'm not sure, if I'm the right person to "review" your

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-13 Thread Martin Buchholz
On Mon, Apr 13, 2009 at 10:56, Mandy Chung wrote: > With the fix for 6829503, ApplicationShutdownHook and DeleteOnExitHook are > both lazily initialized.  Since it is possible that a file could be added to > the list for DeletedOnExit during shutdown, perhaps we also need to change > the Shutdown

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-13 Thread Mandy Chung
Sounds good. The CR for bug #1 is 6829636. I'll let Swamy to review the test fix. Mandy On 04/13/09 13:28, Martin Buchholz wrote: I've put the patch up on http://cr.openjdk.java.net/~martin/LoggingDeadlock2 (my first use (or abuse? I didn't use webrev) of cr.openjdk.java.net) I am not a sh

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-13 Thread Martin Buchholz
I've put the patch up on http://cr.openjdk.java.net/~martin/LoggingDeadlock2 (my first use (or abuse? I didn't use webrev) of cr.openjdk.java.net) I am not a shutdown hook expert - everything I know about shutdown hooks I learned while tracking down LoggingDeadlock2 failures. So I agree it would

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-13 Thread Mandy Chung
Hi Martin, Thanks for catching the regression. I created a Sun bug # 6829503 for bug 2. With the fix for 6829503, ApplicationShutdownHook and DeleteOnExitHook are both lazily initialized. Since it is possible that a file could be added to the list for DeletedOnExit during shutdown, perhaps