Re: 4206909 - adding Z_SYNC_FLUSH support to deflaters

2009-09-04 Thread Martin Buchholz
On Fri, Sep 4, 2009 at 18:02, Xueming Shen wrote: > Thanks for the comments. > > Brandon Long wrote: >> >> In the new Deflater.deflate, you are checking valid flush values against >> NO_FLUSH twice (and missing FULL_FLUSH) >> > > good catch, a bad copy/paste. More unit tests will be written to catc

Re: 4206909 - adding Z_SYNC_FLUSH support to deflaters

2009-09-04 Thread Xueming Shen
Thanks for the comments. Brandon Long wrote: In the new Deflater.deflate, you are checking valid flush values against NO_FLUSH twice (and missing FULL_FLUSH) good catch, a bad copy/paste. More unit tests will be written to catch this kind of problem after we finalize the APIs. The new D

Re: 4206909 - adding Z_SYNC_FLUSH support to deflaters

2009-09-04 Thread Brandon Long
In the new Deflater.deflate, you are checking valid flush values against NO_FLUSH twice (and missing FULL_FLUSH) The new DeflaterOutputStream.flush, you loop as long as some output is generated, which can call deflate an extra time. Normally, code that does this loops until there is no def.needsI

Re: 4206909 - adding Z_SYNC_FLUSH support to deflaters

2009-09-04 Thread Xueming Shen
I would like to take the conservative (read compatible) approach for this issue. (1)expose zlib's flush mode Z_NO_FLUSH, Z_SYNC_FLUSH and Z_FULL_FLUSH (2)add deflate(byte[] b, int off, int len, int flush) (3)document the existing deflate() continues to use Z_NO_FLUSH (4)add DeflaterOutputStrea

hg: jdk7/tl/jdk: 6879368: Remove stray quote in Character javadoc

2009-09-04 Thread martinrb
Changeset: 704296144175 Author:martin Date: 2009-09-04 13:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/704296144175 6879368: Remove stray quote in Character javadoc Summary: Remove stray quote in Character.valueOf javadoc, using Ulf's \u005Cu technique Reviewed-by:

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-04 Thread Joseph D. Darcy
Hello. Martin Buchholz wrote: Joe, here's a fix for the stray double quote. Mea culpa! I've used {...@code with \u005C with the hope of making Ulf happy. As usual, we'll need bug filed, etc... I've filed bug 6879368 "Remove stray quote in Character javadoc" for this issue. diff

hg: jdk7/tl/jdk: 6873951: test/java/lang/reflect/Generics/Probe.java fails.

2009-09-04 Thread joe . darcy
Changeset: c34f92a47245 Author:darcy Date: 2009-09-04 13:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c34f92a47245 6873951: test/java/lang/reflect/Generics/Probe.java fails. Reviewed-by: alanb ! test/java/lang/reflect/Generics/Probe.java

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-04 Thread Ulf Zibis
Am 04.09.2009 17:10, Martin Buchholz schrieb: On Fri, Sep 4, 2009 at 02:14, Ulf Zibis wrote: Oops sorry, I only recognized javadoc update from 1.6.0_14 to 1.7.0 b70, Do you know about "hg blame" ? Good idea. :-) I rarely used it. Thanks for remembering me. -Ulf

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-04 Thread Martin Buchholz
On Fri, Sep 4, 2009 at 02:14, Ulf Zibis wrote: > Oops sorry, I only recognized javadoc update from 1.6.0_14 to 1.7.0 b70, Do you know about "hg blame" ?

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-04 Thread Ulf Zibis
Am 04.09.2009 03:52, Martin Buchholz schrieb: When you say "you", I assume you are using the "royal you". That change was actually made by Joe Darcy. Martin Oops sorry, I only recognized javadoc update from 1.6.0_14 to 1.7.0 b70, so as this particular change was in similar flavour of your

hg: jdk7/tl/jdk: 2 new changesets

2009-09-04 Thread weijun . wang
Changeset: ee5300e1835a Author:weijun Date: 2009-09-04 14:58 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee5300e1835a 6876328: different names for the same digest algorithms breaks jarsigner Reviewed-by: mullan ! src/share/classes/sun/security/tools/JarSigner.java + test/