hg: jdk7/tl/jdk: 6349921: (enum) Include links from java.lang.Enum to EnumSet and EnumMap

2009-10-13 Thread joe . darcy
Changeset: 151baf5e19ca Author:darcy Date: 2009-10-13 17:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/151baf5e19ca 6349921: (enum) Include links from java.lang.Enum to EnumSet and EnumMap Reviewed-by: martin ! src/share/classes/java/lang/Enum.java

Re: j.u.Objects follow-up: deepEquals(Object, Object)?

2009-10-13 Thread Bob Lee
On Mon, Oct 12, 2009 at 10:40 AM, Joseph D. Darcy wrote: > I think Objects is a better home for deepEquals(Object, Object) than Arrays > since the arguments are not arrays and since it is a sibling method to > equals(Object, Object). > While the argument types are Object, the behavior and usage

Sponsoring getting 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 7

2009-10-13 Thread Joseph D. Darcy
Hello. Following up from threads earlier this year, http://mail.openjdk.java.net/pipermail/core-libs-dev/2009-February/001061.html http://mail.openjdk.java.net/pipermail/core-libs-dev/2009-March/001191.html I'm willing and interested to sponsor getting String.join functionality into JDK 7. T

java.util.Objects, round two

2009-10-13 Thread Joseph D. Darcy
Hello. After recent discussions on the list, the following methods will be included in round two of the evolution of java.util.Objects: Under bug 6889858: Add nonNull methods to java.util.Objects: /** * Checks that the specified object reference is not {...@code null}. This * method

hg: jdk7/tl/langtools: 6891079: Compiler allows invalid binary literals 0b and oBL

2009-10-13 Thread jonathan . gibbons
Changeset: 8a4543b30586 Author:jjg Date: 2009-10-13 15:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8a4543b30586 6891079: Compiler allows invalid binary literals 0b and oBL Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/

hg: jdk7/tl/jdk: 6648344: (reflect spec) State default of isAccessible for reflective objects

2009-10-13 Thread joe . darcy
Changeset: 9d240dbadaa3 Author:darcy Date: 2009-10-13 14:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d240dbadaa3 6648344: (reflect spec) State default of isAccessible for reflective objects Reviewed-by: alanb ! src/share/classes/java/lang/reflect/AccessibleObject.java

hg: jdk7/tl/langtools: 6887895: CONSTANT_Class_info getBaseName does not handle arrays of primitives correctly

2009-10-13 Thread jonathan . gibbons
Changeset: e526e39579ae Author:jjg Date: 2009-10-13 14:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e526e39579ae 6887895: CONSTANT_Class_info getBaseName does not handle arrays of primitives correctly Reviewed-by: ksrini ! src/share/classes/com/sun/tools/classfil

Re: Code review request for 6648344: (reflect spec) State default of isAccessible for reflective objects

2009-10-13 Thread Alan Bateman
Joseph D. Darcy wrote: Hello. Please review this simple specification clarification (with accompanying test) for 6648344: (reflect spec) State default of isAccessible for reflective objects This looks good to me. -Alan.

More native closeable resources

2009-10-13 Thread Paulo Levi
Probably JavaSound is another candidate for closeable refactoring for jdk7? Specifically all the Line implementations : TargetDataLine, SourceDataline, Clip.

Re: First round of java.util.Objects for code review (bug 6797535)

2009-10-13 Thread Joshua Bloch
Joe, Hi. I've attached a file containing the methods and a JTReg "basic test" for inclusion in your BasicObjectTests. I adhered to your style, for easy integration. If you could take it from here, I'd be ever so grateful. Thanks, Josh On Thu, Oct 8, 2009 at 6:21 PM, Joe Darcy wrote:

Re: j.u.Objects follow-up: deepEquals(Object, Object)?

2009-10-13 Thread Joshua Bloch
Joe, I don't feel too strongly about this one. Do the right thing. Josh On Mon, Oct 12, 2009 at 10:40 AM, Joseph D. Darcy wrote: > Joshua Bloch wrote: > >> I don't think method really pays for itself. If it belongs anywhere, it >> belongs in java.util.Arrays. >> >> Josh >>

Re: j.u.Objects follow-up: deepEquals(Object, Object)?

2009-10-13 Thread Joseph D. Darcy
Joshua Bloch wrote: I don't think method really pays for itself. If it belongs anywhere, it belongs in java.util.Arrays. Josh I think there is room in the platform for this functionality. Even if this is mostly used in tests, code used in tests is code too :-) I think Objects i

Re: j.ul.Objects follow-up: methods for var-argification?

2009-10-13 Thread Joseph D. Darcy
Rémi Forax wrote: Le 12/10/2009 19:25, Joseph D. Darcy a écrit : Joshua Bloch wrote: Joe, I'm not sure I like this idea. My one experience with forcing an array method to do double duty as varargs method was a disaster. The method was Arrays.asList, and the result was Puzzler # 7 from "Th

Benchmark for java.nio.charset.Charset cache

2009-10-13 Thread Ulf Zibis
Hi, Martin, Xueming, I did a benchmark: unsynchronized 2-ElementCache ./. synchronized 4-ElementCache Result: Usage: java -Xint -Xbootclasspath/p:..\build\classes;..\build\test\classes java.nio.charset.CharsetBenchmark As in real world, excessive loops on Charset.forName() are unlik

Re: First round of java.util.Objects for code review (bug 6797535)

2009-10-13 Thread Joseph D. Darcy
Joshua Bloch wrote: Joe, Hi. I've attached a file containing the methods and a JTReg "basic test" for inclusion in your BasicObjectTests. I adhered to your style, for easy integration. If you could take it from here, I'd be ever so grateful. Will do. Cheers, -Joe Thanks, Jos

Re: First round of java.util.Objects for code review (bug 6797535)

2009-10-13 Thread Joshua Bloch
Joe, Thanks very much! Josh On Tue, Oct 13, 2009 at 11:12 AM, Joseph D. Darcy wrote: > Joshua Bloch wrote: > >> Joe, >> >> Hi. I've attached a file containing the methods and a JTReg "basic test" >> for inclusion in your BasicObjectTests. I adhered to your style, for easy >> integrati

Re: j.ul.Objects follow-up: methods for var-argification?

2009-10-13 Thread Bob Lee
On Mon, Oct 12, 2009 at 12:52 PM, Rémi Forax wrote: > It's not a good idea to have a hashCode() that allocate objects, > at least until escape analysis is implemented in all VMs. Agree with Joe--these methods don't carry their weight. If the allocation is too much to bear, it's easy enough to w

Re: j.ul.Objects follow-up: methods for var-argification?

2009-10-13 Thread Rémi Forax
Le 12/10/2009 19:25, Joseph D. Darcy a écrit : Joshua Bloch wrote: Joe, I'm not sure I like this idea. My one experience with forcing an array method to do double duty as varargs method was a disaster. The method was Arrays.asList, and the result was Puzzler # 7 from "The Continuing Advent

Re: j.ul.Objects follow-up: methods for var-argification?

2009-10-13 Thread Rémi Forax
Le 12/10/2009 20:41, Joseph D. Darcy a écrit : Rémi Forax wrote: Le 12/10/2009 19:25, Joseph D. Darcy a écrit : Joshua Bloch wrote: Joe, I'm not sure I like this idea. My one experience with forcing an array method to do double duty as varargs method was a disaster. The method was Arrays.

Re: What methods should go into a java.util.Objects class in JDK 7?

2009-10-13 Thread Alan Bateman
Ulf Zibis wrote: : In java.nio.file.Filesystem b72 I don't find information about sharing attributes. These are provider specific open options so they aren't in the javadoc. If you look at the dosSharingOptionTests in jdk/test/java/nio/Path/SBC.java you will see tests for these options. -Ala