Re: Code review request for 4206909 : adding Z_SYNC_FLUSH support to deflaters

Thanks, Sherman, This looks fine to me. [+ Brandon Long, who deserves more credit than I] Martin On Tue, Oct 20, 2009 at 14:54, Xueming Shen wrote: > Martin, Alan. > > Finally got the CCC approval. Here is the final webrev > > http://cr.openjdk.java.net/~sherman/4206909/webrev > > The only diff

Re: Code review request for 6891113: More methods for java.util.Objects: deepEquals, hash, toString with default

Neal Gafter wrote: There should be a shortcut in Arrays.deepEquals0 when e1==e2. That shortcut is in Objects.deepEquals(Object a, Object b) and Arrays.deepEquals on lines 3947 and 3948. The nested call in deepEquals0 is to deepEquals rather than deepEquals0 so the shortcut is used on all l

Re: Code review request for 6891113: More methods for java.util.Objects: deepEquals, hash, toString with default

There should be a shortcut in Arrays.deepEquals0 when e1==e2. Also, the code will throw an assertion error if e1!=null and e2==null (which can occur when called from Arrays.deepEquals). The simplest way to fix these is to move the if statements from Objects.deepEquals into Arrays.deepEquals0. Alt

Code review request for 6891113: More methods for java.util.Objects: deepEquals, hash, toString with default

Hello. Please review this webrev to add deepEquals(Object, Object), hash(Object...) and toString(Object, String) to j.u.Objects: 6891113 More methods for java.util.Objects: deepEquals, hash, toString with default http://cr.openjdk.java.net/~darcy/6891113.0/ Thanks, -Joe

Re: Why does the for each loop doesn't work with naturals?

Maybe better post to coin-...@openjdk.java.net. -Ulf Am 21.10.2009 22:33, Paulo Levi schrieb: For example: for(int i : intNumberVariable)

Why does the for each loop doesn't work with naturals?

For example: for(int i : intNumberVariable)

hg: jdk7/tl/jdk: 3 new changesets

Changeset: a88ca066dad4 Author:sherman Date: 2009-10-21 11:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a88ca066dad4 6878475: Better syntax for the named capture group in regex Summary: Updated the syntax of the newly added named capture group Reviewed-by: martin, alanb

Re: Code review request for 4206909 : adding Z_SYNC_FLUSH support to deflaters

Thanks Alan, the webrev has been updated according. http://cr.openjdk.java.net/~sherman/4206909/webrev sherman Alan Bateman wrote: Xueming Shen wrote: Martin, Alan. Finally got the CCC approval. Here is the final webrev http://cr.openjdk.java.net/~sherman/4206909/webrev The only difference

hg: jdk7/tl/jdk: 6560935: BigInteger.modPow() throws ArithmeticException for negative exponent

Changeset: 98558a60c555 Author:darcy Date: 2009-10-21 09:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98558a60c555 6560935: BigInteger.modPow() throws ArithmeticException for negative exponent Reviewed-by: alanb ! src/share/classes/java/math/BigInteger.java

hg: jdk7/tl/jdk: 3 new changesets

Changeset: 44fa9caa1727 Author:chegar Date: 2009-10-21 15:41 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/44fa9caa1727 6893238: Move NTLM and SPNEGO implementations into separate packages Reviewed-by: michaelm, alanb ! make/java/net/Makefile ! make/sun/net/FILES_java.gmk !

hg: jdk7/tl/jdk: 6851617: Remove JSR 255 (JMX API 2.0) from JDK 7

Changeset: f23a3ae59169 Author:emcmanus Date: 2009-10-21 17:33 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f23a3ae59169 6851617: Remove JSR 255 (JMX API 2.0) from JDK 7 Summary: See http://weblogs.java.net/blog/2009/06/16/jsr-255-jmx-api-20-postponed Reviewed-by: dfuchs

Re: Review request for 6878475: Better regex named-group and backreference syntax

Xueming Shen wrote: Alan, Martin The CCC also approved this change. Would you please help review? There is no doc/impl change in the webrev since you guys reviewed (for CCC) last time. http://cr.openjdk.java.net/~sherman/6878475/webrev Thanks, Sherman This looks good to me. -Alan

hg: jdk7/tl/jdk: 6893702: Overhaul of Ftp Client internal code

Changeset: 75c453fa1aa1 Author:jccollet Date: 2009-10-21 16:28 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/75c453fa1aa1 6893702: Overhaul of Ftp Client internal code Summary: Major reorg of internal FTP client code Reviewed-by: chegar ! make/sun/net/FILES_java.gmk ! src/s

Re: Code review request for 4206909 : adding Z_SYNC_FLUSH support to deflaters

Xueming Shen wrote: Martin, Alan. Finally got the CCC approval. Here is the final webrev http://cr.openjdk.java.net/~sherman/4206909/webrev The only difference compared to the webrev you guys reviewed last time at http://cr.openjdk.java.net/~sherman/zipflush/webrev is to use the Google copy

Re: Code review request for 6560935: BigInteger.modPow() throws ArithmeticException for negative exponent

Joseph D. Darcy wrote: Hello. Please review this small doc clarification; modPow is not defined for negative exponents unless the BigInteger being operated on is relatively prime to the modulus. There are a few stylistic javadoc cleanups in the patch below too. Webrev: http://cr.openjdk.ja

hg: jdk7/tl/jdk: 6873543: CookieManager doesn't enforce httpOnly

Changeset: 5ab37d9d9260 Author:jccollet Date: 2009-10-21 13:42 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5ab37d9d9260 6873543: CookieManager doesn't enforce httpOnly Summary: Adds check for httpOnly tag and clarifies javadoc Reviewed-by: chegar ! src/share/classes/java/

hg: jdk7/tl/jdk: 6893426: ShellScaffold.sh fails on Solaris 10 update releases: /usr/bin/id: illegal option -- u

Changeset: b0433598e26d Author:tbell Date: 2009-10-21 00:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b0433598e26d 6893426: ShellScaffold.sh fails on Solaris 10 update releases: /usr/bin/id: illegal option -- u Reviewed-by: ohair, dcubed ! test/com/sun/jdi/ShellScaffol