Andrew John Hughes wrote:
2009/11/3 Joseph D. Darcy :
Hello.
Please review this simple change to replace several calls to val.length()
with an already cached copy of val.length(); patch below.
6897550 BigInteger constructor should use local cached String length
http://cr.openjdk.java.net/~d
On Tue, Nov 3, 2009 at 01:06, Rémi Forax wrote:
> Hi Martin,
> Your patch can break backward compat.
>
> add(E) now delegates to a public method (an overridable one)
> (addLast). So If I have a class that inherits from LinkedList
> and overrides addLast() the current semantics of add(E) is not al
Thanks Joe, looks good.
-Chris.
Joseph D. Darcy wrote:
Hello.
Please review this simple change to replace several calls to
val.length() with an already cached copy of val.length(); patch below.
6897550 BigInteger constructor should use local cached String length
http://cr.openjdk.java.net/~
Hello.
Please review this simple change to replace several calls to
val.length() with an already cached copy of val.length(); patch below.
6897550 BigInteger constructor should use local cached String length
http://cr.openjdk.java.net/~darcy/6897550.0/
-Joe
--- old/src/share/classes/java/mat
Changeset: e740080fd1a4
Author:darcy
Date: 2009-11-03 15:01 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e740080fd1a4
6897550: BigInteger constructor should use local cached String length
Reviewed-by: andrew, chegar
! src/share/classes/java/math/BigInteger.java
2009/11/3 Joseph D. Darcy :
> Hello.
>
> Please review this simple change to replace several calls to val.length()
> with an already cached copy of val.length(); patch below.
>
> 6897550 BigInteger constructor should use local cached String length
> http://cr.openjdk.java.net/~darcy/6897550.0/
>
>
Martin Buchholz wrote:
I would like to contribute an improvement to LinkedList
webrev:
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/LinkedList/
Josh, Bill and I have discussed this offline,
and they have given their blessing.
(i.e. I am not asking for reviewers)
I apologize for this -
Le 03/11/2009 03:29, Martin Buchholz a écrit :
I would like to contribute an improvement to LinkedList
webrev:
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/LinkedList/
Josh, Bill and I have discussed this offline,
and they have given their blessing.
(i.e. I am not asking for reviewers)