Re: final transient fields serialization

2009-12-03 Thread Tom Hawtin
Peter Jones wrote: Regarding a language solution, though, I don't see how to avoid making a [...] `readObject` is a `psuedo-constructor`. Ideally it would be a real constructor (with choice of defaultReadObject/readFields similar to super), but that would require significant changes to the

Re: Gap Buffer based AbstractStringBuilder implementation

2009-12-03 Thread Goktug Gokdogan
On Tue, Dec 1, 2009 at 2:16 AM, Martin Buchholz marti...@google.com wrote: On Thu, Nov 26, 2009 at 00:57, Goktug Gokdogan gokdo...@gmail.com wrote: I think, we can overcome the slowdown. The point of my prototype is to check the general performance characteristics. Slowdown is more likely

Re: final transient fields serialization

2009-12-03 Thread David M. Lloyd
This is exactly the solution I present to users of JBoss Marshalling. The access check performed verifies that the field being updated is a non-static instance field (final or otherwise, any access level) of the caller's class; IllegalAccessException is then not thrown at runtime when the

hg: jdk7/tl/jdk: 6906854: SSL/Krb5 testcase should not use a fixed port number

2009-12-03 Thread vincent . ryan
Changeset: bc12627832e0 Author:vinnie Date: 2009-12-03 21:30 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bc12627832e0 6906854: SSL/Krb5 testcase should not use a fixed port number Reviewed-by: alanb ! test/ProblemList.txt ! test/sun/security/krb5/auto/SSL.java

hg: jdk7/tl/langtools: 6906748: Project Coin: Minor strings in switch cleanup

2009-12-03 Thread joe . darcy
Changeset: 121e0ebf1658 Author:darcy Date: 2009-12-03 14:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/121e0ebf1658 6906748: Project Coin: Minor strings in switch cleanup Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java !

Code review request for 6907177 Update jdk tests to remove unncessary -source and -target options

2009-12-03 Thread Joe Darcy
Hello. The fix for 6907177 Update jdk tests to remove unncessary -source and -target options alters about 100 regression tests in the jdk repository that have inappropriate -source options to compile code to earlier source levels. Often these directives were created in JDK 5 before the

Re: Code review request for 6907177 Update jdk tests to remove unncessary -source and -target options

2009-12-03 Thread Kelly O'Hair
Looks fine Joe. I also have some of these same changes, on the jvmti demo tests but they should merge fine when I get your changeset. -kto Joe Darcy wrote: Hello. The fix for 6907177 Update jdk tests to remove unncessary -source and -target options alters about 100 regression tests in the

hg: jdk7/tl/jdk: 6907177: Update jdk tests to remove unncessary -source and -target options

2009-12-03 Thread joe . darcy
Changeset: 1755493c5774 Author:darcy Date: 2009-12-03 18:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1755493c5774 6907177: Update jdk tests to remove unncessary -source and -target options Reviewed-by: ohair ! test/demo/jvmti/hprof/CpuOldTest.java !