Re: Bugs in java.util.ArrayList, java.util.Hashtable and java.io.ByteArrayOutputStream

2010-05-13 Thread Martin Buchholz
OK, I committed the fix for this. I also added some gratuitous tests to the new test case. Martin On Thu, May 13, 2010 at 15:46, David Holmes wrote: > CR: 6952330 Fix for 6933217 broke contract of StringBuffer.ensureCapacity > > Thanks, > David > > David Holmes said the following on 05/13/10 11:

hg: jdk7/tl/jdk: 6952330: Fix for 6933217 broke contract of StringBuffer.ensureCapacity

2010-05-13 Thread martinrb
Changeset: e85e03ef61c1 Author:martin Date: 2010-05-13 21:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e85e03ef61c1 6952330: Fix for 6933217 broke contract of StringBuffer.ensureCapacity Summary: make sure to grow with size => size * 2 + 2 Reviewed-by: dholmes, chegar, o

hg: jdk7/tl/jdk: 6951064: Typo in javadoc for ZipException ctors

2010-05-13 Thread xueming . shen
Changeset: aa1b15bdbf2b Author:sherman Date: 2010-05-13 21:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aa1b15bdbf2b 6951064: Typo in javadoc for ZipException ctors Summary: fixed the doc typo Reviewed-by: martin ! src/share/classes/java/util/zip/ZipException.java

Re: Typo in ZipException an -> a

2010-05-13 Thread Martin Buchholz
Looks good to me! On Thu, May 13, 2010 at 20:03, Xueming Shen wrote: > A trivial doc typo. > > http://cr.openjdk.java.net/~sherman/6951064/webrev > > Thanks, > -Sherman >

Typo in ZipException an -> a

2010-05-13 Thread Xueming Shen
A trivial doc typo. http://cr.openjdk.java.net/~sherman/6951064/webrev Thanks, -Sherman

hg: jdk7/tl/langtools: 6952188: update timeout for langtools jtreg tests on JPRT

2010-05-13 Thread jonathan . gibbons
Changeset: ebf09be0222c Author:jjg Date: 2010-05-13 11:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ebf09be0222c 6952188: update timeout for langtools jtreg tests on JPRT Reviewed-by: ohair ! test/Makefile

Re: signal chaining and self defence

2010-05-13 Thread Paul Hohensee
A partial answer: one of the Hotspot engineers says "I think the short answer is that chaining requires LD_PRELOAD to override the signal entry points. Otherwise we [Hotspot] wouldn't see the calls that change the signal handlers. If the Java command itself linked against jsig that would work

Re: Bugs in java.util.ArrayList, java.util.Hashtable and java.io.ByteArrayOutputStream

2010-05-13 Thread David Holmes
CR: 6952330 Fix for 6933217 broke contract of StringBuffer.ensureCapacity Thanks, David David Holmes said the following on 05/13/10 11:59: Hi Martin, Bugtraq is offline so I can't file a CR right now. The was caught by Mauve tests. Kelly sent a link to the mailing list but I don't think he's

RE: Re[4]: New portion of improvements for Dual-Pivot Quicksort

2010-05-13 Thread Dmytro Sheyko
Yes. I prefer F (Find First zero using binary search) over C (Count negatives) and S (Smart Scan for zero). > From: iaroslav...@mail.ru > To: dmytro_she...@hotmail.com > CC: j...@google.com; core-libs-dev@openjdk.java.net; iaroslav...@mail.ru > Subject: Re[4]: New portion of improvements for Dua

Re[4]: New portion of improvements for Dual-Pivot Quicksort

2010-05-13 Thread Vladimir Iaroslavski
Dmytro, I've tested your suggested variants, and found that case "C" (very interesting approach to find first position of zero by counting negative elements) works slower than original or two other cases. Implementations "F" and "S" are very close to each other and little bit faster than original

hg: jdk7/tl/jdk: 6951887: Wrong redirection useage in test sun/nio/cs/Test4200310.sh

2010-05-13 Thread ptisnovs
Changeset: f6b72c9023f4 Author:ptisnovs Date: 2010-05-13 10:11 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f6b72c9023f4 6951887: Wrong redirection useage in test sun/nio/cs/Test4200310.sh Summary: Testcase correction. Reviewed-by: sherman ! test/sun/nio/cs/Test4200310.sh

Re: 4813885: RFE: GZIPOutputStream should implement flush using Z_SYNC_FLUSH

2010-05-13 Thread Xueming Shen
Martin Buchholz wrote: On Wed, May 12, 2010 at 23:46, Xueming Shen wrote: Thanks for the review. The Z_SYNC_FLUSH is supposed to fully replace the Z_PARTIAL_FLUSH. We concluded last round that Z_SYNC_FLUSH is enough for the "high-level" DOS, as well as the GZIPOS, use Deflater directly if