Review request for 6961894: TEST_BUG: jdk_lang tests fail in samevm mode

2010-06-17 Thread Mandy Chung
Another patch of test fixes - with these fixes, there are now 5 remaining tests in ProblemList.txt excluded for jdk_lang test target. 6961894: TEST_BUG: jdk_lang tests fail in samevm mode Webrev at: http://cr.openjdk.java.net/~mchung/6961894/webrev.00/ - Some tests are marked to run in

hg: jdk7/tl/jdk: 6961408: test/java/util/logging/ParentLoggersTest.java fails in samevm mode

2010-06-17 Thread mandy . chung
Changeset: c995607e7719 Author:mchung Date: 2010-06-16 23:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c995607e7719 6961408: test/java/util/logging/ParentLoggersTest.java fails in samevm mode Summary: Check against the list of loggers added since the test begins to run

Re: Review request for 6961894: TEST_BUG: jdk_lang tests fail in samevm mode

2010-06-17 Thread Alan Bateman
Mandy Chung wrote: Another patch of test fixes - with these fixes, there are now 5 remaining tests in ProblemList.txt excluded for jdk_lang test target. 6961894: TEST_BUG: jdk_lang tests fail in samevm mode Webrev at: http://cr.openjdk.java.net/~mchung/6961894/webrev.00/ - Some tests are

6962045: TEST_BUG: Tests in test/java/io/Serializable leave files open

2010-06-17 Thread Alan Bateman
Many of the serialization tests leave files open and this causes problems, particularly on Windows, when running these tests in jtreg samevm mode. One failure can cascade and cause all subsequent tests to fail. I've taken a pass over these tests so that all 115 now pass in this mode. The

TEST_BUG: Tests in java/util/zip/ZipFile leave file open

2010-06-17 Thread Xueming Shen
These tests leave either ZipFile or io stream open after testing, fail in samevm mode, so are not in ProblemList.txt now. With the change they now all pass. http://cr.openjdk.java.net/~sherman/6962067/webrev Thanks, -Sherman

Re: Review request for 6961894: TEST_BUG: jdk_lang tests fail in samevm mode

2010-06-17 Thread Mandy Chung
Alan Bateman wrote: Mandy Chung wrote: Another patch of test fixes - with these fixes, there are now 5 remaining tests in ProblemList.txt excluded for jdk_lang test target. 6961894: TEST_BUG: jdk_lang tests fail in samevm mode Webrev at:

hg: jdk7/tl/jdk: 6395224: (so) SocketChannel writer blocked on large buffer is not preempted by close method (vista)

2010-06-17 Thread alan . bateman
Changeset: 1281181df71b Author:alanb Date: 2010-06-17 17:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1281181df71b 6395224: (so) SocketChannel writer blocked on large buffer is not preempted by close method (vista) Reviewed-by: chegar !

Re: TEST_BUG: Tests in java/util/zip/ZipFile leave file open

2010-06-17 Thread Alan Bateman
Xueming Shen wrote: These tests leave either ZipFile or io stream open after testing, fail in samevm mode, so are not in ProblemList.txt now. With the change they now all pass. http://cr.openjdk.java.net/~sherman/6962067/webrev Thanks, -Sherman Good to see more tests coming off the problem

Re: TEST_BUG: Tests in java/util/zip/ZipFile leave file open

2010-06-17 Thread Rémi Forax
Le 17/06/2010 17:31, Xueming Shen a écrit : These tests leave either ZipFile or io stream open after testing, fail in samevm mode, so are not in ProblemList.txt now. With the change they now all pass. http://cr.openjdk.java.net/~sherman/6962067/webrev Thanks, -Sherman Looks good to me.

Re: TEST_BUG: Tests in java/util/zip/ZipFile leave file open

2010-06-17 Thread Xueming Shen
Thanks for the review. InfoZip fails gracefully (increase the failed number) when test fails, and if there is an unexpected IO failure/exception the test fails anyway. So I did not add the try/finally/close pattern. But, it does not hurt to do that, so I added suggested anyway. Same thing

Re: TEST_BUG: Tests in java/util/zip/ZipFile leave file open

2010-06-17 Thread Alan Bateman
Xueming Shen wrote: Thanks for the review. InfoZip fails gracefully (increase the failed number) when test fails, and if there is an unexpected IO failure/exception the test fails anyway. So I did not add the try/finally/close pattern. But, it does not hurt to do that, so I added suggested

Re: TEST_BUG: Tests in java/util/zip/ZipFile leave file open

2010-06-17 Thread Xueming Shen
It looks much better/neater:-) Thanks, Sherman Alan Bateman wrote: Xueming Shen wrote: Thanks for the review. InfoZip fails gracefully (increase the failed number) when test fails, and if there is an unexpected IO failure/exception the test fails anyway. So I did not add the

hg: jdk7/tl/jdk: 6962067: TEST_BUG: Tests in java/util/zip/ZipFile leave file open

2010-06-17 Thread xueming . shen
Changeset: 5e4547833379 Author:sherman Date: 2010-06-17 13:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5e4547833379 6962067: TEST_BUG: Tests in java/util/zip/ZipFile leave file open Summary: Close zipfile and io stream when done Reviewed-by: alanb !

hg: jdk7/tl/jdk: 6869741: Integrate JAX-WS 2.2 and JAXB 2.2 in JDK 7

2010-06-17 Thread kelly . ohair
Changeset: 006e852b692e Author:ohair Date: 2010-06-17 14:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/006e852b692e 6869741: Integrate JAX-WS 2.2 and JAXB 2.2 in JDK 7 Reviewed-by: ramap ! make/docs/CORE_PKGS.gmk

hg: jdk7/tl/jaxws: 2 new changesets

2010-06-17 Thread kelly . ohair
Changeset: 38fd32b8e990 Author:ohair Date: 2010-06-17 17:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/38fd32b8e990 6869741: Integrate JAX-WS 2.2 and JAXB 2.2 in JDK 7 Reviewed-by: darcy, ramap ! jaxws.properties Changeset: 48872561d4b1 Author:ohair Date:

hg: jdk7/tl/jaxp: 2 new changesets

2010-06-17 Thread kelly . ohair
Changeset: 214f47923c24 Author:ohair Date: 2010-06-17 10:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/214f47923c24 6955301: Update names and references to rebranded drop bundles (jaxp, jaxws, jaf) Reviewed-by: darcy ! jaxp.properties Changeset: 961ad5ff3b19 Author: