Re: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-02 Thread Martin Buchholz
On Thu, Sep 2, 2010 at 17:50, Joe Darcy wrote: > Martin Buchholz wrote: > >> The usage T[] suggests that T is a reference type, as with generics, which >> is not the case here. >> >> More precisely, both the runtime types and compiletime types of the object >> returned from clone of any array is

hg: jdk7/tl/langtools: 6458823: Messager messages on TypeParamterElements to not include position information.

2010-09-02 Thread sundararajan . a
Changeset: 25dd23fa2511 Author:sundar Date: 2010-09-03 11:25 +0530 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/25dd23fa2511 6458823: Messager messages on TypeParamterElements to not include position information. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/tr

hg: jdk7/tl/langtools: 6921495: spurious semicolons in class def cause empty NOPOS blocks

2010-09-02 Thread jonathan . gibbons
Changeset: 3ff3f20471b4 Author:jjg Date: 2010-09-02 18:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3ff3f20471b4 6921495: spurious semicolons in class def cause empty NOPOS blocks Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.

Re: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-02 Thread Ulf Zibis
Am 03.09.2010 02:50, schrieb Joe Darcy: Martin Buchholz wrote: The usage T[] suggests that T is a reference type, as with generics, which is not the case here. More precisely, both the runtime types and compiletime types of the object returned from clone of any array is identical to its inp

Re: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-02 Thread Joe Darcy
Martin Buchholz wrote: The usage T[] suggests that T is a reference type, as with generics, which is not the case here. More precisely, both the runtime types and compiletime types of the object returned from clone of any array is identical to its input. Is there a non-confusing way of saying

Re: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-02 Thread Martin Buchholz
The usage T[] suggests that T is a reference type, as with generics, which is not the case here. More precisely, both the runtime types and compiletime types of the object returned from clone of any array is identical to its input. Is there a non-confusing way of saying that? Martin On Thu, Sep

Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-02 Thread Joe Darcy
Hello. Please review my spec clarification fix for 4881419 "The type of X[].clone() should be X[]" http://cr.openjdk.java.net/~darcy/4881419/ The statement about the return type of the clone method for an array is given in JLSv3 section 6.4.5: http://java.sun.com/docs/books/jls/third_ed

hg: jdk7/tl/langtools: 6458749: TypeParameterElement.getEnclosedElements throws NPE within javac.

2010-09-02 Thread sundararajan . a
Changeset: f37253c9e082 Author:sundar Date: 2010-09-02 23:10 +0530 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f37253c9e082 6458749: TypeParameterElement.getEnclosedElements throws NPE within javac. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java