Do it as two commits (one for diamond, the other for line formatting)
that way you can keep the work separate. You may even want 2 Sun
tracking issue in case you need to do several commits under one issue.
Paul
On Thu, Dec 16, 2010 at 10:43 PM, Joe Darcy joe.da...@oracle.com wrote:
On
On 12/17/10 6:54 AM, Paul Benedict wrote:
Do it as two commits (one for diamond, the other for line formatting)
that way you can keep the work separate. You may even want 2 Sun
tracking issue in case you need to do several commits under one issue.
The jcheck rules *require* a separate bug ID
On 12/17/2010 11:57 AM, Stuart Marks wrote:
On 12/17/10 6:54 AM, Paul Benedict wrote:
Do it as two commits (one for diamond, the other for line formatting)
that way you can keep the work separate. You may even want 2 Sun
tracking issue in case you need to do several commits under one issue.
On 12/16/10 7:14 PM, Stuart Marks wrote:
I've run the line joiner and it changed ten files. Here's an
incremental webrev, over and above yesterday's:
http://cr.openjdk.java.net/~smarks/reviews/6880112/webrev.1/
Looks good to me.
Mandy
All changes look good to me.
On Dec 16 2010, at 19:14 , Stuart Marks wrote:
I've run the line joiner and it changed ten files. Here's an incremental
webrev, over and above yesterday's:
http://cr.openjdk.java.net/~smarks/reviews/6880112/webrev.1/
I've posted a webrev for review at
http://cr.openjdk.java.net/~mduigou/6728865.0/webrev/
which improves the behaviour of Collections.disjoint() when the collection c1
is not a Set and is larger than c2.
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6728865
I've included some other
