Re: SocketPermission's implies() interesting behavior

2011-02-18 Thread Chris Hegarty
[ bcc'ing off core-libs-dev and cc'ing (more appropriate) net-dev ] Hi Charles, I'm not sure I follow you here. I would not expect '*.java.net' to imply 'java.net'. I would however expect it to imply sub domains of java.net, i.e. openjdk.java.net -Chris. On 17/02/2011 09:19, Charles Lee wro

Re: hg: jdk7/tl/langtools: 7020047: Project Coin: generate null-check around try-with-resources close call

2011-02-18 Thread Paul Benedict
Joe, I like how you snuck a little tribute to Leslie Nielsen in the test: "Nothing to see here, move along" http://www.youtube.com/watch?v=5NNOrp_83RU On Fri, Feb 18, 2011 at 5:55 PM, wrote: > Changeset: 75e25df50873 > Author:darcy > Date: 2011-02-18 15:55 -0800 > URL: http://hg.o

hg: jdk7/tl/langtools: 7020047: Project Coin: generate null-check around try-with-resources close call

2011-02-18 Thread joe . darcy
Changeset: 75e25df50873 Author:darcy Date: 2011-02-18 15:55 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/75e25df50873 7020047: Project Coin: generate null-check around try-with-resources close call Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.j

hg: jdk7/tl/jdk: 7018385: update javax.sql classes to use try-with-resources

2011-02-18 Thread stuart . marks
Changeset: 5bf920749b97 Author:smarks Date: 2011-02-18 12:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5bf920749b97 7018385: update javax.sql classes to use try-with-resources Reviewed-by: alanb, lancea, darcy ! src/share/classes/javax/sql/rowset/serial/SerialClob.java

Re: Zlib level in JDK7

2011-02-18 Thread Alan Bateman
Steve Poole wrote: : Running zlibs own tests is unlikely to be too helpful. I'd be quite happy to run any JDK tests you have and there are also testcases in Apache Harmony for the related Java APIs. I'm curious to understand just what level of testing is already done though? I wasn't clear

Re: Zlib level in JDK7

2011-02-18 Thread Steve Poole
On Thu, 2011-02-17 at 10:20 +, Alan Bateman wrote: > Steve Poole wrote: > > : > > What sort of testing did you have in mind? You mean run the zlib tests > > and/or OpenJDK testcases? > > > To be honest, I don't know. The zip tests should clearly be run but they > are unlikely to stress th

hg: jdk7/tl/langtools: 7020626: diamond: add diagnostic test for diamond and non-generic classes

2011-02-18 Thread maurizio . cimadamore
Changeset: 51e643f41a3a Author:mcimadamore Date: 2011-02-18 16:17 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/51e643f41a3a 7020626: diamond: add diagnostic test for diamond and non-generic classes Summary: Fix failure in regression test CheckExamples Reviewed-by: jjg

hg: jdk7/tl/langtools: 7018859: javac turn off the Zip optimization by default

2011-02-18 Thread kumar . x . srinivasan
Changeset: 3d45cc94ee0f Author:ksrini Date: 2011-02-18 08:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3d45cc94ee0f 7018859: javac turn off the Zip optimization by default Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! test/t

Re: SocketPermission's implies() interesting behavior

2011-02-18 Thread Alan Bateman
Charles Lee wrote: Hi guys, I am reading the SocketPermission source code recently and find some thing strange. It might be better to bring this to the net-dev list as that is where the networking code, including SocketPermission, is maintained. -Alan.

hg: jdk7/tl/langtools: 7020043: Project Coin: diamond allowed on non-generic type

2011-02-18 Thread maurizio . cimadamore
Changeset: 4ce95dc0b908 Author:mcimadamore Date: 2011-02-18 12:28 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4ce95dc0b908 7020043: Project Coin: diamond allowed on non-generic type Summary: Diamond oerator should be disallowed on non-generic class types (i.e. Strin