Re: Review CR #6611830: UUID thread-safety and performance improvements

2011-02-23 Thread Vitaly Davidovich
resending as I just realized I replied only to Brian. On Wed, Feb 23, 2011 at 12:19 AM, Vitaly Davidovich vita...@gmail.comwrote: Hi David/Brian, Yes, I meant whether the entire string.hashcode technique can be used, including the default zero values. I agree on the initial -1 assignment

java.util.Objects.requireNonNull: an opportunity for NullArgumentException?

2011-02-23 Thread Martin Desruisseaux
Hello all I apologize if this question was already debated previously. I just wonder: since JDK 7 defines an Object.requireNonNull(…) method for explicit checks of argument value, does the Project-Coin expert group has considered the addition of an explicit NullArgumentException extends

hg: jdk7/tl/jdk: 7017493: ConcurrentLinkedDeque: Unexpected initialization order can lead to crash due to use of Unsafe

2011-02-23 Thread chris . hegarty
Changeset: 892c3fc7249e Author:dl Date: 2011-02-23 14:56 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/892c3fc7249e 7017493: ConcurrentLinkedDeque: Unexpected initialization order can lead to crash due to use of Unsafe Reviewed-by: chegar !

Re: Review CR #6611830: UUID thread-safety and performance improvements

2011-02-23 Thread Brian Goetz
Ignore my comment -- I was reading the diffs backwards :( On 2/22/2011 11:53 PM, Brian Goetz wrote: I think you have a potential visibility problem here. You use -1 as the initial value, but observing threads might see instead the default value if the initializing write is not visible, and

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-02-23 Thread Rama Pulavarthi
Hi Alan, On 2/23/11 12:44 AM, Alan Bateman wrote: Rama Pulavarthi wrote: Hi, Need reviewer for CR 7020513: Add com.sun.xml.internal to the package.access property in $JAVA_HOME/lib/security/java.security Webrev is available at

hg: jdk7/tl/jaxws: Added tag jdk7-b130 for changeset ba1fac1c2083

2011-02-23 Thread lana . steuck
Changeset: a8ffd75ad5df Author:cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/a8ffd75ad5df Added tag jdk7-b130 for changeset ba1fac1c2083 ! .hgtags

hg: jdk7/tl/langtools: 7 new changesets

2011-02-23 Thread lana . steuck
Changeset: 2cbaa43eb075 Author:lana Date: 2011-02-14 16:31 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2cbaa43eb075 Merge - test/tools/javac/TryWithResources/TwrInference.java - test/tools/javac/TryWithResources/TwrIntersection.java -

hg: jdk7/tl/corba: 5 new changesets

2011-02-23 Thread lana . steuck
Changeset: 30ecf5c90a30 Author:mfang Date: 2011-02-10 11:07 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/30ecf5c90a30 7014477: pt_BR corba resource bundle is missing in jdk7 build Reviewed-by: ohair ! make/common/Defs.gmk Changeset: c08dff674e53 Author:mfang Date:

hg: jdk7/tl: 9 new changesets

2011-02-23 Thread lana . steuck
Changeset: 995077c73fbb Author:cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/995077c73fbb Added tag jdk7-b130 for changeset cc58c11af154 ! .hgtags Changeset: 0fd0aeb592cb Author:jqzuo Date: 2010-12-09 10:58 -0500 URL:

hg: jdk7/tl/jaxp: Added tag jdk7-b130 for changeset ab107c1bc4b9

2011-02-23 Thread lana . steuck
Changeset: f2ad604323c0 Author:cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/f2ad604323c0 Added tag jdk7-b130 for changeset ab107c1bc4b9 ! .hgtags

hg: jdk7/tl/hotspot: 26 new changesets

2011-02-23 Thread lana . steuck
Changeset: b7a938236e43 Author:tonyp Date: 2011-01-31 16:28 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b7a938236e43 7014679: G1: deadlock during concurrent cleanup Summary: There's a potential deadlock between the concurrent cleanup thread and the GC workers that

hg: jdk7/tl/jdk: 40 new changesets

2011-02-23 Thread lana . steuck
Changeset: bad0ddc6f573 Author:prr Date: 2011-01-26 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bad0ddc6f573 7014738: Update jdk repo application manifests with Windows 7 compatibility section. Reviewed-by: bae, igor ! src/windows/resource/java.manifest

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-02-23 Thread Alan Bateman
Rama Pulavarthi wrote: : Just porting the fix along with tests from Open JDK 6 workspace, that's why I kept the old date. Does it need to be changed? This test was added then following the convention of other tests. I will check other tests in JDK 7 to see if it needs any update. Sorry

review request for 7021582, use try-with-resources in jar/zip implementation and tests

2011-02-23 Thread Stuart Marks
Hi Sherman, all, Here's a webrev to convert code in the jar/zip implementation files and tests to use the new Java 7 try-with-resources construct. http://cr.openjdk.java.net/~smarks/reviews/7021582/webrev.0/ There are rather a lot of files, however, most of the changes are pretty

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

2011-02-23 Thread Xueming Shen
Kumar, Would you please help review the change in your pack code? Thanks, -Sherman On 2011-2-23 22:26, Stuart Marks wrote: Hi Sherman, all, Here's a webrev to convert code in the jar/zip implementation files and tests to use the new Java 7 try-with-resources construct.

hg: jdk7/tl/jdk: 6844879: Source distribution should be more robustly built without the security source distribution

2011-02-23 Thread bradford . wetmore
Changeset: 0f0d6b8f98cc Author:wetmore Date: 2011-02-23 22:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f0d6b8f98cc 6844879: Source distribution should be more robustly built without the security source distribution Reviewed-by: ohair !

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

2011-02-23 Thread David Holmes
Hi Stuart, Just taking a look as a curious observer ... I'm somewhat dismayed by the lack of exception handling in the original code. Stuart Marks said the following on 02/24/11 16:26: * src/share/classes/com/sun/java/util/jar/pack/Driver.java I narrowed the scope of the open resource. No