Re: review request for 7022624, convert java.io test to use try-with-resources

2011-03-01 Thread Rémi Forax
On 03/01/2011 11:26 PM, Stuart Marks wrote: On 3/1/11 7:28 AM, Rémi Forax wrote: Le 01/03/2011 10:46, Alan Bateman a écrit : Stuart Marks wrote: Here's a small webrev with changes to a handful of java.io tests to use TWR. http://cr.openjdk.java.net/~smarks/reviews/7022624/webrev.0/ * test

hg: jdk7/tl/jdk: 7022624: use try-with-resources in java.io tests

2011-03-01 Thread stuart . marks
Changeset: 98d2d57d9e73 Author:smarks Date: 2011-03-01 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98d2d57d9e73 7022624: use try-with-resources in java.io tests Reviewed-by: alanb ! test/java/io/File/SetLastModified.java ! test/java/io/FileOutputStream/AtomicAppend.

Re: review request for 7022624, convert java.io test to use try-with-resources

2011-03-01 Thread Stuart Marks
On 3/1/11 7:28 AM, Rémi Forax wrote: Le 01/03/2011 10:46, Alan Bateman a écrit : Stuart Marks wrote: Here's a small webrev with changes to a handful of java.io tests to use TWR. http://cr.openjdk.java.net/~smarks/reviews/7022624/webrev.0/ * test/java/io/OutputStreamWriter/Encode.java Prett

Re: review request for 7022624, convert java.io test to use try-with-resources

2011-03-01 Thread Stuart Marks
On 3/1/11 1:46 AM, Alan Bateman wrote: Stuart Marks wrote: Here's a small webrev with changes to a handful of java.io tests to use TWR. http://cr.openjdk.java.net/~smarks/reviews/7022624/webrev.0/ [snip] * test/java/io/OutputStreamWriter/Encode.java Pretty clearly a ServerSocket is a disti

hg: jdk7/tl/langtools: 7021183: 269: assertion failure getting enclosing element of an undefined name

2011-03-01 Thread jonathan . gibbons
Changeset: 938dda0bec17 Author:jjg Date: 2011-03-01 12:00 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/938dda0bec17 7021183: 269: assertion failure getting enclosing element of an undefined name Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Sy

Re: Support for Turkish locale

2011-03-01 Thread Naoto Sato
As Phil said, Turkish is not in the "User Interface Translation" list that Oracle JRE provides (http://www.oracle.com/technetwork/java/javase/locales-137662.html#translation). So you won't see FileChooser UI texts in Turkish even in Turkish locale. The second issue you raised is a bit differen

Re: Support for Turkish locale

2011-03-01 Thread Phil Race
I should clarify that Alan is correct that the i18n-dev list is the more appropriate place to raise this as its the right place to discuss I18N and L10N .. since I don't know of any L10N list. -phil. On 3/1/2011 7:40 AM, Phil Race wrote: This is a localisation issue (not internationalisation i

Re: review request for 7022624, convert java.io test to use try-with-resources

2011-03-01 Thread Alan Bateman
Rémi Forax wrote: : try (ServerSocket listener = ss; Socket s = listener.accept(); BufferedReader reader = new BufferedReader(new InputStreamReader(s.getInputStream())) { ... } While you are there, I assume ss should be final. Local variables declared in a try-with resources

RE: Crash in ntdll.dll due to JdbcOdbcConnection

2011-03-01 Thread Jason Mehrens
> Lance is the best person to comment on this but I don't think the > JDBC-ODBC bridge has been maintained for a few years and probably isn't > up to the latest JDBC version. No problem proposing a patch but I just > wonder if it is actually used these days. The only thing I've used the JDBC-O

Re: Support for Turkish locale

2011-03-01 Thread Phil Race
This is a localisation issue (not internationalisation issue as Alan suggested). but the bottom line is whilst many locales are supported that does not mean that user interface messages are translated into all those locales. There's a huge cost issue behind that. There was an openjdk project to a

Re: review request for 7022624, convert java.io test to use try-with-resources

2011-03-01 Thread Rémi Forax
Le 01/03/2011 10:46, Alan Bateman a écrit : Stuart Marks wrote: Here's a small webrev with changes to a handful of java.io tests to use TWR. http://cr.openjdk.java.net/~smarks/reviews/7022624/webrev.0/ * test/java/io/OutputStreamWriter/Encode.java Pretty clearly a ServerSocket is a dis

Re: How to find IBM's contributions?

2011-03-01 Thread Paul Benedict
Steve, I worked with WebSphere for a long time and IBM's JDK class files (via the source code) were very interesting to read. I find it fascinating to see how companies diverge and converge on similar bugs. I wonder if any of those fixes in IBM's JDK will backport into OpenJDK? This project is all

Re: Crash in ntdll.dll due to JdbcOdbcConnection

2011-03-01 Thread Alan Bateman
Lance Andersen - Oracle wrote: : If you want to contribute a fix, I will look to include it when I have a cycle. Silly me, I remembered something after replying - the JDBC-ODBC bridge isn't in the jdk repository, it's somewhere else and I think only ever shipped with the proprietary releases.

Re: Crash in ntdll.dll due to JdbcOdbcConnection

2011-03-01 Thread Lance Andersen - Oracle
Alan is correct, we do not officially support the bridge, from: http://download.oracle.com/javase/6/docs/technotes/guides/jdbc/bridge.html: Status of the JDBC-ODBC Bridge The JDBC-ODBC Bridge should be considered a transitional solution. Sun Microsystems and DataDirect Technologies are working

hg: jdk7/tl/jdk: 7023034: Files.createTempDirectory((Path)null, "temp") does not throw NPE

2011-03-01 Thread alan . bateman
Changeset: b7e763a573a4 Author:alanb Date: 2011-03-01 12:03 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b7e763a573a4 7023034: Files.createTempDirectory((Path)null, "temp") does not throw NPE Reviewed-by: forax ! src/share/classes/java/nio/file/Files.java ! test/java/nio/f

Re: Crash in ntdll.dll due to JdbcOdbcConnection

2011-03-01 Thread Alan Bateman
Jing LV wrote: Hello, I've found a bug, and find it already raised as Oracle Bug 7002634: Crash in ntdll.dll RtlEnterCriticalSection due to race condition in JdbcOdbcConnection. However it's been deferred. I believe I can provide a fix for this, would someone help me? Thanks! Lance is the be

Re: Support for Turkish locale

2011-03-01 Thread Alan Bateman
Jing LV wrote: Hello, I've found several problem while using OpenJDK under Turkish Locale. I don't know if the folks that maintain this area on this list, you might be better to bring it to i18n-dev. -Alan

Crash in ntdll.dll due to JdbcOdbcConnection

2011-03-01 Thread Jing LV
Hello, I've found a bug, and find it already raised as Oracle Bug 7002634: Crash in ntdll.dll RtlEnterCriticalSection due to race condition in JdbcOdbcConnection. However it's been deferred. I believe I can provide a fix for this, would someone help me? Thanks! -- Best Regards, Jimmy, Jing LV

Re: How to find IBM's contributions?

2011-03-01 Thread Steve Poole
On Fri, 2011-02-25 at 14:15 -0600, Paul Benedict wrote: > To the community, > > Is there any easily identifiable way to determine when IBM contributes > fixes/patches to the repositories? I know all Oracle employees have Oracle > email addresses. What about those from IBM? I was hoping to see what

Support for Turkish locale

2011-03-01 Thread Jing LV
Hello, I've found several problem while using OpenJDK under Turkish Locale. For some examples: (All testcase should run with parameter -Duser.language=tr -Duser.region=TR) public static void main(String args[]) { System.out.println(" locale :" + Locale.getDefault());

Re: review request for 7022624, convert java.io test to use try-with-resources

2011-03-01 Thread Alan Bateman
Stuart Marks wrote: Here's a small webrev with changes to a handful of java.io tests to use TWR. http://cr.openjdk.java.net/~smarks/reviews/7022624/webrev.0/ I have a few minor questions: * test/java/io/File/SetLastModified.java Should the channel corresponding to a stream be considered a se

hg: jdk7/tl/jdk: 7020531: test: java/security/cert/CertificateFactory/openssl/OpenSSLCert.java file not closed after run

2011-03-01 Thread weijun . wang
Changeset: f8bf888edf20 Author:weijun Date: 2011-03-01 16:22 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f8bf888edf20 7020531: test: java/security/cert/CertificateFactory/openssl/OpenSSLCert.java file not closed after run Reviewed-by: alanb, smarks ! test/ProblemList.txt