Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-01 Thread Neil Richards
On Sat, 2011-04-02 at 09:17 +1000, David Holmes wrote: > Xueming Shen said the following on 04/02/11 05:07: > > On 04/01/2011 09:42 AM, Neil Richards wrote: > >> On Wed, 2011-03-30 at 13:31 -0700, Xueming Shen wrote: > >>> Isn't it true that when the finalize()->close() gets invoked, there > >>> sh

Re: Review Request for 6751338: ZIP inflater/deflater performance

2011-04-01 Thread Frances Ho
Sherman, Regarding micro benchmark, did you ever get together with monica from performance team so that she can start building suites of micro benchmarks? I think we need to start doing this so that they help(take over) performance validation in the future. Of course developers should still do

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-01 Thread David Holmes
Xueming Shen said the following on 04/02/11 05:07: On 04/01/2011 09:42 AM, Neil Richards wrote: On Wed, 2011-03-30 at 13:31 -0700, Xueming Shen wrote: Isn't it true that when the finalize()->close() gets invoked, there should be no strong reference anywhere else that you can use to invoke close

Review Request for 6751338: ZIP inflater/deflater performance

2011-04-01 Thread Xueming Shen
Dave, Alan, Here is the final webrev based on Dave's patch and the jdk1.5 code that does not have the change for 6206933. JPRT job result suggests no new testing failure and my "non-scientific" benchmark test (to use GZIPOu/InputStream to compress/ decompress the rt.jar) does show relative per

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-01 Thread Xueming Shen
On 04/01/2011 09:42 AM, Neil Richards wrote: On Wed, 2011-03-30 at 13:31 -0700, Xueming Shen wrote: Isn't it true that when the finalize()->close() gets invoked, there should be no strong reference anywhere else that you can use to invoke close() in other thread? It's true that once finalize()

hg: jdk7/tl/jdk: 56 new changesets

2011-04-01 Thread lana . steuck
Changeset: 1c7cac250f71 Author:asaha Date: 2011-03-21 21:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1c7cac250f71 7029704: JFB: Refix JFB Custom Revision Version Build/Makefile changes Reviewed-by: mr, ohair ! make/common/Defs.gmk ! make/common/Release.gmk Changeset:

hg: jdk7/tl/hotspot: 61 new changesets

2011-04-01 Thread lana . steuck
Changeset: 9f44e9aad2d9 Author:coleenp Date: 2011-03-03 19:51 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9f44e9aad2d9 7022999: Can't build with FORCE_TIERED=0 Summary: Put UseFastLocking test under #ifdef COMPILER1 Reviewed-by: kvn, phh, never, dcubed ! src/share/vm/

hg: jdk7/tl/langtools: 5 new changesets

2011-04-01 Thread lana . steuck
Changeset: 028248b9a397 Author:schien Date: 2011-03-24 11:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/028248b9a397 Added tag jdk7-b135 for changeset 9d0a61ac567b ! .hgtags Changeset: ed0f7f1f9511 Author:lana Date: 2011-03-26 00:11 -0700 URL: http:

hg: jdk7/tl/jaxp: 2 new changesets

2011-04-01 Thread lana . steuck
Changeset: 1759daa85d33 Author:schien Date: 2011-03-24 11:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/1759daa85d33 Added tag jdk7-b135 for changeset 4aa9916693dc ! .hgtags Changeset: 1d87f7460cde Author:schien Date: 2011-03-31 18:14 -0700 URL: http://h

hg: jdk7/tl/jaxws: 2 new changesets

2011-04-01 Thread lana . steuck
Changeset: c81d289c9a53 Author:schien Date: 2011-03-24 11:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/c81d289c9a53 Added tag jdk7-b135 for changeset d5fc61f18043 ! .hgtags Changeset: ccea3282991c Author:schien Date: 2011-03-31 18:14 -0700 URL: http://

hg: jdk7/tl: 7 new changesets

2011-04-01 Thread lana . steuck
Changeset: b87875789600 Author:ohair Date: 2011-03-22 08:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/b87875789600 6896934: README: Document how the drop source bundles work for jaxp/jaxws 6896978: README: Updates to openjdk README-builds.html 6903517: README: OpenJDK additi

hg: jdk7/tl/corba: 2 new changesets

2011-04-01 Thread lana . steuck
Changeset: 48ef0c712e7c Author:schien Date: 2011-03-24 11:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/48ef0c712e7c Added tag jdk7-b135 for changeset e0b72ae5dc5e ! .hgtags Changeset: a66c01d8bf89 Author:schien Date: 2011-03-31 18:13 -0700 URL: http://

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-01 Thread Neil Richards
On Wed, 2011-03-30 at 13:31 -0700, Xueming Shen wrote: > Isn't it true that when the finalize()->close() gets invoked, there > should be no strong reference anywhere else that you can use to invoke > close() in other thread? It's true that once finalize() has been called, there can't be another e

hg: jdk7/tl/langtools: 7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource

2011-04-01 Thread maurizio . cimadamore
Changeset: b945b846c979 Author:mcimadamore Date: 2011-04-01 12:30 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b945b846c979 7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource Summary: missing name check before calling MethodSymbol.