Re: Reviewer needed - fix for regression test LastErrorString

2011-05-06 Thread Dr Andrew John Hughes
On 5 May 2011 20:45, Alan Bateman alan.bate...@oracle.com wrote: Pavel Tisnovsky wrote: Hi all, I'd like to push fix for regression test java/io/IOException/LastErrorString.java to OpenJDK7 and OpenJDK6. This fix ensures that no system-important files can be erased and/or rewritten by this

Re: Reviewer needed - fix for regression test LastErrorString

2011-05-06 Thread Pavel Tisnovsky
Alan Bateman wrote: Pavel Tisnovsky wrote: Hi all, I'd like to push fix for regression test java/io/IOException/LastErrorString.java to OpenJDK7 and OpenJDK6. This fix ensures that no system-important files can be erased and/or rewritten by this test even if root started JTreg. Fixed test

Re: Reviewer needed - fix for regression test LastErrorString

2011-05-06 Thread Pavel Tisnovsky
Alan Bateman wrote: Pavel Tisnovsky wrote: : I agree that this test should be fixed but I don't know about jdk7 as it's being stabilized now and only critical changes are allowed. just to be sure - are you talking about proprietary JDK7 or OpenJDK7? I'm talking about the

Re: Reviewer needed - fix for regression test LastErrorString

2011-05-06 Thread Alan Bateman
Alan Bateman wrote: I also need to create a bug for this as I don't think we have one already Here it is: 7042603: TEST_BUG: test/java/io/IOException/LastErrorString.java touches system files

hg: jdk7/tl/jdk: 7011326: Add informative example to @SafeVarargs type or language discussion

2011-05-06 Thread joe . darcy
Changeset: 85cbf90d88b9 Author:darcy Date: 2011-05-06 17:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/85cbf90d88b9 7011326: Add informative example to @SafeVarargs type or language discussion Reviewed-by: mcimadamore, mduigou !