hg: jdk8/tl/jdk: 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE

2011-08-10 Thread chris . hegarty
Changeset: af15e902cf08 Author:chegar Date: 2011-08-10 12:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af15e902cf08 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE Reviewed-by: alanb !

Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

2011-08-10 Thread Alexandre Boulgakov
Hello Joe, Could you please review these small changes to remove javac build warnings from the reflection classes? Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7077389 webrev: http://cr.openjdk.java.net/~mduigou/7077389/0/webrev/

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

2011-08-10 Thread Joe Darcy
On 8/10/2011 11:36 AM, Alexandre Boulgakov wrote: Hello Joe, Could you please review these small changes to remove javac build warnings from the reflection classes? Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7077389 webrev:

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

2011-08-10 Thread Alexandre Boulgakov
Hello Joe, Thanks for reviewing and responding so quickly! On 8/10/2011 12:39 PM, Joe Darcy wrote: On 8/10/2011 11:36 AM, Alexandre Boulgakov wrote: Hello Joe, Could you please review these small changes to remove javac build warnings from the reflection classes? Bug detail:

Re: JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

2011-08-10 Thread Sebastian Sickelmann
Thanks for the quick first review. I have created to new patches for it: Some logistics: - What is the best way to bring this into the real codebase? Patch by Patch, or some bigger Diff - How to integrate? Should we rebase our work every time and keep it actual to newest commits,

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

2011-08-10 Thread Rémi Forax
On 08/10/2011 09:39 PM, Joe Darcy wrote: On 8/10/2011 11:36 AM, Alexandre Boulgakov wrote: Hello Joe, Could you please review these small changes to remove javac build warnings from the reflection classes? Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7077389 webrev:

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

2011-08-10 Thread Rémi Forax
On 08/10/2011 09:39 PM, Joe Darcy wrote: On 8/10/2011 11:36 AM, Alexandre Boulgakov wrote: Hello Joe, Could you please review these small changes to remove javac build warnings from the reflection classes? Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7077389 webrev:

hg: jdk8/tl/jdk: 7077451: SerialLob, SerialClob have the wrong checks for setStream methods

2011-08-10 Thread lance . andersen
Changeset: 7676670d1e97 Author:lancea Date: 2011-08-10 16:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7676670d1e97 7077451: SerialLob, SerialClob have the wrong checks for setStream methods Reviewed-by: alanb Contributed-by: Patrick Reinhart patr...@reini.net !

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

2011-08-10 Thread Alexandre Boulgakov
Hello Remi, Thanks for the feedback! On 8/10/2011 1:22 PM, Rémi Forax wrote: On 08/10/2011 09:39 PM, Joe Darcy wrote: On 8/10/2011 11:36 AM, Alexandre Boulgakov wrote: Hello Joe, Could you please review these small changes to remove javac build warnings from the reflection classes? Bug

hg: jdk8/tl/jdk: 7072353: JNDI libraries do not build with javac -Xlint:all -Werror

2011-08-10 Thread jonathan . gibbons
Changeset: 18329abcdb7c Author:jjg Date: 2011-08-10 13:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18329abcdb7c 7072353: JNDI libraries do not build with javac -Xlint:all -Werror Reviewed-by: xuelei Contributed-by: alexandre.boulga...@oracle.com !

Code review request for 4900206 Include worst-case rounding tests for Math library functions

2011-08-10 Thread Joe Darcy
Hello. Cleaning up my bug backlog, please review the addition of some new math library tests: 4900206 Include worst-case rounding tests for Math library functions http://cr.openjdk.java.net/~darcy/4900206.0/ These tests probe at hard to round values generated by number-theoretic

Re: hg: jdk8/tl/jdk: 7077451: SerialLob, SerialClob have the wrong checks for setStream methods

2011-08-10 Thread Patrick Reinhart
Thanks a lot :-) Am 10.8.2011 22:25, schrieb lance.ander...@oracle.com: Changeset: 7676670d1e97 Author:lancea Date: 2011-08-10 16:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7676670d1e97 7077451: SerialLob, SerialClob have the wrong checks for setStream methods